mikser-io 10.0.3 → 10.0.4

package/docs/configuration.md

@@ -47,7 +47,7 @@ These options are part of `runtime.options` and apply to the engine itself.
 | `outputFolder` | `-o, --output-folder` | string | `out` | Folder where rendered output is written. |
 | `runtimeFolder` | `-e, --runtime-folder` | string | `runtime` | Folder for temporary files. The engine's sqlite substrate lives at `runtime/mikser.sqlite` (entities, refs, snapshots, journal, schema-version meta all in one file). |
 | `plugins` | — | factory-call[] | `[]` | Array of factory returns. Import the factory by name and call it: `plugins: [documents(), layouts({ cleanUrls: true })]`. Config-only — there's no `--plugins` CLI flag under v9 because identifiers can't be passed via the command line (ADR-0010). |
-| `config` | `-c, --config` | string | `./mikser.config.js` | Path to the config file. |
+| `config` | `-c, --config` | string | `./mikser.config.js` | Path to the config file, relative to `workingFolder` like every other path — so `-c prod.config.js` means the one in the folder you pointed at, and repeating the working folder in the path doubles it. A project with no config file at the default location runs on defaults; a path given here that does not exist is an error, because the alternative is a green build with an empty output folder. |
 | `mode` | `-m, --mode` | string | `development` | Runtime mode, accessible as `runtime.options.mode`. |
 | `clear` | `-r, --clear` | boolean | `false` | Delete `outputFolder` and `runtimeFolder` before each run. |
 | `watch` | `-w, --watch` | boolean | `false` | Watch source folders for changes and rebuild incrementally. |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mikser-io",
-  "version": "10.0.3",
+  "version": "10.0.4",
   "files": [
     "app.js",
     "index.js",

package/src/config.js

@@ -103,6 +103,18 @@ onLoad(async () => {
     // during evaluation both exit 1. Module resolution is the only one that
     // needs this to stay in line with them.
     if (!existsSync(configFile)) {
+        // Absent by DEFAULT is a project without a config, which is allowed.
+        // Absent after the caller named it is a typo, and continuing on
+        // defaults answers a question nobody asked: the build prints the path
+        // it did not find, reports "No plugins loaded", writes nothing and
+        // exits 0. That is the same green-build-empty-output failure the
+        // module-resolution note above exists to prevent, reached by the
+        // shorter route of getting the path wrong.
+        if (runtime.options.configExplicit) {
+            throw new Error(`No config file at ${configFile} — it was named with --config, so this is a wrong `
+                + 'path rather than a project without a config. A relative --config resolves against the '
+                + `working folder (${runtime.options.workingFolder}), so it does not repeat it.`)
+        }
         logger.debug('No config file at %s — using defaults', configFile)
     } else {
         // No catch: any failure loading a config that EXISTS is fatal.

package/src/engine.js

@@ -683,6 +683,22 @@ The full version, with what each code means: docs/diagnostics.md`)
         // deliberate: engine's onInitialize does setup that the rest of
         // the engine infrastructure depends on; onInitialized does
         // things plugins may need.
+        // Whether --config was TYPED, for config.js.
+        //
+        // Relative config paths resolve against the working folder, not the
+        // folder the command was run in — that is what makes the default
+        // './mikser.config.js' follow --working-folder, and `-c prod.js`
+        // reads as "the prod config of the site I am pointing at", which is
+        // how it is used. Deliberately unchanged.
+        //
+        // What was missing is what happens when the path is wrong. Nothing
+        // distinguished "this project has no config" from "the config you
+        // named is not there", so a mistyped path printed the path, reported
+        // no plugins, and exited 0 over an empty output folder. config.js
+        // needs to know which case it is in, and only commander can say.
+        runtime.options.configExplicit =
+            runtime.engine?.commander?.getOptionValueSource?.('config') === 'cli'
+
         runtime.options.workingFolder = path.resolve(runtime.options.workingFolder)
         process.chdir(runtime.options.workingFolder)