midnight-mcp 0.1.21 → 0.1.22

package/dist/tools/repository/validation.js

@@ -1379,6 +1379,44 @@ export async function extractContractStructure(input) {
             }
         }
     }
+    // 10. Detect constructor parameters assigned to ledger without disclose()
+    // Constructor parameters are treated as witness values and need disclose() when written to ledger
+    const constructorMatch = code.match(/constructor\s*\(([^)]*)\)\s*\{([\s\S]*?)(?=\n\s*(?:export|circuit|witness|ledger|constructor|\}|$))/);
+    if (constructorMatch) {
+        const paramsStr = constructorMatch[1];
+        const constructorBody = constructorMatch[2];
+        // Extract constructor parameter names
+        const paramPattern = /(\w+)\s*:\s*[^,)]+/g;
+        const constructorParams = [];
+        let paramMatch;
+        while ((paramMatch = paramPattern.exec(paramsStr)) !== null) {
+            constructorParams.push(paramMatch[1]);
+        }
+        // Check each parameter for direct assignment to ledger without disclose
+        for (const param of constructorParams) {
+            // Look for direct assignment: ledgerField = param (without disclose)
+            const assignmentPattern = new RegExp(`(\\w+)\\s*=\\s*(?!disclose\\s*\\()${param}\\b`, "g");
+            let assignMatch;
+            while ((assignMatch = assignmentPattern.exec(constructorBody)) !== null) {
+                const fieldName = assignMatch[1];
+                // Check if the field is a ledger item
+                const isLedgerField = ledgerItems.some((l) => l.name === fieldName);
+                if (isLedgerField) {
+                    // Find the line number
+                    const beforeAssign = code.substring(0, constructorMatch.index +
+                        constructorMatch[0].indexOf(assignMatch[0]));
+                    const lineNum = (beforeAssign.match(/\n/g) || []).length + 1;
+                    potentialIssues.push({
+                        type: "undisclosed_constructor_param",
+                        line: lineNum,
+                        message: `Constructor parameter '${param}' assigned to ledger field '${fieldName}' without disclose()`,
+                        suggestion: `Wrap in disclose(): '${fieldName} = disclose(${param});'`,
+                        severity: "error",
+                    });
+                }
+            }
+        }
+    }
     const summary = [];
     if (circuits.length > 0) {
         summary.push(`${circuits.length} circuit(s)`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "midnight-mcp",
-  "version": "0.1.21",
+  "version": "0.1.22",
   "description": "Model Context Protocol Server for Midnight Blockchain Development",
   "type": "module",
   "main": "dist/index.js",