metro 0.71.0 → 0.71.3

package/src/lib/JsonReporter.js

@@ -9,8 +9,6 @@
  */
 "use strict";
 
-const { Writable } = require("stream");
-
 class JsonReporter {
   constructor(stream) {
     this._stream = stream;

package/src/lib/JsonReporter.js.flow

@@ -10,7 +10,7 @@
 
 'use strict';
 
-const {Writable} = require('stream');
+import type {Writable} from 'stream';
 
 class JsonReporter<TEvent: {[string]: any, ...}> {
   _stream: Writable;

package/src/lib/getAppendScripts.js

@@ -9,6 +9,12 @@
  */
 "use strict";
 
+var _CountingSet = _interopRequireDefault(require("./CountingSet"));
+
+function _interopRequireDefault(obj) {
+  return obj && obj.__esModule ? obj : { default: obj };
+}
+
 const getInlineSourceMappingURL = require("../DeltaBundler/Serializers/helpers/getInlineSourceMappingURL");
 
 const sourceMapString = require("../DeltaBundler/Serializers/sourceMapString");
@@ -38,7 +44,7 @@ function getAppendScripts(entryPoint, modules, importBundleNames, options) {
       path: "$$importBundleNames",
       dependencies: new Map(),
       getSource: () => Buffer.from(""),
-      inverseDependencies: new Set(),
+      inverseDependencies: new _CountingSet.default(),
       output: [
         {
           type: "js/script/virtual",
@@ -64,7 +70,7 @@ function getAppendScripts(entryPoint, modules, importBundleNames, options) {
           path: `require-${path}`,
           dependencies: new Map(),
           getSource: () => Buffer.from(""),
-          inverseDependencies: new Set(),
+          inverseDependencies: new _CountingSet.default(),
           output: [
             {
               type: "js/script/virtual",
@@ -94,7 +100,7 @@ function getAppendScripts(entryPoint, modules, importBundleNames, options) {
       path: "source-map",
       dependencies: new Map(),
       getSource: () => Buffer.from(""),
-      inverseDependencies: new Set(),
+      inverseDependencies: new _CountingSet.default(),
       output: [
         {
           type: "js/script/virtual",
@@ -114,7 +120,7 @@ function getAppendScripts(entryPoint, modules, importBundleNames, options) {
       path: "source-url",
       dependencies: new Map(),
       getSource: () => Buffer.from(""),
-      inverseDependencies: new Set(),
+      inverseDependencies: new _CountingSet.default(),
       output: [
         {
           type: "js/script/virtual",

package/src/lib/getAppendScripts.js.flow

@@ -12,6 +12,8 @@
 
 import type {Module} from '../DeltaBundler';
 
+import CountingSet from './CountingSet';
+
 const getInlineSourceMappingURL = require('../DeltaBundler/Serializers/helpers/getInlineSourceMappingURL');
 const sourceMapString = require('../DeltaBundler/Serializers/sourceMapString');
 const countLines = require('./countLines');
@@ -56,7 +58,7 @@ function getAppendScripts<T: number | string>(
       path: '$$importBundleNames',
       dependencies: new Map(),
       getSource: (): Buffer => Buffer.from(''),
-      inverseDependencies: new Set(),
+      inverseDependencies: new CountingSet(),
       output: [
         {
           type: 'js/script/virtual',
@@ -82,7 +84,7 @@ function getAppendScripts<T: number | string>(
           path: `require-${path}`,
           dependencies: new Map(),
           getSource: (): Buffer => Buffer.from(''),
-          inverseDependencies: new Set(),
+          inverseDependencies: new CountingSet(),
           output: [
             {
               type: 'js/script/virtual',
@@ -113,7 +115,7 @@ function getAppendScripts<T: number | string>(
       path: 'source-map',
       dependencies: new Map(),
       getSource: (): Buffer => Buffer.from(''),
-      inverseDependencies: new Set(),
+      inverseDependencies: new CountingSet(),
       output: [
         {
           type: 'js/script/virtual',
@@ -133,7 +135,7 @@ function getAppendScripts<T: number | string>(
       path: 'source-url',
       dependencies: new Map(),
       getSource: (): Buffer => Buffer.from(''),
-      inverseDependencies: new Set(),
+      inverseDependencies: new CountingSet(),
       output: [
         {
           type: 'js/script/virtual',

package/src/lib/getPreludeCode.js

@@ -9,14 +9,32 @@
  */
 "use strict";
 
-function getPreludeCode({ extraVars, isDev, globalPrefix }) {
+function getPreludeCode({
+  extraVars,
+  isDev,
+  globalPrefix,
+  requireCycleIgnorePatterns,
+}) {
   const vars = [
+    // Ensure these variable names match the ones referenced in metro-runtime
+    // require.js
     "__BUNDLE_START_TIME__=this.nativePerformanceNow?nativePerformanceNow():Date.now()",
     `__DEV__=${String(isDev)}`,
     ...formatExtraVars(extraVars),
     "process=this.process||{}",
     `__METRO_GLOBAL_PREFIX__='${globalPrefix}'`,
   ];
+
+  if (isDev) {
+    // Ensure these variable names match the ones referenced in metro-runtime
+    // require.js
+    vars.push(
+      `${globalPrefix}__requireCycleIgnorePatterns=[${requireCycleIgnorePatterns
+        .map((regex) => regex.toString())
+        .join(",")}]`
+    );
+  }
+
   return `var ${vars.join(",")};${processEnv(
     isDev ? "development" : "production"
   )}`;

package/src/lib/getPreludeCode.js.flow

@@ -14,18 +14,33 @@ function getPreludeCode({
   extraVars,
   isDev,
   globalPrefix,
+  requireCycleIgnorePatterns,
 }: {
   +extraVars?: {[string]: mixed, ...},
   +isDev: boolean,
   +globalPrefix: string,
+  +requireCycleIgnorePatterns: $ReadOnlyArray<RegExp>,
 }): string {
   const vars = [
+    // Ensure these variable names match the ones referenced in metro-runtime
+    // require.js
     '__BUNDLE_START_TIME__=this.nativePerformanceNow?nativePerformanceNow():Date.now()',
     `__DEV__=${String(isDev)}`,
     ...formatExtraVars(extraVars),
     'process=this.process||{}',
     `__METRO_GLOBAL_PREFIX__='${globalPrefix}'`,
   ];
+
+  if (isDev) {
+    // Ensure these variable names match the ones referenced in metro-runtime
+    // require.js
+    vars.push(
+      `${globalPrefix}__requireCycleIgnorePatterns=[${requireCycleIgnorePatterns
+        .map(regex => regex.toString())
+        .join(',')}]`,
+    );
+  }
+
   return `var ${vars.join(',')};${processEnv(
     isDev ? 'development' : 'production',
   )}`;

package/src/lib/getPrependedScripts.js

@@ -9,6 +9,12 @@
  */
 "use strict";
 
+var _CountingSet = _interopRequireDefault(require("./CountingSet"));
+
+function _interopRequireDefault(obj) {
+  return obj && obj.__esModule ? obj : { default: obj };
+}
+
 const countLines = require("./countLines");
 
 const getPreludeCode = require("./getPreludeCode");
@@ -53,21 +59,23 @@ async function getPrependedScripts(config, options, bundler, deltaBundler) {
     _getPrelude({
       dev: options.dev,
       globalPrefix: config.transformer.globalPrefix,
+      requireCycleIgnorePatterns: config.resolver.requireCycleIgnorePatterns,
     }),
     ...dependencies.values(),
   ];
 }
 
-function _getPrelude({ dev, globalPrefix }) {
+function _getPrelude({ dev, globalPrefix, requireCycleIgnorePatterns }) {
   const code = getPreludeCode({
     isDev: dev,
     globalPrefix,
+    requireCycleIgnorePatterns,
   });
   const name = "__prelude__";
   return {
     dependencies: new Map(),
     getSource: () => Buffer.from(code),
-    inverseDependencies: new Set(),
+    inverseDependencies: new _CountingSet.default(),
     path: name,
     output: [
       {

package/src/lib/getPrependedScripts.js.flow

@@ -15,6 +15,8 @@ import type DeltaBundler, {Module} from '../DeltaBundler';
 import type {TransformInputOptions} from '../DeltaBundler/types.flow';
 import type {ConfigT} from 'metro-config/src/configTypes.flow';
 
+import CountingSet from './CountingSet';
+
 const countLines = require('./countLines');
 const getPreludeCode = require('./getPreludeCode');
 const transformHelpers = require('./transformHelpers');
@@ -69,6 +71,7 @@ async function getPrependedScripts(
     _getPrelude({
       dev: options.dev,
       globalPrefix: config.transformer.globalPrefix,
+      requireCycleIgnorePatterns: config.resolver.requireCycleIgnorePatterns,
     }),
     ...dependencies.values(),
   ];
@@ -77,18 +80,24 @@ async function getPrependedScripts(
 function _getPrelude({
   dev,
   globalPrefix,
+  requireCycleIgnorePatterns,
 }: {
   dev: boolean,
   globalPrefix: string,
+  requireCycleIgnorePatterns: $ReadOnlyArray<RegExp>,
   ...
 }): Module<> {
-  const code = getPreludeCode({isDev: dev, globalPrefix});
+  const code = getPreludeCode({
+    isDev: dev,
+    globalPrefix,
+    requireCycleIgnorePatterns,
+  });
   const name = '__prelude__';
 
   return {
     dependencies: new Map(),
     getSource: (): Buffer => Buffer.from(code),
-    inverseDependencies: new Set(),
+    inverseDependencies: new CountingSet(),
     path: name,
     output: [
       {

package/src/lib/reporting.js

@@ -11,8 +11,6 @@
 
 const chalk = require("chalk");
 
-const { Terminal } = require("metro-core");
-
 const stripAnsi = require("strip-ansi");
 
 const util = require("util");

package/src/lib/reporting.js.flow

@@ -10,8 +10,9 @@
 
 'use strict';
 
+import type {Terminal} from 'metro-core';
+
 const chalk = require('chalk');
-const {Terminal} = require('metro-core');
 const stripAnsi = require('strip-ansi');
 const util = require('util');
 

package/src/node-haste/DependencyGraph/ModuleResolution.js

@@ -144,7 +144,10 @@ class ModuleResolver {
             `  * ${Resolver.formatFileCandidates(
               this._removeRoot(candidates.dir)
             )}`,
-          ].join("\n")
+          ].join("\n"),
+          {
+            cause: error,
+          }
         );
       }
 
@@ -162,7 +165,10 @@ class ModuleResolver {
           [
             `${moduleName} could not be found within the project${hint || "."}`,
             ...displayDirPaths.map((dirPath) => `  ${dirPath}`),
-          ].join("\n")
+          ].join("\n"),
+          {
+            cause: error,
+          }
         );
       }
 
@@ -238,7 +244,11 @@ class UnableToResolveError extends Error {
    * The name of the module that was required, no necessarily a path,
    * ex. `./bar`, or `invariant`.
    */
-  constructor(originModulePath, targetModuleName, message) {
+
+  /**
+   * Original error that causes this error
+   */
+  constructor(originModulePath, targetModuleName, message, options) {
     super();
     this.originModulePath = originModulePath;
     this.targetModuleName = targetModuleName;
@@ -250,6 +260,8 @@ class UnableToResolveError extends Error {
         originModulePath,
         message
       ) + (codeFrameMessage ? "\n" + codeFrameMessage : "");
+    this.cause =
+      options === null || options === void 0 ? void 0 : options.cause;
   }
 
   buildCodeFrameMessage() {

package/src/node-haste/DependencyGraph/ModuleResolution.js.flow

@@ -201,6 +201,9 @@ class ModuleResolver<TModule: Moduleish, TPackage: Packageish> {
               this._removeRoot(candidates.dir),
             )}`,
           ].join('\n'),
+          {
+            cause: error,
+          },
         );
       }
       if (error instanceof Resolver.FailedToResolveNameError) {
@@ -220,6 +223,9 @@ class ModuleResolver<TModule: Moduleish, TPackage: Packageish> {
             `${moduleName} could not be found within the project${hint || '.'}`,
             ...displayDirPaths.map((dirPath: string) => `  ${dirPath}`),
           ].join('\n'),
+          {
+            cause: error,
+          },
         );
       }
       throw error;
@@ -287,11 +293,18 @@ class UnableToResolveError extends Error {
    * ex. `./bar`, or `invariant`.
    */
   targetModuleName: string;
+  /**
+   * Original error that causes this error
+   */
+  cause: ?Error;
 
   constructor(
     originModulePath: string,
     targetModuleName: string,
     message: string,
+    options?: $ReadOnly<{
+      cause?: Error,
+    }>,
   ) {
     super();
     this.originModulePath = originModulePath;
@@ -304,6 +317,8 @@ class UnableToResolveError extends Error {
         originModulePath,
         message,
       ) + (codeFrameMessage ? '\n' + codeFrameMessage : '');
+
+    this.cause = options?.cause;
   }
 
   buildCodeFrameMessage(): ?string {

package/src/node-haste/DependencyGraph/createHasteMap.js

@@ -1,9 +1,47 @@
 "use strict";
 
-var _metroFileMap = _interopRequireDefault(require("metro-file-map"));
+var _metroFileMap = _interopRequireWildcard(require("metro-file-map"));
 
-function _interopRequireDefault(obj) {
-  return obj && obj.__esModule ? obj : { default: obj };
+function _getRequireWildcardCache(nodeInterop) {
+  if (typeof WeakMap !== "function") return null;
+  var cacheBabelInterop = new WeakMap();
+  var cacheNodeInterop = new WeakMap();
+  return (_getRequireWildcardCache = function (nodeInterop) {
+    return nodeInterop ? cacheNodeInterop : cacheBabelInterop;
+  })(nodeInterop);
+}
+
+function _interopRequireWildcard(obj, nodeInterop) {
+  if (!nodeInterop && obj && obj.__esModule) {
+    return obj;
+  }
+  if (obj === null || (typeof obj !== "object" && typeof obj !== "function")) {
+    return { default: obj };
+  }
+  var cache = _getRequireWildcardCache(nodeInterop);
+  if (cache && cache.has(obj)) {
+    return cache.get(obj);
+  }
+  var newObj = {};
+  var hasPropertyDescriptor =
+    Object.defineProperty && Object.getOwnPropertyDescriptor;
+  for (var key in obj) {
+    if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) {
+      var desc = hasPropertyDescriptor
+        ? Object.getOwnPropertyDescriptor(obj, key)
+        : null;
+      if (desc && (desc.get || desc.set)) {
+        Object.defineProperty(newObj, key, desc);
+      } else {
+        newObj[key] = obj[key];
+      }
+    }
+  }
+  newObj.default = obj;
+  if (cache) {
+    cache.set(obj, newObj);
+  }
+  return newObj;
 }
 
 /**
@@ -19,8 +57,6 @@ const ci = require("ci-info");
 
 const path = require("path");
 
-const JEST_HASTE_MAP_CACHE_BREAKER = 5;
-
 function getIgnorePattern(config) {
   // For now we support both options
   const { blockList, blacklistRE } = config.resolver;
@@ -45,7 +81,10 @@ function getIgnorePattern(config) {
 }
 
 function createHasteMap(config, options) {
-  var _config$fileMapCacheD, _options$name, _options$throwOnModul;
+  var _config$unstable_file,
+    _config$unstable_perf,
+    _config$unstable_perf2,
+    _options$throwOnModul;
 
   const dependencyExtractor =
     (options === null || options === void 0
@@ -55,28 +94,47 @@ function createHasteMap(config, options) {
       : config.resolver.dependencyExtractor;
   const computeDependencies = dependencyExtractor != null;
   return _metroFileMap.default.create({
-    cacheDirectory:
-      (_config$fileMapCacheD = config.fileMapCacheDirectory) !== null &&
-      _config$fileMapCacheD !== void 0
-        ? _config$fileMapCacheD
-        : config.hasteMapCacheDirectory,
+    cacheManagerFactory:
+      (_config$unstable_file =
+        config === null || config === void 0
+          ? void 0
+          : config.unstable_fileMapCacheManagerFactory) !== null &&
+      _config$unstable_file !== void 0
+        ? _config$unstable_file
+        : (buildParameters) => {
+            var _config$fileMapCacheD;
+
+            return new _metroFileMap.DiskCacheManager({
+              buildParameters,
+              cacheDirectory:
+                (_config$fileMapCacheD = config.fileMapCacheDirectory) !==
+                  null && _config$fileMapCacheD !== void 0
+                  ? _config$fileMapCacheD
+                  : config.hasteMapCacheDirectory,
+              cacheFilePrefix:
+                options === null || options === void 0
+                  ? void 0
+                  : options.cacheFilePrefix,
+            });
+          },
+    perfLogger:
+      (_config$unstable_perf =
+        (_config$unstable_perf2 = config.unstable_perfLogger) === null ||
+        _config$unstable_perf2 === void 0
+          ? void 0
+          : _config$unstable_perf2.subSpan("hasteMap")) !== null &&
+      _config$unstable_perf !== void 0
+        ? _config$unstable_perf
+        : null,
     computeDependencies,
     computeSha1: true,
     dependencyExtractor: config.resolver.dependencyExtractor,
     extensions: config.resolver.sourceExts.concat(config.resolver.assetExts),
     forceNodeFilesystemAPI: !config.resolver.useWatchman,
     hasteImplModulePath: config.resolver.hasteImplModulePath,
-    hasteMapModulePath: config.resolver.unstable_hasteMapModulePath,
     ignorePattern: getIgnorePattern(config),
     maxWorkers: config.maxWorkers,
     mocksPattern: "",
-    name: `${
-      (_options$name =
-        options === null || options === void 0 ? void 0 : options.name) !==
-        null && _options$name !== void 0
-        ? _options$name
-        : "metro"
-    }-${JEST_HASTE_MAP_CACHE_BREAKER}`,
     platforms: config.resolver.platforms,
     retainAllFiles: true,
     resetCache: config.resetCache,
@@ -95,6 +153,7 @@ function createHasteMap(config, options) {
       (options === null || options === void 0 ? void 0 : options.watch) == null
         ? !ci.isCI
         : options.watch,
+    watchmanDeferStates: config.watcher.watchman.deferStates,
   });
 }
 

package/src/node-haste/DependencyGraph/createHasteMap.js.flow

@@ -10,13 +10,11 @@
 
 import type {ConfigT} from 'metro-config/src/configTypes.flow';
 
-import MetroFileMap from 'metro-file-map';
+import MetroFileMap, {DiskCacheManager} from 'metro-file-map';
 
 const ci = require('ci-info');
 const path = require('path');
 
-const JEST_HASTE_MAP_CACHE_BREAKER = 5;
-
 function getIgnorePattern(config: ConfigT): RegExp {
   // For now we support both options
   const {blockList, blacklistRE} = config.resolver;
@@ -27,7 +25,7 @@ function getIgnorePattern(config: ConfigT): RegExp {
     return / ^/;
   }
 
-  const combine = regexes =>
+  const combine = (regexes: Array<RegExp>) =>
     new RegExp(
       regexes
         .map(regex => '(' + regex.source.replace(/\//g, path.sep) + ')')
@@ -48,7 +46,7 @@ function createHasteMap(
     extractDependencies?: boolean,
     watch?: boolean,
     throwOnModuleCollision?: boolean,
-    name?: string,
+    cacheFilePrefix?: string,
   }>,
 ): MetroFileMap {
   const dependencyExtractor =
@@ -58,19 +56,25 @@ function createHasteMap(
   const computeDependencies = dependencyExtractor != null;
 
   return MetroFileMap.create({
-    cacheDirectory:
-      config.fileMapCacheDirectory ?? config.hasteMapCacheDirectory,
+    cacheManagerFactory:
+      config?.unstable_fileMapCacheManagerFactory ??
+      (buildParameters =>
+        new DiskCacheManager({
+          buildParameters,
+          cacheDirectory:
+            config.fileMapCacheDirectory ?? config.hasteMapCacheDirectory,
+          cacheFilePrefix: options?.cacheFilePrefix,
+        })),
+    perfLogger: config.unstable_perfLogger?.subSpan('hasteMap') ?? null,
     computeDependencies,
     computeSha1: true,
     dependencyExtractor: config.resolver.dependencyExtractor,
     extensions: config.resolver.sourceExts.concat(config.resolver.assetExts),
     forceNodeFilesystemAPI: !config.resolver.useWatchman,
     hasteImplModulePath: config.resolver.hasteImplModulePath,
-    hasteMapModulePath: config.resolver.unstable_hasteMapModulePath,
     ignorePattern: getIgnorePattern(config),
     maxWorkers: config.maxWorkers,
     mocksPattern: '',
-    name: `${options?.name ?? 'metro'}-${JEST_HASTE_MAP_CACHE_BREAKER}`,
     platforms: config.resolver.platforms,
     retainAllFiles: true,
     resetCache: config.resetCache,
@@ -79,6 +83,7 @@ function createHasteMap(
     throwOnModuleCollision: options?.throwOnModuleCollision ?? true,
     useWatchman: config.resolver.useWatchman,
     watch: options?.watch == null ? !ci.isCI : options.watch,
+    watchmanDeferStates: config.watcher.watchman.deferStates,
   });
 }
 

package/src/node-haste/DependencyGraph.js

@@ -15,8 +15,6 @@ const createHasteMap = require("./DependencyGraph/createHasteMap");
 
 const { ModuleResolver } = require("./DependencyGraph/ModuleResolution");
 
-const Module = require("./Module");
-
 const ModuleCache = require("./ModuleCache");
 
 const { EventEmitter } = require("events");
@@ -117,6 +115,8 @@ class DependencyGraph extends EventEmitter {
 
     return null;
   }
+  /* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
+   * LTI update could not be added via codemod */
 
   _onHasteChange({ eventsQueue, hasteFS, moduleMap }) {
     this._hasteFS = hasteFS;

package/src/node-haste/DependencyGraph.js.flow

@@ -11,12 +11,12 @@
 import type Package from './Package';
 import type {ConfigT} from 'metro-config/src/configTypes.flow';
 import type MetroFileMap, {HasteFS} from 'metro-file-map';
+import type Module from './Module';
 
 import {ModuleMap as MetroFileMapModuleMap} from 'metro-file-map';
 
 const createHasteMap = require('./DependencyGraph/createHasteMap');
 const {ModuleResolver} = require('./DependencyGraph/ModuleResolution');
-const Module = require('./Module');
 const ModuleCache = require('./ModuleCache');
 const {EventEmitter} = require('events');
 const fs = require('fs');
@@ -33,7 +33,7 @@ const {DuplicateHasteCandidatesError} = MetroFileMapModuleMap;
 
 function getOrCreate<T>(
   map: Map<string, Map<string, T>>,
-  field,
+  field: string,
 ): Map<string, T> {
   let subMap = map.get(field);
   if (!subMap) {
@@ -131,6 +131,8 @@ class DependencyGraph extends EventEmitter {
     return null;
   }
 
+  /* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
+   * LTI update could not be added via codemod */
   _onHasteChange({eventsQueue, hasteFS, moduleMap}) {
     this._hasteFS = hasteFS;
     this._resolutionCache = new Map();