metro-runtime 0.83.1 → 0.83.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "metro-runtime",
-  "version": "0.83.1",
+  "version": "0.83.2",
   "description": "🚇 Module required for evaluating Metro bundles.",
   "exports": {
     "./package.json": "./package.json",
@@ -28,9 +28,9 @@
   },
   "devDependencies": {
     "@babel/core": "^7.25.2",
-    "react": "19.1.0",
+    "react": "19.1.1",
     "react-refresh": "^0.14.0",
-    "react-test-renderer": "19.1.0"
+    "react-test-renderer": "19.1.1"
   },
   "engines": {
     "node": ">=20.19.4"

package/src/modules/HMRClient.js.flow

@@ -10,8 +10,8 @@
  */
 
 'use strict';
-import type {HmrModule} from './types.flow';
-import type {HmrMessage, HmrUpdate} from './types.flow';
+import type {HmrModule} from './types';
+import type {HmrMessage, HmrUpdate} from './types';
 
 const EventEmitter = require('./vendor/eventemitter3');
 

package/src/modules/asyncRequire.js

@@ -26,14 +26,14 @@ async function asyncRequire(moduleID, paths, moduleName) {
 }
 asyncRequire.unstable_importMaybeSync = function unstable_importMaybeSync(
   moduleID,
-  paths
+  paths,
 ) {
   return asyncRequireImpl(moduleID, paths);
 };
 asyncRequire.prefetch = function (moduleID, paths, moduleName) {
   maybeLoadBundle(moduleID, paths)?.then(
     () => {},
-    () => {}
+    () => {},
   );
 };
 module.exports = asyncRequire;

package/src/modules/{types.flow.js.flow → types.js.flow}

@@ -9,8 +9,6 @@
  * @oncall react_native
  */
 
-'use strict';
-
 export type ModuleMap = $ReadOnlyArray<[number, string]>;
 
 export type Bundle = {
@@ -82,7 +80,6 @@ export type HmrClientMessage =
         | 'groupEnd'
         | 'debug',
       +data: Array<mixed>,
-      +mode: 'BRIDGE' | 'NOBRIDGE',
     }
   | {
       +type: 'log-opt-in',

package/src/modules/vendor/eventemitter3.js

@@ -19,7 +19,7 @@ function addListener(emitter, event, fn, context, once) {
   var listener = new EE(fn, context || emitter, once),
     evt = prefix ? prefix + event : event;
   if (!emitter._events[evt])
-    (emitter._events[evt] = listener), emitter._eventsCount++;
+    ((emitter._events[evt] = listener), emitter._eventsCount++);
   else if (!emitter._events[evt].fn) emitter._events[evt].push(listener);
   else emitter._events[evt] = [emitter._events[evt], listener];
   return emitter;
@@ -74,17 +74,17 @@ EventEmitter.prototype.emit = function emit(event, a1, a2, a3, a4, a5) {
       this.removeListener(event, listeners.fn, undefined, true);
     switch (len) {
       case 1:
-        return listeners.fn.call(listeners.context), true;
+        return (listeners.fn.call(listeners.context), true);
       case 2:
-        return listeners.fn.call(listeners.context, a1), true;
+        return (listeners.fn.call(listeners.context, a1), true);
       case 3:
-        return listeners.fn.call(listeners.context, a1, a2), true;
+        return (listeners.fn.call(listeners.context, a1, a2), true);
       case 4:
-        return listeners.fn.call(listeners.context, a1, a2, a3), true;
+        return (listeners.fn.call(listeners.context, a1, a2, a3), true);
       case 5:
-        return listeners.fn.call(listeners.context, a1, a2, a3, a4), true;
+        return (listeners.fn.call(listeners.context, a1, a2, a3, a4), true);
       case 6:
-        return listeners.fn.call(listeners.context, a1, a2, a3, a4, a5), true;
+        return (listeners.fn.call(listeners.context, a1, a2, a3, a4, a5), true);
     }
     for (i = 1, args = new Array(len - 1); i < len; i++) {
       args[i - 1] = arguments[i];
@@ -130,7 +130,7 @@ EventEmitter.prototype.removeListener = function removeListener(
   event,
   fn,
   context,
-  once
+  once,
 ) {
   var evt = prefix ? prefix + event : event;
   if (!this._events[evt]) return this;

package/src/polyfills/require.js

@@ -70,13 +70,13 @@ function metroRequire(moduleId, maybeNameForDev) {
     moduleId = getModuleIdForVerboseName(verboseName);
     console.warn(
       `Requiring module "${verboseName}" by name is only supported for ` +
-        "debugging purposes and will BREAK IN PRODUCTION!"
+        "debugging purposes and will BREAK IN PRODUCTION!",
     );
   }
   const moduleIdReallyIsNumber = moduleId;
   if (__DEV__) {
     const initializingIndex = initializingModuleIds.indexOf(
-      moduleIdReallyIsNumber
+      moduleIdReallyIsNumber,
     );
     if (initializingIndex !== -1) {
       const cycle = initializingModuleIds
@@ -87,7 +87,7 @@ function metroRequire(moduleId, maybeNameForDev) {
         console.warn(
           `Require cycle: ${cycle.join(" -> ")}\n\n` +
             "Require cycles are allowed, but can result in uninitialized values. " +
-            "Consider refactoring to remove the need for a cycle."
+            "Consider refactoring to remove the need for a cycle.",
         );
       }
     }
@@ -159,17 +159,17 @@ metroRequire.importAll = metroImportAll;
 metroRequire.context = function fallbackRequireContext() {
   if (__DEV__) {
     throw new Error(
-      "The experimental Metro feature `require.context` is not enabled in your project.\nThis can be enabled by setting the `transformer.unstable_allowRequireContext` property to `true` in your Metro configuration."
+      "The experimental Metro feature `require.context` is not enabled in your project.\nThis can be enabled by setting the `transformer.unstable_allowRequireContext` property to `true` in your Metro configuration.",
     );
   }
   throw new Error(
-    "The experimental Metro feature `require.context` is not enabled in your project."
+    "The experimental Metro feature `require.context` is not enabled in your project.",
   );
 };
 metroRequire.resolveWeak = function fallbackRequireResolveWeak() {
   if (__DEV__) {
     throw new Error(
-      "require.resolveWeak cannot be called dynamically. Ensure you are using the same version of `metro` and `metro-runtime`."
+      "require.resolveWeak cannot be called dynamically. Ensure you are using the same version of `metro` and `metro-runtime`.",
     );
   }
   throw new Error("require.resolveWeak cannot be called dynamically.");
@@ -212,13 +212,13 @@ function registerSegment(segmentId, moduleDefiner, moduleIds) {
   if (__DEV__) {
     if (segmentId === 0 && moduleIds) {
       throw new Error(
-        "registerSegment: Expected moduleIds to be null for main segment"
+        "registerSegment: Expected moduleIds to be null for main segment",
       );
     }
     if (segmentId !== 0 && !moduleIds) {
       throw new Error(
         "registerSegment: Expected moduleIds to be passed for segment #" +
-          segmentId
+          segmentId,
       );
     }
   }
@@ -289,7 +289,7 @@ function loadModuleImplementation(moduleId, module) {
       metroImportAll,
       moduleObject,
       moduleObject.exports,
-      dependencyMap
+      dependencyMap,
     );
     if (!__DEV__) {
       module.factory = undefined;
@@ -302,7 +302,7 @@ function loadModuleImplementation(moduleId, module) {
         registerExportsForReactRefresh(
           Refresh,
           moduleObject.exports,
-          prefixedModuleId
+          prefixedModuleId,
         );
       }
     }
@@ -317,7 +317,7 @@ function loadModuleImplementation(moduleId, module) {
     if (__DEV__) {
       if (initializingModuleIds.pop() !== moduleId) {
         throw new Error(
-          "initializingModuleIds is corrupt; something is terribly wrong"
+          "initializingModuleIds is corrupt; something is terribly wrong",
         );
       }
       global.$RefreshReg$ = prevRefreshReg;
@@ -362,7 +362,7 @@ if (__DEV__) {
     id,
     factory,
     dependencyMap,
-    inverseDependencies
+    inverseDependencies,
   ) {
     const mod = modules.get(id);
     if (!mod) {
@@ -391,14 +391,14 @@ if (__DEV__) {
           const pendingHot = pendingModule.hot;
           if (pendingHot == null) {
             throw new Error(
-              "[Refresh] Expected module.hot to always exist in DEV."
+              "[Refresh] Expected module.hot to always exist in DEV.",
             );
           }
           let canAccept = pendingHot._didAccept;
           if (!canAccept && Refresh != null) {
             const isBoundary = isReactRefreshBoundary(
               Refresh,
-              pendingModule.publicModule.exports
+              pendingModule.publicModule.exports,
             );
             if (isBoundary) {
               canAccept = true;
@@ -419,7 +419,7 @@ if (__DEV__) {
           }
           return parentIDs;
         },
-        () => didBailOut
+        () => didBailOut,
       ).reverse();
     } catch (e) {
       if (e === CYCLE_DETECTED) {
@@ -448,7 +448,7 @@ if (__DEV__) {
       const didError = runUpdatedModule(
         updatedID,
         updatedID === id ? factory : undefined,
-        updatedID === id ? dependencyMap : undefined
+        updatedID === id ? dependencyMap : undefined,
       );
       const nextExports = updatedMod.publicModule.exports;
       if (didError) {
@@ -457,12 +457,12 @@ if (__DEV__) {
       if (refreshBoundaryIDs.has(updatedID)) {
         const isNoLongerABoundary = !isReactRefreshBoundary(
           Refresh,
-          nextExports
+          nextExports,
         );
         const didInvalidate = shouldInvalidateReactRefreshBoundary(
           Refresh,
           prevExports,
-          nextExports
+          nextExports,
         );
         if (isNoLongerABoundary || didInvalidate) {
           const parentIDs = inverseDependencies[updatedID];
@@ -474,7 +474,7 @@ if (__DEV__) {
               {
                 source: mod,
                 failed: updatedMod,
-              }
+              },
             );
             return;
           }
@@ -486,7 +486,7 @@ if (__DEV__) {
             }
             const canAcceptParent = isReactRefreshBoundary(
               Refresh,
-              parentMod.publicModule.exports
+              parentMod.publicModule.exports,
             );
             if (canAcceptParent) {
               refreshBoundaryIDs.add(parentID);
@@ -555,7 +555,7 @@ if (__DEV__) {
       } catch (error) {
         console.error(
           `Error while calling dispose handler for module ${id}: `,
-          error
+          error,
         );
       }
     }
@@ -589,7 +589,7 @@ if (__DEV__) {
       } catch (error) {
         console.error(
           `Error while calling accept handler for module ${id}: `,
-          error
+          error,
         );
       }
     }
@@ -608,13 +608,19 @@ if (__DEV__) {
         const sourceName = modules.source?.verboseName ?? "unknown";
         const failedName = modules.failed?.verboseName ?? "unknown";
         Refresh.performFullRefresh(
-          `Fast Refresh - ${reason} <${sourceName}> <${failedName}>`
+          `Fast Refresh - ${reason} <${sourceName}> <${failedName}>`,
         );
       } else {
         console.warn("Could not reload the application after an edit.");
       }
     }
   };
+  const isExportSafeToAccess = (moduleExports, key) => {
+    return (
+      moduleExports?.__esModule ||
+      Object.getOwnPropertyDescriptor(moduleExports, key)?.get == null
+    );
+  };
   var isReactRefreshBoundary = function (Refresh, moduleExports) {
     if (Refresh.isLikelyComponentType(moduleExports)) {
       return true;
@@ -628,9 +634,7 @@ if (__DEV__) {
       hasExports = true;
       if (key === "__esModule") {
         continue;
-      }
-      const desc = Object.getOwnPropertyDescriptor(moduleExports, key);
-      if (desc && desc.get) {
+      } else if (!isExportSafeToAccess(moduleExports, key)) {
         return false;
       }
       const exportValue = moduleExports[key];
@@ -643,7 +647,7 @@ if (__DEV__) {
   var shouldInvalidateReactRefreshBoundary = (
     Refresh,
     prevExports,
-    nextExports
+    nextExports,
   ) => {
     const prevSignature = getRefreshBoundarySignature(Refresh, prevExports);
     const nextSignature = getRefreshBoundarySignature(Refresh, nextExports);
@@ -666,9 +670,7 @@ if (__DEV__) {
     for (const key in moduleExports) {
       if (key === "__esModule") {
         continue;
-      }
-      const desc = Object.getOwnPropertyDescriptor(moduleExports, key);
-      if (desc && desc.get) {
+      } else if (!isExportSafeToAccess(moduleExports, key)) {
         continue;
       }
       const exportValue = moduleExports[key];
@@ -683,8 +685,7 @@ if (__DEV__) {
       return;
     }
     for (const key in moduleExports) {
-      const desc = Object.getOwnPropertyDescriptor(moduleExports, key);
-      if (desc && desc.get) {
+      if (!isExportSafeToAccess(moduleExports, key)) {
         continue;
       }
       const exportValue = moduleExports[key];

package/src/polyfills/require.js.flow

@@ -191,7 +191,7 @@ function metroRequire(
     );
   }
 
-  //$FlowFixMe: at this point we know that moduleId is a number
+  //$FlowFixMe[incompatible-type]: at this point we know that moduleId is a number
   const moduleIdReallyIsNumber: number = moduleId;
 
   if (__DEV__) {
@@ -244,7 +244,7 @@ function metroImportDefault(
     moduleId = getModuleIdForVerboseName(verboseName);
   }
 
-  //$FlowFixMe: at this point we know that moduleId is a number
+  //$FlowFixMe[incompatible-type]: at this point we know that moduleId is a number
   const moduleIdReallyIsNumber: number = moduleId;
 
   const maybeInitializedModule = modules.get(moduleIdReallyIsNumber);
@@ -276,7 +276,7 @@ function metroImportAll(
     moduleId = getModuleIdForVerboseName(verboseName);
   }
 
-  //$FlowFixMe: at this point we know that moduleId is a number
+  //$FlowFixMe[incompatible-type]: at this point we know that moduleId is a number
   const moduleIdReallyIsNumber: number = moduleId;
 
   const maybeInitializedModule = modules.get(moduleIdReallyIsNumber);
@@ -457,7 +457,7 @@ function loadModuleImplementation(
   }
   try {
     if (__DEV__) {
-      // $FlowIgnore: we know that __DEV__ is const and `Systrace` exists
+      // $FlowFixMe[incompatible-use]: we know that __DEV__ is const and `Systrace` exists
       Systrace.beginEvent('JS_require_' + (module.verboseName || moduleId));
     }
 
@@ -497,13 +497,13 @@ function loadModuleImplementation(
 
     // avoid removing factory in DEV mode as it breaks HMR
     if (!__DEV__) {
-      // $FlowFixMe: This is only sound because we never access `factory` again
+      // $FlowFixMe[incompatible-type]: This is only sound because we never access `factory` again
       module.factory = undefined;
       module.dependencyMap = undefined;
     }
 
     if (__DEV__) {
-      // $FlowIgnore: we know that __DEV__ is const and `Systrace` exists
+      // $FlowFixMe[incompatible-use]: we know that __DEV__ is const and `Systrace` exists
       Systrace.endEvent();
 
       if (Refresh != null) {
@@ -585,6 +585,8 @@ if (__DEV__) {
   ) {
     const mod = modules.get(id);
     if (!mod) {
+      /* $FlowFixMe[constant-condition] Error discovered during Constant
+       * Condition roll out. See https://fburl.com/workplace/1v97vimq. */
       if (factory) {
         // New modules are going to be handled by the define() method.
         return;
@@ -927,6 +929,21 @@ if (__DEV__) {
     }
   };
 
+  // Check whether accessing an export may be side-effectful
+  const isExportSafeToAccess = (
+    moduleExports: Exports,
+    key: string,
+  ): boolean => {
+    return (
+      // Transformed ESM syntax uses getters to support live bindings - we
+      // consider those safe. ESM itself does not allow user-defined getters
+      // on exports.
+      moduleExports?.__esModule ||
+      // CommonJS modules exporting getters may have side-effects.
+      Object.getOwnPropertyDescriptor(moduleExports, key)?.get == null
+    );
+  };
+
   // Modules that only export components become React Refresh boundaries.
   var isReactRefreshBoundary = function (
     Refresh: any,
@@ -945,9 +962,7 @@ if (__DEV__) {
       hasExports = true;
       if (key === '__esModule') {
         continue;
-      }
-      const desc = Object.getOwnPropertyDescriptor<any>(moduleExports, key);
-      if (desc && desc.get) {
+      } else if (!isExportSafeToAccess(moduleExports, key)) {
         // Don't invoke getters as they may have side effects.
         return false;
       }
@@ -992,9 +1007,7 @@ if (__DEV__) {
     for (const key in moduleExports) {
       if (key === '__esModule') {
         continue;
-      }
-      const desc = Object.getOwnPropertyDescriptor<any>(moduleExports, key);
-      if (desc && desc.get) {
+      } else if (!isExportSafeToAccess(moduleExports, key)) {
         continue;
       }
       const exportValue = moduleExports[key];
@@ -1016,8 +1029,7 @@ if (__DEV__) {
       return;
     }
     for (const key in moduleExports) {
-      const desc = Object.getOwnPropertyDescriptor<any>(moduleExports, key);
-      if (desc && desc.get) {
+      if (!isExportSafeToAccess(moduleExports, key)) {
         // Don't invoke getters as they may have side effects.
         continue;
       }