metro-runtime 0.71.1 → 0.71.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "metro-runtime",
-  "version": "0.71.1",
+  "version": "0.71.2",
   "description": "🚇 Module required for evaluating Metro bundles.",
   "main": "src",
   "repository": {

package/src/polyfills/require.js

@@ -111,14 +111,17 @@ function metroRequire(moduleId) {
     if (initializingIndex !== -1) {
       const cycle = initializingModuleIds
         .slice(initializingIndex)
-        .map((id) => (modules[id] ? modules[id].verboseName : "[unknown]")); // We want to show A -> B -> A:
+        .map((id) => (modules[id] ? modules[id].verboseName : "[unknown]"));
 
-      cycle.push(cycle[0]);
-      console.warn(
-        `Require cycle: ${cycle.join(" -> ")}\n\n` +
-          "Require cycles are allowed, but can result in uninitialized values. " +
-          "Consider refactoring to remove the need for a cycle."
-      );
+      if (shouldPrintRequireCycle(cycle)) {
+        cycle.push(cycle[0]); // We want to print A -> B -> A:
+
+        console.warn(
+          `Require cycle: ${cycle.join(" -> ")}\n\n` +
+            "Require cycles are allowed, but can result in uninitialized values. " +
+            "Consider refactoring to remove the need for a cycle."
+        );
+      }
     }
   }
 
@@ -126,6 +129,21 @@ function metroRequire(moduleId) {
   return module && module.isInitialized
     ? module.publicModule.exports
     : guardedLoadModule(moduleIdReallyIsNumber, module);
+} // We print require cycles unless they match a pattern in the
+// `requireCycleIgnorePatterns` configuration.
+
+function shouldPrintRequireCycle(modules) {
+  const regExps =
+    global[__METRO_GLOBAL_PREFIX__ + "__requireCycleIgnorePatterns"];
+
+  if (!Array.isArray(regExps)) {
+    return true;
+  }
+
+  const isIgnored = (module) =>
+    module != null && regExps.some((regExp) => regExp.test(module)); // Print the cycle unless any part of it is ignored
+
+  return modules.every((module) => !isIgnored(module));
 }
 
 function metroImportDefault(moduleId) {

package/src/polyfills/require.js.flow

@@ -177,13 +177,15 @@ function metroRequire(moduleId: ModuleID | VerboseModuleNameForDev): Exports {
         .map((id: number) =>
           modules[id] ? modules[id].verboseName : '[unknown]',
         );
-      // We want to show A -> B -> A:
-      cycle.push(cycle[0]);
-      console.warn(
-        `Require cycle: ${cycle.join(' -> ')}\n\n` +
-          'Require cycles are allowed, but can result in uninitialized values. ' +
-          'Consider refactoring to remove the need for a cycle.',
-      );
+
+      if (shouldPrintRequireCycle(cycle)) {
+        cycle.push(cycle[0]); // We want to print A -> B -> A:
+        console.warn(
+          `Require cycle: ${cycle.join(' -> ')}\n\n` +
+            'Require cycles are allowed, but can result in uninitialized values. ' +
+            'Consider refactoring to remove the need for a cycle.',
+        );
+      }
     }
   }
 
@@ -194,6 +196,22 @@ function metroRequire(moduleId: ModuleID | VerboseModuleNameForDev): Exports {
     : guardedLoadModule(moduleIdReallyIsNumber, module);
 }
 
+// We print require cycles unless they match a pattern in the
+// `requireCycleIgnorePatterns` configuration.
+function shouldPrintRequireCycle(modules: $ReadOnlyArray<?string>): boolean {
+  const regExps =
+    global[__METRO_GLOBAL_PREFIX__ + '__requireCycleIgnorePatterns'];
+  if (!Array.isArray(regExps)) {
+    return true;
+  }
+
+  const isIgnored = module =>
+    module != null && regExps.some(regExp => regExp.test(module));
+
+  // Print the cycle unless any part of it is ignored
+  return modules.every(module => !isIgnored(module));
+}
+
 function metroImportDefault(moduleId: ModuleID | VerboseModuleNameForDev) {
   if (__DEV__ && typeof moduleId === 'string') {
     const verboseName = moduleId;