metal-orm 1.0.39 → 1.0.41

package/src/core/dialect/base/groupby-compiler.ts

@@ -1,4 +1,6 @@
-import { SelectQueryNode } from '../../ast/query.js';
+import { OrderingTerm, SelectQueryNode } from '../../ast/query.js';
+
+type TermRenderer = (term: OrderingTerm) => string;
 
 /**
  * Compiler for GROUP BY clauses in SELECT statements.
@@ -8,14 +10,12 @@ export class GroupByCompiler {
   /**
    * Compiles GROUP BY clause from a SELECT query AST.
    * @param ast - The SELECT query AST containing grouping columns.
-   * @param quoteIdentifier - Function to quote identifiers according to dialect rules.
+   * @param renderTerm - Function to render a grouping term.
    * @returns SQL GROUP BY clause (e.g., " GROUP BY table.col1, table.col2") or empty string if no grouping.
    */
-  static compileGroupBy(ast: SelectQueryNode, quoteIdentifier: (id: string) => string): string {
+  static compileGroupBy(ast: SelectQueryNode, renderTerm: TermRenderer): string {
     if (!ast.groupBy || ast.groupBy.length === 0) return '';
-    const cols = ast.groupBy
-      .map(c => `${quoteIdentifier(c.table)}.${quoteIdentifier(c.name)}`)
-      .join(', ');
+    const cols = ast.groupBy.map(renderTerm).join(', ');
     return ` GROUP BY ${cols}`;
   }
 }

package/src/core/dialect/base/join-compiler.ts

@@ -1,22 +1,19 @@
-import { SelectQueryNode } from '../../ast/query.js';
 import { CompilerContext } from '../abstract.js';
+import { JoinNode } from '../../ast/join.js';
 
 /**
  * Compiler for JOIN clauses in SELECT statements.
  * Handles compilation of all join types (INNER, LEFT, RIGHT, FULL, CROSS).
  */
 export class JoinCompiler {
-  /**
-   * Compiles all JOIN clauses from a SELECT query AST.
-   * @param ast - The SELECT query AST containing join definitions.
-   * @param ctx - The compiler context for expression compilation.
-   * @param compileFrom - Function to compile table sources (tables or subqueries).
-   * @param compileExpression - Function to compile join condition expressions.
-   * @returns SQL JOIN clauses (e.g., " LEFT JOIN table ON condition") or empty string if no joins.
-   */
-  static compileJoins(ast: SelectQueryNode, ctx: CompilerContext, compileFrom: (from: any, ctx: CompilerContext) => string, compileExpression: (expr: any, ctx: CompilerContext) => string): string {
-    if (!ast.joins || ast.joins.length === 0) return '';
-    const parts = ast.joins.map(j => {
+  static compileJoins(
+    joins: JoinNode[] | undefined,
+    ctx: CompilerContext,
+    compileFrom: (from: any, ctx: CompilerContext) => string,
+    compileExpression: (expr: any, ctx: CompilerContext) => string
+  ): string {
+    if (!joins || joins.length === 0) return '';
+    const parts = joins.map(j => {
       const table = compileFrom(j.table as any, ctx);
       const cond = compileExpression(j.condition, ctx);
       return `${j.kind} JOIN ${table} ON ${cond}`;

package/src/core/dialect/base/orderby-compiler.ts

@@ -1,4 +1,8 @@
-import { SelectQueryNode } from '../../ast/query.js';
+import { OrderByNode, SelectQueryNode } from '../../ast/query.js';
+
+type NullsRenderer = (order: OrderByNode) => string | undefined;
+type CollationRenderer = (order: OrderByNode) => string | undefined;
+type TermRenderer = (term: OrderByNode['term']) => string;
 
 /**
  * Compiler for ORDER BY clauses in SELECT statements.
@@ -8,14 +12,24 @@ export class OrderByCompiler {
   /**
    * Compiles ORDER BY clause from a SELECT query AST.
    * @param ast - The SELECT query AST containing sort specifications.
-   * @param quoteIdentifier - Function to quote identifiers according to dialect rules.
+   * @param renderTerm - Function to render an ordering term.
+   * @param renderNulls - Optional function to render NULLS FIRST/LAST.
+   * @param renderCollation - Optional function to render COLLATE clause.
    * @returns SQL ORDER BY clause (e.g., " ORDER BY table.col1 ASC, table.col2 DESC") or empty string if no ordering.
    */
-  static compileOrderBy(ast: SelectQueryNode, quoteIdentifier: (id: string) => string): string {
+  static compileOrderBy(
+    ast: SelectQueryNode,
+    renderTerm: TermRenderer,
+    renderNulls?: NullsRenderer,
+    renderCollation?: CollationRenderer
+  ): string {
     if (!ast.orderBy || ast.orderBy.length === 0) return '';
-    const parts = ast.orderBy
-      .map(o => `${quoteIdentifier(o.column.table)}.${quoteIdentifier(o.column.name)} ${o.direction}`)
-      .join(', ');
+    const parts = ast.orderBy.map(o => {
+      const term = renderTerm(o.term);
+      const collation = renderCollation ? renderCollation(o) : o.collation ? ` COLLATE ${o.collation}` : '';
+      const nulls = renderNulls ? renderNulls(o) : o.nulls ? ` NULLS ${o.nulls}` : '';
+      return `${term} ${o.direction}${collation}${nulls}`;
+    }).join(', ');
     return ` ORDER BY ${parts}`;
   }
 }

package/src/core/dialect/base/sql-dialect.ts

@@ -1,138 +1,194 @@
-import { CompilerContext, Dialect } from '../abstract.js';
-import { SelectQueryNode, InsertQueryNode, UpdateQueryNode, DeleteQueryNode, TableSourceNode, DerivedTableNode, FunctionTableNode } from '../../ast/query.js';
-import { ColumnNode } from '../../ast/expression.js';
+import { CompilerContext, Dialect } from '../abstract.js';
+import {
+  SelectQueryNode,
+  InsertQueryNode,
+  UpdateQueryNode,
+  DeleteQueryNode,
+  InsertSourceNode,
+  TableSourceNode,
+  DerivedTableNode,
+  FunctionTableNode,
+  OrderByNode,
+  TableNode
+} from '../../ast/query.js';
+import { ColumnNode } from '../../ast/expression.js';
 import { FunctionTableFormatter } from './function-table-formatter.js';
-import { PaginationStrategy, StandardLimitOffsetPagination } from './pagination-strategy.js';
-import { CteCompiler } from './cte-compiler.js';
-import { ReturningStrategy, NoReturningStrategy } from './returning-strategy.js';
-import { JoinCompiler } from './join-compiler.js';
-import { GroupByCompiler } from './groupby-compiler.js';
-import { OrderByCompiler } from './orderby-compiler.js';
-
-
-export abstract class SqlDialectBase extends Dialect {
-  abstract quoteIdentifier(id: string): string;
-
-  protected paginationStrategy: PaginationStrategy = new StandardLimitOffsetPagination();
-  protected returningStrategy: ReturningStrategy = new NoReturningStrategy();
-
-  protected compileSelectAst(ast: SelectQueryNode, ctx: CompilerContext): string {
-    const hasSetOps = !!(ast.setOps && ast.setOps.length);
-    const ctes = CteCompiler.compileCtes(
-      ast,
-      ctx,
-      this.quoteIdentifier.bind(this),
-      this.compileSelectAst.bind(this),
-      this.normalizeSelectAst?.bind(this) ?? ((a) => a),
-      this.stripTrailingSemicolon.bind(this)
-    );
-    const baseAst: SelectQueryNode = hasSetOps
-      ? { ...ast, setOps: undefined, orderBy: undefined, limit: undefined, offset: undefined }
-      : ast;
-    const baseSelect = this.compileSelectCore(baseAst, ctx);
-    if (!hasSetOps) {
-      return `${ctes}${baseSelect}`;
-    }
-    return this.compileSelectWithSetOps(ast, baseSelect, ctes, ctx);
-  }
-
-  private compileSelectWithSetOps(
-    ast: SelectQueryNode,
-    baseSelect: string,
-    ctes: string,
-    ctx: CompilerContext
-  ): string {
-    const compound = ast.setOps!
-      .map(op => `${op.operator} ${this.wrapSetOperand(this.compileSelectAst(op.query, ctx))}`)
-      .join(' ');
-    const orderBy = OrderByCompiler.compileOrderBy(ast, this.quoteIdentifier.bind(this));
-    const pagination = this.paginationStrategy.compilePagination(ast.limit, ast.offset);
-    const combined = `${this.wrapSetOperand(baseSelect)} ${compound}`;
-    return `${ctes}${combined}${orderBy}${pagination}`;
-  }
-
-  protected compileInsertAst(ast: InsertQueryNode, ctx: CompilerContext): string {
-    const table = this.compileTableName(ast.into);
-    const columnList = this.compileInsertColumnList(ast.columns);
-    const values = this.compileInsertValues(ast.values, ctx);
-    const returning = this.compileReturning(ast.returning, ctx);
-    return `INSERT INTO ${table} (${columnList}) VALUES ${values}${returning}`;
-  }
-
-  protected compileReturning(returning: ColumnNode[] | undefined, ctx: CompilerContext): string {
-    return this.returningStrategy.compileReturning(returning, ctx);
-  }
-
+import { PaginationStrategy, StandardLimitOffsetPagination } from './pagination-strategy.js';
+import { CteCompiler } from './cte-compiler.js';
+import { ReturningStrategy, NoReturningStrategy } from './returning-strategy.js';
+import { JoinCompiler } from './join-compiler.js';
+import { GroupByCompiler } from './groupby-compiler.js';
+import { OrderByCompiler } from './orderby-compiler.js';
+
+
+export abstract class SqlDialectBase extends Dialect {
+  abstract quoteIdentifier(id: string): string;
+
+  protected paginationStrategy: PaginationStrategy = new StandardLimitOffsetPagination();
+  protected returningStrategy: ReturningStrategy = new NoReturningStrategy();
+
+  protected compileSelectAst(ast: SelectQueryNode, ctx: CompilerContext): string {
+    const hasSetOps = !!(ast.setOps && ast.setOps.length);
+    const ctes = CteCompiler.compileCtes(
+      ast,
+      ctx,
+      this.quoteIdentifier.bind(this),
+      this.compileSelectAst.bind(this),
+      this.normalizeSelectAst?.bind(this) ?? ((a) => a),
+      this.stripTrailingSemicolon.bind(this)
+    );
+    const baseAst: SelectQueryNode = hasSetOps
+      ? { ...ast, setOps: undefined, orderBy: undefined, limit: undefined, offset: undefined }
+      : ast;
+    const baseSelect = this.compileSelectCore(baseAst, ctx);
+    if (!hasSetOps) {
+      return `${ctes}${baseSelect}`;
+    }
+    return this.compileSelectWithSetOps(ast, baseSelect, ctes, ctx);
+  }
+
+  private compileSelectWithSetOps(
+    ast: SelectQueryNode,
+    baseSelect: string,
+    ctes: string,
+    ctx: CompilerContext
+  ): string {
+    const compound = ast.setOps!
+      .map(op => `${op.operator} ${this.wrapSetOperand(this.compileSelectAst(op.query, ctx))}`)
+      .join(' ');
+    const orderBy = OrderByCompiler.compileOrderBy(
+      ast,
+      term => this.compileOrderingTerm(term, ctx),
+      this.renderOrderByNulls.bind(this),
+      this.renderOrderByCollation.bind(this)
+    );
+    const pagination = this.paginationStrategy.compilePagination(ast.limit, ast.offset);
+    const combined = `${this.wrapSetOperand(baseSelect)} ${compound}`;
+    return `${ctes}${combined}${orderBy}${pagination}`;
+  }
+
+  protected compileInsertAst(ast: InsertQueryNode, ctx: CompilerContext): string {
+    if (!ast.columns.length) {
+      throw new Error('INSERT queries must specify columns.');
+    }
+
+    const table = this.compileTableName(ast.into);
+    const columnList = this.compileInsertColumnList(ast.columns);
+    const source = this.compileInsertSource(ast.source, ctx);
+    const returning = this.compileReturning(ast.returning, ctx);
+    return `INSERT INTO ${table} (${columnList}) ${source}${returning}`;
+  }
+
+  protected compileReturning(returning: ColumnNode[] | undefined, ctx: CompilerContext): string {
+    return this.returningStrategy.compileReturning(returning, ctx);
+  }
+
+  private compileInsertSource(source: InsertSourceNode, ctx: CompilerContext): string {
+    if (source.type === 'InsertValues') {
+      if (!source.rows.length) {
+        throw new Error('INSERT ... VALUES requires at least one row.');
+      }
+      const values = source.rows
+        .map(row => `(${row.map(value => this.compileOperand(value, ctx)).join(', ')})`)
+        .join(', ');
+      return `VALUES ${values}`;
+    }
+
+    const normalized = this.normalizeSelectAst(source.query);
+    return this.compileSelectAst(normalized, ctx).trim();
+  }
+
   private compileInsertColumnList(columns: ColumnNode[]): string {
     return columns.map(column => this.quoteIdentifier(column.name)).join(', ');
   }
-
-  private compileInsertValues(values: any[][], ctx: CompilerContext): string {
-    return values
-      .map(row => `(${row.map(value => this.compileOperand(value, ctx)).join(', ')})`)
-      .join(', ');
-  }
-
-  private compileSelectCore(ast: SelectQueryNode, ctx: CompilerContext): string {
-    const columns = this.compileSelectColumns(ast, ctx);
-    const from = this.compileFrom(ast.from, ctx);
-    const joins = JoinCompiler.compileJoins(ast, ctx, this.compileFrom.bind(this), this.compileExpression.bind(this));
-    const whereClause = this.compileWhere(ast.where, ctx);
-    const groupBy = GroupByCompiler.compileGroupBy(ast, this.quoteIdentifier.bind(this));
-    const having = this.compileHaving(ast, ctx);
-    const orderBy = OrderByCompiler.compileOrderBy(ast, this.quoteIdentifier.bind(this));
-    const pagination = this.paginationStrategy.compilePagination(ast.limit, ast.offset);
-    return `SELECT ${this.compileDistinct(ast)}${columns} FROM ${from}${joins}${whereClause}${groupBy}${having}${orderBy}${pagination}`;
-  }
-
-  protected compileUpdateAst(ast: UpdateQueryNode, ctx: CompilerContext): string {
-    const table = this.compileTableName(ast.table);
-    const assignments = this.compileUpdateAssignments(ast.set, ctx);
-    const whereClause = this.compileWhere(ast.where, ctx);
-    const returning = this.compileReturning(ast.returning, ctx);
-    return `UPDATE ${table} SET ${assignments}${whereClause}${returning}`;
-  }
-
-  private compileUpdateAssignments(
-    assignments: { column: ColumnNode; value: any }[],
-    ctx: CompilerContext
-  ): string {
+
+  private compileSelectCore(ast: SelectQueryNode, ctx: CompilerContext): string {
+    const columns = this.compileSelectColumns(ast, ctx);
+    const from = this.compileFrom(ast.from, ctx);
+    const joins = JoinCompiler.compileJoins(
+      ast.joins,
+      ctx,
+      this.compileFrom.bind(this),
+      this.compileExpression.bind(this)
+    );
+    const whereClause = this.compileWhere(ast.where, ctx);
+    const groupBy = GroupByCompiler.compileGroupBy(ast, term => this.compileOrderingTerm(term, ctx));
+    const having = this.compileHaving(ast, ctx);
+    const orderBy = OrderByCompiler.compileOrderBy(
+      ast,
+      term => this.compileOrderingTerm(term, ctx),
+      this.renderOrderByNulls.bind(this),
+      this.renderOrderByCollation.bind(this)
+    );
+    const pagination = this.paginationStrategy.compilePagination(ast.limit, ast.offset);
+    return `SELECT ${this.compileDistinct(ast)}${columns} FROM ${from}${joins}${whereClause}${groupBy}${having}${orderBy}${pagination}`;
+  }
+
+  protected compileUpdateAst(ast: UpdateQueryNode, ctx: CompilerContext): string {
+    const target = this.compileTableReference(ast.table);
+    const assignments = this.compileUpdateAssignments(ast.set, ast.table, ctx);
+    const fromClause = this.compileUpdateFromClause(ast, ctx);
+    const whereClause = this.compileWhere(ast.where, ctx);
+    const returning = this.compileReturning(ast.returning, ctx);
+    return `UPDATE ${target} SET ${assignments}${fromClause}${whereClause}${returning}`;
+  }
+
+  private compileUpdateAssignments(
+    assignments: { column: ColumnNode; value: any }[],
+    table: TableNode,
+    ctx: CompilerContext
+  ): string {
     return assignments
       .map(assignment => {
         const col = assignment.column;
-        const target = this.quoteIdentifier(col.name);
+        const target = this.compileQualifiedColumn(col, table);
         const value = this.compileOperand(assignment.value, ctx);
         return `${target} = ${value}`;
       })
       .join(', ');
   }
-
-  protected compileDeleteAst(ast: DeleteQueryNode, ctx: CompilerContext): string {
-    const table = this.compileTableName(ast.from);
-    const whereClause = this.compileWhere(ast.where, ctx);
-    const returning = this.compileReturning(ast.returning, ctx);
-    return `DELETE FROM ${table}${whereClause}${returning}`;
-  }
-
-  protected formatReturningColumns(returning: ColumnNode[]): string {
-    return this.returningStrategy.formatReturningColumns(returning, this.quoteIdentifier.bind(this));
-  }
-
-  protected compileDistinct(ast: SelectQueryNode): string {
-    return ast.distinct ? 'DISTINCT ' : '';
-  }
-
-  protected compileSelectColumns(ast: SelectQueryNode, ctx: CompilerContext): string {
-    return ast.columns.map(c => {
-      const expr = this.compileOperand(c, ctx);
-      if (c.alias) {
-        if (c.alias.includes('(')) return c.alias;
-        return `${expr} AS ${this.quoteIdentifier(c.alias)}`;
-      }
-      return expr;
-    }).join(', ');
-  }
-
+
+  protected compileQualifiedColumn(column: ColumnNode, table: TableNode): string {
+    const baseTableName = table.name;
+    const alias = table.alias;
+    const columnTable = column.table ?? alias ?? baseTableName;
+    const tableQualifier =
+      alias && column.table === baseTableName ? alias : columnTable;
+
+    if (!tableQualifier) {
+      return this.quoteIdentifier(column.name);
+    }
+
+    return `${this.quoteIdentifier(tableQualifier)}.${this.quoteIdentifier(column.name)}`;
+  }
+
+  protected compileDeleteAst(ast: DeleteQueryNode, ctx: CompilerContext): string {
+    const target = this.compileTableReference(ast.from);
+    const usingClause = this.compileDeleteUsingClause(ast, ctx);
+    const whereClause = this.compileWhere(ast.where, ctx);
+    const returning = this.compileReturning(ast.returning, ctx);
+    return `DELETE FROM ${target}${usingClause}${whereClause}${returning}`;
+  }
+
+  protected formatReturningColumns(returning: ColumnNode[]): string {
+    return this.returningStrategy.formatReturningColumns(returning, this.quoteIdentifier.bind(this));
+  }
+
+  protected compileDistinct(ast: SelectQueryNode): string {
+    return ast.distinct ? 'DISTINCT ' : '';
+  }
+
+  protected compileSelectColumns(ast: SelectQueryNode, ctx: CompilerContext): string {
+    return ast.columns.map(c => {
+      const expr = this.compileOperand(c, ctx);
+      if (c.alias) {
+        if (c.alias.includes('(')) return c.alias;
+        return `${expr} AS ${this.quoteIdentifier(c.alias)}`;
+      }
+      return expr;
+    }).join(', ');
+  }
+
   protected compileFrom(ast: SelectQueryNode['from'], ctx?: CompilerContext): string {
     const tableSource = ast as any;
     if (tableSource.type === 'FunctionTable') {
@@ -170,24 +226,67 @@ export abstract class SqlDialectBase extends Dialect {
     return table.alias ? `${base} AS ${this.quoteIdentifier(table.alias)}` : base;
   }
 
-  protected compileTableName(table: { name: string; schema?: string }): string {
+  protected compileTableName(table: { name: string; schema?: string; alias?: string }): string {
     if (table.schema) {
       return `${this.quoteIdentifier(table.schema)}.${this.quoteIdentifier(table.name)}`;
     }
     return this.quoteIdentifier(table.name);
   }
-
-  protected compileHaving(ast: SelectQueryNode, ctx: CompilerContext): string {
-    if (!ast.having) return '';
-    return ` HAVING ${this.compileExpression(ast.having, ctx)}`;
-  }
-
-  protected stripTrailingSemicolon(sql: string): string {
-    return sql.trim().replace(/;$/, '');
-  }
-
-  protected wrapSetOperand(sql: string): string {
-    const trimmed = this.stripTrailingSemicolon(sql);
-    return `(${trimmed})`;
-  }
+
+  protected compileTableReference(table: { name: string; schema?: string; alias?: string }): string {
+    const base = this.compileTableName(table);
+    return table.alias ? `${base} AS ${this.quoteIdentifier(table.alias)}` : base;
+  }
+
+  private compileUpdateFromClause(ast: UpdateQueryNode, ctx: CompilerContext): string {
+    if (!ast.from && (!ast.joins || ast.joins.length === 0)) return '';
+    if (!ast.from) {
+      throw new Error('UPDATE with JOINs requires an explicit FROM clause.');
+    }
+    const from = this.compileFrom(ast.from, ctx);
+    const joins = JoinCompiler.compileJoins(
+      ast.joins,
+      ctx,
+      this.compileFrom.bind(this),
+      this.compileExpression.bind(this)
+    );
+    return ` FROM ${from}${joins}`;
+  }
+
+  private compileDeleteUsingClause(ast: DeleteQueryNode, ctx: CompilerContext): string {
+    if (!ast.using && (!ast.joins || ast.joins.length === 0)) return '';
+    if (!ast.using) {
+      throw new Error('DELETE with JOINs requires a USING clause.');
+    }
+    const usingTable = this.compileFrom(ast.using, ctx);
+    const joins = JoinCompiler.compileJoins(
+      ast.joins,
+      ctx,
+      this.compileFrom.bind(this),
+      this.compileExpression.bind(this)
+    );
+    return ` USING ${usingTable}${joins}`;
+  }
+
+  protected compileHaving(ast: SelectQueryNode, ctx: CompilerContext): string {
+    if (!ast.having) return '';
+    return ` HAVING ${this.compileExpression(ast.having, ctx)}`;
+  }
+
+  protected stripTrailingSemicolon(sql: string): string {
+    return sql.trim().replace(/;$/, '');
+  }
+
+  protected wrapSetOperand(sql: string): string {
+    const trimmed = this.stripTrailingSemicolon(sql);
+    return `(${trimmed})`;
+  }
+
+  protected renderOrderByNulls(order: OrderByNode): string | undefined {
+    return order.nulls ? ` NULLS ${order.nulls}` : '';
+  }
+
+  protected renderOrderByCollation(order: OrderByNode): string | undefined {
+    return order.collation ? ` COLLATE ${order.collation}` : '';
+  }
 }