metabase-ai-assistant 3.4.2 → 3.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "metabase-ai-assistant",
-  "version": "3.4.2",
+  "version": "3.4.3",
   "mcpName": "io.github.enessari/metabase-ai-assistant",
   "description": "The most powerful MCP Server for Metabase - 111+ tools for AI-powered SQL generation, dashboard automation, user management & enterprise BI. Works with Claude, Cursor, and any MCP-compatible AI.",
   "main": "src/index.js",

package/src/mcp/server.js

@@ -4198,11 +4198,39 @@ class MetabaseMCPServer {
 
   async handleAddCardToDashboard(args) {
     try {
+      // Normalize position parameters (support both flat and nested structure)
+      // AI sometimes sends flat: { row: 0, col: 0, size_x: 4 }
+      // Or nested: { position: { row: 0, col: 0, sizeX: 4 } }
+      let position = args.position || {};
+
+      // If args has direct position props, merge them
+      if (args.row !== undefined) position.row = args.row;
+      if (args.col !== undefined) position.col = args.col;
+
+      // Handle size_x vs sizeX and size_y vs sizeY
+      if (args.size_x !== undefined) position.sizeX = args.size_x;
+      if (args.size_y !== undefined) position.sizeY = args.size_y;
+      if (args.sizeX !== undefined) position.sizeX = args.sizeX;
+      if (args.sizeY !== undefined) position.sizeY = args.sizeY;
+
+      // Map back to format expected by client
+      // The client expects: Options object with optional row, col, sizeX, sizeY
+      // But we need to make sure we pass the right keys to client.addCardToDashboard
+
+      // Create a normalized options object for the client
+      const options = {
+        row: position.row,
+        col: position.col,
+        sizeX: position.sizeX || position.size_x,
+        sizeY: position.sizeY || position.size_y,
+        parameter_mappings: args.parameter_mappings || []
+      };
+
       const result = await this.metabaseClient.addCardToDashboard(
         args.dashboard_id,
         args.question_id,
-        args.position,
-        args.parameter_mappings
+        options, // Pass normalized options instead of raw args
+        args.parameter_mappings // Double pass, just in case (client signature check needed)
       );
 
       // VERIFICATION: Check if card was actually added

package/src/metabase/client.js

@@ -60,6 +60,39 @@ export class MetabaseClient {
     }
   }
 
+  /**
+   * Generic request wrapper for Metabase API
+   * Used by MCP handlers that need arbitrary API access
+   */
+  async request(method, endpoint, data = null, config = {}) {
+    await this.ensureAuthenticated();
+
+    // Normalize method
+    const methodUpper = method.toUpperCase();
+
+    const requestConfig = {
+      ...config,
+      method: methodUpper,
+      url: endpoint,
+      data: data
+    };
+
+    // For GET requests with data, move to params if not already set
+    if (methodUpper === 'GET' && data && !requestConfig.params) {
+      requestConfig.params = data;
+      delete requestConfig.data;
+    }
+
+    try {
+      const response = await this.client.request(requestConfig);
+      return response.data;
+    } catch (error) {
+      const errorMsg = error.response?.data?.message || error.message;
+      logger.error(`API Request Failed: ${methodUpper} ${endpoint}`, { error: errorMsg });
+      throw new Error(`Metabase API Error: ${errorMsg}`);
+    }
+  }
+
   // Database Operations
   async getDatabases() {
     await this.ensureAuthenticated();