mervexai 0.0.97

package/src/cli/ui.ts

@@ -0,0 +1,131 @@
+import { EOL } from "os"
+import { Schema } from "effect"
+import { logo as glyphs } from "./logo"
+
+const wordmark = [
+  `█▄▄ █▀▀ █▀█ █▄▄ █▀▀ █  █`,
+  `█▄█ ██▄ █▀▄ █▄█ ██▄ █  █`,
+  `█ █ █▄▄ █ █ █▄▄ █▄▄ █▄▄█`,
+]
+
+export class CancelledError extends Schema.TaggedErrorClass<CancelledError>()("UICancelledError", {}) {}
+
+export const Style = {
+  TEXT_HIGHLIGHT: "\x1b[96m",
+  TEXT_HIGHLIGHT_BOLD: "\x1b[96m\x1b[1m",
+  TEXT_DIM: "\x1b[90m",
+  TEXT_DIM_BOLD: "\x1b[90m\x1b[1m",
+  TEXT_NORMAL: "\x1b[0m",
+  TEXT_NORMAL_BOLD: "\x1b[1m",
+  TEXT_WARNING: "\x1b[93m",
+  TEXT_WARNING_BOLD: "\x1b[93m\x1b[1m",
+  TEXT_DANGER: "\x1b[91m",
+  TEXT_DANGER_BOLD: "\x1b[91m\x1b[1m",
+  TEXT_SUCCESS: "\x1b[92m",
+  TEXT_SUCCESS_BOLD: "\x1b[92m\x1b[1m",
+  TEXT_INFO: "\x1b[94m",
+  TEXT_INFO_BOLD: "\x1b[94m\x1b[1m",
+}
+
+export function println(...message: string[]) {
+  print(...message)
+  process.stderr.write(EOL)
+}
+
+export function print(...message: string[]) {
+  blank = false
+  process.stderr.write(message.join(" "))
+}
+
+let blank = false
+export function empty() {
+  if (blank) return
+  println("" + Style.TEXT_NORMAL)
+  blank = true
+}
+
+export function logo(pad?: string) {
+  if (!process.stdout.isTTY && !process.stderr.isTTY) {
+    const result = []
+    for (const row of wordmark) {
+      if (pad) result.push(pad)
+      result.push(row)
+      result.push(EOL)
+    }
+    return result.join("").trimEnd()
+  }
+
+  const result: string[] = []
+  const reset = "\x1b[0m"
+  const left = {
+    fg: "\x1b[90m",
+    shadow: "\x1b[38;5;235m",
+    bg: "\x1b[48;5;235m",
+  }
+  const right = {
+    fg: reset,
+    shadow: "\x1b[38;5;238m",
+    bg: "\x1b[48;5;238m",
+  }
+  const gap = " "
+  const draw = (line: string, fg: string, shadow: string, bg: string) => {
+    const parts: string[] = []
+    for (const char of line) {
+      if (char === "_") {
+        parts.push(bg, " ", reset)
+        continue
+      }
+      if (char === "^") {
+        parts.push(fg, bg, "▀", reset)
+        continue
+      }
+      if (char === "~") {
+        parts.push(shadow, "▀", reset)
+        continue
+      }
+      if (char === " ") {
+        parts.push(" ")
+        continue
+      }
+      parts.push(fg, char, reset)
+    }
+    return parts.join("")
+  }
+  glyphs.left.forEach((row, index) => {
+    if (pad) result.push(pad)
+    result.push(draw(row, left.fg, left.shadow, left.bg))
+    result.push(gap)
+    const other = glyphs.right[index] ?? ""
+    result.push(draw(other, right.fg, right.shadow, right.bg))
+    result.push(EOL)
+  })
+  return result.join("").trimEnd()
+}
+
+export async function input(prompt: string): Promise<string> {
+  const readline = require("readline")
+  const rl = readline.createInterface({
+    input: process.stdin,
+    output: process.stdout,
+  })
+
+  return new Promise((resolve) => {
+    rl.question(prompt, (answer: string) => {
+      rl.close()
+      resolve(answer.trim())
+    })
+  })
+}
+
+export function error(message: string) {
+  if (message.startsWith("Error: ")) {
+    message = message.slice("Error: ".length)
+  }
+  println(Style.TEXT_DANGER_BOLD + "Error: " + Style.TEXT_NORMAL + message)
+}
+
+export function markdown(text: string): string {
+  return text
+}
+
+export * as UI from "./ui"

package/src/cli/upgrade.ts

@@ -0,0 +1,68 @@
+import { Config } from "@/config/config"
+import { AppRuntime } from "@/effect/app-runtime"
+import { Flag } from "@msrfteam/core/flag/flag"
+import { Installation } from "@/installation"
+import { InstallationVersion } from "@msrfteam/core/installation/version"
+import { GlobalBus } from "@/bus/global"
+import semver from "semver"
+
+function isNewer(latest: string, current: string): boolean {
+  try {
+    return semver.gt(latest, current)
+  } catch {
+    return latest !== current
+  }
+}
+
+export async function upgrade() {
+  const config = await AppRuntime.runPromise(Config.Service.use((cfg) => cfg.getGlobal()))
+  if (config.autoupdate === false || Flag.MERVEX_DISABLE_AUTOUPDATE) return
+  const method = await Installation.method()
+  const latest = await Installation.latest(method).catch(() => {})
+  if (!latest) return
+
+  // Never prompt or upgrade when the published release is not newer
+  // than the running build (e.g. local dev builds ahead of releases).
+  if (!isNewer(latest, InstallationVersion)) return
+
+  const prompt = config.autoupdate === "prompt"
+
+  if (Flag.MERVEX_ALWAYS_NOTIFY_UPDATE) {
+    GlobalBus.emit("event", {
+      directory: "global",
+      payload: {
+        type: Installation.Event.UpdateAvailable.type,
+        properties: { version: latest, prompt },
+      },
+    })
+    return
+  }
+
+  if (InstallationVersion === latest) return
+
+  const kind = Installation.getReleaseType(InstallationVersion, latest)
+
+  if (prompt || config.autoupdate === "notify" || kind !== "patch") {
+    GlobalBus.emit("event", {
+      directory: "global",
+      payload: {
+        type: Installation.Event.UpdateAvailable.type,
+        properties: { version: latest, prompt },
+      },
+    })
+    return
+  }
+
+  if (method === "unknown") return
+  await Installation.upgrade(method, latest)
+    .then(() =>
+      GlobalBus.emit("event", {
+        directory: "global",
+        payload: {
+          type: Installation.Event.Updated.type,
+          properties: { version: latest },
+        },
+      }),
+    )
+    .catch(() => {})
+}

package/src/command/index.ts

@@ -0,0 +1,328 @@
+import { LayerNode } from "@msrfteam/core/effect/layer-node"
+import path from "path"
+import { InstanceState } from "@/effect/instance-state"
+import { EffectBridge } from "@/effect/bridge"
+import type { InstanceContext } from "@/project/instance-context"
+import { Effect, Layer, Context, Schema } from "effect"
+import { Config } from "@/config/config"
+import { Provider } from "@/provider/provider"
+import { ProviderV2 } from "@msrfteam/core/provider"
+import { ModelV2 } from "@msrfteam/core/model"
+import { MCP } from "../mcp"
+import { Skill } from "../skill"
+import PROMPT_INITIALIZE from "./template/initialize.txt"
+import PROMPT_REVIEW from "./template/review.txt"
+import { LegacyEvent } from "@msrfteam/schema/legacy-event"
+
+type State = {
+  commands: Record<string, Info>
+}
+
+export const Event = {
+  Executed: LegacyEvent.CommandExecuted,
+}
+
+export const Info = Schema.Struct({
+  name: Schema.String,
+  description: Schema.optional(Schema.String),
+  agent: Schema.optional(Schema.String),
+  model: Schema.optional(Schema.String),
+  source: Schema.optional(Schema.Literals(["command", "mcp", "skill"])),
+  // Some command templates are lazy promises from MCP prompt resolution.
+  template: Schema.Unknown,
+  subtask: Schema.optional(Schema.Boolean),
+  hints: Schema.Array(Schema.String),
+}).annotate({ identifier: "Command" })
+
+export type Info = Omit<Schema.Schema.Type<typeof Info>, "template"> & { template: Promise<string> | string }
+
+export function hints(template: string) {
+  const result: string[] = []
+  const numbered = template.match(/\$\d+/g)
+  if (numbered) {
+    for (const match of [...new Set(numbered)].sort()) result.push(match)
+  }
+  if (template.includes("$ARGUMENTS")) result.push("$ARGUMENTS")
+  return result
+}
+
+export const Default = {
+  INIT: "init",
+  REVIEW: "review",
+} as const
+
+export interface Interface {
+  readonly get: (name: string) => Effect.Effect<Info | undefined>
+  readonly list: () => Effect.Effect<Info[]>
+}
+
+export class Service extends Context.Service<Service, Interface>()("@mervex/Command") {}
+
+const layer = Layer.effect(
+  Service,
+  Effect.gen(function* () {
+    const config = yield* Config.Service
+    const provider = yield* Provider.Service
+    const mcp = yield* MCP.Service
+    const skill = yield* Skill.Service
+
+    const init = Effect.fn("Command.state")(function* (ctx: InstanceContext) {
+      const cfg = yield* config.get()
+      const bridge = yield* EffectBridge.make()
+      const commands: Record<string, Info> = {}
+
+      const modelID = cfg.model
+      const [providerIDStr, modelIDStr] = modelID ? modelID.split("/") : ["", ""]
+      const ctxInfo: { modelID: string; modelName: string; context: number; output: number } = {
+        modelID: modelID ?? "unknown",
+        modelName: "unknown",
+        context: 0,
+        output: 0,
+      }
+      if (providerIDStr && modelIDStr) {
+        const result = yield* provider
+          .getModel(ProviderV2.ID.make(providerIDStr), ModelV2.ID.make(modelIDStr))
+          .pipe(Effect.catch(() => Effect.succeed(undefined)))
+        if (result) {
+          ctxInfo.modelName = result.name
+          ctxInfo.context = result.limit.context
+          ctxInfo.output = result.limit.output
+        }
+      }
+
+      commands[Default.INIT] = {
+        name: Default.INIT,
+        description: "guided AGENTS.md setup",
+        source: "command",
+        get template() {
+          return PROMPT_INITIALIZE.replace("${path}", ctx.worktree)
+        },
+        hints: hints(PROMPT_INITIALIZE),
+      }
+      commands[Default.REVIEW] = {
+        name: Default.REVIEW,
+        description: "review changes [commit|branch|pr], defaults to uncommitted",
+        source: "command",
+        get template() {
+          return PROMPT_REVIEW.replace("${path}", ctx.worktree)
+        },
+        subtask: true,
+        hints: hints(PROMPT_REVIEW),
+      }
+      commands["repomap"] = {
+        name: "repomap",
+        description: "generate a codebase map showing files, functions, and classes",
+        source: "command",
+        get template() {
+          return "Please generate a repository map of the current codebase. Use the repomap tool to scan the codebase and show the most important files, functions, and classes."
+        },
+        hints: [],
+      }
+      commands["architect"] = {
+        name: "architect",
+        description: "switch to architect mode — analyze and plan only, no code changes",
+        source: "command",
+        agent: "architect",
+        get template() {
+          return "Switched to architect mode. Analyze the codebase, design solutions, and create plans. Do NOT modify any files."
+        },
+        hints: [],
+      }
+      commands["ask"] = {
+        name: "ask",
+        description: "switch to ask mode — answer questions only, no code changes",
+        source: "command",
+        agent: "ask",
+        get template() {
+          return "Switched to ask mode. Answer questions about the codebase. Do NOT modify any files."
+        },
+        hints: [],
+      }
+      commands["context"] = {
+        name: "context",
+        description: "show current model context window size and usage information",
+        source: "command",
+        get template() {
+          return `Current model: ${ctxInfo.modelName} (${ctxInfo.modelID}).
+Context window: ${ctxInfo.context} tokens.
+Max output: ${ctxInfo.output} tokens.
+Report the current token usage if available, otherwise explain the model limits.`
+        },
+        hints: [],
+      }
+      commands["add"] = {
+        name: "add",
+        description: "pin files into every reply, usage: /add <file...> (bare /add lists pinned)",
+        source: "command",
+        get template() {
+          return "List the pinned files."
+        },
+        hints: ["$ARGUMENTS"],
+      }
+      commands["drop"] = {
+        name: "drop",
+        description: "unpin files from reply context, usage: /drop <file...> (bare /drop lists pinned)",
+        source: "command",
+        get template() {
+          return "List the pinned files."
+        },
+        hints: ["$ARGUMENTS"],
+      }
+      commands["commit"] = {
+        name: "commit",
+        description: "generate a commit message with AI and commit all working-tree changes",
+        source: "command",
+        get template() {
+          return "Commit all working-tree changes with an AI-generated conventional commit message."
+        },
+        hints: [],
+      }
+      commands["add-model"] = {
+        name: "add-model",
+        description:
+          "add a custom model, usage: /add-model <providerID> <modelID> [name] [baseURL] [apiKey] (missing parts are asked interactively)",
+        source: "command",
+        get template() {
+          return `Add a custom model to the Mervex config.
+
+User input: $ARGUMENTS
+
+Follow these steps exactly:
+
+1. Parse the user input as: <providerID> <modelID> [display name] [baseURL] [apiKey]. Any part may be missing.
+2. For every missing part, use the question tool to ask the user:
+   - providerID: which provider owns the model (offer the already-configured provider IDs first, plus a "new provider" option).
+   - modelID: the exact model ID as the provider API expects it.
+   - display name: optional, defaults to the model ID.
+   - baseURL and apiKey: only needed for a brand-new provider. Assume "@ai-sdk/openai-compatible" for new providers unless the user says otherwise.
+3. Read the global config file (mervex.jsonc under the global config directory) with the read tool. Never invent the path: resolve it via the config directory.
+4. Merge the model in with the edit tool (small exact-string edits, never rewrite the whole file):
+   - Existing provider: add "provider": { "<providerID>": { "models": { "<modelID>": { "name": "<display name>" } } } }, creating missing objects along the path.
+   - New provider: add a full entry with "npm": "@ai-sdk/openai-compatible", "name", "options": { "baseURL": ..., "apiKey": ... }, and the "models" object above.
+5. Verify the file is still valid JSONC by reading the edited section back.
+6. Tell the user the CLI must be restarted for the new model to appear in the model list, and show the exact "providerID/modelID" string to select.`
+        },
+        hints: ["$ARGUMENTS"],
+      }
+      commands["doctor"] = {
+        name: "doctor",
+        description: "diagnose config, models, providers, git and session health",
+        source: "command",
+        get template() {
+          return "Run a health check and report the results."
+        },
+        hints: [],
+      }
+      commands["usage"] = {
+        name: "usage",
+        description: "show session token usage, cost, duration and changed files",
+        source: "command",
+        get template() {
+          return "Report this session's usage statistics."
+        },
+        hints: [],
+      }
+      commands["repair"] = {
+        name: "repair",
+        description: "diagnose and fix config, provider and model problems, then report ready",
+        source: "command",
+        get template() {
+          return `Repair this Mervex setup. Work through these steps and report "READY" only when done:
+
+1. Read the global config file (mervex.jsonc under the global config directory) and check it parses. If it is corrupt, fix it with small exact-string edits (never rewrite the whole file) and keep a backup of every secret value already present.
+2. Run the CLI doctor flow yourself: execute \`mervex --repair\` in the shell and read its output. It tests providers and models with automatic fallback.
+3. If a provider or model fails, investigate (bad key, rate limit, overload, wrong baseURL) and fix the config. Never invent credentials: if a key is missing or invalid, use the question tool to ask the user for it.
+4. Keep retrying across the configured providers and models until one answers. Do not loop forever: stop after every candidate was tried twice.
+5. When a working provider/model answers, reply with READY and the exact "providerID/modelID" string the user should select.`
+        },
+        hints: [],
+      }
+
+      for (const [name, command] of Object.entries(cfg.command ?? {})) {
+        commands[name] = {
+          name,
+          agent: command.agent,
+          model: command.model,
+          description: command.description,
+          source: "command",
+          get template() {
+            return command.template
+          },
+          subtask: command.subtask,
+          hints: hints(command.template),
+        }
+      }
+
+      for (const [name, prompt] of Object.entries(yield* mcp.prompts())) {
+        commands[name] = {
+          name,
+          source: "mcp",
+          description: prompt.description,
+          get template() {
+            return bridge.promise(
+              mcp
+                .getPrompt(
+                  prompt.client,
+                  prompt.name,
+                  prompt.arguments
+                    ? Object.fromEntries(prompt.arguments.map((argument, i) => [argument.name, `$${i + 1}`]))
+                    : {},
+                )
+                .pipe(
+                  Effect.map(
+                    (template) =>
+                      template?.messages
+                        .map((message) => (message.content.type === "text" ? message.content.text : ""))
+                        .join("\n") || "",
+                  ),
+                ),
+            )
+          },
+          hints: prompt.arguments?.map((_, i) => `$${i + 1}`) ?? [],
+        }
+      }
+
+      for (const item of yield* skill.all()) {
+        if (commands[item.name]) continue
+        const dir = item.location === "<built-in>" ? undefined : path.dirname(item.location)
+        commands[item.name] = {
+          name: item.name,
+          description: item.description,
+          source: "skill",
+          get template() {
+            if (!dir) return item.content
+            return [
+              item.content,
+              "",
+              `Base directory for this skill: ${dir}`,
+              "Relative paths in this skill (e.g., scripts/, references/) are relative to this base directory.",
+            ].join("\n")
+          },
+          hints: [],
+        }
+      }
+
+      return {
+        commands,
+      }
+    })
+
+    const state = yield* InstanceState.make<State>((ctx) => init(ctx))
+
+    const get = Effect.fn("Command.get")(function* (name: string) {
+      const s = yield* InstanceState.get(state)
+      return s.commands[name]
+    })
+
+    const list = Effect.fn("Command.list")(function* () {
+      const s = yield* InstanceState.get(state)
+      return Object.values(s.commands)
+    })
+
+    return Service.of({ get, list })
+  }),
+)
+
+export const node = LayerNode.make({ service: Service, layer: layer, deps: [Config.node, Provider.node, MCP.node, Skill.node] })
+
+export * as Command from "."

package/src/command/template/initialize.txt

@@ -0,0 +1,66 @@
+Create or update `AGENTS.md` for this repository.
+
+The goal is a compact instruction file that helps future Mervex sessions avoid mistakes and ramp up quickly. Every line should answer: "Would an agent likely miss this without help?" If not, leave it out.
+
+User-provided focus or constraints (honor these):
+$ARGUMENTS
+
+## How to investigate
+
+Read the highest-value sources first:
+- `README*`, root manifests, workspace config, lockfiles
+- build, test, lint, formatter, typecheck, and codegen config
+- CI workflows and pre-commit / task runner config
+- existing instruction files (`AGENTS.md`, `CLAUDE.md`, `.cursor/rules/`, `.cursorrules`, `.github/copilot-instructions.md`)
+- repo-local Mervex config such as `mervex.json`
+
+If architecture is still unclear after reading config and docs, inspect a small number of representative code files to find the real entrypoints, package boundaries, and execution flow. Prefer reading the files that explain how the system is wired together over random leaf files.
+
+Prefer executable sources of truth over prose. If docs conflict with config or scripts, trust the executable source and only keep what you can verify.
+
+## What to extract
+
+Look for the highest-signal facts for an agent working in this repo:
+- exact developer commands, especially non-obvious ones
+- how to run a single test, a single package, or a focused verification step
+- required command order when it matters, such as `lint -> typecheck -> test`
+- monorepo or multi-package boundaries, ownership of major directories, and the real app/library entrypoints
+- framework or toolchain quirks: generated code, migrations, codegen, build artifacts, special env loading, dev servers, infra deploy flow
+- repo-specific style or workflow conventions that differ from defaults
+- testing quirks: fixtures, integration test prerequisites, snapshot workflows, required services, flaky or expensive suites
+- important constraints from existing instruction files worth preserving
+
+Good `AGENTS.md` content is usually hard-earned context that took reading multiple files to infer.
+
+## Questions
+
+Only ask the user questions if the repo cannot answer something important. Use the `question` tool for one short batch at most.
+
+Good questions:
+- undocumented team conventions
+- branch / PR / release expectations
+- missing setup or test prerequisites that are known but not written down
+
+Do not ask about anything the repo already makes clear.
+
+## Writing rules
+
+Include only high-signal, repo-specific guidance such as:
+- exact commands and shortcuts the agent would otherwise guess wrong
+- architecture notes that are not obvious from filenames
+- conventions that differ from language or framework defaults
+- setup requirements, environment quirks, and operational gotchas
+- references to existing instruction sources that matter
+
+Exclude:
+- generic software advice
+- long tutorials or exhaustive file trees
+- obvious language conventions
+- speculative claims or anything you could not verify
+- content better stored in another file referenced via `mervex.json` `instructions`
+
+When in doubt, omit.
+
+Prefer short sections and bullets. If the repo is simple, keep the file simple. If the repo is large, summarize the few structural facts that actually change how an agent should work.
+
+If `AGENTS.md` already exists at `${path}`, improve it in place rather than rewriting blindly. Preserve verified useful guidance, delete fluff or stale claims, and reconcile it with the current codebase.

package/src/command/template/review.txt

@@ -0,0 +1,101 @@
+You are a code reviewer. Your job is to review code changes and provide actionable feedback.
+
+---
+
+Input: $ARGUMENTS
+
+---
+
+## Determining What to Review
+
+Based on the input provided, determine which type of review to perform:
+
+1. **No arguments (default)**: Review all uncommitted changes
+   - Run: `git diff` for unstaged changes
+   - Run: `git diff --cached` for staged changes
+   - Run: `git status --short` to identify untracked (net new) files
+
+2. **Commit hash** (40-char SHA or short hash): Review that specific commit
+   - Run: `git show $ARGUMENTS`
+
+3. **Branch name**: Compare current branch to the specified branch
+   - Run: `git diff $ARGUMENTS...HEAD`
+
+4. **PR URL or number** (contains "github.com" or "pull" or looks like a PR number): Review the pull request
+   - Run: `gh pr view $ARGUMENTS` to get PR context
+   - Run: `gh pr diff $ARGUMENTS` to get the diff
+
+Use best judgement when processing input.
+
+---
+
+## Gathering Context
+
+**Diffs alone are not enough.** After getting the diff, read the entire file(s) being modified to understand the full context. Code that looks wrong in isolation may be correct given surrounding logic—and vice versa.
+
+- Use the diff to identify which files changed
+- Use `git status --short` to identify untracked files, then read their full contents
+- Read the full file to understand existing patterns, control flow, and error handling
+- Check for existing style guide or conventions files (CONVENTIONS.md, AGENTS.md, .editorconfig, etc.)
+
+---
+
+## What to Look For
+
+**Bugs** - Your primary focus.
+- Logic errors, off-by-one mistakes, incorrect conditionals
+- If-else guards: missing guards, incorrect branching, unreachable code paths
+- Edge cases: null/empty/undefined inputs, error conditions, race conditions
+- Security issues: injection, auth bypass, data exposure
+- Broken error handling that swallows failures, throws unexpectedly or returns error types that are not caught.
+
+**Structure** - Does the code fit the codebase?
+- Does it follow existing patterns and conventions?
+- Are there established abstractions it should use but doesn't?
+- Excessive nesting that could be flattened with early returns or extraction
+
+**Performance** - Only flag if obviously problematic.
+- O(n²) on unbounded data, N+1 queries, blocking I/O on hot paths
+
+**Behavior Changes** - If a behavioral change is introduced, raise it (especially if it's possibly unintentional).
+
+---
+
+## Before You Flag Something
+
+**Be certain.** If you're going to call something a bug, you need to be confident it actually is one.
+
+- Only review the changes - do not review pre-existing code that wasn't modified
+- Don't flag something as a bug if you're unsure - investigate first
+- Don't invent hypothetical problems - if an edge case matters, explain the realistic scenario where it breaks
+- If you need more context to be sure, use the tools below to get it
+
+**Don't be a zealot about style.** When checking code against conventions:
+
+- Verify the code is *actually* in violation. Don't complain about else statements if early returns are already being used correctly.
+- Some "violations" are acceptable when they're the simplest option. A `let` statement is fine if the alternative is convoluted.
+- Excessive nesting is a legitimate concern regardless of other style choices.
+- Don't flag style preferences as issues unless they clearly violate established project conventions.
+
+---
+
+## Tools
+
+Use these to inform your review:
+
+- **Explore agent** - Find how existing code handles similar problems. Check patterns, conventions, and prior art before claiming something doesn't fit.
+- **Exa Code Context** - Verify correct usage of libraries/APIs before flagging something as wrong.
+- **Web Search** - Research best practices if you're unsure about a pattern.
+
+If you're uncertain about something and can't verify it with these tools, say "I'm not sure about X" rather than flagging it as a definite issue.
+
+---
+
+## Output
+
+1. If there is a bug, be direct and clear about why it is a bug.
+2. Clearly communicate severity of issues. Do not overstate severity.
+3. Critiques should clearly and explicitly communicate the scenarios, environments, or inputs that are necessary for the bug to arise. The comment should immediately indicate that the issue's severity depends on these factors.
+4. Your tone should be matter-of-fact and not accusatory or overly positive. It should read as a helpful AI assistant suggestion without sounding too much like a human reviewer.
+5. Write so the reader can quickly understand the issue without reading too closely.
+6. AVOID flattery, do not give any comments that are not helpful to the reader. Avoid phrasing like "Great job ...", "Thanks for ...".