memtrace 0.3.89 → 0.3.90

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "memtrace",
-  "version": "0.3.89",
+  "version": "0.3.90",
   "description": "Code intelligence graph — MCP server + AI agent skills + visualization UI",
   "keywords": [
     "mcp",
@@ -39,11 +39,11 @@
     "fs-extra": "^11.0.0"
   },
   "optionalDependencies": {
-    "@memtrace/darwin-arm64": "0.3.89",
-    "@memtrace/linux-x64": "0.3.89",
-    "@memtrace/win32-x64": "0.3.89",
-    "@memtrace/linux-x64-noavx2": "0.3.89",
-    "@memtrace/win32-x64-noavx2": "0.3.89"
+    "@memtrace/darwin-arm64": "0.3.90",
+    "@memtrace/linux-x64": "0.3.90",
+    "@memtrace/win32-x64": "0.3.90",
+    "@memtrace/linux-x64-noavx2": "0.3.90",
+    "@memtrace/win32-x64-noavx2": "0.3.90"
   },
   "engines": {
     "node": ">=18"

package/uninstall.js

@@ -294,7 +294,85 @@ function legacyCleanup(options = {}) {
   removeClaudeIntegration(home);
 }
 
+function killRunningMemtraceProcesses(env = process.env) {
+  // npm's atomic global install on macOS / Linux works by renaming the
+  // existing `node_modules/memtrace` directory aside (to a `.memtrace-XXXX`
+  // tempname) before extracting the new tarball. If any memtrace process
+  // is still running — a long-lived daemon from `memtrace start`, an MCP
+  // server an agent left attached, the file watcher — the binary on disk
+  // is mmap'd into that process and the rename fails with ENOTEMPTY,
+  // leaving both the old dir AND a partially-renamed temp dir on disk.
+  // The user then has to manually rm both and retry. We can prevent that
+  // by killing memtrace processes BEFORE npm tries the rename — which is
+  // exactly what the preuninstall hook (this script) runs.
+  //
+  // Self-upgrade case: `memtrace install` sets MEMTRACE_INSTALL_PARENT=1
+  // before spawning npm, so the running memtrace binary is OUR PARENT.
+  // Killing it would abort the npm install we're a child of. Skip in
+  // that path — the parent will exit cleanly after its npm child returns
+  // and the rename will succeed on its way out.
+  if (env.MEMTRACE_INSTALL_PARENT === "1") {
+    return;
+  }
+
+  const tryKill = (cmd, args) => {
+    try {
+      spawnSync(cmd, args, { stdio: "ignore" });
+    } catch {
+      // taskkill / pkill missing from PATH is rare but possible inside
+      // pared-down containers or locked-down enterprise images. We don't
+      // want to abort the user's install because a process-killer isn't
+      // installed — fall through and let npm's rename try its luck.
+    }
+  };
+
+  if (process.platform === "win32") {
+    // /F  = force terminate
+    // /T  = also kill child processes (file watchers, embed-worker children
+    //       spawned by `memtrace start`, MCP server's notify-rs threads)
+    // /IM = match by image name; covers every launcher because the npm
+    //       shim execs the same `memtrace.exe` binary regardless of
+    //       `start` / `mcp` / `daemon` argv.
+    tryKill("taskkill", ["/F", "/T", "/IM", "memtrace.exe"]);
+    // Defensive: some Windows installs end up with a `node.exe` running
+    // `memtrace.js` (the npm shim) that hasn't yet exec'd the platform
+    // binary. Kill any node process whose command line references our
+    // shim path via PowerShell — wrapped so a missing PS install (rare
+    // on modern Windows but possible on Server Core) doesn't abort.
+    tryKill("powershell", [
+      "-NoProfile",
+      "-NonInteractive",
+      "-Command",
+      "Get-CimInstance Win32_Process -Filter \"Name='node.exe'\" | " +
+        "Where-Object { $_.CommandLine -like '*memtrace*\\bin\\memtrace.js*' } | " +
+        "ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue }",
+    ]);
+  } else {
+    // Three patterns cover every launcher shape the binary exposes.
+    // `pkill -f` matches against the full command line, so `memtrace mcp`
+    // catches both the npm-shim invocation AND the platform binary it
+    // exec'd into. Missing-process exit (1) is ignored via stdio: ignore.
+    tryKill("pkill", ["-9", "-f", "memtrace mcp"]);
+    tryKill("pkill", ["-9", "-f", "memtrace start"]);
+    tryKill("pkill", ["-9", "-f", "memtrace daemon"]);
+  }
+
+  // Settle window: SIGKILL / taskkill is synchronous but the OS needs a
+  // tick to tear down mmap'd page tables and release directory entries.
+  // - macOS / Linux: 200ms is enough on every machine tested; the vnode
+  //   reference usually drops within ~50ms after TASK_INACTIVE.
+  // - Windows: longer hold because Windows Defender, Search Indexer, and
+  //   any OneDrive sync agent each take a file-handle reference when the
+  //   binary exits. 750ms is empirically enough to clear those — well
+  //   under any human-noticeable install delay.
+  const settleMs = process.platform === "win32" ? 750 : 200;
+  const until = Date.now() + settleMs;
+  // eslint-disable-next-line no-empty
+  while (Date.now() < until) {}
+}
+
 function run() {
+  killRunningMemtraceProcesses();
   console.log("memtrace: cleaning up...");
 
   // Try delegating to the compiled installer (handles ALL agents via registry)
@@ -346,6 +424,7 @@ module.exports = {
   removeMemtraceHomeDir,
   isUpgradeLifecycle,
   shouldPurgeMemtraceHomeDir,
+  killRunningMemtraceProcesses,
   removeClaudeIntegration,
   legacyCleanup,
 };