memtrace 0.3.33 → 0.3.35

package/uninstall.js

@@ -6,6 +6,17 @@ const path = require("path");
 const fs = require("fs");
 const { execSync, spawnSync } = require("child_process");
 
+// claude-integration may not be present in old installs running this
+// uninstall script from ~/.memtrace/. Resolve it lazily so the absence
+// of the module is a soft no-op.
+function loadClaudeIntegration() {
+  try {
+    return require("./lib/claude-integration");
+  } catch {
+    return null;
+  }
+}
+
 // ── Constants ─────────────────────────────────────────────────────────────────
 
 const PLUGIN_NAME = "memtrace-skills";
@@ -42,9 +53,13 @@ const SKILL_NAMES = [
 ];
 
 // ── Remove skills ───────────────────────────────────────────────────────────
+//
+// Each cleanup helper takes an optional `home` parameter so we can
+// drive it against a tmp dir in tests. Production callers pass
+// nothing and the helper defaults to the real home directory.
 
-function removeSkills() {
-  const claudeSkillsDir = path.join(os.homedir(), ".claude", "skills");
+function removeSkills(home = os.homedir()) {
+  const claudeSkillsDir = path.join(home, ".claude", "skills");
   let removed = 0;
 
   for (const name of SKILL_NAMES) {
@@ -62,15 +77,20 @@ function removeSkills() {
   if (removed > 0) {
     console.log(`memtrace: removed ${removed} skills from ${claudeSkillsDir}`);
   }
+  return removed;
 }
 
 // ── Settings.json helpers ────────────────────────────────────────────────────
 
-function readSettings() {
-  const settingsFile = path.join(os.homedir(), ".claude", "settings.json");
-  if (fs.existsSync(settingsFile)) {
+function settingsPath(home = os.homedir()) {
+  return path.join(home, ".claude", "settings.json");
+}
+
+function readSettings(home = os.homedir()) {
+  const file = settingsPath(home);
+  if (fs.existsSync(file)) {
     try {
-      return JSON.parse(fs.readFileSync(settingsFile, "utf-8"));
+      return JSON.parse(fs.readFileSync(file, "utf-8"));
     } catch {
       return {};
     }
@@ -78,9 +98,8 @@ function readSettings() {
   return {};
 }
 
-function writeSettings(settings) {
-  const settingsFile = path.join(os.homedir(), ".claude", "settings.json");
-  fs.writeFileSync(settingsFile, JSON.stringify(settings, null, 2) + "\n");
+function writeSettings(settings, home = os.homedir()) {
+  fs.writeFileSync(settingsPath(home), JSON.stringify(settings, null, 2) + "\n");
 }
 
 function isRecord(value) {
@@ -89,8 +108,8 @@ function isRecord(value) {
 
 // ── Remove MCP server ───────────────────────────────────────────────────────
 
-function removeMcpServer() {
-  const settings = readSettings();
+function removeMcpServer(home = os.homedir()) {
+  const settings = readSettings(home);
   let changed = false;
 
   if (isRecord(settings.mcpServers) && settings.mcpServers[MCP_SERVER_NAME]) {
@@ -102,13 +121,14 @@ function removeMcpServer() {
     console.log("memtrace: removed MCP server from ~/.claude/settings.json");
   }
 
-  if (changed) writeSettings(settings);
+  if (changed) writeSettings(settings, home);
+  return changed;
 }
 
 // ── Remove plugin + marketplace ─────────────────────────────────────────────
 
-function removePlugin() {
-  const settings = readSettings();
+function removePlugin(home = os.homedir()) {
+  const settings = readSettings(home);
   let changed = false;
 
   if (isRecord(settings.enabledPlugins)) {
@@ -144,34 +164,38 @@ function removePlugin() {
     console.log(`memtrace: removed marketplace ${MARKETPLACE_NAME}`);
   }
 
-  if (changed) writeSettings(settings);
+  if (changed) writeSettings(settings, home);
+  return changed;
 }
 
-function removeMarketplaceCaches() {
-  const marketplacesRoot = path.join(os.homedir(), ".claude", "plugins", "marketplaces");
+function removeMarketplaceCaches(home = os.homedir()) {
+  const marketplacesRoot = path.join(home, ".claude", "plugins", "marketplaces");
+  let removed = 0;
   for (const entry of MARKETPLACE_SETTING_KEYS) {
     const dir = path.join(marketplacesRoot, entry);
     if (fs.existsSync(dir)) {
       try {
         fs.rmSync(dir, { recursive: true, force: true });
         console.log(`memtrace: removed marketplace cache ${entry}`);
+        removed++;
       } catch (e) {
         console.warn(`memtrace: failed to remove marketplace cache ${entry}: ${e.message}`);
       }
     }
   }
+  return removed;
 }
 
-function removeInstalledPluginMetadata() {
-  const installedPluginsFile = path.join(os.homedir(), ".claude", "plugins", "installed_plugins.json");
-  if (!fs.existsSync(installedPluginsFile)) return;
+function removeInstalledPluginMetadata(home = os.homedir()) {
+  const installedPluginsFile = path.join(home, ".claude", "plugins", "installed_plugins.json");
+  if (!fs.existsSync(installedPluginsFile)) return false;
   let data;
   try {
     data = JSON.parse(fs.readFileSync(installedPluginsFile, "utf-8"));
   } catch {
-    return;
+    return false;
   }
-  if (!isRecord(data.plugins)) return;
+  if (!isRecord(data.plugins)) return false;
 
   let changed = false;
   for (const key of Object.keys(data.plugins)) {
@@ -184,6 +208,19 @@ function removeInstalledPluginMetadata() {
     fs.writeFileSync(installedPluginsFile, JSON.stringify(data, null, 2) + "\n");
     console.log("memtrace: removed plugin metadata");
   }
+  return changed;
+}
+
+function removeMemtraceHomeDir(home = os.homedir()) {
+  const memtraceDir = path.join(home, ".memtrace");
+  if (!fs.existsSync(memtraceDir)) return false;
+  try {
+    fs.rmSync(memtraceDir, { recursive: true, force: true });
+    return true;
+  } catch (e) {
+    console.warn(`memtrace: failed to remove ${memtraceDir}: ${e.message}`);
+    return false;
+  }
 }
 
 // ── Try Claude CLI uninstall ────────────────────────────────────────────────
@@ -209,15 +246,30 @@ function tryClaudeCliUninstall() {
 
 // ── Main uninstall logic ───────────────────────────────────────────────────
 
+function removeClaudeIntegration(home = os.homedir()) {
+  const ci = loadClaudeIntegration();
+  if (!ci) return;
+  try {
+    const summary = ci.uninstallFromFs({ claudeDir: path.join(home, ".claude") });
+    if (summary.removed.length > 0) {
+      console.log(`memtrace: cleaned Claude Code integration (${summary.removed.length} item(s))`);
+    }
+  } catch (e) {
+    console.warn(`memtrace: Claude Code integration cleanup failed: ${e.message}`);
+  }
+}
+
 function legacyCleanup(options = {}) {
-  try { removeSkills(); } catch (e) { console.warn(`memtrace: skill removal failed: ${e.message}`); }
+  const home = options.home || os.homedir();
+  try { removeSkills(home); } catch (e) { console.warn(`memtrace: skill removal failed: ${e.message}`); }
   if (!options.skipClaudeCli) {
     try { tryClaudeCliUninstall(); } catch { /* silent */ }
   }
-  try { removePlugin(); } catch (e) { console.warn(`memtrace: plugin removal failed: ${e.message}`); }
-  try { removeMcpServer(); } catch (e) { console.warn(`memtrace: MCP server removal failed: ${e.message}`); }
-  try { removeMarketplaceCaches(); } catch (e) { console.warn(`memtrace: marketplace cache cleanup failed: ${e.message}`); }
-  try { removeInstalledPluginMetadata(); } catch (e) { console.warn(`memtrace: installed plugin metadata cleanup failed: ${e.message}`); }
+  try { removePlugin(home); } catch (e) { console.warn(`memtrace: plugin removal failed: ${e.message}`); }
+  try { removeMcpServer(home); } catch (e) { console.warn(`memtrace: MCP server removal failed: ${e.message}`); }
+  try { removeMarketplaceCaches(home); } catch (e) { console.warn(`memtrace: marketplace cache cleanup failed: ${e.message}`); }
+  try { removeInstalledPluginMetadata(home); } catch (e) { console.warn(`memtrace: installed plugin metadata cleanup failed: ${e.message}`); }
+  removeClaudeIntegration(home);
 }
 
 function run() {
@@ -242,23 +294,39 @@ function run() {
   }
 
   // Always clean up ~/.memtrace/
-  try {
-    const memtraceDir = path.join(os.homedir(), ".memtrace");
-    if (fs.existsSync(memtraceDir)) {
-      fs.rmSync(memtraceDir, { recursive: true, force: true });
-      console.log("memtrace: removed ~/.memtrace/");
-    }
-  } catch (e) {
-    console.warn(`memtrace: failed to remove ~/.memtrace/: ${e.message}`);
+  if (removeMemtraceHomeDir()) {
+    console.log("memtrace: removed ~/.memtrace/");
   }
 
   console.log("memtrace: uninstall complete");
 }
 
-// Run when called directly (npm preuninstall hook) or when require()'d
+// Exports for testability. legacyCleanup accepts `{ home }` so test
+// suites can drive the full cleanup pipeline against a tmp dir.
+module.exports = {
+  SKILL_NAMES,
+  PLUGIN_KEY,
+  PLUGIN_NAME,
+  MARKETPLACE_NAME,
+  MCP_SERVER_NAME,
+  MARKETPLACE_SETTING_KEYS,
+  MARKETPLACE_SETTING_CONTAINERS,
+  removeSkills,
+  readSettings,
+  writeSettings,
+  removeMcpServer,
+  removePlugin,
+  removeMarketplaceCaches,
+  removeInstalledPluginMetadata,
+  removeMemtraceHomeDir,
+  removeClaudeIntegration,
+  legacyCleanup,
+};
+
+// Run when called directly (npm preuninstall hook). When require()'d
+// for tests, exports are available without running. The `memtrace
+// uninstall` CLI invokes run() through bin/memtrace.js, not via this
+// module's auto-execution.
 if (require.main === module) {
   run();
-} else {
-  // Called via `memtrace uninstall` — run immediately
-  run();
 }