memory-lancedb-pro 1.0.24 → 1.0.25

package/index.ts

@@ -743,11 +743,22 @@ function parsePluginConfig(value: unknown): PluginConfig {
   }
 
   // Accept single key (string) or array of keys for round-robin rotation
-  const apiKey: string | string[] = typeof embedding.apiKey === "string"
-    ? embedding.apiKey
-    : Array.isArray(embedding.apiKey) && embedding.apiKey.length > 0 && embedding.apiKey.every((k: unknown) => typeof k === "string")
-      ? (embedding.apiKey as string[])
-      : process.env.OPENAI_API_KEY || "";
+  let apiKey: string | string[];
+  if (typeof embedding.apiKey === "string") {
+    apiKey = embedding.apiKey;
+  } else if (Array.isArray(embedding.apiKey) && embedding.apiKey.length > 0) {
+    // Validate every element is a non-empty string
+    const invalid = embedding.apiKey.findIndex((k: unknown) => typeof k !== "string" || (k as string).trim().length === 0);
+    if (invalid !== -1) {
+      throw new Error(`embedding.apiKey[${invalid}] is invalid: expected non-empty string`);
+    }
+    apiKey = embedding.apiKey as string[];
+  } else if (embedding.apiKey !== undefined) {
+    // apiKey is present but wrong type — throw, don't silently fall back
+    throw new Error("embedding.apiKey must be a string or non-empty array of strings");
+  } else {
+    apiKey = process.env.OPENAI_API_KEY || "";
+  }
 
   if (!apiKey || (Array.isArray(apiKey) && apiKey.length === 0)) {
     throw new Error("embedding.apiKey is required (set directly or via OPENAI_API_KEY env var)");

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "memory-lancedb-pro",
   "name": "Memory (LanceDB Pro)",
   "description": "Enhanced LanceDB-backed long-term memory with hybrid retrieval, multi-scope isolation, long-context chunking, and management CLI",
-  "version": "1.0.23",
+  "version": "1.0.24",
   "kind": "memory",
   "configSchema": {
     "type": "object",
@@ -18,8 +18,18 @@
           },
           "apiKey": {
             "oneOf": [
-              { "type": "string" },
-              { "type": "array", "items": { "type": "string" }, "minItems": 1 }
+              {
+                "type": "string",
+                "minLength": 1
+              },
+              {
+                "type": "array",
+                "items": {
+                  "type": "string",
+                  "minLength": 1
+                },
+                "minItems": 1
+              }
             ],
             "description": "Single API key or array of keys for round-robin rotation"
           },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "memory-lancedb-pro",
-  "version": "1.0.24",
+  "version": "1.0.25",
   "description": "OpenClaw enhanced LanceDB memory plugin with hybrid retrieval (Vector + BM25), cross-encoder rerank, multi-scope isolation, long-context chunking, and management CLI",
   "type": "module",
   "main": "index.ts",

package/src/embedder.ts

@@ -208,14 +208,28 @@ export class Embedder {
     return client;
   }
 
-  /** Check whether an error is a rate-limit / quota-exceeded error. */
+  /** Check whether an error is a rate-limit / quota-exceeded / overload error. */
   private isRateLimitError(error: unknown): boolean {
-    // OpenAI SDK typed error
-    if (error && typeof error === "object" && "status" in error && (error as any).status === 429) {
-      return true;
+    if (!error || typeof error !== "object") return false;
+
+    const err = error as Record<string, any>;
+
+    // HTTP status: 429 (rate limit) or 503 (service overload)
+    if (err.status === 429 || err.status === 503) return true;
+
+    // OpenAI SDK structured error code
+    if (err.code === "rate_limit_exceeded" || err.code === "insufficient_quota") return true;
+
+    // Nested error object (some providers)
+    const nested = err.error;
+    if (nested && typeof nested === "object") {
+      if (nested.type === "rate_limit_exceeded" || nested.type === "insufficient_quota") return true;
+      if (nested.code === "rate_limit_exceeded" || nested.code === "insufficient_quota") return true;
     }
+
+    // Fallback: message text matching
     const msg = error instanceof Error ? error.message : String(error);
-    return /rate.limit|quota|too many requests|insufficient.*credit|429/i.test(msg);
+    return /rate.limit|quota|too many requests|insufficient.*credit|429|503.*overload/i.test(msg);
   }
 
   /**
@@ -231,19 +245,27 @@ export class Embedder {
       try {
         return await client.embeddings.create(payload);
       } catch (error) {
+        lastError = error instanceof Error ? error : new Error(String(error));
+
         if (this.isRateLimitError(error) && attempt < maxAttempts - 1) {
           console.log(
-            `[memory-lancedb-pro] API key ${attempt + 1}/${maxAttempts} hit rate limit, rotating to next key...`
+            `[memory-lancedb-pro] Attempt ${attempt + 1}/${maxAttempts} hit rate limit, rotating to next key...`
           );
-          lastError = error instanceof Error ? error : new Error(String(error));
           continue;
         }
-        // Non-rate-limit error or last attempt — let caller handle
-        throw error;
+
+        // Non-rate-limit error → don't retry, let caller handle (e.g. chunking)
+        if (!this.isRateLimitError(error)) {
+          throw error;
+        }
       }
     }
 
-    throw lastError || new Error("All API keys exhausted (rate limited)");
+    // All keys exhausted with rate-limit errors
+    throw new Error(
+      `All ${maxAttempts} API keys exhausted (rate limited). Last error: ${lastError?.message || "unknown"}`,
+      { cause: lastError }
+    );
   }
 
   /** Number of API keys in the rotation pool. */