memorix 1.4.3 → 1.4.5

package/src/cli/commands/message.ts

@@ -1,27 +1,27 @@
-import { defineCommand } from 'citty';
+import { defineCommand } from 'citty';
 import { emitError, emitResult, getCliProjectContext, resolveCliActorId, shortId } from './operator-shared.js';
-
-export default defineCommand({
-  meta: {
-    name: 'message',
-    description: 'Send, broadcast, and read team messages from the CLI',
-  },
-  args: {
-    from: { type: 'string', description: 'Sender agent ID' },
-    to: { type: 'string', description: 'Recipient agent ID' },
-    type: { type: 'string', description: 'Message type (request, response, info, handoff, etc.)' },
-    content: { type: 'string', description: 'Message content' },
-    agentId: { type: 'string', description: 'Agent ID for inbox reads' },
-    markRead: { type: 'boolean', description: 'Mark inbox messages as read after listing them' },
-    toRole: { type: 'string', description: 'Optional role target for the message' },
-    handoffStatus: { type: 'string', description: 'Optional handoff status when type=handoff' },
-    json: { type: 'boolean', description: 'Emit machine-readable JSON output' },
-  },
-  run: async ({ args }) => {
-    const action = (args._ as string[])?.[0] || '';
-    const asJson = !!args.json;
-
-    try {
+
+export default defineCommand({
+  meta: {
+    name: 'message',
+    description: 'Send, broadcast, and read team messages from the CLI',
+  },
+  args: {
+    from: { type: 'string', description: 'Sender agent ID' },
+    to: { type: 'string', description: 'Recipient agent ID' },
+    type: { type: 'string', description: 'Message type (request, response, info, handoff, etc.)' },
+    content: { type: 'string', description: 'Message content' },
+    agentId: { type: 'string', description: 'Agent ID for inbox reads' },
+    markRead: { type: 'boolean', description: 'Mark inbox messages as read after listing them' },
+    toRole: { type: 'string', description: 'Optional role target for the message' },
+    handoffStatus: { type: 'string', description: 'Optional handoff status when type=handoff' },
+    json: { type: 'boolean', description: 'Emit machine-readable JSON output' },
+  },
+  run: async ({ args }) => {
+    const action = (args._ as string[])?.[0] || '';
+    const asJson = !!args.json;
+
+    try {
       const { project, teamStore, identity } = await getCliProjectContext();
       const senderAgentId = resolveCliActorId(args.from, identity, 'from');
       const inboxAgentId = resolveCliActorId(
@@ -29,65 +29,65 @@ export default defineCommand({
         identity,
         'agentId',
       );
-
-      switch (action) {
-        case 'send': {
+
+      switch (action) {
+        case 'send': {
           if (!senderAgentId || !args.type || !args.content) {
             emitError('type, content, and an active CLI identity or from agentId are required for "memorix message send"', asJson);
-            return;
-          }
-          if (!args.to && !args.toRole) {
-            emitError('Either --to or --toRole is required for "memorix message send"', asJson);
-            return;
-          }
-          const message = teamStore.sendMessage({
-            projectId: project.id,
+            return;
+          }
+          if (!args.to && !args.toRole) {
+            emitError('Either --to or --toRole is required for "memorix message send"', asJson);
+            return;
+          }
+          const message = teamStore.sendMessage({
+            projectId: project.id,
             senderAgentId,
-            recipientAgentId: (args.to as string | undefined) ?? null,
-            type: args.type as string,
-            content: args.content as string,
-            toRole: (args.toRole as string | undefined) ?? null,
-            handoffStatus:
-              (args.handoffStatus as string | undefined) ??
-              ((args.type as string) === 'handoff' ? 'open' : null),
-          });
-          if ('error' in message) {
-            emitError(message.error, asJson);
-            return;
-          }
-          emitResult(
-            { project, message },
-            `Message sent: ${shortId(message.id)} to ${args.to ? shortId(args.to as string) : `role ${args.toRole}`}`,
-            asJson,
-          );
-          return;
-        }
-
-        case 'broadcast': {
+            recipientAgentId: (args.to as string | undefined) ?? null,
+            type: args.type as string,
+            content: args.content as string,
+            toRole: (args.toRole as string | undefined) ?? null,
+            handoffStatus:
+              (args.handoffStatus as string | undefined) ??
+              ((args.type as string) === 'handoff' ? 'open' : null),
+          });
+          if ('error' in message) {
+            emitError(message.error, asJson);
+            return;
+          }
+          emitResult(
+            { project, message },
+            `Message sent: ${shortId(message.id)} to ${args.to ? shortId(args.to as string) : `role ${args.toRole}`}`,
+            asJson,
+          );
+          return;
+        }
+
+        case 'broadcast': {
           if (!senderAgentId || !args.type || !args.content) {
             emitError('type, content, and an active CLI identity or from agentId are required for "memorix message broadcast"', asJson);
-            return;
-          }
-          const message = teamStore.sendMessage({
-            projectId: project.id,
+            return;
+          }
+          const message = teamStore.sendMessage({
+            projectId: project.id,
             senderAgentId,
-            recipientAgentId: null,
-            type: args.type as string,
-            content: args.content as string,
-          });
-          if ('error' in message) {
-            emitError(message.error, asJson);
-            return;
-          }
-          emitResult(
-            { project, message },
-            `Broadcast sent: ${shortId(message.id)}`,
-            asJson,
-          );
-          return;
-        }
-
-        case 'inbox': {
+            recipientAgentId: null,
+            type: args.type as string,
+            content: args.content as string,
+          });
+          if ('error' in message) {
+            emitError(message.error, asJson);
+            return;
+          }
+          emitResult(
+            { project, message },
+            `Broadcast sent: ${shortId(message.id)}`,
+            asJson,
+          );
+          return;
+        }
+
+        case 'inbox': {
           if (!inboxAgentId) {
             emitError('an active CLI identity or agentId is required for "memorix message inbox"', asJson);
             return;
@@ -96,31 +96,31 @@ export default defineCommand({
           const unreadCount = teamStore.getUnreadCount(project.id, inboxAgentId);
           if (args.markRead) {
             teamStore.markAllRead(project.id, inboxAgentId);
-          }
-          emitResult(
-            { project, unreadCount, messages },
-            messages.length === 0
-              ? 'Inbox empty.'
-              : [`Inbox: ${unreadCount} unread / ${messages.length} total`, '', ...messages.map((message) => {
-                  const sender = teamStore.getAgent(message.sender_agent_id);
-                  return `- ${message.read_at ? ' ' : '*'} [${message.type}] from ${sender?.name ?? shortId(message.sender_agent_id)}: ${message.content}`;
-                })].join('\n'),
-            asJson,
-          );
-          return;
-        }
-
-        default:
-          console.log('Memorix Message Commands');
-          console.log('');
-          console.log('Usage:');
-          console.log('  memorix message send --from <agentId> --to <agentId> --type info --content "..."');
-          console.log('  memorix message send --from <agentId> --toRole reviewer --type handoff --content "..."');
-          console.log('  memorix message broadcast --from <agentId> --type announcement --content "..."');
-          console.log('  memorix message inbox --agentId <id> [--markRead]');
-      }
-    } catch (error) {
-      emitError(error instanceof Error ? error.message : String(error), asJson);
-    }
-  },
-});
+          }
+          emitResult(
+            { project, unreadCount, messages },
+            messages.length === 0
+              ? 'Inbox empty.'
+              : [`Inbox: ${unreadCount} unread / ${messages.length} total`, '', ...messages.map((message) => {
+                  const sender = teamStore.getAgent(message.sender_agent_id);
+                  return `- ${message.read_at ? ' ' : '*'} [${message.type}] from ${sender?.name ?? shortId(message.sender_agent_id)}: ${message.content}`;
+                })].join('\n'),
+            asJson,
+          );
+          return;
+        }
+
+        default:
+          console.log('Memorix Message Commands');
+          console.log('');
+          console.log('Usage:');
+          console.log('  memorix message send --from <agentId> --to <agentId> --type info --content "..."');
+          console.log('  memorix message send --from <agentId> --toRole reviewer --type handoff --content "..."');
+          console.log('  memorix message broadcast --from <agentId> --type announcement --content "..."');
+          console.log('  memorix message inbox --agentId <id> [--markRead]');
+      }
+    } catch (error) {
+      emitError(error instanceof Error ? error.message : String(error), asJson);
+    }
+  },
+});

package/src/cli/commands/operator-shared.ts

@@ -147,9 +147,52 @@ export function emitError(message: string, asJson?: boolean): void {
   process.exitCode = 1;
 }
 
-export function parseCsvList(input?: string | null): string[] {
+/**
+ * Coerce a citty named argument into a trimmed string.
+ *
+ * Citty accumulates repeated string flags into an array (`--text a --text b`
+ * becomes `["a", "b"]`), and Windows shells can split one long quoted
+ * argument into several argv elements that re-introduce the flag mid-value
+ * (issue #194). Joining the fragments preserves as much of the original text
+ * as possible and prevents `TypeError: named?.trim is not a function`.
+ */
+export function asStringArg(value: unknown): string | undefined {
+  if (value == null) return undefined;
+  if (typeof value === 'string') {
+    const trimmed = value.trim();
+    return trimmed.length > 0 ? trimmed : undefined;
+  }
+  if (Array.isArray(value)) {
+    const joined = value
+      .filter((item): item is string => typeof item === 'string')
+      .map((item) => item.trim())
+      .filter(Boolean)
+      .join(' ');
+    return joined.length > 0 ? joined : undefined;
+  }
+  return undefined;
+}
+
+/**
+ * Coerce a repeated scalar flag to its last value (last-wins convention for
+ * enums, IDs, and numeric limits). Repeated flags are otherwise accumulated
+ * into arrays by citty and would reach `.trim()` as non-strings.
+ */
+export function lastStringArg(value: unknown): string | undefined {
+  if (typeof value === 'string') return value;
+  if (Array.isArray(value)) {
+    const strings = value.filter((item): item is string => typeof item === 'string');
+    return strings[strings.length - 1];
+  }
+  return undefined;
+}
+
+export function parseCsvList(input?: string | string[] | null): string[] {
   if (!input) return [];
-  return input
+  const source = Array.isArray(input)
+    ? input.filter((item): item is string => typeof item === 'string').join(',')
+    : input;
+  return source
     .split(',')
     .map((item) => item.trim())
     .filter(Boolean);
@@ -174,14 +217,15 @@ export function shortId(id?: string | null): string {
   return id ? `${id.slice(0, 8)}…` : '-';
 }
 
-export function parsePositiveInt(input: string | undefined, fallback: number): number {
-  if (input == null || input.trim() === '') return fallback;
-  if (!/^\d+$/.test(input.trim())) {
-    throw new Error(`Expected a positive integer, received "${input}".`);
+export function parsePositiveInt(input: string | string[] | undefined, fallback: number): number {
+  const value = lastStringArg(input);
+  if (value == null || value.trim() === '') return fallback;
+  if (!/^\d+$/.test(value.trim())) {
+    throw new Error(`Expected a positive integer, received "${value}".`);
   }
-  const parsed = Number(input);
+  const parsed = Number(value);
   if (!Number.isSafeInteger(parsed) || parsed <= 0) {
-    throw new Error(`Expected a positive integer, received "${input}".`);
+    throw new Error(`Expected a positive integer, received "${value}".`);
   }
   return parsed;
 }
@@ -203,36 +247,36 @@ const OBSERVATION_TYPES: ObservationType[] = [
 const OBSERVATION_STATUSES: ObservationStatus[] = ['active', 'resolved', 'archived'];
 const RETRIEVAL_QUALITIES: RetrievalQuality[] = ['fast', 'balanced', 'thorough'];
 
-export function coerceObservationType(input?: string): ObservationType {
-  const normalized = (input ?? 'discovery') as ObservationType;
+export function coerceObservationType(input?: unknown): ObservationType {
+  const normalized = (lastStringArg(input) ?? 'discovery') as ObservationType;
   if (!OBSERVATION_TYPES.includes(normalized)) {
     throw new Error(
-      `Unknown observation type "${input}". Valid types: ${OBSERVATION_TYPES.join(', ')}`,
+      `Unknown observation type "${String(input ?? '')}". Valid types: ${OBSERVATION_TYPES.join(', ')}`,
     );
   }
   return normalized;
 }
 
-export function coerceObservationStatus(input?: string): ObservationStatus {
-  const normalized = (input ?? 'resolved') as ObservationStatus;
+export function coerceObservationStatus(input?: unknown): ObservationStatus {
+  const normalized = (lastStringArg(input) ?? 'resolved') as ObservationStatus;
   if (!OBSERVATION_STATUSES.includes(normalized)) {
     throw new Error(
-      `Unknown observation status "${input}". Valid statuses: ${OBSERVATION_STATUSES.join(', ')}`,
+      `Unknown observation status "${String(input ?? '')}". Valid statuses: ${OBSERVATION_STATUSES.join(', ')}`,
     );
   }
   return normalized;
 }
 
-export function coerceRetrievalQuality(input?: string): RetrievalQuality {
-  const normalized = (input ?? 'balanced').trim().toLowerCase() as RetrievalQuality;
+export function coerceRetrievalQuality(input?: unknown): RetrievalQuality {
+  const normalized = (lastStringArg(input) ?? 'balanced').trim().toLowerCase() as RetrievalQuality;
   if (!RETRIEVAL_QUALITIES.includes(normalized)) {
     throw new Error('quality must be fast, balanced, or thorough');
   }
   return normalized;
 }
 
-export function coerceObservationVisibility(input?: string): ObservationVisibility {
-  const normalized = (input ?? 'project').trim().toLowerCase();
+export function coerceObservationVisibility(input?: unknown): ObservationVisibility {
+  const normalized = (lastStringArg(input) ?? 'project').trim().toLowerCase();
   if (normalized === 'personal' || normalized === 'project' || normalized === 'team') {
     return normalized;
   }

package/src/cli/commands/poll.ts

@@ -1,32 +1,32 @@
-import { defineCommand } from 'citty';
-import { computePoll, computeWatermark } from '../../team/poll.js';
-import { getObservationStore } from '../../store/obs-store.js';
+import { defineCommand } from 'citty';
+import { computePoll, computeWatermark } from '../../team/poll.js';
+import { getObservationStore } from '../../store/obs-store.js';
 import { getAllObservations } from '../../memory/observations.js';
 import { withFreshIndex } from '../../memory/freshness.js';
 import { filterReadableObservations } from '../../memory/visibility.js';
 import { emitError, emitResult, getCliProjectContext, resolveCliActorId, shortId } from './operator-shared.js';
-
-export default defineCommand({
-  meta: {
-    name: 'poll',
-    description: 'Get a full project coordination snapshot for an agent',
-  },
-  args: {
-    agentId: { type: 'string', description: 'Agent ID for personalized situational awareness' },
-    markInboxRead: { type: 'boolean', description: 'Mark all inbox messages as read after returning them' },
-    json: { type: 'boolean', description: 'Emit machine-readable JSON output' },
-  },
-  run: async ({ args }) => {
-    const asJson = !!args.json;
-
-    try {
+
+export default defineCommand({
+  meta: {
+    name: 'poll',
+    description: 'Get a full project coordination snapshot for an agent',
+  },
+  args: {
+    agentId: { type: 'string', description: 'Agent ID for personalized situational awareness' },
+    markInboxRead: { type: 'boolean', description: 'Mark all inbox messages as read after returning them' },
+    json: { type: 'boolean', description: 'Emit machine-readable JSON output' },
+  },
+  run: async ({ args }) => {
+    const asJson = !!args.json;
+
+    try {
       const { project, teamStore, identity, reader: activeReader } = await getCliProjectContext();
       const agentId = resolveCliActorId(args.agentId, identity);
       let reader = activeReader;
-
-      let watermark = computeWatermark(0, 0, 0);
-      if (agentId) {
-        const agent = teamStore.getAgent(agentId);
+
+      let watermark = computeWatermark(0, 0, 0);
+      if (agentId) {
+        const agent = teamStore.getAgent(agentId);
         if (!agent || agent.project_id !== project.id) {
           emitError(`Unknown agent "${agentId}"`, asJson);
           return;
@@ -36,45 +36,45 @@ export default defineCommand({
           agentId,
           isTeamMember: agent.status === 'active',
         };
-
-        const lastSeen = agent.last_seen_obs_generation;
-        const currentGen = getObservationStore().getGeneration();
-        const projectObs = await withFreshIndex(() =>
+
+        const lastSeen = agent.last_seen_obs_generation;
+        const currentGen = getObservationStore().getGeneration();
+        const projectObs = await withFreshIndex(() =>
           filterReadableObservations(
             getAllObservations().filter(
               (obs) => obs.projectId === project.id && (obs.writeGeneration ?? 0) > lastSeen,
             ),
             reader,
           ),
-        );
-        watermark = computeWatermark(lastSeen, currentGen, projectObs.length);
-        teamStore.updateWatermark(agentId, currentGen);
-        teamStore.heartbeat(agentId);
-      }
-
-      const poll = computePoll(teamStore, project.id, agentId ?? null, watermark);
-      if (args.markInboxRead && agentId) {
-        teamStore.markAllRead(project.id, agentId);
-      }
-
-      const text = [
-        poll.agent ? `You: ${shortId(poll.agent.agentId)} (${poll.agent.status})` : 'Project-level overview',
-        poll.watermark.newObservationCount > 0
-          ? `${poll.watermark.newObservationCount} new observation(s)`
-          : 'No unseen observations',
-        poll.inbox.unreadCount > 0 ? `${poll.inbox.unreadCount} unread message(s)` : 'Inbox clear',
-        poll.tasks.myInProgress.length > 0
-          ? `${poll.tasks.myInProgress.length} in-progress task(s)`
-          : 'No in-progress tasks',
-        poll.tasks.availableToClaim.length > 0
-          ? `${poll.tasks.availableToClaim.length} task(s) available to claim`
-          : 'No claimable tasks',
-        `Team: ${poll.team.activeAgents.length} active / ${poll.team.totalAgents} total`,
-      ].join('\n');
-
-      emitResult({ project, poll }, text, asJson);
-    } catch (error) {
-      emitError(error instanceof Error ? error.message : String(error), asJson);
-    }
-  },
-});
+        );
+        watermark = computeWatermark(lastSeen, currentGen, projectObs.length);
+        teamStore.updateWatermark(agentId, currentGen);
+        teamStore.heartbeat(agentId);
+      }
+
+      const poll = computePoll(teamStore, project.id, agentId ?? null, watermark);
+      if (args.markInboxRead && agentId) {
+        teamStore.markAllRead(project.id, agentId);
+      }
+
+      const text = [
+        poll.agent ? `You: ${shortId(poll.agent.agentId)} (${poll.agent.status})` : 'Project-level overview',
+        poll.watermark.newObservationCount > 0
+          ? `${poll.watermark.newObservationCount} new observation(s)`
+          : 'No unseen observations',
+        poll.inbox.unreadCount > 0 ? `${poll.inbox.unreadCount} unread message(s)` : 'Inbox clear',
+        poll.tasks.myInProgress.length > 0
+          ? `${poll.tasks.myInProgress.length} in-progress task(s)`
+          : 'No in-progress tasks',
+        poll.tasks.availableToClaim.length > 0
+          ? `${poll.tasks.availableToClaim.length} task(s) available to claim`
+          : 'No claimable tasks',
+        `Team: ${poll.team.activeAgents.length} active / ${poll.team.totalAgents} total`,
+      ].join('\n');
+
+      emitResult({ project, poll }, text, asJson);
+    } catch (error) {
+      emitError(error instanceof Error ? error.message : String(error), asJson);
+    }
+  },
+});

package/src/cli/commands/purge-all-memory.ts

@@ -1,85 +1,85 @@
-/**
- * CLI Command: memorix purge all-memory
- *
- * Delete ALL memories (dangerous operation).
- */
-
-import { defineCommand } from 'citty';
-import * as p from '@clack/prompts';
-
-export default defineCommand({
-  meta: {
-    name: 'all-memory',
-    description: 'Delete ALL memories (dangerous)',
-  },
-  args: {},
-  run: async ({}) => {
-    p.intro('[WARN]  Purge All Memory');
-
-    // Show warning
-    console.log('');
-    console.log('[WARN]  WARNING: This will delete ALL memories!');
-    console.log('');
-    console.log('This will remove:');
-    console.log('  - All observations from all projects');
-    console.log('  - All entities and relations');
-    console.log('  - All embeddings');
-    console.log('');
-    console.log('This action CANNOT be undone.');
-    console.log('');
-    console.log('Project artifacts (hook files) will be preserved.');
-    console.log('');
-
-    // First confirmation
-    const confirmed1 = await p.confirm({
-      message: 'Are you sure you want to delete ALL memories?',
-    });
-
-    if (p.isCancel(confirmed1) || !confirmed1) {
-      p.outro('Purge cancelled.');
-      return;
-    }
-
-    // Second confirmation (type "DELETE" to confirm)
-    const confirmed2 = await p.text({
-      message: 'Type "DELETE" to confirm:',
-      validate: (value) => {
-        if (value !== 'DELETE') {
-          return 'Please type "DELETE" to confirm';
-        }
-        return undefined;
-      },
-    });
-
-    if (p.isCancel(confirmed2) || confirmed2 !== 'DELETE') {
-      p.outro('Purge cancelled.');
-      return;
-    }
-
-    // Delete all memories
-    try {
-      const {
-        getAllObservations,
-        resolveObservations,
-      } = await import('../../memory/observations.js');
-      const { withFreshIndex } = await import('../../memory/freshness.js');
-      const observations = await withFreshIndex(() => getAllObservations());
-      const ids = observations.map((o) => o.id);
-
-      if (ids.length === 0) {
-        console.log('No observations found.');
-        p.outro('No memories to purge.');
-        return;
-      }
-
-      const result = await resolveObservations(ids, 'archived');
-
-      console.log(`[OK] Archived ${result.resolved.length} observations`);
-
-      p.outro(`All memory purged. ${result.resolved.length} observations archived.`);
-    } catch (err) {
-      console.error(`[ERROR] Failed to purge all memory: ${err}`);
-      p.outro('Purge failed.');
-    }
-  },
-});
+/**
+ * CLI Command: memorix purge all-memory
+ *
+ * Delete ALL memories (dangerous operation).
+ */
+
+import { defineCommand } from 'citty';
+import * as p from '@clack/prompts';
+
+export default defineCommand({
+  meta: {
+    name: 'all-memory',
+    description: 'Delete ALL memories (dangerous)',
+  },
+  args: {},
+  run: async ({}) => {
+    p.intro('[WARN]  Purge All Memory');
+
+    // Show warning
+    console.log('');
+    console.log('[WARN]  WARNING: This will delete ALL memories!');
+    console.log('');
+    console.log('This will remove:');
+    console.log('  - All observations from all projects');
+    console.log('  - All entities and relations');
+    console.log('  - All embeddings');
+    console.log('');
+    console.log('This action CANNOT be undone.');
+    console.log('');
+    console.log('Project artifacts (hook files) will be preserved.');
+    console.log('');
+
+    // First confirmation
+    const confirmed1 = await p.confirm({
+      message: 'Are you sure you want to delete ALL memories?',
+    });
+
+    if (p.isCancel(confirmed1) || !confirmed1) {
+      p.outro('Purge cancelled.');
+      return;
+    }
+
+    // Second confirmation (type "DELETE" to confirm)
+    const confirmed2 = await p.text({
+      message: 'Type "DELETE" to confirm:',
+      validate: (value) => {
+        if (value !== 'DELETE') {
+          return 'Please type "DELETE" to confirm';
+        }
+        return undefined;
+      },
+    });
+
+    if (p.isCancel(confirmed2) || confirmed2 !== 'DELETE') {
+      p.outro('Purge cancelled.');
+      return;
+    }
+
+    // Delete all memories
+    try {
+      const {
+        getAllObservations,
+        resolveObservations,
+      } = await import('../../memory/observations.js');
+      const { withFreshIndex } = await import('../../memory/freshness.js');
+      const observations = await withFreshIndex(() => getAllObservations());
+      const ids = observations.map((o) => o.id);
+
+      if (ids.length === 0) {
+        console.log('No observations found.');
+        p.outro('No memories to purge.');
+        return;
+      }
+
+      const result = await resolveObservations(ids, 'archived');
+
+      console.log(`[OK] Archived ${result.resolved.length} observations`);
+
+      p.outro(`All memory purged. ${result.resolved.length} observations archived.`);
+    } catch (err) {
+      console.error(`[ERROR] Failed to purge all memory: ${err}`);
+      p.outro('Purge failed.');
+    }
+  },
+});