memorix 0.9.15 → 0.9.16

package/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.9.16] — 2026-02-26
+
+### Architecture
+- **Classify → Policy → Store pipeline** — Replaced the monolithic `switch/case` handler (527 lines) with a clean declarative pipeline (432 lines). Inspired by claude-mem's store-first philosophy and mcp-memory-service's configurable scoring.
+- **Tool Taxonomy** — `classifyTool()` categorizes tools into `file_modify | file_read | command | search | memorix_internal | unknown`. Each category has a declarative `StoragePolicy` (store mode, minLength, defaultType).
+- **Pattern detection = classification only** — Pattern detection now only determines observation *type* (decision, error, etc.), not whether to store. Storage decisions are made by policy.
+- **Unified `TYPE_EMOJI`** — Single exported constant, eliminating 3 duplicated copies across handler and session_start.
+
+### Fixed
+- **🔴 Critical: Bash commands with `cd` prefix silently dropped** — Claude Code sends Bash commands as `cd /project && npm test 2>&1`. The noise filter `/^cd\b/` matched the `cd` prefix and silently discarded the entire command. This caused `npm test`, `npm install express`, `node -e "..."`, and all other project-scoped commands to never be stored. Fix: `extractRealCommand()` strips `cd path && ` prefix before noise checking, so `cd /path && npm test` is correctly evaluated as `npm test`.
+- **Cooldown key too broad** — Old key `post_tool:Bash` meant ALL Bash commands shared one 30-second cooldown. New key uses `event:filePath|command|toolName`, so `npm test` and `npm install` have independent cooldowns.
+- **Store-first for commands** — Command-category tools now use `store: 'always'` policy with minLength 30 (down from 50-200), capturing more meaningful development activity.
+
 ## [0.9.15] — 2026-02-26
 
 ### Fixed

package/README.md

@@ -8,7 +8,7 @@
     <a href="https://www.npmjs.com/package/memorix"><img src="https://img.shields.io/npm/dm/memorix.svg?style=flat-square&color=blue" alt="npm downloads"></a>
     <a href="LICENSE"><img src="https://img.shields.io/badge/license-Apache%202.0-green.svg?style=flat-square" alt="License"></a>
     <a href="https://github.com/AVIDS2/memorix"><img src="https://img.shields.io/github/stars/AVIDS2/memorix?style=flat-square&color=yellow" alt="GitHub stars"></a>
-    <img src="https://img.shields.io/badge/tests-505%20passed-brightgreen?style=flat-square" alt="Tests">
+    <img src="https://img.shields.io/badge/tests-507%20passed-brightgreen?style=flat-square" alt="Tests">
   </p>
   <p align="center">
     <img src="https://img.shields.io/badge/Works%20with-Cursor-orange?style=flat-square" alt="Cursor">

package/README.zh-CN.md

@@ -8,7 +8,7 @@
     <a href="https://www.npmjs.com/package/memorix"><img src="https://img.shields.io/npm/dm/memorix.svg?style=flat-square&color=blue" alt="npm downloads"></a>
     <a href="LICENSE"><img src="https://img.shields.io/badge/license-Apache%202.0-green.svg?style=flat-square" alt="License"></a>
     <a href="https://github.com/AVIDS2/memorix"><img src="https://img.shields.io/github/stars/AVIDS2/memorix?style=flat-square&color=yellow" alt="GitHub stars"></a>
-    <img src="https://img.shields.io/badge/tests-505%20passed-brightgreen?style=flat-square" alt="Tests">
+    <img src="https://img.shields.io/badge/tests-507%20passed-brightgreen?style=flat-square" alt="Tests">
   </p>
   <p align="center">
     <img src="https://img.shields.io/badge/Works%20with-Cursor-orange?style=flat-square" alt="Cursor">

package/dist/cli/index.js

@@ -39920,7 +39920,7 @@ async function getSessionContext(projectDir2, projectId, limit = 3) {
     lines.push("");
   }
   const PRIORITY_TYPES = /* @__PURE__ */ new Set(["gotcha", "decision", "problem-solution", "trade-off", "discovery"]);
-  const TYPE_EMOJI = {
+  const TYPE_EMOJI2 = {
     "gotcha": "\u{1F534}",
     "decision": "\u{1F7E4}",
     "problem-solution": "\u{1F7E1}",
@@ -39935,7 +39935,7 @@ async function getSessionContext(projectDir2, projectId, limit = 3) {
   if (priorityObs.length > 0) {
     lines.push(`## Key Memories`);
     for (const obs of priorityObs) {
-      const emoji2 = TYPE_EMOJI[obs.type] ?? "\u{1F4CC}";
+      const emoji2 = TYPE_EMOJI2[obs.type] ?? "\u{1F4CC}";
       const fact = obs.facts?.[0] ? ` \u2014 ${obs.facts[0]}` : "";
       lines.push(`${emoji2} ${obs.title}${fact}`);
     }
@@ -43746,10 +43746,37 @@ var init_pattern_detector = __esm({
 // src/hooks/handler.ts
 var handler_exports = {};
 __export(handler_exports, {
+  TYPE_EMOJI: () => TYPE_EMOJI,
   handleHookEvent: () => handleHookEvent,
   resetCooldowns: () => resetCooldowns,
   runHook: () => runHook
 });
+function classifyTool(input) {
+  if (input.event === "post_edit") return "file_modify";
+  if (input.event === "post_command") return "command";
+  const name = (input.toolName ?? "").toLowerCase();
+  if (name.startsWith("memorix_")) return "memorix_internal";
+  if (/^(write|edit|multi_?edit|multiedittool|create|patch|insert|notebook_?edit)$/i.test(name)) {
+    return "file_modify";
+  }
+  if (/^(read|read_?file|view|list_?dir)$/i.test(name)) {
+    return "file_read";
+  }
+  if (/^(bash|shell|terminal|command|run)$/i.test(name) || input.command) {
+    return "command";
+  }
+  if (/^(search|grep|ripgrep|find_?by_?name|glob)$/i.test(name)) {
+    return "search";
+  }
+  return "unknown";
+}
+function extractRealCommand(command) {
+  return command.replace(/^cd\s+\S+\s*&&\s*/i, "").trim();
+}
+function isNoiseCommand(command) {
+  const real = extractRealCommand(command);
+  return NOISE_COMMANDS.some((r4) => r4.test(real));
+}
 function isInCooldown(eventKey) {
   const last = cooldowns.get(eventKey);
   if (!last) return false;
@@ -43766,7 +43793,7 @@ function extractContent(input) {
   if (input.userPrompt) parts.push(input.userPrompt);
   if (input.aiResponse) parts.push(input.aiResponse);
   if (input.commandOutput) parts.push(input.commandOutput);
-  if (input.command) parts.push(`Command: ${input.command}`);
+  if (input.command) parts.push(`Command: ${extractRealCommand(input.command)}`);
   if (input.filePath) parts.push(`File: ${input.filePath}`);
   if (input.edits) {
     for (const edit of input.edits) {
@@ -43782,8 +43809,7 @@ function extractContent(input) {
       parts.push(`File: ${input.toolInput.file_path}`);
     }
     if (input.toolInput.content) {
-      const content = input.toolInput.content;
-      parts.push(content.slice(0, 1e3));
+      parts.push(input.toolInput.content.slice(0, 1e3));
     }
     if (input.toolInput.old_string || input.toolInput.new_string) {
       const oldStr = input.toolInput.old_string ?? "";
@@ -43804,7 +43830,7 @@ function deriveEntityName(input) {
   }
   if (input.toolName) return input.toolName;
   if (input.command) {
-    const firstWord = input.command.split(/\s+/)[0];
+    const firstWord = extractRealCommand(input.command).split(/\s+/)[0];
     return firstWord.replace(/[^a-zA-Z0-9-_]/g, "");
   }
   return "session";
@@ -43817,16 +43843,17 @@ function generateTitle(input, patternType) {
     return `${verb} ${filename}`.slice(0, maxLen);
   }
   if (input.command) {
-    return `Ran: ${input.command}`.slice(0, maxLen);
+    return `Ran: ${extractRealCommand(input.command)}`.slice(0, maxLen);
   }
   if (input.userPrompt) {
     return input.userPrompt.slice(0, maxLen);
   }
   return `Session activity (${patternType})`;
 }
-function buildObservation(input, content) {
+function buildObservation(input, content, category) {
   const pattern = detectBestPattern(content);
-  const fallbackType = input.filePath ? "what-changed" : "discovery";
+  const policy = STORAGE_POLICY[category] ?? STORAGE_POLICY.unknown;
+  const fallbackType = input.filePath ? "what-changed" : policy.defaultType;
   const obsType = pattern ? patternToObservationType(pattern.type) : fallbackType;
   return {
     entityName: deriveEntityName(input),
@@ -43837,212 +43864,111 @@ function buildObservation(input, content) {
       `Agent: ${input.agent}`,
       `Session: ${input.sessionId}`,
       ...input.filePath ? [`File: ${input.filePath}`] : [],
-      ...input.command ? [`Command: ${input.command}`] : []
+      ...input.command ? [`Command: ${extractRealCommand(input.command)}`] : []
     ],
     concepts: pattern?.matchedKeywords ?? [],
     filesModified: input.filePath ? [input.filePath] : []
   };
 }
-async function handleHookEvent(input) {
-  const defaultOutput = { continue: true };
-  if (input.toolName === "memorix_store" || input.toolName === "memorix_search") {
-    return { observation: null, output: defaultOutput };
-  }
-  switch (input.event) {
-    case "session_start": {
-      let contextSummary = "";
-      try {
-        const { detectProject: detectProject2 } = await Promise.resolve().then(() => (init_detector(), detector_exports));
-        const { getProjectDataDir: getProjectDataDir2, loadObservationsJson: loadObservationsJson2 } = await Promise.resolve().then(() => (init_persistence(), persistence_exports));
-        const project = await detectProject2(input.cwd || process.cwd());
-        const dataDir = await getProjectDataDir2(project.id);
-        const allObs = await loadObservationsJson2(dataDir);
-        if (allObs.length > 0) {
-          const PRIORITY_ORDER = {
-            "gotcha": 6,
-            "decision": 5,
-            "problem-solution": 4,
-            "trade-off": 3,
-            "discovery": 2,
-            "how-it-works": 1
-          };
-          const LOW_QUALITY_PATTERNS2 = [
-            /^Session activity/i,
-            /^Updated \S+\.\w+$/i,
-            // "Updated foo.ts" — too generic
-            /^Created \S+\.\w+$/i,
-            // "Created bar.js"
-            /^Deleted \S+\.\w+$/i,
-            /^Modified \S+\.\w+$/i
-          ];
-          const isLowQuality2 = (title) => LOW_QUALITY_PATTERNS2.some((p2) => p2.test(title));
-          const scored = allObs.map((obs, i2) => {
-            const title = obs.title ?? "";
-            const hasFacts = (obs.facts?.length ?? 0) > 0;
-            const hasSubstance = title.length > 20 || hasFacts;
-            const quality = isLowQuality2(title) ? 0.1 : hasSubstance ? 1 : 0.5;
-            return {
-              obs,
-              priority: PRIORITY_ORDER[obs.type ?? ""] ?? 0,
-              quality,
-              recency: i2
-              // higher index = more recent
-            };
-          }).sort((a3, b3) => {
-            const scoreA = a3.priority * a3.quality;
-            const scoreB = b3.priority * b3.quality;
-            if (scoreB !== scoreA) return scoreB - scoreA;
-            return b3.recency - a3.recency;
-          });
-          const top = scored.slice(0, 5);
-          const TYPE_EMOJI = {
-            "gotcha": "\u{1F534}",
-            "decision": "\u{1F7E4}",
-            "problem-solution": "\u{1F7E1}",
-            "trade-off": "\u2696\uFE0F",
-            "discovery": "\u{1F7E3}",
-            "how-it-works": "\u{1F535}",
-            "what-changed": "\u{1F7E2}",
-            "why-it-exists": "\u{1F7E0}",
-            "session-request": "\u{1F3AF}"
-          };
-          const lines = top.map(({ obs }) => {
-            const emoji2 = TYPE_EMOJI[obs.type ?? ""] ?? "\u{1F4CC}";
-            const title = obs.title ?? "(untitled)";
-            const fact = obs.facts?.[0] ? ` \u2014 ${obs.facts[0]}` : "";
-            return `${emoji2} ${title}${fact}`;
-          });
-          contextSummary = `
+async function handleSessionStart(input) {
+  let contextSummary = "";
+  try {
+    const { detectProject: detectProject2 } = await Promise.resolve().then(() => (init_detector(), detector_exports));
+    const { getProjectDataDir: getProjectDataDir2, loadObservationsJson: loadObservationsJson2 } = await Promise.resolve().then(() => (init_persistence(), persistence_exports));
+    const project = await detectProject2(input.cwd || process.cwd());
+    const dataDir = await getProjectDataDir2(project.id);
+    const allObs = await loadObservationsJson2(dataDir);
+    if (allObs.length > 0) {
+      const PRIORITY_ORDER = {
+        "gotcha": 6,
+        "decision": 5,
+        "problem-solution": 4,
+        "trade-off": 3,
+        "discovery": 2,
+        "how-it-works": 1
+      };
+      const LOW_QUALITY_PATTERNS2 = [
+        /^Session activity/i,
+        /^Updated \S+\.\w+$/i,
+        /^Created \S+\.\w+$/i,
+        /^Deleted \S+\.\w+$/i,
+        /^Modified \S+\.\w+$/i
+      ];
+      const isLowQuality2 = (title) => LOW_QUALITY_PATTERNS2.some((p2) => p2.test(title));
+      const scored = allObs.map((obs, i2) => {
+        const title = obs.title ?? "";
+        const hasFacts = (obs.facts?.length ?? 0) > 0;
+        const hasSubstance = title.length > 20 || hasFacts;
+        const quality = isLowQuality2(title) ? 0.1 : hasSubstance ? 1 : 0.5;
+        return { obs, priority: PRIORITY_ORDER[obs.type ?? ""] ?? 0, quality, recency: i2 };
+      }).sort((a3, b3) => {
+        const scoreA = a3.priority * a3.quality;
+        const scoreB = b3.priority * b3.quality;
+        if (scoreB !== scoreA) return scoreB - scoreA;
+        return b3.recency - a3.recency;
+      });
+      const top = scored.slice(0, 5);
+      const lines = top.map(({ obs }) => {
+        const emoji2 = TYPE_EMOJI[obs.type ?? ""] ?? "\u{1F4CC}";
+        const title = obs.title ?? "(untitled)";
+        const fact = obs.facts?.[0] ? ` \u2014 ${obs.facts[0]}` : "";
+        return `${emoji2} ${title}${fact}`;
+      });
+      contextSummary = `
 
 Recent project memories (${project.name}):
 ${lines.join("\n")}`;
-        }
-      } catch {
-      }
-      return {
-        observation: null,
-        output: {
-          continue: true,
-          systemMessage: `Memorix is active. Your memories from previous sessions are available via memorix_search.${contextSummary}`
-        }
-      };
-    }
-    case "pre_compact": {
-      const compactContent = extractContent(input);
-      if (compactContent.length < MIN_STORE_LENGTH) {
-        return { observation: null, output: defaultOutput };
-      }
-      return {
-        observation: buildObservation(input, compactContent),
-        output: defaultOutput
-      };
-    }
-    case "session_end":
-      return {
-        observation: buildObservation(input, extractContent(input)),
-        output: defaultOutput
-      };
-    case "post_edit": {
-      const editKey = `post_edit:${input.filePath ?? "general"}`;
-      if (isInCooldown(editKey)) {
-        return { observation: null, output: defaultOutput };
-      }
-      const editContent = extractContent(input);
-      if (editContent.length < MIN_EDIT_LENGTH) {
-        return { observation: null, output: defaultOutput };
-      }
-      const editPattern = detectBestPattern(editContent, 0.6);
-      if (!editPattern) {
-        return { observation: null, output: defaultOutput };
-      }
-      markTriggered(editKey);
-      return {
-        observation: buildObservation(input, editContent),
-        output: defaultOutput
-      };
-    }
-    case "post_command": {
-      if (input.command && NOISE_COMMANDS.some((r4) => r4.test(input.command))) {
-        return { observation: null, output: defaultOutput };
-      }
-      const cmdKey = `post_command:${input.command ?? "general"}`;
-      if (isInCooldown(cmdKey)) {
-        return { observation: null, output: defaultOutput };
-      }
-      const cmdContent = input.commandOutput || extractContent(input);
-      if (cmdContent.length < MIN_STORE_LENGTH) {
-        return { observation: null, output: defaultOutput };
-      }
-      detectBestPattern(cmdContent);
-      markTriggered(cmdKey);
-      return {
-        observation: buildObservation(input, cmdContent),
-        output: defaultOutput
-      };
-    }
-    case "post_tool": {
-      const toolKey = `post_tool:${input.toolName ?? "general"}`;
-      if (isInCooldown(toolKey)) {
-        return { observation: null, output: defaultOutput };
-      }
-      const toolContent = extractContent(input);
-      if (input.command) {
-        if (NOISE_COMMANDS.some((r4) => r4.test(input.command))) {
-          return { observation: null, output: defaultOutput };
-        }
-        if (toolContent.length < 50) {
-          return { observation: null, output: defaultOutput };
-        }
-        markTriggered(toolKey);
-        return {
-          observation: buildObservation(input, toolContent),
-          output: defaultOutput
-        };
-      }
-      if (toolContent.length < MIN_STORE_LENGTH) {
-        return { observation: null, output: defaultOutput };
-      }
-      const isFileModifyingTool = /^(write|edit|multi_?edit|multiedittool|create|patch|insert)/i.test(
-        input.toolName ?? ""
-      );
-      if (isFileModifyingTool) {
-        markTriggered(toolKey);
-        return {
-          observation: buildObservation(input, toolContent),
-          output: defaultOutput
-        };
-      }
-      const toolPattern = detectBestPattern(toolContent);
-      if (!toolPattern && toolContent.length < 200) {
-        return { observation: null, output: defaultOutput };
-      }
-      markTriggered(toolKey);
-      return {
-        observation: buildObservation(input, toolContent),
-        output: defaultOutput
-      };
     }
-    case "post_response":
-    case "user_prompt": {
-      const promptKey = `${input.event}:${input.sessionId ?? "general"}`;
-      if (isInCooldown(promptKey)) {
-        return { observation: null, output: defaultOutput };
-      }
-      const content = extractContent(input);
-      const minLen = input.event === "user_prompt" ? MIN_PROMPT_LENGTH : MIN_STORE_LENGTH;
-      if (content.length < minLen) {
-        return { observation: null, output: defaultOutput };
-      }
-      detectBestPattern(content);
-      markTriggered(promptKey);
-      return {
-        observation: buildObservation(input, content),
-        output: defaultOutput
-      };
+  } catch {
+  }
+  return {
+    observation: null,
+    output: {
+      continue: true,
+      systemMessage: `Memorix is active. Your memories from previous sessions are available via memorix_search.${contextSummary}`
     }
-    default:
+  };
+}
+async function handleHookEvent(input) {
+  const defaultOutput = { continue: true };
+  if (input.event === "session_start") {
+    return handleSessionStart(input);
+  }
+  if (input.event === "session_end") {
+    return {
+      observation: buildObservation(input, extractContent(input), "unknown"),
+      output: defaultOutput
+    };
+  }
+  const category = classifyTool(input);
+  const policy = STORAGE_POLICY[category] ?? STORAGE_POLICY.unknown;
+  const content = extractContent(input);
+  if (policy.store === "never") {
+    return { observation: null, output: defaultOutput };
+  }
+  if (category === "command" && input.command && isNoiseCommand(input.command)) {
+    return { observation: null, output: defaultOutput };
+  }
+  const minLen = input.event === "user_prompt" ? MIN_PROMPT_LENGTH : policy.minLength;
+  if (content.length < minLen) {
+    return { observation: null, output: defaultOutput };
+  }
+  const effectiveStore = input.event === "user_prompt" || input.event === "post_response" ? "always" : policy.store;
+  if (effectiveStore === "if_substantial") {
+    const pattern = detectBestPattern(content);
+    if (!pattern && content.length < 200) {
       return { observation: null, output: defaultOutput };
+    }
   }
+  const cooldownKey = `${input.event}:${input.filePath ?? input.command ?? input.toolName ?? "general"}`;
+  if (isInCooldown(cooldownKey)) {
+    return { observation: null, output: defaultOutput };
+  }
+  markTriggered(cooldownKey);
+  return {
+    observation: buildObservation(input, content, category),
+    output: defaultOutput
+  };
 }
 async function runHook() {
   const chunks = [];
@@ -44072,17 +43998,6 @@ async function runHook() {
       const dataDir = await getProjectDataDir2(project.id);
       await initObservations2(dataDir);
       await storeObservation2({ ...observation, projectId: project.id });
-      const TYPE_EMOJI = {
-        "gotcha": "\u{1F534}",
-        "decision": "\u{1F7E4}",
-        "problem-solution": "\u{1F7E1}",
-        "trade-off": "\u2696\uFE0F",
-        "discovery": "\u{1F7E3}",
-        "how-it-works": "\u{1F535}",
-        "what-changed": "\u{1F7E2}",
-        "why-it-exists": "\u{1F7E0}",
-        "session-request": "\u{1F3AF}"
-      };
       const emoji2 = TYPE_EMOJI[observation.type] ?? "\u{1F4DD}";
       output.systemMessage = (output.systemMessage ?? "") + `
 ${emoji2} Memorix saved: ${observation.title} [${observation.type}]`;
@@ -44091,26 +44006,41 @@ ${emoji2} Memorix saved: ${observation.title} [${observation.type}]`;
   }
   process.stdout.write(JSON.stringify(output));
 }
-var cooldowns, COOLDOWN_MS, MIN_STORE_LENGTH, MIN_PROMPT_LENGTH, MIN_EDIT_LENGTH, NOISE_COMMANDS, MAX_CONTENT_LENGTH;
+var TYPE_EMOJI, cooldowns, COOLDOWN_MS, MIN_PROMPT_LENGTH, MAX_CONTENT_LENGTH, NOISE_COMMANDS, STORAGE_POLICY;
 var init_handler = __esm({
   "src/hooks/handler.ts"() {
     "use strict";
     init_esm_shims();
     init_normalizer();
     init_pattern_detector();
+    TYPE_EMOJI = {
+      "gotcha": "\u{1F534}",
+      "decision": "\u{1F7E4}",
+      "problem-solution": "\u{1F7E1}",
+      "trade-off": "\u2696\uFE0F",
+      "discovery": "\u{1F7E3}",
+      "how-it-works": "\u{1F535}",
+      "what-changed": "\u{1F7E2}",
+      "why-it-exists": "\u{1F7E0}",
+      "session-request": "\u{1F3AF}"
+    };
     cooldowns = /* @__PURE__ */ new Map();
     COOLDOWN_MS = 3e4;
-    MIN_STORE_LENGTH = 100;
     MIN_PROMPT_LENGTH = 20;
-    MIN_EDIT_LENGTH = 30;
+    MAX_CONTENT_LENGTH = 4e3;
     NOISE_COMMANDS = [
-      /^(ls|dir|cd|pwd|echo|cat|type|head|tail|wc|find|which|where|whoami)\b/i,
-      /^(Get-Content|Test-Path|Get-Item|Get-ChildItem|Set-Location|Write-Host)\b/i,
-      /^(Start-Sleep|Select-String|Select-Object|Format-Table|Measure-Object)\b/i,
-      /^(mkdir|rm|cp|mv|touch|chmod|chown)\b/i,
-      /^(node -[ep]|python -c)\b/i
+      /^(ls|dir|cd|pwd|echo|cat|type|head|tail|wc|which|where|whoami)(\s|$)/i,
+      /^(Get-Content|Test-Path|Get-Item|Get-ChildItem|Set-Location|Write-Host)(\s|$)/i,
+      /^(Start-Sleep|Select-String|Select-Object|Format-Table|Measure-Object)(\s|$)/i
     ];
-    MAX_CONTENT_LENGTH = 4e3;
+    STORAGE_POLICY = {
+      file_modify: { store: "always", minLength: 50, defaultType: "what-changed" },
+      command: { store: "always", minLength: 30, defaultType: "discovery" },
+      file_read: { store: "if_substantial", minLength: 200, defaultType: "discovery" },
+      search: { store: "if_substantial", minLength: 200, defaultType: "discovery" },
+      memorix_internal: { store: "never", minLength: 0, defaultType: "discovery" },
+      unknown: { store: "if_substantial", minLength: 100, defaultType: "discovery" }
+    };
   }
 });