memories-lite 0.9.0 → 0.9.2

package/dist/vectorstores/lite.js

@@ -8,6 +8,7 @@ exports.LiteVectorStore = void 0;
 const path_1 = __importDefault(require("path"));
 const sqlite3_1 = __importDefault(require("sqlite3"));
 const crypto_1 = require("crypto");
+const fs_1 = require("fs");
 /**
  * LiteVectorStore provides a simple vector storage implementation.
  *
@@ -27,27 +28,32 @@ class LiteVectorStore {
         this.currentUserId = currentUserId;
         this.isSecure = config.secure || false;
         this.scoringConfig = config.scoring;
-        this.cleanupThreshold = config.recencyCleanupThreshold; // Store threshold
+        this.cleanupThreshold = config.recencyCleanupThreshold || 0.25; // (default 0.25 means 2 times the half-life  )
         config.rootPath = config.rootPath || process.cwd();
         const filename = this.isSecure ? `memories-lite-${currentUserId}.db` : `memories-lite-global.db`;
-        const dbPath = (config.rootPath == ':memory:') ? ':memory:' : path_1.default.join(config.rootPath, filename);
+        this.dbPath = (config.rootPath == ':memory:') ? ':memory:' : path_1.default.join(config.rootPath, filename);
         // Add error handling callback for the database connection
-        this.db = new sqlite3_1.default.Database(dbPath);
+        this.db = new sqlite3_1.default.Database(this.dbPath);
     }
     async init() {
-        await this.run(`
-      CREATE TABLE IF NOT EXISTS vectors (
-        id TEXT PRIMARY KEY,
+        try {
+            await this.run(`
+        CREATE TABLE IF NOT EXISTS vectors (
+          id TEXT PRIMARY KEY,
         vector BLOB NOT NULL,
         payload TEXT NOT NULL
       )
     `);
-        await this.run(`
+            await this.run(`
       CREATE TABLE IF NOT EXISTS memory_migrations (
         id INTEGER PRIMARY KEY AUTOINCREMENT,
         user_id TEXT NOT NULL UNIQUE
       )
     `);
+        }
+        catch (err) {
+            console.log("-- DBG init error:", err);
+        }
     }
     async run(sql, params = []) {
         return new Promise((resolve, reject) => {
@@ -129,9 +135,11 @@ class LiteVectorStore {
         if (cachedStore) {
             Object.setPrototypeOf(cachedStore, LiteVectorStore.prototype);
             cachedStore.currentUserId = hashedUserId;
-            // Ensure scoring config and threshold are updated if config object changed
-            cachedStore.scoringConfig = config.scoring;
-            cachedStore.cleanupThreshold = config.recencyCleanupThreshold;
+            //
+            // if the database file does not exist, we need to reinitialize the store
+            if (cachedStore.dbPath !== ':memory:' && !(0, fs_1.existsSync)(cachedStore.dbPath)) {
+                return new LiteVectorStore(config, hashedUserId);
+            }
             return cachedStore;
         }
         // Pass the full config (including scoring) to the constructor
@@ -145,17 +153,28 @@ class LiteVectorStore {
             if (vectors[i].length !== this.dimension) {
                 throw new Error(`Vector dimension mismatch. Expected ${this.dimension}, got ${vectors[i].length}`);
             }
+            const payload = { ...payloads[i] };
+            //
+            // case of global store (insecure)
+            if (!payload.userId) {
+                throw new Error("userId is required in payload");
+            }
             //
             // remove the userId from the payload as sensitive data
-            this.isSecure && delete payloads[i].userId;
+            this.isSecure && delete payload.userId;
             const vectorBuffer = Buffer.from(new Float32Array(vectors[i]).buffer);
-            await this.run(`INSERT OR REPLACE INTO vectors (id, vector, payload) VALUES (?, ?, ?)`, [ids[i], vectorBuffer, JSON.stringify(payloads[i])]);
+            await this.run(`INSERT OR REPLACE INTO vectors (id, vector, payload) VALUES (?, ?, ?)`, [ids[i], vectorBuffer, JSON.stringify(payload)]);
         }
     }
     async search(query, limit = 10, filters) {
         if (query.length !== this.dimension) {
             throw new Error(`Query dimension mismatch. Expected ${this.dimension}, got ${query.length}`);
         }
+        if (!filters || !filters.userId) {
+            throw new Error("userId is mandatory in search");
+        }
+        filters = { ...filters };
+        this.isSecure && delete filters.userId;
         const results = [];
         const rows = await this.all(`SELECT * FROM vectors`);
         for (const row of rows) {
@@ -225,17 +244,21 @@ class LiteVectorStore {
     async list(filters, limit = 100) {
         const rows = await this.all(`SELECT * FROM vectors`);
         const results = [];
+        //
+        // remove the userId from the payload as sensitive data
+        filters = { ...filters };
+        this.isSecure && delete filters?.userId;
         for (const row of rows) {
             const memoryVector = {
                 id: row.id,
                 vector: Array.from(new Float32Array(row.vector.buffer)),
-                payload: {},
+                payload: JSON.parse(row.payload),
             };
             if (this.filterVector(memoryVector, filters)) {
                 // load payload at the end
                 results.push({
                     id: memoryVector.id,
-                    payload: JSON.parse(row.payload),
+                    payload: memoryVector.payload,
                 });
             }
         }
@@ -278,7 +301,15 @@ class LiteVectorStore {
         // Ensure score is within a reasonable range (e.g., 0 to alpha+beta+gamma)
         return Math.max(0, hybridScore);
     }
-    // Internal method to clean up vectors based on recency score threshold
+    /**
+     * Internal method to clean up vectors based on recency score threshold.
+     *
+     * @param threshold - The minimum recency score required for a memory to be retained.
+     *   - Recency score is calculated using exponential decay: 1.0 means brand new, 0.5 means at half-life, 0.0 means fully decayed.
+     *   - Memories with a recency score below this threshold will be deleted (unless their half-life is infinite or zero).
+     *   - For example, a threshold of 0.25 will remove all memories whose recency score has decayed 2 times the half-life.
+     *   - Use a lower threshold to keep more old memories, or a higher threshold to keep only fresher ones.
+     */
     async _cleanupByRecency(threshold) {
         const rows = await this.all(`SELECT id, payload FROM vectors`);
         let deletedCount = 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "memories-lite",
-  "version": "0.9.0",
+  "version": "0.9.2",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {

package/src/memory/index.ts

@@ -162,7 +162,7 @@ export class MemoriesLite {
 
     const $t = this.$t;
     const vectorStore = await this.getVectorStore(userId);
-    const parsedMessages = messages.filter((m) => typeof m.content === 'string').map((m) => `${m.role=='user' ? '**USER**: ' : '**ASSISTANT**: '}${$t(m.content as string)}\n`).join("\n");
+    const parsedMessages = messages.filter((m) => typeof m.content === 'string' && m.role=='user').map((m) => `${m.role=='user' ? '**USER**: ' : '**ASSISTANT**: '}${$t(m.content as string)}\n`).join("\n");
 
     const [systemPrompt, userPrompt] = getFactRetrievalMessages(parsedMessages, customFacts||this.customPrompt);
 
@@ -202,6 +202,9 @@ export class MemoriesLite {
     const newMessageEmbeddings: Record<string, number[]> = {};
     const retrievedOldMemory: Array<{ id: string; text: string; type: string }> = [];
 
+    //
+    // add the userId to the filters
+    filters.userId = userId;
     // Create embeddings and search for similar memories
     for (const elem of facts) {
       const fact = elem.fact;
@@ -250,7 +253,7 @@ export class MemoriesLite {
         console.log(`-- ⛔ LLM Error: ${action.event}, ${action.type}, "${action.text}"`);
         continue;
       }
-      console.log(`-- DBG memory action: ${action.event}, ${action.type}, "${action.text}", why: "${action.reason}"`);
+      console.log(`-- DBG memory "${userId}": ${action.event}, ${action.type}, "${action.text}", why: "${action.reason}"`);
       try {
         switch (action.event) {
           case "ADD": {
@@ -276,7 +279,7 @@ export class MemoriesLite {
           }
           case "UPDATE": {
             const realMemoryId = tempUuidMapping[action.id];
-            const type = uniqueOldMemories[action.id].type as MemoryType;
+            const type = metadata.type = uniqueOldMemories[action.id].type || action.type;
             await this.updateMemory(
               realMemoryId,
               action.text,
@@ -455,7 +458,7 @@ export class MemoriesLite {
     }
 
     const vectorStore = await this.getVectorStore(userId);
-
+    filters.userId = userId;
 
     // Search vector store
     const queryEmbedding = await this.embedder.embed(query);
@@ -597,6 +600,7 @@ export class MemoriesLite {
     if (agentId) filters.agentId = agentId;
     if (runId) filters.runId = runId;
     if (type) filters.type = type;
+    filters.userId = userId;
     const [memories] = await vectorStore.list(filters, limit);
 
     const excludedKeys = new Set([
@@ -640,6 +644,7 @@ export class MemoriesLite {
       ...metadata,
       data,
       hash: createHash("md5").update(data).digest("hex"),
+      userId,
       createdAt: new Date().toISOString(),
     };
 
@@ -676,6 +681,7 @@ export class MemoriesLite {
       ...metadata,
       data,
       hash: createHash("md5").update(data).digest("hex"),
+      type: existingMemory.payload.type,
       createdAt: existingMemory.payload.createdAt,
       updatedAt: new Date().toISOString(),
       ...(existingMemory.payload.agentId && {

package/src/prompts/index.ts

@@ -20,7 +20,12 @@ export const FactRetrievalSchema_extended = z.object({
     z.object({
       fact: z.string().describe("The fact extracted from the conversation."),
       existing: z.boolean().describe("Whether the fact is already present"),
-      type: z.enum(["assistant_preference","factual", "episodic", "procedural", "semantic"]).describe("The type of the fact. Use 'assistant_preference' for Assistant behavior preferences."),
+      type: z.enum(["assistant_preference","factual", "episodic", "procedural", "semantic"])
+      .describe(`The type of the fact. 
+        Use 'assistant_preference' for Assistant behavior preferences.
+        Use 'episodic' always for time-based events.
+        Use 'procedural' always when it concerns a business question.
+        Use 'semantic' for Understanding of concepts, relationships and general meanings.`),
     })
   )
 });
@@ -71,7 +76,7 @@ export const MEMORY_STRING_SYSTEM = `# DIRECTIVES FOR MEMORIES
 - You must adapt your answer based on the contents found within the <memories> section.
 - If the memories are irrelevant to the user's query, you MUST ignore them.
 - By default, do not reference this section or the memories in your response.
-- Use the memory type only to guide your reasoning. Do not respond to this section of the prompt, nor to the memories themselves — they are for your reference only.`;
+- Use memories only to guide your reasoning. Do not respond to the memories themselves.`;
 
 export const MEMORY_STRING_PREFIX = "Use these contextual memories to guide your response. Prioritize the user's question. Ignore irrelevant memories."
 
@@ -97,17 +102,17 @@ Your mission is to analyze a input content line by line and produce:
 
 Filter content before extracting triplets:
   - Ignore content with no direct relevance to user (e.g., "today is sunny", "I'm working").
-  - If the user asks about a process, regulation, or third-party policy (e.g. company workflows, public steps, legal actions), assume they are seeking information, not expressing a personal desire.
-  - Eliminate introductions, sub-facts, detailed repetitive elements, stylistic fillers, or vague statements. A general fact always takes precedence over multiple sub-facts (signal vs noise).
+  - Eliminate introductions, vague statements and detailed repetitive elements.
   
 You must extract {Subject, Predicate, Object} triplets by following these rules:
 1. Identify named entities, preferences, and meaningful user-related concepts:
-  - All extracted triplets describe the user query intention as: the user’s preferences, beliefs, actions, experiences, learning, identity, work, or relationships (e.g., "I'm love working").
+  - All extracted triplets describe the user query intention as: the user’s preferences, beliefs, actions, experiences, learning, identity, work, or relationships (e.g., "I love working with precise Agents").
+  - Merge triplets from sub-facts or detailed objects. A general fact always takes precedence over multiple sub-facts (signal vs noise).
   - If the user asks about third-party business information classify it as "procedural" type.
   - The query intention can include specific preferences about how the Assistant should respond (e.g., "answer concisely", "explain in detail").   
   - Use inference to compress each fact (max 10 words).
   - DO NOT infer personal facts from third-party informations.
-  - Treat "Assistant Answer:" messages as external responses from the Assistant to the user. These responses MUST be used to enrich your reasoning process.
+  - Treat "Assistant:" messages as external and transient responses, there is no fact to extract from them. These responses MUST be used to enrich your reasoning process.
 2. Compress the facts:
   - Keep only the most shortest version of the Triplet.
 3. Rewrite comparatives, conditionals, or temporals into explicit predicates (e.g., "prefers", "available during", "used because of").
@@ -148,15 +153,15 @@ You must strictly extract {Subject, Predicate, Object} triplets by following the
   - Extract triplets that describe facts *about the user* based on their statements, covering areas like preferences, beliefs, actions, experiences, learning, identity, work, or relationships (e.g., "I love working").
   - Apply explicit, precise, and unambiguous predicates (e.g., "owns", "is located at", "is a", "has function", "causes", etc.).
   - Determine the triplet type (e.g., "factual", "episodic", "procedural", "semantic") based on the content and meaning.
-    - "episodic" for time-based events (e.g., "I went to the park yesterday").
+    - "episodic" If a fact depends on a temporal, situational, or immediate personal context, then that fact AND ALL OF ITS sub-facts MUST be classified as episodic.
     - "procedural" for business processes (e.g., "Looking for customer John Doe address", "How to create a new contract").
     - "factual" for stable user data (except procedural that prevails).
     
   - Eliminate introductions, sub-facts, detailed repetitive elements, stylistic fillers, or vague statements. General facts always takes precedence over multiple sub-facts (signal vs noise).
   - The query intention can include specific preferences about how the Assistant should respond (e.g., "answer concisely", "explain in detail").   
-  - Compress each fact  and reason (less than 12 words).
+  - Compress each OUTPUT (fact and reason) with less than 10 words.
   - DO NOT infer personal facts from third-party informations.
-  - Treat "Assistant Answer:" as external responses from the Assistant to enrich your reasoning process about the user.
+  - Treat "**ASSISTANT**:" as responses to enrich context of your reasoning process about the USER query.
 2. Use pronoun "I" instead of "The user" in the subject of the triplet.
 3. Do not output any facts already present in section # PRE-EXISTING FACTS.
   - If you find facts already present in section # PRE-EXISTING FACTS, use field "existing" to store them.

package/src/vectorstores/lite.ts

@@ -5,6 +5,7 @@ import sqlite3 from 'sqlite3';
 import { VectorStore } from "./base";
 import { SearchFilters, VectorStoreConfig, VectorStoreResult, MemoryPayload, MemoryScoringConfig, MemoryType } from "../types";
 import { createHash } from 'crypto';
+import { existsSync } from 'fs';
 
 
 // Define interface for database rows
@@ -25,6 +26,7 @@ interface MemoryVector {
  */
 export class LiteVectorStore implements VectorStore {
   private db: sqlite3.Database;
+  private dbPath: string;
   private isSecure: boolean;
   private dimension: number;
   private currentUserId: string;
@@ -39,20 +41,21 @@ export class LiteVectorStore implements VectorStore {
     this.currentUserId = currentUserId;
     this.isSecure = config.secure || false;
     this.scoringConfig = config.scoring;
-    this.cleanupThreshold = config.recencyCleanupThreshold; // Store threshold
+    this.cleanupThreshold = config.recencyCleanupThreshold || 0.25; // (default 0.25 means 2 times the half-life  )
     config.rootPath = config.rootPath || process.cwd();
     const filename = this.isSecure ? `memories-lite-${currentUserId}.db` : `memories-lite-global.db`;
-    const dbPath = (config.rootPath == ':memory:') ? ':memory:' : path.join(config.rootPath, filename);
+    this.dbPath = (config.rootPath == ':memory:') ? ':memory:' : path.join(config.rootPath, filename);
 
     // Add error handling callback for the database connection
-    this.db = new sqlite3.Database(dbPath);
+    this.db = new sqlite3.Database(this.dbPath);
   }
 
 
   private async init() {
-    await this.run(`
-      CREATE TABLE IF NOT EXISTS vectors (
-        id TEXT PRIMARY KEY,
+    try{
+      await this.run(`
+        CREATE TABLE IF NOT EXISTS vectors (
+          id TEXT PRIMARY KEY,
         vector BLOB NOT NULL,
         payload TEXT NOT NULL
       )
@@ -64,6 +67,9 @@ export class LiteVectorStore implements VectorStore {
         user_id TEXT NOT NULL UNIQUE
       )
     `);
+    }catch(err){
+      console.log("-- DBG init error:",err);
+    }
   }
 
   private async run(sql: string, params: any[] = []): Promise<void> {
@@ -151,9 +157,12 @@ export class LiteVectorStore implements VectorStore {
     if (cachedStore) {
       Object.setPrototypeOf(cachedStore, LiteVectorStore.prototype);
       cachedStore.currentUserId = hashedUserId;
-      // Ensure scoring config and threshold are updated if config object changed
-      cachedStore.scoringConfig = config.scoring;
-      cachedStore.cleanupThreshold = config.recencyCleanupThreshold;
+
+      //
+      // if the database file does not exist, we need to reinitialize the store
+      if (cachedStore.dbPath!==':memory:' && !existsSync(cachedStore.dbPath)) {
+        return new LiteVectorStore(config, hashedUserId);
+      }
       return cachedStore;
     }
 
@@ -176,13 +185,20 @@ export class LiteVectorStore implements VectorStore {
           `Vector dimension mismatch. Expected ${this.dimension}, got ${vectors[i].length}`,
         );
       }
+
+      const payload = {...payloads[i]};
+      //
+      // case of global store (insecure)
+      if(!payload.userId){
+        throw new Error("userId is required in payload");
+      }
       //
       // remove the userId from the payload as sensitive data
-      this.isSecure && delete payloads[i].userId;
+      this.isSecure && delete payload.userId;
       const vectorBuffer = Buffer.from(new Float32Array(vectors[i]).buffer);
       await this.run(
         `INSERT OR REPLACE INTO vectors (id, vector, payload) VALUES (?, ?, ?)`,
-        [ids[i], vectorBuffer, JSON.stringify(payloads[i])],
+        [ids[i], vectorBuffer, JSON.stringify(payload)],
       );
     }
 
@@ -199,6 +215,15 @@ export class LiteVectorStore implements VectorStore {
       );
     }
 
+
+
+    if(!filters || !filters.userId){
+      throw new Error("userId is mandatory in search");
+    }
+    filters = {...filters};
+    this.isSecure && delete filters.userId;
+
+
     const results: VectorStoreResult[] = [];
     const rows = await this.all(`SELECT * FROM vectors`);
 
@@ -290,18 +315,23 @@ export class LiteVectorStore implements VectorStore {
     const rows = await this.all(`SELECT * FROM vectors`);
     const results: VectorStoreResult[] = [];
 
+    //
+    // remove the userId from the payload as sensitive data
+    filters = {...filters};
+    this.isSecure && delete filters?.userId;
+
     for (const row of rows) {
       const memoryVector: MemoryVector = {
         id: row.id,
         vector: Array.from(new Float32Array(row.vector.buffer)),
-        payload: {},
+        payload: JSON.parse(row.payload),
       };
 
       if (this.filterVector(memoryVector, filters)) {
         // load payload at the end
         results.push({
           id: memoryVector.id,
-          payload: JSON.parse(row.payload),
+          payload:memoryVector.payload,
         });
       }
     }
@@ -356,7 +386,15 @@ export class LiteVectorStore implements VectorStore {
     return Math.max(0, hybridScore);
   }
 
-  // Internal method to clean up vectors based on recency score threshold
+  /**
+   * Internal method to clean up vectors based on recency score threshold.
+   * 
+   * @param threshold - The minimum recency score required for a memory to be retained.
+   *   - Recency score is calculated using exponential decay: 1.0 means brand new, 0.5 means at half-life, 0.0 means fully decayed.
+   *   - Memories with a recency score below this threshold will be deleted (unless their half-life is infinite or zero).
+   *   - For example, a threshold of 0.25 will remove all memories whose recency score has decayed 2 times the half-life.
+   *   - Use a lower threshold to keep more old memories, or a higher threshold to keep only fresher ones.
+   */
   private async _cleanupByRecency(threshold: number): Promise<number> {
     const rows = await this.all(`SELECT id, payload FROM vectors`);
     let deletedCount = 0;

package/tests/init.mem.ts

@@ -0,0 +1,40 @@
+/// <reference types="jest" />
+import { MemoriesLite } from "../src";
+import dotenv from "dotenv";
+
+dotenv.config();
+
+/**
+ * Helper to initialize MemoriesLite instance and generate a random userId.
+ * @param customPrompt Optional prompt to inject into the memory config.
+ */
+export function createTestMemory({customPrompt, dimension, rootPath, secure}:any) {
+  dimension = dimension || 768;
+  const userId =
+    Math.random().toString(36).substring(2, 15) +
+    Math.random().toString(36).substring(2, 15);
+
+  const memory = new MemoriesLite({
+    version: "v1.1",
+    disableHistory: true,
+    ...(customPrompt ? { customPrompt } : {}),
+    embedder: {
+      provider: "openai",
+      config: { dimension, apiKey: process.env.OPENAI_API_KEY!, model: "text-embedding-3-small" }
+    },
+    vectorStore: {
+      provider: "lite",
+      config: { 
+        dimension, 
+        rootPath: (rootPath || ":memory:"), 
+        secure: secure || false }
+    },
+    llm: {
+      provider: "openai",
+      config: { apiKey: process.env.OPENAI_API_KEY || "", model: "gpt-4.1-mini" }
+    },
+    historyDbPath: ":memory:"
+  });
+
+  return { memory, userId };
+} 

package/tests/memory.facts.test.ts

@@ -2,6 +2,7 @@
 import { MemoriesLite } from "../src";
 import { MemoryItem, SearchResult } from "../src/types";
 import dotenv from "dotenv";
+import { createTestMemory } from "./init.mem";
 
 dotenv.config();
 
@@ -9,42 +10,11 @@ jest.setTimeout(30000); // Increase timeout to 30 seconds
 
 describe("Memory Class facts regression tests", () => {
   let memory: MemoriesLite;
-  const userId =
-    Math.random().toString(36).substring(2, 15) +
-    Math.random().toString(36).substring(2, 15);
-
-  const dimension = 768;
+  let userId: string;
 
   beforeEach(async () => {
-    // Initialize with default configuration
-    memory = new MemoriesLite({
-      version: "v1.1",
-      disableHistory: true,
-      customPrompt: "L'utilisateur travail pour une régie immobilière!",
-      embedder: {
-        provider: "openai",
-        config: {
-          dimension,
-          apiKey: process.env.OPENAI_API_KEY || "",
-          model: "text-embedding-3-small",
-        },
-      },
-      vectorStore: {
-        provider: "lite",
-        config: {
-          dimension,
-          rootPath: ":memory:",
-        },
-      },
-      llm: {
-        provider: "openai",
-        config: {
-          apiKey: process.env.OPENAI_API_KEY || "",
-          model: "gpt-4.1-mini",
-        },
-      },
-      historyDbPath: ":memory:", // Use in-memory SQLite for tests
-    });
+    // Initialize memory via helper
+    ({ memory, userId } = createTestMemory({customPrompt:"L'utilisateur travail pour une régie immobilière!"}));
     // Reset all memories before each test
     await memory.reset(userId);
   });
@@ -56,69 +26,37 @@ describe("Memory Class facts regression tests", () => {
 
   describe("Edge cases for Facts", () => {
 
-    it("should not extract personal information as facts from business queries", async () => {
-      //  type?: "factual" | "episodic" | "semantic"|"procedural" | "assistant_preference";
-      // Capture a query that contains a name but is asking for contact information
-      const result = (await memory.capture(
-        "je cherche le téléphone de mon client Alphonse MAGLOIRE",
-        userId,
-        {},
-      )) as SearchResult;
-
-      // Verify no memory was created (business query)
-      expect(result).toBeDefined();
-      expect(result.results).toBeDefined();
-      expect(Array.isArray(result.results)).toBe(true);
-      expect(result.results.length).toBe(1);
-      const type = result.results[0]?.type; 
-      expect(["procedural","episodic"].includes(type)).toBe(true);
-      // Now search for memories that might contain "Alphonse MAGLOIRE"
-      // const searchResult = (await memory.retrieve(
-      //   "Qui est Alphonse MAGLOIRE?",
-      //   userId,
-      //   {},
-      // )) as SearchResult;
-
-      // // Verify no personal fact like "Je m'appelle Alphonse MAGLOIRE" was created
-      // expect(searchResult).toBeDefined();
-      // expect(searchResult.results).toBeDefined();
-      // expect(Array.isArray(searchResult.results)).toBe(true);
-      // expect(searchResult.results.length).toBe(0);
-      
-      // // Ensure no memory contains the name as a personal fact
-      // const allMemories = await memory.getAll(userId, {});
-      // const personalFacts = allMemories.results.filter(mem => 
-      //   mem.memory.toLowerCase().includes("Alphonse MAGLOIRE")
-      // );
-      // expect(personalFacts.length).toBe(0);
-    });
 
-    it("should add a single procedural memory", async () => {
-      const customFacts = "Je suis Olivier Poulain\nIT chez Immeuble SA";
+    it("should not add memory: Qui suis-je ?", async () => {
+      const customFacts = "Je suis Olivier Poulain\nIT et je travaille chez Immeuble SA";
       const result = (await memory.capture([
         {role:"user", content:"Qui suis-je ?"},
-        {role:"assitant", content:"Vous êtes Olivier Poulain, Chef de Projets au département IT & Gestion de projet, dans l'équipe IT de Immeuble SA. Ces informations proviennent de votre profil collaborateur enregistré dans le système interne de Immeuble SA"}],
+        {role:"assistant", content:"Vous êtes Olivier Poulain, Chef de Projets au département IT & Gestion de projet, dans l'équipe IT de Immeuble SA"}],
         userId,
         {customFacts},
       )) as SearchResult;
       expect(result).toBeDefined();
       expect(result.results).toBeDefined();
-      expect(result.results.length).toBe(1);
-      expect(result.results[0]?.type).toBe("factual");
+      expect(result.results.length).toBe(0);
+      // expect(result.results[0]?.type).toBe("factual");
     });
-    it("should add a single episodic memory", async () => {
+    it("episodic: Je veux manger des sushis pour ma pause de midi.", async () => {
+      const customFacts = "Je suis Olivier Poulain\nIT et je travaille chez Immeuble SA";
       const result = (await memory.capture([
-        {role:"user", content:"je veux trouver un bon film pour ce soir au cinéma avec ma copine,"}],
+        {role:"user", content:"J'ai faim, je veux manger des sushis pour ma pause de midi."},
+        {role:"user", content:"Cherche un restaurant de sushis près de chez moi."}],
         userId,
-        {},
+        {customFacts},
       )) as SearchResult;
 
       expect(result).toBeDefined();
       expect(result.results).toBeDefined();
-      expect(result.results.length).toBeGreaterThan(0);
+      expect(result.results.length).toBeGreaterThan(1);
       expect(result.results[0]?.type).toBe("episodic");
+      expect(result.results[1]?.type).toBe("episodic");
     });
 
+
     it("should add assistant_preference memory", async () => {
       const result = (await memory.capture(
         "tu dois répondre de manière concise et précise",
@@ -134,9 +72,28 @@ describe("Memory Class facts regression tests", () => {
       expect(result.results[0]?.type).toBe("assistant_preference");
     });
 
-    it("business facts are not factual (1)", async () => {
+    it("business:je cherche le téléphone de mon client Alphonse MAGLOIRE", async () => {
+      //  type?: "factual" | "episodic" | "semantic"|"procedural" | "assistant_preference";
+      // Capture a query that contains a name but is asking for contact information
+      const result = (await memory.capture(
+        "je cherche le téléphone de mon client Alphonse MAGLOIRE",
+        userId,
+        {},
+      )) as SearchResult;
+
+      // Verify no memory was created (business query)
+      expect(result).toBeDefined();
+      expect(result.results).toBeDefined();
+      expect(Array.isArray(result.results)).toBe(true);
+      expect(result.results.length).toBe(1);
+      const type = result.results[0]?.type; 
+      expect(["procedural","episodic"].includes(type)).toBe(true);
+    });
+
+    it("business:Le logement de Alphonse MAGLOIRE  au 5ème étage est de combien pièces", async () => {
       const result = (await memory.capture([
-        {role:"user", content:"Je sais que Alphonse MAGLOIRE a un logement de 4 pièces au 5ème étage",}],
+        {role:"user", content:"Le logement de Alphonse MAGLOIRE  au 5ème étage est de combien pièces.",},
+        {role:"assitant", content:"Alphonse MAGLOIRE a un logement de 4 pièces au 5ème étage",}],
         userId,
         {customFacts:"Je suis Olivier Poulain, Je m'occupe de la gérance locataire chez Immeuble SA"},
       )) as SearchResult;
@@ -171,9 +128,9 @@ describe("Memory Class facts regression tests", () => {
       }
     });
 
-    it("should not add business queries (3)", async () => {
+    it("business:Est-ce que Claude RIBUR est à jour avec son loyer ?", async () => {
       const result = (await memory.capture([
-        {role:"user", content:"Est-ce que Jean BURRI est à jour avec son loyer ?"}],
+        {role:"user", content:"Est-ce que Claude RIBUR est à jour avec son loyer ?"}],
         userId,
         {customFacts:"Je suis Olivier Poulain, Je m'occupe de la gérance locataire chez Immeuble SA"},
       )) as SearchResult;