mediasoup 3.20.0 → 3.20.2

package/worker/src/RTC/SCTP/association/HeartbeatHandler.cpp

@@ -96,7 +96,7 @@ namespace RTC
 			auto packet             = this->tcbContext->CreatePacket();
 			auto* heartbeatAckChunk = packet->BuildChunkInPlace<HeartbeatAckChunk>();
 
-			// Here we have to extract all Parameters from receivedHeartbeatRequestChunk
+			// Here we have to extract all parameters from receivedHeartbeatRequestChunk
 			// and add them into heartbeatAckChunk.
 			for (auto it = receivedHeartbeatRequestChunk->ParametersBegin();
 			     it != receivedHeartbeatRequestChunk->ParametersEnd();
@@ -126,7 +126,7 @@ namespace RTC
 			{
 				this->associationListener.OnAssociationError(
 				  Types::ErrorKind::PARSE_FAILED,
-				  "ignoring HEARTBEAT_ACK chunk without Heartbeat Info parameter");
+				  "ignoring HEARTBEAT-ACK chunk without Heartbeat Info parameter");
 
 				return;
 			}
@@ -156,14 +156,14 @@ namespace RTC
 			{
 				const uint64_t rttMs = nowMs - createdAtMs;
 
-				MS_DEBUG_DEV("valid HEARTBEAT_ACK Chunk received, calling ObserveRttMs(%" PRIu64 ")", rttMs);
+				MS_DEBUG_DEV("valid HEARTBEAT-ACK chunk received, calling ObserveRttMs(%" PRIu64 ")", rttMs);
 
 				this->tcbContext->ObserveRttMs(rttMs);
 			}
 			else
 			{
 				MS_WARN_DEV(
-				  "ignoring received HEARTBEAT_ACK Chunk with invalid info content [createdAtMs:%" PRIu64
+				  "ignoring received HEARTBEAT-ACK chunk with invalid info content [createdAtMs:%" PRIu64
 				  ", nowMs:%" PRIu64 "]",
 				  createdAtMs,
 				  nowMs);
@@ -182,7 +182,7 @@ namespace RTC
 
 			if (!this->tcbContext->IsAssociationEstablished())
 			{
-				MS_DEBUG_DEV("won't send HEARTBEAT_REQUEST when SCTP Association is not established");
+				MS_DEBUG_DEV("won't send HEARTBEAT-REQUEST when SCTP association is not established");
 
 				return;
 			}
@@ -205,7 +205,7 @@ namespace RTC
 			heartbeatInfoParameter->Consolidate();
 			heartbeatRequestChunk->Consolidate();
 
-			MS_DEBUG_DEV("sending HEARTBEAT_REQUEST Chunk with info content [nowMs:%" PRIu64 "]", nowMs);
+			MS_DEBUG_DEV("sending HEARTBEAT-REQUEST chunk with info content [nowMs:%" PRIu64 "]", nowMs);
 
 			this->tcbContext->SendPacket(packet.get());
 		}

package/worker/src/RTC/SCTP/association/NegotiatedCapabilities.cpp

@@ -35,7 +35,7 @@ namespace RTC
 
 			// Partial Reliability Extension is negotiated if we desire it and
 			// peer announces support via Forward-TSN-Supported Parameter or via
-			// Supported Extensions Parameter.
+			// Supported extensions parameter.
 			negotiatedCapabilities.partialReliability =
 			  sctpOptions.enablePartialReliability &&
 			  (remoteForwardTsnSupportedParameter ||
@@ -43,14 +43,14 @@ namespace RTC
 			    remoteSupportedExtensionsParameter->IncludesChunkType(Chunk::ChunkType::FORWARD_TSN)));
 
 			// Message Interleaving is negotiated if we desire it and peer
-			// announces support via Supported Extensions Parameter.
+			// announces support via Supported Extensions parameter.
 			negotiatedCapabilities.messageInterleaving =
 			  sctpOptions.enableMessageInterleaving && remoteSupportedExtensionsParameter &&
 			  remoteSupportedExtensionsParameter->IncludesChunkType(Chunk::ChunkType::I_DATA) &&
 			  remoteSupportedExtensionsParameter->IncludesChunkType(Chunk::ChunkType::I_FORWARD_TSN);
 
 			// Stream Re-Configuration is negotiated if peer announces support via
-			// Supported Extensions Parameter.
+			// Supported extensions parameter.
 			negotiatedCapabilities.reConfig =
 			  remoteSupportedExtensionsParameter &&
 			  remoteSupportedExtensionsParameter->IncludesChunkType(Chunk::ChunkType::RE_CONFIG);

package/worker/src/RTC/SCTP/association/PacketSender.cpp

@@ -42,7 +42,7 @@ namespace RTC
 
 			if (!sent)
 			{
-				MS_WARN_TAG(sctp, "couldn't send SCTP Packet");
+				MS_WARN_TAG(sctp, "couldn't send SCTP packet");
 			}
 
 			return sent;

package/worker/src/RTC/SCTP/association/StreamResetHandler.cpp

@@ -188,7 +188,7 @@ namespace RTC
 				}
 			}
 
-			MS_WARN_TAG(sctp, "invalid set of RE-CONFIG Parameters");
+			MS_WARN_TAG(sctp, "invalid set of RE-CONFIG parameters");
 
 			return false;
 		}
@@ -241,7 +241,7 @@ namespace RTC
 			}
 			else if (reqSeqNbr != this->lastProcessedReqSeqNbr.GetNextValue())
 			{
-				// Too old, too new, from wrong Association, etc.
+				// Too old, too new, from wrong association, etc.
 				MS_WARN_TAG(sctp, "bad reqSeqNbr: %" PRIu32, reqSeqNbr.Wrap());
 
 				return ReqSeqNbrValidationResult::BAD_SEQUENCE_NUMBER;

package/worker/src/RTC/SCTP/association/TransmissionControlBlock.cpp

@@ -290,13 +290,13 @@ namespace RTC
 			{
 				const auto packet = CreatePacket();
 
-				// Only add control Chunks to the first Packet that is sent, if sending
-				// multiple Packets in one go (as allowed by the congestion window).
+				// Only add control chunks to the first packet that is sent, if sending
+				// multiple packets in one go (as allowed by the congestion window).
 				if (packetIdx == 0)
 				{
 					if (addCookieAckChunk)
 					{
-						MS_DEBUG_DEV("adding COOKIE_ACK Chunk to the Packet");
+						MS_DEBUG_DEV("adding COOKIE-ACK chunk to the packet");
 
 						const auto* cookieAckChunk = packet->BuildChunkInPlace<CookieAckChunk>();
 
@@ -312,7 +312,7 @@ namespace RTC
 						if (packet->GetChunksCount() > 0)
 						{
 							MS_THROW_ERROR(
-							  "Packet must have no Chunks [addCookieAckChunk:%s]",
+							  "packet must have no chunks [addCookieAckChunk:%s]",
 							  addCookieAckChunk ? "true" : "no");
 						}
 
@@ -411,7 +411,7 @@ namespace RTC
 		{
 			MS_TRACE();
 
-			// In the COOKIE_ECHO state, let the T1-COOKIE timer trigger
+			// In the COOKIE-ECHO state, let the T1-COOKIE timer trigger
 			// retransmissions, to avoid having two timers doing that.
 			if (this->remoteStateCookie.has_value())
 			{

package/worker/src/RTC/SCTP/packet/Chunk.cpp

@@ -44,27 +44,27 @@ namespace RTC
 		/* Class variables. */
 
 		// clang-format off
-		const std::unordered_map<Chunk::ChunkType, std::string> Chunk::ChunkType2String =
+		const ankerl::unordered_dense::map<Chunk::ChunkType, std::string> Chunk::ChunkType2String =
 		{
 			{ Chunk::ChunkType::DATA,              "DATA"              },
 			{ Chunk::ChunkType::INIT,              "INIT"              },
-			{ Chunk::ChunkType::INIT_ACK,          "INIT_ACK"          },
+			{ Chunk::ChunkType::INIT_ACK,          "INIT-ACK"          },
 			{ Chunk::ChunkType::SACK,              "SACK"              },
-			{ Chunk::ChunkType::HEARTBEAT_REQUEST, "HEARTBEAT_REQUEST" },
-			{ Chunk::ChunkType::HEARTBEAT_ACK,     "HEARTBEAT_ACK"     },
+			{ Chunk::ChunkType::HEARTBEAT_REQUEST, "HEARTBEAT-REQUEST" },
+			{ Chunk::ChunkType::HEARTBEAT_ACK,     "HEARTBEAT-ACK"     },
 			{ Chunk::ChunkType::ABORT,             "ABORT"             },
 			{ Chunk::ChunkType::SHUTDOWN,          "SHUTDOWN"          },
-			{ Chunk::ChunkType::SHUTDOWN_ACK,      "SHUTDOWN_ACK"      },
-			{ Chunk::ChunkType::OPERATION_ERROR,   "OPERATION_ERROR"   },
-			{ Chunk::ChunkType::COOKIE_ECHO,       "COOKIE_ECHO"       },
-			{ Chunk::ChunkType::COOKIE_ACK,        "COOKIE_ACK"        },
+			{ Chunk::ChunkType::SHUTDOWN_ACK,      "SHUTDOWN-ACK"      },
+			{ Chunk::ChunkType::OPERATION_ERROR,   "OPERATION-ERROR"   },
+			{ Chunk::ChunkType::COOKIE_ECHO,       "COOKIE-ECHO"       },
+			{ Chunk::ChunkType::COOKIE_ACK,        "COOKIE-ACK"        },
 			{ Chunk::ChunkType::ECNE,              "ECNE"              },
 			{ Chunk::ChunkType::CWR,               "CWR"               },
-			{ Chunk::ChunkType::SHUTDOWN_COMPLETE, "SHUTDOWN_COMPLETE" },
-			{ Chunk::ChunkType::FORWARD_TSN,       "FORWARD_TSN"       },
-			{ Chunk::ChunkType::RE_CONFIG,         "RE_CONFIG"         },
-			{ Chunk::ChunkType::I_DATA,            "I_DATA"            },
-			{ Chunk::ChunkType::I_FORWARD_TSN,     "I_FORWARD_TSN"     },
+			{ Chunk::ChunkType::SHUTDOWN_COMPLETE, "SHUTDOWN-COMPLETE" },
+			{ Chunk::ChunkType::FORWARD_TSN,       "FORWARD-TSN"       },
+			{ Chunk::ChunkType::RE_CONFIG,         "RE-CONFIG"         },
+			{ Chunk::ChunkType::I_DATA,            "I-DATA"            },
+			{ Chunk::ChunkType::I_FORWARD_TSN,     "I-FORWARD-TSN"     },
 		};
 		// clang-format on
 
@@ -117,7 +117,7 @@ namespace RTC
 			MS_TRACE();
 
 			// NOTE: Here we cannot check CanHaveParameters() or CanHaveErrorCauses()
-			// because this is the destructor of Chunk so the subclass has been
+			// because this is the destructor of chunk so the subclass has been
 			// already destroyed (its destructor runs first).
 
 			for (const auto* parameter : this->parameters)
@@ -170,15 +170,15 @@ namespace RTC
 
 			const size_t previousLength = GetLength();
 
-			// This will update the total length and Length field of the Chunk.
+			// This will update the total length and length field of the chunk.
 			// NOTE: It may throw.
 			AddItem(parameter);
 
-			// Let's append the Parameter at the end of existing Parameters.
+			// Let's append the parameter at the end of existing parameters.
 			auto* clonedParameter =
 			  parameter->Clone(const_cast<uint8_t*>(GetBuffer()) + previousLength, parameter->GetLength());
 
-			// Add the Parameter to the list.
+			// Add the parameter to the list.
 			this->parameters.push_back(clonedParameter);
 		}
 
@@ -191,11 +191,11 @@ namespace RTC
 
 			const size_t previousLength = GetLength();
 
-			// This will update the total length and Length field of the Chunk.
+			// This will update the total length and length field of the chunk.
 			// NOTE: It may throw.
 			AddItem(errorCause);
 
-			// Let's append the Error Cause at the end of existing Error Causes.
+			// Let's append the error cause at the end of existing error causes.
 			auto* clonedErrorCause = errorCause->Clone(
 			  const_cast<uint8_t*>(GetBuffer()) + previousLength, errorCause->GetLength());
 
@@ -282,7 +282,7 @@ namespace RTC
 		{
 			MS_TRACE();
 
-			// Soft clone Parameters into the given Chunk.
+			// Soft clone parameters into the given chunk.
 			if (CanHaveParameters())
 			{
 				for (auto* parameter : this->parameters)
@@ -295,7 +295,7 @@ namespace RTC
 				}
 			}
 
-			// Soft clone Error Causes into the given Chunk.
+			// Soft clone error causes into the given chunk.
 			if (CanHaveErrorCauses())
 			{
 				for (auto* errorCause : this->errorCauses)
@@ -327,16 +327,16 @@ namespace RTC
 
 			AssertCanHaveParameters();
 
-			// Here we assume that the Chunk buffer has been validated and
-			// GetLength() returns the fixed minimum length of the specific Chunk
+			// Here we assume that the chunk buffer has been validated and
+			// GetLength() returns the fixed minimum length of the specific chunk
 			// subclass, so GetBuffer() + GetLength() points to the beginning of the
-			// potential Parameters. And of course we assume that a Chunk cannot have
-			// both Parameters and Error Causes.
+			// potential parameters. And of course we assume that a chunk cannot have
+			// both parameters and error causes.
 			auto* ptr = const_cast<uint8_t*>(GetBuffer()) + GetLength();
 
-			// Here we assume that the Chunk has been validated so Length field is
-			// reliable. We want to be ready for Length field to include or not the
-			// possible padding of the last Parameter (as per RFC recommendation). In
+			// Here we assume that the chunk has been validated so length field is
+			// reliable. We want to be ready for length field to include or not the
+			// possible padding of the last parameter (as per RFC recommendation). In
 			// fact, we rely on parameter->GetLength() while parsing the buffer so we
 			// want to provide each Parameter::StrictParse() call with a 4-bytes
 			// padded buffer length.
@@ -345,10 +345,10 @@ namespace RTC
 			while (ptr < end)
 			{
 				// The remaining length in the given length is the potential buffer
-				// length of the Parameter.
+				// length of the parameter.
 				const size_t parameterMaxBufferLength = end - ptr;
 
-				// Here we must anticipate the type of each Parameter to use its
+				// Here we must anticipate the type of each parameter to use its
 				// appropriate parser.
 				Parameter::ParameterType parameterType;
 				uint16_t parameterLength;
@@ -357,7 +357,7 @@ namespace RTC
 				if (!Parameter::IsParameter(
 				      ptr, parameterMaxBufferLength, parameterType, parameterLength, padding))
 				{
-					MS_WARN_TAG(sctp, "not an SCTP Parameter");
+					MS_WARN_TAG(sctp, "not an SCTP parameter");
 
 					return false;
 				}
@@ -534,16 +534,16 @@ namespace RTC
 
 			AssertCanHaveErrorCauses();
 
-			// Here we assume that the Chunk buffer has been validated and GetLength()
-			// returns the fixed minimum length of the specific Chunk subclass, so
+			// Here we assume that the chunk buffer has been validated and GetLength()
+			// returns the fixed minimum length of the specific chunk subclass, so
 			// GetBuffer() + GetLength() points to the beginning of the potential
-			// Error Causes. And of course we assume that a Chunk cannot have both
-			// Parameters and Error Causes.
+			// error causes. And of course we assume that a chunk cannot have both
+			// parameters and error causes.
 			auto* ptr = const_cast<uint8_t*>(GetBuffer()) + GetLength();
 
-			// Here we assume that the Chunk has been validated so Length field is
-			// reliable. We want to be ready for Length field to include or not the
-			// possible padding of the last Error Cause (as per RFCrecommendation).
+			// Here we assume that the chunk has been validated so length field is
+			// reliable. We want to be ready for length field to include or not the
+			// possible padding of the last error cause (as per RFCrecommendation).
 			// In fact, we rely on errorCause->GetLength() while parsing the buffer
 			// so we want to provide each ErrorCause::StrictParse() call with a
 			// 4-bytes padded buffer length.
@@ -552,10 +552,10 @@ namespace RTC
 			while (ptr < end)
 			{
 				// The remaining length in the given length is the potential buffer
-				// length of the Error Cause.
+				// length of the error cause.
 				const size_t errorCauseMaxBufferLength = end - ptr;
 
-				// Here we must anticipate the type of each Error Cause to use its
+				// Here we must anticipate the type of each error cause to use its
 				// appropriate parser.
 				ErrorCause::ErrorCauseCode causeCode;
 				uint16_t causeLength;
@@ -563,7 +563,7 @@ namespace RTC
 
 				if (!ErrorCause::IsErrorCause(ptr, errorCauseMaxBufferLength, causeCode, causeLength, padding))
 				{
-					MS_WARN_TAG(sctp, "not an SCTP Error Cause");
+					MS_WARN_TAG(sctp, "not an SCTP error cause");
 
 					return false;
 				}
@@ -716,22 +716,22 @@ namespace RTC
 
 			this->needsConsolidation = true;
 
-			// When the application completes the Parameter it must call
+			// When the application completes the parameter it must call
 			// `parameter->Consolidate()` and that will trigger this event.
 			parameter->SetConsolidatedListener(
 			  [this, parameter]()
 			  {
 				  try
 				  {
-					  // Fix buffer length assigned to the Parameter.
+					  // Fix buffer length assigned to the parameter.
 					  // NOTE: It may throw.
 					  parameter->SetBufferLength(parameter->GetLength());
 
-					  // This will update the total length and Length field of the Chunk.
+					  // This will update the total length and length field of the chunk.
 					  // NOTE: It may throw.
 					  AddItem(parameter);
 
-					  // Add the Parameter to the list.
+					  // Add the parameter to the list.
 					  this->parameters.push_back(parameter);
 
 					  this->needsConsolidation = false;
@@ -751,21 +751,21 @@ namespace RTC
 
 			this->needsConsolidation = true;
 
-			// When the application completes the Error Cause it must call
+			// When the application completes the error cause it must call
 			// `errorCause->Consolidate()` and that will trigger this event.
 			errorCause->SetConsolidatedListener(
 			  [this, errorCause]()
 			  {
 				  try
 				  {
-					  // Fix buffer length assigned to the Error Cause.
+					  // Fix buffer length assigned to the error cause.
 					  errorCause->SetBufferLength(errorCause->GetLength());
 
-					  // This will update the total length and Length field of the Chunk.
+					  // This will update the total length and length field of the chunk.
 					  // NOTE: It may throw.
 					  AddItem(errorCause);
 
-					  // Add the Error Cause to the list.
+					  // Add the error cause to the list.
 					  this->errorCauses.push_back(errorCause);
 
 					  this->needsConsolidation = false;
@@ -785,7 +785,7 @@ namespace RTC
 
 			if (!CanHaveParameters())
 			{
-				MS_THROW_ERROR("this Chunk class cannot have Parameters");
+				MS_THROW_ERROR("this chunk class cannot have parameters");
 			}
 		}
 
@@ -795,7 +795,7 @@ namespace RTC
 
 			if (!CanHaveErrorCauses())
 			{
-				MS_THROW_ERROR("this Chunk class cannot have Error Causes");
+				MS_THROW_ERROR("this chunk class cannot have error causes");
 			}
 		}
 
@@ -805,7 +805,7 @@ namespace RTC
 
 			if (this->needsConsolidation)
 			{
-				MS_THROW_ERROR("Chunk needs consolidation of some ongoing Parameter or Error Cause");
+				MS_THROW_ERROR("chunk needs consolidation of some ongoing parameter or error cause");
 			}
 		}
 	} // namespace SCTP

package/worker/src/RTC/SCTP/packet/ErrorCause.cpp

@@ -12,21 +12,21 @@ namespace RTC
 		/* Class variables. */
 
 		// clang-format off
-		const std::unordered_map<ErrorCause::ErrorCauseCode, std::string> ErrorCause::ErrorCauseCode2String =
+		const ankerl::unordered_dense::map<ErrorCause::ErrorCauseCode, std::string> ErrorCause::ErrorCauseCode2String =
 		{
-			{ ErrorCause::ErrorCauseCode::INVALID_STREAM_IDENTIFIER,                    "INVALID_STREAM_IDENTIFIER"                    },
-			{ ErrorCause::ErrorCauseCode::MISSING_MANDATORY_PARAMETER,                  "MISSING_MANDATORY_PARAMETER"                  },
-			{ ErrorCause::ErrorCauseCode::STALE_COOKIE,                                 "STALE_COOKIE"                                 },
-			{ ErrorCause::ErrorCauseCode::OUT_OF_RESOURCE,                              "OUT_OF_RESOURCE"                              },
-			{ ErrorCause::ErrorCauseCode::UNRESOLVABLE_ADDRESS,                         "UNRESOLVABLE_ADDRESS"                         },
-			{ ErrorCause::ErrorCauseCode::UNRECOGNIZED_CHUNK_TYPE,                      "UNRECOGNIZED_CHUNK_TYPE"                      },
-			{ ErrorCause::ErrorCauseCode::INVALID_MANDATORY_PARAMETER,                  "INVALID_MANDATORY_PARAMETER"                  },
-			{ ErrorCause::ErrorCauseCode::UNRECOGNIZED_PARAMETERS,                      "UNRECOGNIZED_PARAMETERS"                      },
-			{ ErrorCause::ErrorCauseCode::NO_USER_DATA,                                 "NO_USER_DATA"                                 },
-			{ ErrorCause::ErrorCauseCode::COOKIE_RECEIVED_WHILE_SHUTTING_DOWN,          "COOKIE_RECEIVED_WHILE_SHUTTING_DOWN"          },
-			{ ErrorCause::ErrorCauseCode::RESTART_OF_AN_ASSOCIATION_WITH_NEW_ADDRESSES, "RESTART_OF_AN_ASSOCIATION_WITH_NEW_ADDRESSES" },
-			{ ErrorCause::ErrorCauseCode::USER_INITIATED_ABORT,                         "USER_INITIATED_ABORT"                         },
-			{ ErrorCause::ErrorCauseCode::PROTOCOL_VIOLATION,                           "PROTOCOL_VIOLATION"                           },
+			{ ErrorCause::ErrorCauseCode::INVALID_STREAM_IDENTIFIER,                    "INVALID-STREAM-IDENTIFIER"                    },
+			{ ErrorCause::ErrorCauseCode::MISSING_MANDATORY_PARAMETER,                  "MISSING-MANDATORY-PARAMETER"                  },
+			{ ErrorCause::ErrorCauseCode::STALE_COOKIE,                                 "STALE-COOKIE"                                 },
+			{ ErrorCause::ErrorCauseCode::OUT_OF_RESOURCE,                              "OUT-OF-RESOURCE"                              },
+			{ ErrorCause::ErrorCauseCode::UNRESOLVABLE_ADDRESS,                         "UNRESOLVABLE-ADDRESS"                         },
+			{ ErrorCause::ErrorCauseCode::UNRECOGNIZED_CHUNK_TYPE,                      "UNRECOGNIZED-CHUNK-TYPE"                      },
+			{ ErrorCause::ErrorCauseCode::INVALID_MANDATORY_PARAMETER,                  "INVALID-MANDATORY-PARAMETER"                  },
+			{ ErrorCause::ErrorCauseCode::UNRECOGNIZED_PARAMETERS,                      "UNRECOGNIZED-PARAMETERS"                      },
+			{ ErrorCause::ErrorCauseCode::NO_USER_DATA,                                 "NO-USER-DATA"                                 },
+			{ ErrorCause::ErrorCauseCode::COOKIE_RECEIVED_WHILE_SHUTTING_DOWN,          "COOKIE-RECEIVED-WHILE-SHUTTING-DOWN"          },
+			{ ErrorCause::ErrorCauseCode::RESTART_OF_AN_ASSOCIATION_WITH_NEW_ADDRESSES, "RESTART-OF-AN-ASSOCIATION-WITH-NEW-ADDRESSES" },
+			{ ErrorCause::ErrorCauseCode::USER_INITIATED_ABORT,                         "USER-INITIATED-ABORT"                         },
+			{ ErrorCause::ErrorCauseCode::PROTOCOL_VIOLATION,                           "PROTOCOL-VIOLATION"                           },
 		};
 		// clang-format on
 

package/worker/src/RTC/SCTP/packet/Packet.cpp

@@ -42,7 +42,7 @@ namespace RTC
 
 			if (!Packet::IsSctp(buffer, bufferLength))
 			{
-				MS_WARN_TAG(sctp, "not an SCTP Packet");
+				MS_WARN_TAG(sctp, "not an SCTP packet");
 
 				return nullptr;
 			}
@@ -50,7 +50,7 @@ namespace RTC
 			auto* packet = new Packet(const_cast<uint8_t*>(buffer), bufferLength);
 
 			// Pointer that initially points to the given data buffer and is later
-			// incremented to point to other parts of the Packet.
+			// incremented to point to other parts of the packet.
 			const auto* ptr = buffer;
 
 			// Move to chunks.
@@ -59,10 +59,10 @@ namespace RTC
 			while (ptr < buffer + bufferLength)
 			{
 				// The remaining length in the buffer is the potential buffer length
-				// of the Chunk.
+				// of the chunk.
 				const size_t chunkMaxBufferLength = bufferLength - (ptr - buffer);
 
-				// Here we must anticipate the type of each Chunk to use its appropriate
+				// Here we must anticipate the type of each chunk to use its appropriate
 				// parser.
 				Chunk::ChunkType chunkType;
 				uint16_t chunkLength;
@@ -70,7 +70,7 @@ namespace RTC
 
 				if (!Chunk::IsChunk(ptr, chunkMaxBufferLength, chunkType, chunkLength, padding))
 				{
-					MS_WARN_TAG(sctp, "not an SCTP Chunk");
+					MS_WARN_TAG(sctp, "not an SCTP chunk");
 
 					delete packet;
 					return nullptr;
@@ -78,7 +78,7 @@ namespace RTC
 
 				Chunk* chunk{ nullptr }; // NOLINT(misc-const-correctness)
 
-				MS_DEBUG_DEV("parsing SCTP Chunk [ptr:%zu, type:%" PRIu8 "]", ptr - buffer, chunkType);
+				MS_DEBUG_DEV("parsing SCTP chunk [ptr:%zu, type:%" PRIu8 "]", ptr - buffer, chunkType);
 
 				switch (chunkType)
 				{
@@ -238,7 +238,7 @@ namespace RTC
 			}
 
 			// It's mandatory to call SetLength() once we are done and we know the
-			// exact length of the Packet.
+			// exact length of the packet.
 			packet->SetLength(computedLength);
 
 			return packet;
@@ -265,7 +265,7 @@ namespace RTC
 			packet->SetChecksum(0u);
 
 			// No need to invoke SetLength() since constructor invoked it with
-			// minimum Packet length.
+			// minimum packet length.
 
 			return packet;
 		}
@@ -334,7 +334,7 @@ namespace RTC
 
 			Serializable::CloneInto(clonedPacket);
 
-			// Soft clone Packet Chunks into the given cloned Packet.
+			// Soft clone packet chunks into the given cloned packet.
 			for (auto* chunk : this->chunks)
 			{
 				const size_t offset = chunk->GetBuffer() - GetBuffer();
@@ -383,7 +383,7 @@ namespace RTC
 
 			const size_t length = GetLength() + chunk->GetLength();
 
-			// Let's append the Chunk at the end of existing Chunks.
+			// Let's append the chunk at the end of existing chunks.
 			auto* clonedChunk =
 			  chunk->Clone(const_cast<uint8_t*>(GetBuffer()) + GetLength(), chunk->GetLength());
 
@@ -435,7 +435,7 @@ namespace RTC
 
 			this->needsConsolidation = true;
 
-			// When the application completes the Chunk it must call
+			// When the application completes the chunk it must call
 			// `chunk->Consolidate()` and that will trigger this event.
 			chunk->SetConsolidatedListener(
 			  [this, chunk]()
@@ -444,18 +444,18 @@ namespace RTC
 				  {
 					  if (chunk->NeedsConsolidation())
 					  {
-						  MS_THROW_ERROR("ongoing Chunk needs consolidation");
+						  MS_THROW_ERROR("ongoing chunk needs consolidation");
 					  }
 
-					  // Fix buffer length assigned to the Chunk.
+					  // Fix buffer length assigned to the chunk.
 					  chunk->SetBufferLength(chunk->GetLength());
 
-					  // Update Packet length.
-					  // NOTE: This will throw if there is no enough space in the Packet
+					  // Update packet length.
+					  // NOTE: This will throw if there is no enough space in the packet
 					  // buffer.
 					  SetLength(GetLength() + chunk->GetLength());
 
-					  // Add the Chunk to the list.
+					  // Add the chunk to the list.
 					  this->chunks.push_back(chunk);
 					  this->needsConsolidation = false;
 				  }
@@ -474,7 +474,7 @@ namespace RTC
 
 			if (this->needsConsolidation)
 			{
-				MS_THROW_ERROR("Packet needs consolidation of some ongoing Chunk");
+				MS_THROW_ERROR("packet needs consolidation of some ongoing chunk");
 			}
 		}
 	} // namespace SCTP

package/worker/src/RTC/SCTP/packet/Parameter.cpp

@@ -12,24 +12,24 @@ namespace RTC
 		/* Class variables. */
 
 		// clang-format off
-		const std::unordered_map<Parameter::ParameterType, std::string> Parameter::ParameterType2String =
+		const ankerl::unordered_dense::map<Parameter::ParameterType, std::string> Parameter::ParameterType2String =
 		{
-			{ Parameter::ParameterType::HEARTBEAT_INFO,               "HEARTBEAT_INFO"               },
-			{ Parameter::ParameterType::IPV4_ADDRESS,                 "IPV4_ADDRESS"                 },
-			{ Parameter::ParameterType::IPV6_ADDRESS,                 "IPV6_ADDRESS"                 },
-			{ Parameter::ParameterType::STATE_COOKIE,                 "STATE_COOKIE"                 },
-			{ Parameter::ParameterType::UNRECOGNIZED_PARAMETER,       "UNRECOGNIZED_PARAMETER"       },
-			{ Parameter::ParameterType::COOKIE_PRESERVATIVE,          "COOKIE_PRESERVATIVE"          },
-			{ Parameter::ParameterType::SUPPORTED_ADDRESS_TYPES,      "SUPPORTED_ADDRESS_TYPES"      },
-			{ Parameter::ParameterType::FORWARD_TSN_SUPPORTED,        "FORWARD_TSN_SUPPORTED"        },
-			{ Parameter::ParameterType::SUPPORTED_EXTENSIONS,         "SUPPORTED_EXTENSIONS"         },
-			{ Parameter::ParameterType::OUTGOING_SSN_RESET_REQUEST,   "OUTGOING_SSN_RESET_REQUEST"   },
-			{ Parameter::ParameterType::INCOMING_SSN_RESET_REQUEST,   "INCOMING_SSN_RESET_REQUEST"   },
-			{ Parameter::ParameterType::SSN_TSN_RESET_REQUEST,        "SSN_TSN_RESET_REQUEST"        },
-			{ Parameter::ParameterType::RECONFIGURATION_RESPONSE,     "RECONFIGURATION_RESPONSE"     },
-			{ Parameter::ParameterType::ADD_OUTGOING_STREAMS_REQUEST, "ADD_OUTGOING_STREAMS_REQUEST" },
-			{ Parameter::ParameterType::ADD_INCOMING_STREAMS_REQUEST, "ADD_INCOMING_STREAMS_REQUEST" },
-			{ Parameter::ParameterType::ZERO_CHECKSUM_ACCEPTABLE,     "ZERO_CHECKSUM_ACCEPTABLE"     },
+			{ Parameter::ParameterType::HEARTBEAT_INFO,               "HEARTBEAT-INFO"               },
+			{ Parameter::ParameterType::IPV4_ADDRESS,                 "IPV4-ADDRESS"                 },
+			{ Parameter::ParameterType::IPV6_ADDRESS,                 "IPV6-ADDRESS"                 },
+			{ Parameter::ParameterType::STATE_COOKIE,                 "STATE-COOKIE"                 },
+			{ Parameter::ParameterType::UNRECOGNIZED_PARAMETER,       "UNRECOGNIZED-PARAMETER"       },
+			{ Parameter::ParameterType::COOKIE_PRESERVATIVE,          "COOKIE-PRESERVATIVE"          },
+			{ Parameter::ParameterType::SUPPORTED_ADDRESS_TYPES,      "SUPPORTED-ADDRESS-TYPES"      },
+			{ Parameter::ParameterType::FORWARD_TSN_SUPPORTED,        "FORWARD-TSN-SUPPORTED"        },
+			{ Parameter::ParameterType::SUPPORTED_EXTENSIONS,         "SUPPORTED-EXTENSIONS"         },
+			{ Parameter::ParameterType::OUTGOING_SSN_RESET_REQUEST,   "OUTGOING-SSN-RESET-REQUEST"   },
+			{ Parameter::ParameterType::INCOMING_SSN_RESET_REQUEST,   "INCOMING-SSN-RESET-REQUEST"   },
+			{ Parameter::ParameterType::SSN_TSN_RESET_REQUEST,        "SSN-TSN-RESET-REQUEST"        },
+			{ Parameter::ParameterType::RECONFIGURATION_RESPONSE,     "RECONFIGURATION-RESPONSE"     },
+			{ Parameter::ParameterType::ADD_OUTGOING_STREAMS_REQUEST, "ADD-OUTGOING-STREAMS-REQUEST" },
+			{ Parameter::ParameterType::ADD_INCOMING_STREAMS_REQUEST, "ADD-INCOMING-STREAMS-REQUEST" },
+			{ Parameter::ParameterType::ZERO_CHECKSUM_ACCEPTABLE,     "ZERO-CHECKSUM-ACCEPTABLE"     },
 		};
 		// clang-format on