mediasoup 3.19.19 → 3.19.21

package/worker/src/Settings.cpp

@@ -60,6 +60,7 @@ void Settings::SetConfiguration(int argc, char* argv[])
 		{ "dtlsPrivateKeyFile",   optional_argument, nullptr, 'p' },
 		{ "libwebrtcFieldTrials", optional_argument, nullptr, 'W' },
 		{ "disableLiburing",      optional_argument, nullptr, 'd' },
+		{ "useBuiltInSctpStack",  optional_argument, nullptr, 's' },
 		{ nullptr,                0,                 nullptr,  0  }
 	};
 	// clang-format on
@@ -165,7 +166,23 @@ void Settings::SetConfiguration(int argc, char* argv[])
 
 				if (stringValue == "true")
 				{
-					Settings::configuration.liburingDisabled = true;
+					Settings::configuration.disableLiburing = true;
+				}
+
+				break;
+			}
+
+			case 's':
+			{
+				stringValue = std::string(optarg);
+
+				if (stringValue == "true")
+				{
+					Settings::configuration.useBuiltInSctpStack = true;
+				}
+				else
+				{
+					Settings::configuration.useBuiltInSctpStack = false;
 				}
 
 				break;
@@ -382,6 +399,9 @@ void Settings::PrintConfiguration()
 		MS_DEBUG_TAG(
 		  info, "  libwebrtcFieldTrials: %s", Settings::configuration.libwebrtcFieldTrials.c_str());
 	}
+	MS_DEBUG_TAG(info, "  disableLiburing: %s", Settings::configuration.disableLiburing ? "yes" : "no");
+	MS_DEBUG_TAG(
+	  info, "  useBuiltInSctpStack: %s", Settings::configuration.useBuiltInSctpStack ? "yes" : "no");
 
 	MS_DEBUG_TAG(info, "</configuration>");
 }

package/worker/src/Worker.cpp

@@ -7,9 +7,8 @@
 #include "DepLibUring.hpp"
 #endif
 #include "DepLibUV.hpp"
-#ifndef MS_SCTP_STACK
+// TODO: Remove once we only use built-in SCTP stack.
 #include "DepUsrSCTP.hpp"
-#endif
 #include "Logger.hpp"
 #include "MediaSoupErrors.hpp"
 #include "Settings.hpp"
@@ -42,10 +41,12 @@ Worker::Worker(::Channel::ChannelSocket* channel) : channel(channel)
 	}
 #endif
 
-#ifndef MS_SCTP_STACK
-	// Create the Checker instance in DepUsrSCTP.
-	DepUsrSCTP::CreateChecker();
-#endif
+	// TODO: Remove once we only use built-in SCTP stack.
+	if (!Settings::configuration.useBuiltInSctpStack)
+	{
+		// Create the Checker instance in DepUsrSCTP.
+		DepUsrSCTP::CreateChecker();
+	}
 
 #ifdef MS_LIBURING_SUPPORTED
 	if (DepLibUring::IsEnabled())
@@ -109,10 +110,12 @@ void Worker::Close()
 	// Delete the RTC::Shared singleton.
 	delete this->shared;
 
-#ifndef MS_SCTP_STACK
-	// Close the Checker instance in DepUsrSCTP.
-	DepUsrSCTP::CloseChecker();
-#endif
+	// TODO: Remove once we only use built-in SCTP stack.
+	if (!Settings::configuration.useBuiltInSctpStack)
+	{
+		// Close the Checker instance in DepUsrSCTP.
+		DepUsrSCTP::CloseChecker();
+	}
 
 #ifdef MS_LIBURING_SUPPORTED
 	if (DepLibUring::IsEnabled())

package/worker/src/lib.cpp

@@ -9,9 +9,8 @@
 #include "DepLibUV.hpp"
 #include "DepLibWebRTC.hpp"
 #include "DepOpenSSL.hpp"
-#ifndef MS_SCTP_STACK
+// TODO: Remove once we only use built-in SCTP stack.
 #include "DepUsrSCTP.hpp"
-#endif
 #include "Logger.hpp"
 #include "MediaSoupErrors.hpp"
 #include "Settings.hpp"
@@ -148,9 +147,11 @@ extern "C" int mediasoup_worker_run(
 		// Initialize static stuff.
 		DepOpenSSL::ClassInit();
 		DepLibSRTP::ClassInit();
-#ifndef MS_SCTP_STACK
-		DepUsrSCTP::ClassInit();
-#endif
+		// TODO: Remove once we only use built-in SCTP stack.
+		if (!Settings::configuration.useBuiltInSctpStack)
+		{
+			DepUsrSCTP::ClassInit();
+		}
 #ifdef MS_LIBURING_SUPPORTED
 		DepLibUring::ClassInit();
 #endif
@@ -173,9 +174,11 @@ extern "C" int mediasoup_worker_run(
 		DepLibUring::ClassDestroy();
 #endif
 		RTC::DtlsTransport::ClassDestroy();
-#ifndef MS_SCTP_STACK
-		DepUsrSCTP::ClassDestroy();
-#endif
+		// TODO: Remove once we only use built-in SCTP stack.
+		if (!Settings::configuration.useBuiltInSctpStack)
+		{
+			DepUsrSCTP::ClassDestroy();
+		}
 		DepLibUV::ClassDestroy();
 
 		return 0;

package/worker/tasks.py

@@ -369,7 +369,7 @@ def format(ctx):
         );
 
 
-@task
+@task(pre=[call(setup, meson_args=MESON_ARGS + ' -Dms_build_tests=true'), flatc])
 def tidy(ctx):
     """
     Performs C++ code checks according to `worker/.clang-tidy` rules
@@ -383,7 +383,7 @@ def tidy(ctx):
         );
 
 
-@task
+@task(pre=[call(setup, meson_args=MESON_ARGS + ' -Dms_build_tests=true'), flatc])
 def tidy_fix(ctx):
     """
     Performs C++ code checks according to `worker/.clang-tidy` rules and applies
@@ -496,39 +496,6 @@ def test_asan_undefined(ctx):
         );
 
 
-@task(pre=[call(setup, meson_args=MESON_ARGS + ' -Dms_build_tests=true -Db_sanitize=thread -Db_lundef=false'), flatc])
-def test_asan_thread(ctx):
-    """
-    Run worker test with thread Sanitizer with -fsanitize=thread
-    """
-    with cd_worker():
-        ctx.run(
-            f'"{MESON}" compile -C "{BUILD_DIR}" -j {NUM_CORES} mediasoup-worker-test-asan-thread',
-            echo=True,
-            pty=PTY_SUPPORTED,
-            shell=SHELL
-        );
-    with cd_worker():
-        ctx.run(
-            f'"{MESON}" install -C "{BUILD_DIR}" --no-rebuild --tags mediasoup-worker-test-asan-thread',
-            echo=True,
-            pty=PTY_SUPPORTED,
-            shell=SHELL
-        );
-
-    mediasoup_test_tags = os.getenv('MEDIASOUP_TEST_TAGS') or '';
-
-    with cd_worker():
-        ctx.run(
-            f'"{BUILD_DIR}/mediasoup-worker-test-asan-thread" --invisibles {mediasoup_test_tags}',
-            echo=True,
-            pty=PTY_SUPPORTED,
-            shell=SHELL,
-            # Exit with error if there are issues.
-            env={**os.environ, 'TSAN_OPTIONS': 'halt_on_error=1:print_stacktrace=1'}
-        );
-
-
 @task(pre=[call(setup, meson_args=MESON_ARGS + ' -Db_sanitize=address -Db_lundef=false'), flatc])
 def fuzzer(ctx):
     """

package/worker/test/src/RTC/SCTP/association/TestNegotiatedCapabilities.cpp

@@ -17,10 +17,10 @@ SCENARIO("SCTP Negotiated Capabilities", "[sctp][negotiatedcapabilities]")
 	{
 		RTC::SCTP::SctpOptions sctpOptions{};
 
-		sctpOptions.maxOutboundStreams        = 8192;
-		sctpOptions.maxInboundStreams         = 2048;
-		sctpOptions.enablePartialReliability  = true;
-		sctpOptions.enableMessageInterleaving = true;
+		sctpOptions.announcedMaxOutboundStreams = 8192;
+		sctpOptions.announcedMaxInboundStreams  = 2048;
+		sctpOptions.enablePartialReliability    = true;
+		sctpOptions.enableMessageInterleaving   = true;
 		sctpOptions.zeroChecksumAlternateErrorDetectionMethod =
 		  RTC::SCTP::ZeroChecksumAcceptableParameter::AlternateErrorDetectionMethod::SCTP_OVER_DTLS;
 
@@ -51,8 +51,8 @@ SCENARIO("SCTP Negotiated Capabilities", "[sctp][negotiatedcapabilities]")
 
 		delete remoteChunk;
 
-		REQUIRE(negotiatedCapabilities.maxOutboundStreams == 1024);
-		REQUIRE(negotiatedCapabilities.maxInboundStreams == 2048);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxOutboundStreams == 1024);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxInboundStreams == 2048);
 		REQUIRE(negotiatedCapabilities.partialReliability == true);
 		REQUIRE(negotiatedCapabilities.messageInterleaving == true);
 		REQUIRE(negotiatedCapabilities.reConfig == true);
@@ -63,10 +63,10 @@ SCENARIO("SCTP Negotiated Capabilities", "[sctp][negotiatedcapabilities]")
 	{
 		RTC::SCTP::SctpOptions sctpOptions{};
 
-		sctpOptions.maxOutboundStreams        = 1000;
-		sctpOptions.maxInboundStreams         = 2000;
-		sctpOptions.enablePartialReliability  = true;
-		sctpOptions.enableMessageInterleaving = true;
+		sctpOptions.announcedMaxOutboundStreams = 1000;
+		sctpOptions.announcedMaxInboundStreams  = 2000;
+		sctpOptions.enablePartialReliability    = true;
+		sctpOptions.enableMessageInterleaving   = true;
 		sctpOptions.zeroChecksumAlternateErrorDetectionMethod =
 		  RTC::SCTP::ZeroChecksumAcceptableParameter::AlternateErrorDetectionMethod::SCTP_OVER_DTLS;
 
@@ -96,6 +96,7 @@ SCENARIO("SCTP Negotiated Capabilities", "[sctp][negotiatedcapabilities]")
 		  remoteChunk->BuildParameterInPlace<RTC::SCTP::ZeroChecksumAcceptableParameter>();
 
 		remoteZeroChecksumAcceptableParameter->SetAlternateErrorDetectionMethod(
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  static_cast<RTC::SCTP::ZeroChecksumAcceptableParameter::AlternateErrorDetectionMethod>(666));
 		remoteZeroChecksumAcceptableParameter->Consolidate();
 
@@ -104,8 +105,8 @@ SCENARIO("SCTP Negotiated Capabilities", "[sctp][negotiatedcapabilities]")
 
 		delete remoteChunk;
 
-		REQUIRE(negotiatedCapabilities.maxOutboundStreams == 1000);
-		REQUIRE(negotiatedCapabilities.maxInboundStreams == 2000);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxOutboundStreams == 1000);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxInboundStreams == 2000);
 		REQUIRE(negotiatedCapabilities.partialReliability == true);
 		REQUIRE(negotiatedCapabilities.messageInterleaving == false);
 		REQUIRE(negotiatedCapabilities.reConfig == false);

package/worker/test/src/RTC/SCTP/association/TestStateCookie.cpp

@@ -70,8 +70,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		auto negotiatedCapabilities = stateCookie->GetNegotiatedCapabilities();
 
-		REQUIRE(negotiatedCapabilities.maxOutboundStreams == 15000);
-		REQUIRE(negotiatedCapabilities.maxInboundStreams == 2500);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxOutboundStreams == 15000);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxInboundStreams == 2500);
 		REQUIRE(negotiatedCapabilities.partialReliability == true);
 		REQUIRE(negotiatedCapabilities.messageInterleaving == false);
 		REQUIRE(negotiatedCapabilities.reConfig == true);
@@ -103,8 +103,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		negotiatedCapabilities = stateCookie->GetNegotiatedCapabilities();
 
-		REQUIRE(negotiatedCapabilities.maxOutboundStreams == 15000);
-		REQUIRE(negotiatedCapabilities.maxInboundStreams == 2500);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxOutboundStreams == 15000);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxInboundStreams == 2500);
 		REQUIRE(negotiatedCapabilities.partialReliability == true);
 		REQUIRE(negotiatedCapabilities.messageInterleaving == false);
 		REQUIRE(negotiatedCapabilities.reConfig == true);
@@ -139,8 +139,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		negotiatedCapabilities = clonedStateCookie->GetNegotiatedCapabilities();
 
-		REQUIRE(negotiatedCapabilities.maxOutboundStreams == 15000);
-		REQUIRE(negotiatedCapabilities.maxInboundStreams == 2500);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxOutboundStreams == 15000);
+		REQUIRE(negotiatedCapabilities.negotiatedMaxInboundStreams == 2500);
 		REQUIRE(negotiatedCapabilities.partialReliability == true);
 		REQUIRE(negotiatedCapabilities.messageInterleaving == false);
 		REQUIRE(negotiatedCapabilities.reConfig == true);
@@ -270,8 +270,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 	SECTION("StateCookie::Factory() succeeds")
 	{
-		RTC::SCTP::NegotiatedCapabilities negotiatedCapabilities = { .maxOutboundStreams  = 62000,
-			                                                           .maxInboundStreams   = 55555,
+		RTC::SCTP::NegotiatedCapabilities negotiatedCapabilities = { .negotiatedMaxOutboundStreams = 62000,
+			                                                           .negotiatedMaxInboundStreams = 55555,
 			                                                           .partialReliability  = true,
 			                                                           .messageInterleaving = true,
 			                                                           .reConfig            = true,
@@ -290,8 +290,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		// Change values of the original NegotiatedCapabilities to assert that it
 		// doesn't affect the internals of StateCookie.
-		negotiatedCapabilities.partialReliability = false;
-		negotiatedCapabilities.maxOutboundStreams = 1024;
+		negotiatedCapabilities.partialReliability           = false;
+		negotiatedCapabilities.negotiatedMaxOutboundStreams = 1024;
 
 		REQUIRE(stateCookie);
 		REQUIRE(stateCookie->GetBuffer() == sctpCommon::FactoryBuffer);
@@ -313,8 +313,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		const auto retrievedNegotiatedCapabilities = stateCookie->GetNegotiatedCapabilities();
 
-		REQUIRE(retrievedNegotiatedCapabilities.maxOutboundStreams == 62000);
-		REQUIRE(retrievedNegotiatedCapabilities.maxInboundStreams == 55555);
+		REQUIRE(retrievedNegotiatedCapabilities.negotiatedMaxOutboundStreams == 62000);
+		REQUIRE(retrievedNegotiatedCapabilities.negotiatedMaxInboundStreams == 55555);
 		REQUIRE(retrievedNegotiatedCapabilities.partialReliability == true);
 		REQUIRE(retrievedNegotiatedCapabilities.messageInterleaving == true);
 		REQUIRE(retrievedNegotiatedCapabilities.reConfig == true);
@@ -347,8 +347,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		const auto retrievedParsedNegotiatedCapabilities = parsedStateCookie->GetNegotiatedCapabilities();
 
-		REQUIRE(retrievedParsedNegotiatedCapabilities.maxOutboundStreams == 62000);
-		REQUIRE(retrievedParsedNegotiatedCapabilities.maxInboundStreams == 55555);
+		REQUIRE(retrievedParsedNegotiatedCapabilities.negotiatedMaxOutboundStreams == 62000);
+		REQUIRE(retrievedParsedNegotiatedCapabilities.negotiatedMaxInboundStreams == 55555);
 		REQUIRE(retrievedParsedNegotiatedCapabilities.partialReliability == true);
 		REQUIRE(retrievedParsedNegotiatedCapabilities.messageInterleaving == true);
 		REQUIRE(retrievedParsedNegotiatedCapabilities.reConfig == true);
@@ -359,8 +359,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 	SECTION("StateCookie::Write() succeeds")
 	{
-		RTC::SCTP::NegotiatedCapabilities negotiatedCapabilities = { .maxOutboundStreams  = 62000,
-			                                                           .maxInboundStreams   = 55555,
+		RTC::SCTP::NegotiatedCapabilities negotiatedCapabilities = { .negotiatedMaxOutboundStreams = 62000,
+			                                                           .negotiatedMaxInboundStreams = 55555,
 			                                                           .partialReliability  = true,
 			                                                           .messageInterleaving = true,
 			                                                           .reConfig            = true,
@@ -381,8 +381,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		// Change values of the original NegotiatedCapabilities to assert that it
 		// doesn't affect the internals of StateCookie.
-		negotiatedCapabilities.partialReliability = false;
-		negotiatedCapabilities.maxOutboundStreams = 1024;
+		negotiatedCapabilities.partialReliability           = false;
+		negotiatedCapabilities.negotiatedMaxOutboundStreams = 1024;
 
 		/* Parse the buffer. */
 
@@ -409,8 +409,8 @@ SCENARIO("SCTP State Cookie", "[sctp][statecookie]")
 
 		const auto retrievedNegotiatedCapabilities = stateCookie->GetNegotiatedCapabilities();
 
-		REQUIRE(retrievedNegotiatedCapabilities.maxOutboundStreams == 62000);
-		REQUIRE(retrievedNegotiatedCapabilities.maxInboundStreams == 55555);
+		REQUIRE(retrievedNegotiatedCapabilities.negotiatedMaxOutboundStreams == 62000);
+		REQUIRE(retrievedNegotiatedCapabilities.negotiatedMaxInboundStreams == 55555);
 		REQUIRE(retrievedNegotiatedCapabilities.partialReliability == true);
 		REQUIRE(retrievedNegotiatedCapabilities.messageInterleaving == true);
 		REQUIRE(retrievedNegotiatedCapabilities.reConfig == true);

package/worker/test/src/RTC/SCTP/common/TestUnwrappedSequenceNumber.cpp

@@ -0,0 +1,210 @@
+#include "common.hpp"
+#include "RTC/SCTP/common/UnwrappedSequenceNumber.hpp"
+#include <catch2/catch_test_macros.hpp>
+
+SCENARIO("SCTP UnwrappedSequenceNumber", "[sctp]")
+{
+	using TestSequence = RTC::SCTP::UnwrappedSequenceNumber<uint16_t>;
+
+	SECTION("simple unwrapping")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		TestSequence s0 = unwrapper.Unwrap(0);
+		TestSequence s1 = unwrapper.Unwrap(1);
+		TestSequence s2 = unwrapper.Unwrap(2);
+		TestSequence s3 = unwrapper.Unwrap(3);
+
+		REQUIRE(s0 < s1);
+		REQUIRE(s0 < s2);
+		REQUIRE(s0 < s3);
+		REQUIRE(s1 < s2);
+		REQUIRE(s1 < s3);
+		REQUIRE(s2 < s3);
+
+		REQUIRE(TestSequence::Difference(s1, s0) == 1);
+		REQUIRE(TestSequence::Difference(s2, s0) == 2);
+		REQUIRE(TestSequence::Difference(s3, s0) == 3);
+
+		REQUIRE(s1 > s0);
+		REQUIRE(s2 > s0);
+		REQUIRE(s3 > s0);
+		REQUIRE(s2 > s1);
+		REQUIRE(s3 > s1);
+		REQUIRE(s3 > s2);
+
+		s0.Increment();
+		REQUIRE(s0 == s1);
+
+		s1.Increment();
+		REQUIRE(s1 == s2);
+
+		s2.Increment();
+		REQUIRE(s2 == s3);
+
+		REQUIRE(TestSequence::AddTo(s0, 2) == s3);
+	}
+
+	SECTION("mid value unwrapping")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		TestSequence s0 = unwrapper.Unwrap(0x7FFE);
+		TestSequence s1 = unwrapper.Unwrap(0x7FFF);
+		TestSequence s2 = unwrapper.Unwrap(0x8000);
+		TestSequence s3 = unwrapper.Unwrap(0x8001);
+
+		REQUIRE(s0 < s1);
+		REQUIRE(s0 < s2);
+		REQUIRE(s0 < s3);
+		REQUIRE(s1 < s2);
+		REQUIRE(s1 < s3);
+		REQUIRE(s2 < s3);
+
+		REQUIRE(TestSequence::Difference(s1, s0) == 1);
+		REQUIRE(TestSequence::Difference(s2, s0) == 2);
+		REQUIRE(TestSequence::Difference(s3, s0) == 3);
+
+		REQUIRE(s1 > s0);
+		REQUIRE(s2 > s0);
+		REQUIRE(s3 > s0);
+		REQUIRE(s2 > s1);
+		REQUIRE(s3 > s1);
+		REQUIRE(s3 > s2);
+
+		s0.Increment();
+		REQUIRE(s0 == s1);
+
+		s1.Increment();
+		REQUIRE(s1 == s2);
+
+		s2.Increment();
+		REQUIRE(s2 == s3);
+
+		REQUIRE(TestSequence::AddTo(s0, 2) == s3);
+	}
+
+	SECTION("wrapped unwrapping")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		TestSequence s0 = unwrapper.Unwrap(0xFFFE);
+		TestSequence s1 = unwrapper.Unwrap(0xFFFF);
+		TestSequence s2 = unwrapper.Unwrap(0x0000);
+		TestSequence s3 = unwrapper.Unwrap(0x0001);
+
+		REQUIRE(s0 < s1);
+		REQUIRE(s0 < s2);
+		REQUIRE(s0 < s3);
+		REQUIRE(s1 < s2);
+		REQUIRE(s1 < s3);
+		REQUIRE(s2 < s3);
+
+		REQUIRE(TestSequence::Difference(s1, s0) == 1);
+		REQUIRE(TestSequence::Difference(s2, s0) == 2);
+		REQUIRE(TestSequence::Difference(s3, s0) == 3);
+
+		REQUIRE(s1 > s0);
+		REQUIRE(s2 > s0);
+		REQUIRE(s3 > s0);
+		REQUIRE(s2 > s1);
+		REQUIRE(s3 > s1);
+		REQUIRE(s3 > s2);
+
+		s0.Increment();
+		REQUIRE(s0 == s1);
+
+		s1.Increment();
+		REQUIRE(s1 == s2);
+
+		s2.Increment();
+		REQUIRE(s2 == s3);
+
+		REQUIRE(TestSequence::AddTo(s0, 2) == s3);
+	}
+
+	SECTION("wrap around a few times")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		const TestSequence s0 = unwrapper.Unwrap(0);
+		TestSequence prev     = s0;
+
+		for (uint32_t i{ 1 }; i < 65536 * 3; ++i)
+		{
+			const auto wrapped    = static_cast<uint16_t>(i);
+			const TestSequence si = unwrapper.Unwrap(wrapped);
+
+			REQUIRE(s0 < si);
+			REQUIRE(prev < si);
+
+			prev = si;
+		}
+	}
+
+	SECTION("increment is same as wrapped")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		TestSequence s0   = unwrapper.Unwrap(0);
+		TestSequence prev = s0;
+
+		for (uint32_t i{ 1 }; i < 65536 * 2; ++i)
+		{
+			const auto wrapped    = static_cast<uint16_t>(i);
+			const TestSequence si = unwrapper.Unwrap(wrapped);
+
+			s0.Increment();
+			REQUIRE(s0 == si);
+
+			prev = si;
+		}
+	}
+
+	SECTION("unwrapping larger number is always larger")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		for (uint32_t i{ 1 }; i < 65536 * 2; ++i)
+		{
+			const auto wrapped    = static_cast<uint16_t>(i);
+			const TestSequence si = unwrapper.Unwrap(wrapped);
+
+			REQUIRE(unwrapper.Unwrap(wrapped + 1) > si);
+			REQUIRE(unwrapper.Unwrap(wrapped + 5) > si);
+			REQUIRE(unwrapper.Unwrap(wrapped + 10) > si);
+			REQUIRE(unwrapper.Unwrap(wrapped + 100) > si);
+		}
+	}
+
+	SECTION("unwrapping smaller number is always smaller")
+	{
+		TestSequence::Unwrapper unwrapper;
+
+		for (uint32_t i{ 1 }; i < 65536 * 2; ++i)
+		{
+			const auto wrapped    = static_cast<uint16_t>(i);
+			const TestSequence si = unwrapper.Unwrap(wrapped);
+
+			REQUIRE(unwrapper.Unwrap(wrapped - 1) < si);
+			REQUIRE(unwrapper.Unwrap(wrapped - 5) < si);
+			REQUIRE(unwrapper.Unwrap(wrapped - 10) < si);
+			REQUIRE(unwrapper.Unwrap(wrapped - 100) < si);
+		}
+	}
+
+	SECTION("difference is absolute")
+	{
+		TestSequence::Unwrapper unwrapper;
+		const TestSequence thisValue  = unwrapper.Unwrap(10);
+		const TestSequence otherValue = TestSequence::AddTo(thisValue, 100);
+
+		REQUIRE(TestSequence::Difference(thisValue, otherValue) == 100);
+		REQUIRE(TestSequence::Difference(otherValue, thisValue) == 100);
+
+		const TestSequence minusValue = TestSequence::AddTo(thisValue, -100);
+
+		REQUIRE(TestSequence::Difference(thisValue, minusValue) == 100);
+		REQUIRE(TestSequence::Difference(minusValue, thisValue) == 100);
+	}
+}

package/worker/test/src/RTC/SCTP/packet/chunks/TestAbortAssociationChunk.cpp

@@ -47,7 +47,7 @@ SCENARIO("SCTP Abort Association Chunk (6)", "[serializable][sctp][chunk]")
 
 		REQUIRE(chunk->GetT() == true);
 
-		auto* errorCause1 =
+		const auto* errorCause1 =
 		  reinterpret_cast<const RTC::SCTP::StaleCookieErrorCause*>(chunk->GetErrorCauseAt(0));
 
 		CHECK_SCTP_ERROR_CAUSE(
@@ -268,7 +268,7 @@ SCENARIO("SCTP Abort Association Chunk (6)", "[serializable][sctp][chunk]")
 
 		REQUIRE(chunk->GetT() == true);
 
-		auto* obtainedErrorCause1 =
+		const auto* obtainedErrorCause1 =
 		  reinterpret_cast<const RTC::SCTP::StaleCookieErrorCause*>(chunk->GetErrorCauseAt(0));
 
 		CHECK_SCTP_ERROR_CAUSE(

package/worker/test/src/RTC/SCTP/packet/chunks/TestHeartbeatAckChunk.cpp

@@ -53,7 +53,7 @@ SCENARIO("SCTP Hearbeat Acknowledgement Chunk (5)", "[serializable][sctp][chunk]
 		  /*canHaveErrorCauses*/ false,
 		  /*errorCausesCount*/ 0);
 
-		auto* parameter1 =
+		const auto* parameter1 =
 		  reinterpret_cast<const RTC::SCTP::HeartbeatInfoParameter*>(chunk->GetParameterAt(0));
 
 		CHECK_SCTP_PARAMETER(
@@ -77,13 +77,15 @@ SCENARIO("SCTP Hearbeat Acknowledgement Chunk (5)", "[serializable][sctp][chunk]
 		// This should be padding.
 		REQUIRE(parameter1->GetInfo()[7] == 0x00);
 
-		auto* parameter2 = reinterpret_cast<const RTC::SCTP::UnknownParameter*>(chunk->GetParameterAt(1));
+		const auto* parameter2 =
+		  reinterpret_cast<const RTC::SCTP::UnknownParameter*>(chunk->GetParameterAt(1));
 
 		CHECK_SCTP_PARAMETER(
 		  /*parameter*/ parameter2,
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -144,6 +146,7 @@ SCENARIO("SCTP Hearbeat Acknowledgement Chunk (5)", "[serializable][sctp][chunk]
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -156,7 +159,7 @@ SCENARIO("SCTP Hearbeat Acknowledgement Chunk (5)", "[serializable][sctp][chunk]
 
 		/* Clone it. */
 
-		auto* clonedChunk = chunk->Clone(sctpCommon::CloneBuffer, sizeof(sctpCommon::CloneBuffer));
+		const auto* clonedChunk = chunk->Clone(sctpCommon::CloneBuffer, sizeof(sctpCommon::CloneBuffer));
 
 		std::memset(sctpCommon::SerializeBuffer, 0x00, sizeof(sctpCommon::SerializeBuffer));
 
@@ -207,6 +210,7 @@ SCENARIO("SCTP Hearbeat Acknowledgement Chunk (5)", "[serializable][sctp][chunk]
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -314,7 +318,8 @@ SCENARIO("SCTP Hearbeat Acknowledgement Chunk (5)", "[serializable][sctp][chunk]
 
 		/* Parse itself and compare. */
 
-		auto* parsedChunk = RTC::SCTP::HeartbeatAckChunk::Parse(chunk->GetBuffer(), chunk->GetLength());
+		const auto* parsedChunk =
+		  RTC::SCTP::HeartbeatAckChunk::Parse(chunk->GetBuffer(), chunk->GetLength());
 
 		delete chunk;
 

package/worker/test/src/RTC/SCTP/packet/chunks/TestHeartbeatRequestChunk.cpp

@@ -86,6 +86,7 @@ SCENARIO("SCTP Hearbeat Request Chunk (4)", "[serializable][sctp][chunk]")
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -148,6 +149,7 @@ SCENARIO("SCTP Hearbeat Request Chunk (4)", "[serializable][sctp][chunk]")
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -213,6 +215,7 @@ SCENARIO("SCTP Hearbeat Request Chunk (4)", "[serializable][sctp][chunk]")
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -309,6 +312,7 @@ SCENARIO("SCTP Hearbeat Request Chunk (4)", "[serializable][sctp][chunk]")
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);
@@ -374,6 +378,7 @@ SCENARIO("SCTP Hearbeat Request Chunk (4)", "[serializable][sctp][chunk]")
 		  /*buffer*/ nullptr,
 		  /*bufferLength*/ 8,
 		  /*length*/ 8,
+		  // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
 		  /*parameterType*/ static_cast<RTC::SCTP::Parameter::ParameterType>(49159),
 		  /*unknownType*/ true,
 		  /*actionForUnknownParameterType*/ RTC::SCTP::Parameter::ActionForUnknownParameterType::SKIP_AND_REPORT);