mediasoup 3.11.20 → 3.11.21

package/node/lib/Worker.js

@@ -90,7 +90,7 @@ class Worker extends EnhancedEventEmitter_1.EnhancedEventEmitter {
         // options
         {
             env: {
-                MEDIASOUP_VERSION: '3.11.20',
+                MEDIASOUP_VERSION: '3.11.21',
                 // Let the worker process inherit all environment variables, useful
                 // if a custom and not in the path GCC is used so the user can set
                 // LD_LIBRARY_PATH environment variable for runtime.

package/node/lib/index.d.ts

@@ -10,7 +10,7 @@ export { types };
 /**
  * Expose mediasoup version.
  */
-export declare const version = "3.11.20";
+export declare const version = "3.11.21";
 /**
  * Expose parseScalabilityMode() function.
  */

package/node/lib/index.js

@@ -11,7 +11,7 @@ exports.types = types;
 /**
  * Expose mediasoup version.
  */
-exports.version = '3.11.20';
+exports.version = '3.11.21';
 /**
  * Expose parseScalabilityMode() function.
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mediasoup",
-  "version": "3.11.20",
+  "version": "3.11.21",
   "description": "Cutting Edge WebRTC Video Conferencing",
   "contributors": [
     "Iñaki Baz Castillo <ibc@aliax.net> (https://inakibaz.me)",
@@ -95,15 +95,15 @@
     "@types/jest": "^29.5.0",
     "@types/node": "^18.15.11",
     "@types/uuid": "^9.0.1",
-    "@typescript-eslint/eslint-plugin": "^5.57.0",
-    "@typescript-eslint/parser": "^5.57.0",
+    "@typescript-eslint/eslint-plugin": "^5.57.1",
+    "@typescript-eslint/parser": "^5.57.1",
     "eslint": "^8.37.0",
     "eslint-plugin-jest": "^27.2.1",
     "jest": "^29.5.0",
     "open-cli": "^7.2.0",
     "pick-port": "^1.0.1",
     "sctp": "^1.0.0",
-    "ts-jest": "^29.0.5",
+    "ts-jest": "^29.1.0",
     "tsc-watch": "^6.0.0",
     "typescript": "^5.0.3"
   }

package/worker/include/RTC/RTCP/FeedbackRtpTransport.hpp

@@ -213,7 +213,8 @@ namespace RTC
 
 		public:
 			AddPacketResult AddPacket(uint16_t sequenceNumber, uint64_t timestamp, size_t maxRtcpPacketLen);
-			void Finish(); // Just for locally generated packets.
+			// Just for locally generated packets.
+			void Finish();
 			bool IsFull()
 			{
 				// NOTE: Since AddPendingChunks() is called at the end, we cannot track
@@ -315,13 +316,16 @@ namespace RTC
 		private:
 			uint16_t baseSequenceNumber{ 0u };
 			uint32_t referenceTime{ 0 };
-			uint16_t latestSequenceNumber{ 0u }; // Just for locally generated packets.
-			uint64_t latestTimestamp{ 0u };      // Just for locally generated packets.
+			// Just for locally generated packets.
+			uint16_t latestSequenceNumber{ 0u };
+			// Just for locally generated packets.
+			uint64_t latestTimestamp{ 0u };
 			uint16_t packetStatusCount{ 0u };
 			uint8_t feedbackPacketCount{ 0u };
 			std::vector<Chunk*> chunks;
 			std::vector<int16_t> deltas;
-			Context context; // Just for locally generated packets.
+			// Just for locally generated packets.
+			Context context;
 			size_t deltasAndChunksSize{ 0u };
 			size_t size{ 0 };
 			bool isCorrect{ true };

package/worker/src/RTC/RTCP/FeedbackRtpTransport.cpp

@@ -48,7 +48,9 @@ namespace RTC
 			  new FeedbackRtpTransportPacket(commonHeader, len));
 
 			if (!packet->IsCorrect())
+			{
 				return nullptr;
+			}
 
 			return packet.release();
 		}
@@ -399,7 +401,9 @@ namespace RTC
 				auto& packetResult = packetResults[idx];
 
 				if (!packetResult.received)
+				{
 					continue;
+				}
 
 				currentReceivedAtMs += this->deltas.at(deltaIdx) / 4;
 				packetResult.delta        = this->deltas.at(deltaIdx);
@@ -418,7 +422,9 @@ namespace RTC
 			uint16_t lost{ 0u };
 
 			if (expected == 0u)
+			{
 				return 0u;
+			}
 
 			for (auto* chunk : this->chunks)
 			{
@@ -428,7 +434,9 @@ namespace RTC
 			// NOTE: If lost equals expected, the math below would produce 256, which
 			// becomes 0 in uint8_t.
 			if (lost == expected)
+			{
 				return 255u;
+			}
 
 			return (lost << 8) / expected;
 		}
@@ -487,9 +495,13 @@ namespace RTC
 			Status status;
 
 			if (delta >= 0 && delta <= 255)
+			{
 				status = Status::SmallDelta;
+			}
 			else
+			{
 				status = Status::LargeDelta;
+			}
 
 			// Create a long run chunk before processing this packet, if needed.
 			// clang-format off
@@ -576,7 +588,9 @@ namespace RTC
 		{
 			// No pending status packets.
 			if (this->context.statuses.empty())
+			{
 				return;
+			}
 
 			if (this->context.allSameStatus)
 			{
@@ -638,9 +652,13 @@ namespace RTC
 				uint8_t symbolSize = data[0] & 0x40;
 
 				if (symbolSize == 0)
+				{
 					return new OneBitVectorChunk(bytes, count);
+				}
 				else
+				{
 					return new TwoBitVectorChunk(bytes, count);
+				}
 			}
 
 			return nullptr;
@@ -717,9 +735,13 @@ namespace RTC
 			MS_TRACE();
 
 			if (this->status == Status::SmallDelta || this->status == Status::LargeDelta)
+			{
 				return this->count;
+			}
 			else
+			{
 				return 0u;
+			}
 		}
 
 		void FeedbackRtpTransportPacket::RunLengthChunk::FillResults(
@@ -837,7 +859,9 @@ namespace RTC
 			for (auto status : this->statuses)
 			{
 				if (status == Status::SmallDelta || status == Status::LargeDelta)
+				{
 					count++;
+				}
 			}
 
 			return count;
@@ -975,7 +999,9 @@ namespace RTC
 			for (auto status : this->statuses)
 			{
 				if (status == Status::SmallDelta || status == Status::LargeDelta)
+				{
 					count++;
+				}
 			}
 
 			return count;

package/worker/src/RTC/TransportCongestionControlClient.cpp

@@ -215,14 +215,21 @@ namespace RTC
 		MS_TRACE();
 
 		// Update packet loss history.
-		const size_t expected_packets = feedback->GetPacketStatusCount();
-		size_t lost_packets           = 0;
+		const size_t expectedPackets = feedback->GetPacketStatusCount();
+		size_t lostPackets           = 0;
+
 		for (const auto& result : feedback->GetPacketResults())
 		{
 			if (!result.received)
-				lost_packets += 1;
+			{
+				lostPackets += 1;
+			}
+		}
+
+		if (expectedPackets > 0)
+		{
+			this->UpdatePacketLoss(static_cast<double>(lostPackets) / expectedPackets);
 		}
-		this->UpdatePacketLoss(static_cast<double>(lost_packets) / expected_packets);
 
 		if (this->rtpTransportControllerSend == nullptr)
 		{
@@ -236,7 +243,9 @@ namespace RTC
 	{
 		// Add the score into the histogram.
 		if (this->packetLossHistory.size() == PacketLossHistogramLength)
+		{
 			this->packetLossHistory.pop_front();
+		}
 
 		this->packetLossHistory.push_back(packetLoss);
 
@@ -303,9 +312,13 @@ namespace RTC
 		// Manage it via trending and increase it a bit to avoid immediate oscillations.
 #ifdef USE_TREND_CALCULATOR
 		if (!force)
+		{
 			this->desiredBitrateTrend.Update(desiredBitrate, nowMs);
+		}
 		else
+		{
 			this->desiredBitrateTrend.ForceUpdate(desiredBitrate, nowMs);
+		}
 #endif
 
 		this->bitrates.desiredBitrate = desiredBitrate;
@@ -512,9 +525,13 @@ namespace RTC
 		// Update availableBitrate.
 		// NOTE: Just in case.
 		if (targetTransferRate.target_rate.bps() > std::numeric_limits<uint32_t>::max())
+		{
 			this->bitrates.availableBitrate = std::numeric_limits<uint32_t>::max();
+		}
 		else
+		{
 			this->bitrates.availableBitrate = static_cast<uint32_t>(targetTransferRate.target_rate.bps());
+		}
 
 		MS_DEBUG_DEV("new available bitrate:%" PRIu32, this->bitrates.availableBitrate);
 

package/worker/src/RTC/TransportCongestionControlServer.cpp

@@ -120,7 +120,9 @@ namespace RTC
 				uint16_t wideSeqNumber;
 
 				if (!packet->ReadTransportWideCc01(wideSeqNumber))
+				{
 					break;
+				}
 
 				// Update the RTCP media SSRC of the ongoing Transport-CC Feedback packet.
 				this->transportCcFeedbackSenderSsrc = 0u;
@@ -186,7 +188,9 @@ namespace RTC
 				uint32_t absSendTime;
 
 				if (!packet->ReadAbsSendTime(absSendTime))
+				{
 					break;
+				}
 
 				// NOTE: nowMs is uint64_t but we need to "convert" it to int64_t before
 				// we give it to libwebrtc lib (althought this is implicit in the
@@ -221,8 +225,12 @@ namespace RTC
 	{
 		MS_TRACE();
 
+		this->transportCcFeedbackPacket->Finish();
+
 		if (!this->transportCcFeedbackPacket->IsSerializable())
+		{
 			return;
+		}
 
 		auto latestWideSeqNumber = this->transportCcFeedbackPacket->GetLatestSequenceNumber();
 		auto latestTimestamp     = this->transportCcFeedbackPacket->GetLatestTimestamp();
@@ -232,15 +240,21 @@ namespace RTC
 		  this, this->transportCcFeedbackPacket.get());
 
 		// Update packet loss history.
-		const size_t expected_packets = this->transportCcFeedbackPacket->GetPacketStatusCount();
-		size_t lost_packets           = 0;
+		const size_t expectedPackets = this->transportCcFeedbackPacket->GetPacketStatusCount();
+		size_t lostPackets           = 0;
+
 		for (const auto& result : this->transportCcFeedbackPacket->GetPacketResults())
 		{
 			if (!result.received)
-				lost_packets += 1;
+			{
+				lostPackets += 1;
+			}
 		}
 
-		this->UpdatePacketLoss(static_cast<double>(lost_packets) / expected_packets);
+		if (expectedPackets > 0)
+		{
+			this->UpdatePacketLoss(static_cast<double>(lostPackets) / expectedPackets);
+		}
 
 		// Create a new feedback packet.
 		this->transportCcFeedbackPacket.reset(new RTC::RTCP::FeedbackRtpTransportPacket(
@@ -265,7 +279,9 @@ namespace RTC
 
 		// May fix unlimitedRembCounter.
 		if (this->unlimitedRembCounter > 0u && this->maxIncomingBitrate != 0u)
+		{
 			this->unlimitedRembCounter = 0u;
+		}
 
 		// In case this is the first unlimited REMB packet, send it fast.
 		// clang-format off
@@ -295,7 +311,9 @@ namespace RTC
 			this->limitationRembSentAtMs = nowMs;
 
 			if (this->unlimitedRembCounter > 0u)
+			{
 				this->unlimitedRembCounter--;
+			}
 		}
 	}
 
@@ -303,7 +321,9 @@ namespace RTC
 	{
 		// Add the score into the histogram.
 		if (this->packetLossHistory.size() == PacketLossHistogramLength)
+		{
 			this->packetLossHistory.pop_front();
+		}
 
 		this->packetLossHistory.push_back(packetLoss);
 
@@ -334,7 +354,9 @@ namespace RTC
 
 		// Limit announced bitrate if requested via API.
 		if (this->maxIncomingBitrate != 0u)
+		{
 			availableBitrate = std::min(availableBitrate, this->maxIncomingBitrate);
+		}
 
 #if MS_LOG_DEV_LEVEL == 3
 		std::ostringstream ssrcsStream;
@@ -366,6 +388,8 @@ namespace RTC
 		MS_TRACE();
 
 		if (timer == this->transportCcFeedbackSendPeriodicTimer)
+		{
 			SendTransportCcFeedback();
+		}
 	}
 } // namespace RTC