mediasoup 3.11.2 → 3.11.3

package/node/lib/Worker.js

@@ -81,7 +81,7 @@ class Worker extends EnhancedEventEmitter_1.EnhancedEventEmitter {
         // options
         {
             env: {
-                MEDIASOUP_VERSION: '3.11.2',
+                MEDIASOUP_VERSION: '3.11.3',
                 // Let the worker process inherit all environment variables, useful
                 // if a custom and not in the path GCC is used so the user can set
                 // LD_LIBRARY_PATH environment variable for runtime.

package/node/lib/index.d.ts

@@ -9,7 +9,7 @@ export { types };
 /**
  * Expose mediasoup version.
  */
-export declare const version = "3.11.2";
+export declare const version = "3.11.3";
 /**
  * Expose parseScalabilityMode() function.
  */

package/node/lib/index.js

@@ -11,7 +11,7 @@ exports.types = types;
 /**
  * Expose mediasoup version.
  */
-exports.version = '3.11.2';
+exports.version = '3.11.3';
 /**
  * Expose parseScalabilityMode() function.
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mediasoup",
-  "version": "3.11.2",
+  "version": "3.11.3",
   "description": "Cutting Edge WebRTC Video Conferencing",
   "contributors": [
     "Iñaki Baz Castillo <ibc@aliax.net> (https://inakibaz.me)",

package/worker/Makefile

@@ -32,10 +32,10 @@ MESON_ARGS ?= ""
 # Workaround for NixOS and Guix that don't work with pre-built binaries, see:
 # https://github.com/NixOS/nixpkgs/issues/142383.
 PIP_BUILD_BINARIES = $(shell [ -f /etc/NIXOS -o -d /etc/guix ] && echo "--no-binary :all:")
-# Let's use a specific version of ninja to avoid version 1.11.1 due to a bug in
-# Meson:
+# Let's use a specific version of ninja to avoid buggy version 1.11.1:
 # https://mediasoup.discourse.group/t/partly-solved-could-not-detect-ninja-v1-8-2-or-newer/
 # https://github.com/ninja-build/ninja/issues/2211
+# https://github.com/ninja-build/ninja/issues/2212
 NINJA_VERSION ?= 1.10.2.4
 
 # Disable `*.pyc` files creation.

package/worker/src/ChannelMessageHandlers.cpp

@@ -63,51 +63,56 @@ void ChannelMessageHandlers::RegisterHandler(
 {
 	MS_TRACE();
 
-	try
+	if (channelRequestHandler != nullptr)
 	{
-		if (channelRequestHandler != nullptr)
+		if (
+		  ChannelMessageHandlers::mapChannelRequestHandlers.find(id) !=
+		  ChannelMessageHandlers::mapChannelRequestHandlers.end())
 		{
-			if (
-			  ChannelMessageHandlers::mapChannelRequestHandlers.find(id) !=
-			  ChannelMessageHandlers::mapChannelRequestHandlers.end())
-			{
-				MS_THROW_ERROR("Channel request handler with ID %s already exists", id.c_str());
-			}
-
-			ChannelMessageHandlers::mapChannelRequestHandlers[id] = channelRequestHandler;
+			MS_THROW_ERROR("Channel request handler with ID %s already exists", id.c_str());
 		}
 
-		if (payloadChannelRequestHandler != nullptr)
+		ChannelMessageHandlers::mapChannelRequestHandlers[id] = channelRequestHandler;
+	}
+
+	if (payloadChannelRequestHandler != nullptr)
+	{
+		if (
+		  ChannelMessageHandlers::mapPayloadChannelRequestHandlers.find(id) !=
+		  ChannelMessageHandlers::mapPayloadChannelRequestHandlers.end())
 		{
-			if (
-			  ChannelMessageHandlers::mapPayloadChannelRequestHandlers.find(id) !=
-			  ChannelMessageHandlers::mapPayloadChannelRequestHandlers.end())
+			if (channelRequestHandler != nullptr)
 			{
-				MS_THROW_ERROR("PayloadChannel request handler with ID %s already exists", id.c_str());
+				ChannelMessageHandlers::mapChannelRequestHandlers.erase(id);
 			}
 
-			ChannelMessageHandlers::mapPayloadChannelRequestHandlers[id] = payloadChannelRequestHandler;
+			MS_THROW_ERROR("PayloadChannel request handler with ID %s already exists", id.c_str());
 		}
 
-		if (payloadChannelNotificationHandler != nullptr)
+		ChannelMessageHandlers::mapPayloadChannelRequestHandlers[id] = payloadChannelRequestHandler;
+	}
+
+	if (payloadChannelNotificationHandler != nullptr)
+	{
+		if (
+		  ChannelMessageHandlers::mapPayloadChannelNotificationHandlers.find(id) !=
+		  ChannelMessageHandlers::mapPayloadChannelNotificationHandlers.end())
 		{
-			if (
-			  ChannelMessageHandlers::mapPayloadChannelNotificationHandlers.find(id) !=
-			  ChannelMessageHandlers::mapPayloadChannelNotificationHandlers.end())
+			if (channelRequestHandler != nullptr)
 			{
-				MS_THROW_ERROR("PayloadChannel notification handler with ID %s already exists", id.c_str());
+				ChannelMessageHandlers::mapChannelRequestHandlers.erase(id);
 			}
 
-			ChannelMessageHandlers::mapPayloadChannelNotificationHandlers[id] =
-			  payloadChannelNotificationHandler;
+			if (payloadChannelRequestHandler != nullptr)
+			{
+				ChannelMessageHandlers::mapPayloadChannelRequestHandlers.erase(id);
+			}
+
+			MS_THROW_ERROR("PayloadChannel notification handler with ID %s already exists", id.c_str());
 		}
-	}
-	catch (const MediaSoupError& error)
-	{
-		// In case of error unregister everything.
-		ChannelMessageHandlers::UnregisterHandler(id);
 
-		throw;
+		ChannelMessageHandlers::mapPayloadChannelNotificationHandlers[id] =
+		  payloadChannelNotificationHandler;
 	}
 }
 

package/worker/src/RTC/RTCP/FeedbackRtpTransport.cpp

@@ -455,7 +455,7 @@ namespace RTC
 				size_t representedPackets{ 0u };
 
 				// Fill statuses vector.
-				for (uint8_t i{ 0u }; i < missingPackets && this->context.statuses.size() < 7; ++i)
+				for (uint16_t i{ 0u }; i < missingPackets && this->context.statuses.size() < 7; ++i)
 				{
 					this->context.statuses.emplace_back(Status::NotReceived);
 					representedPackets++;

package/worker/src/RTC/RtpStreamRecv.cpp

@@ -89,7 +89,7 @@ namespace RTC
 		// Iterate all temporal layers of spatial layers previous to the given one.
 		for (uint8_t sIdx{ 0u }; sIdx < spatialLayer; ++sIdx)
 		{
-			for (uint8_t tIdx{ 0u }; tIdx < this->spatialLayerCounters[sIdx].size(); ++tIdx)
+			for (size_t tIdx{ 0u }; tIdx < this->spatialLayerCounters[sIdx].size(); ++tIdx)
 			{
 				auto& temporalLayerCounter = this->spatialLayerCounters[sIdx][tIdx];
 
@@ -118,7 +118,7 @@ namespace RTC
 
 		// clang-format off
 		for (
-			uint8_t tIdx{ 0u };
+			size_t tIdx{ 0u };
 			tIdx < this->spatialLayerCounters[spatialLayer].size();
 			++tIdx
 		)