mediasoup 3.10.7 → 3.10.8

package/node/lib/WebRtcServer.d.ts

@@ -19,7 +19,7 @@ export interface WebRtcServerListenInfo {
     /**
      * Listening port.
      */
-    port: number;
+    port?: number;
 }
 export declare type WebRtcServerOptions = {
     /**

package/node/lib/WebRtcServer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"WebRtcServer.d.ts","sourceRoot":"","sources":["../src/WebRtcServer.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,oBAAoB,EAAE,MAAM,wBAAwB,CAAC;AAC9D,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AACpC,OAAO,EAAE,iBAAiB,EAAE,MAAM,aAAa,CAAC;AAChD,OAAO,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC;AAEpD,MAAM,WAAW,sBAAsB;IAEtC;;OAEG;IACH,QAAQ,EAAE,iBAAiB,CAAC;IAE5B;;OAEG;IACH,EAAE,EAAE,MAAM,CAAC;IAEX;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,IAAI,EAAE,MAAM,CAAC;CACb;AAED,oBAAY,mBAAmB,GAC/B;IACC;;OAEG;IACH,WAAW,EAAE,sBAAsB,EAAE,CAAC;IAEtC;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CAClC,CAAC;AAEF,oBAAY,kBAAkB,GAC9B;IACC,WAAW,EAAE,EAAE,CAAC;IAEhB,QAAQ,EAAE,EAAE,CAAC;CACb,CAAC;AAEF,oBAAY,0BAA0B,GACtC;IACC,KAAK,EAAE,EAAE,CAAC;IACV,sBAAsB,EAAE,CAAC,eAAe,CAAC,CAAC;IAC1C,wBAAwB,EAAE,CAAC,eAAe,CAAC,CAAC;CAC5C,CAAC;AAEF,aAAK,oBAAoB,GACzB;IACC,cAAc,EAAE,MAAM,CAAC;CACvB,CAAC;AAIF,qBAAa,YAAa,SAAQ,oBAAoB,CAAC,kBAAkB,CAAC;;IAoBzE;;OAEG;gBAEF,EACC,QAAQ,EACR,OAAO,EACP,OAAO,EACP,EACD;QACC,QAAQ,EAAE,oBAAoB,CAAC;QAC/B,OAAO,EAAE,OAAO,CAAC;QACjB,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;KAClC;IAYF;;OAEG;IACH,IAAI,EAAE,IAAI,MAAM,CAGf;IAED;;OAEG;IACH,IAAI,MAAM,IAAI,OAAO,CAGpB;IAED;;OAEG;IACH,IAAI,OAAO,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAGrC;IAED;;OAEG;IACH,IAAI,OAAO,CAAC,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAG3C;IAED;;OAEG;IACH,IAAI,QAAQ,IAAI,oBAAoB,CAAC,0BAA0B,CAAC,CAG/D;IAED;;;OAGG;IACH,IAAI,0BAA0B,IAAI,GAAG,CAAC,MAAM,EAAE,eAAe,CAAC,CAG7D;IAED;;OAEG;IACH,KAAK,IAAI,IAAI;IA8Bb;;;;OAIG;IACH,YAAY,IAAI,IAAI;IAmBpB;;OAEG;IACG,IAAI,IAAI,OAAO,CAAC,GAAG,CAAC;IAO1B;;OAEG;IACH,qBAAqB,CAAC,eAAe,EAAE,eAAe,GAAG,IAAI;CAe7D"}
+{"version":3,"file":"WebRtcServer.d.ts","sourceRoot":"","sources":["../src/WebRtcServer.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,oBAAoB,EAAE,MAAM,wBAAwB,CAAC;AAC9D,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AACpC,OAAO,EAAE,iBAAiB,EAAE,MAAM,aAAa,CAAC;AAChD,OAAO,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC;AAEpD,MAAM,WAAW,sBAAsB;IAEtC;;OAEG;IACH,QAAQ,EAAE,iBAAiB,CAAC;IAE5B;;OAEG;IACH,EAAE,EAAE,MAAM,CAAC;IAEX;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,IAAI,CAAC,EAAE,MAAM,CAAC;CACd;AAED,oBAAY,mBAAmB,GAC/B;IACC;;OAEG;IACH,WAAW,EAAE,sBAAsB,EAAE,CAAC;IAEtC;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CAClC,CAAC;AAEF,oBAAY,kBAAkB,GAC9B;IACC,WAAW,EAAE,EAAE,CAAC;IAEhB,QAAQ,EAAE,EAAE,CAAC;CACb,CAAC;AAEF,oBAAY,0BAA0B,GACtC;IACC,KAAK,EAAE,EAAE,CAAC;IACV,sBAAsB,EAAE,CAAC,eAAe,CAAC,CAAC;IAC1C,wBAAwB,EAAE,CAAC,eAAe,CAAC,CAAC;CAC5C,CAAC;AAEF,aAAK,oBAAoB,GACzB;IACC,cAAc,EAAE,MAAM,CAAC;CACvB,CAAC;AAIF,qBAAa,YAAa,SAAQ,oBAAoB,CAAC,kBAAkB,CAAC;;IAoBzE;;OAEG;gBAEF,EACC,QAAQ,EACR,OAAO,EACP,OAAO,EACP,EACD;QACC,QAAQ,EAAE,oBAAoB,CAAC;QAC/B,OAAO,EAAE,OAAO,CAAC;QACjB,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;KAClC;IAYF;;OAEG;IACH,IAAI,EAAE,IAAI,MAAM,CAGf;IAED;;OAEG;IACH,IAAI,MAAM,IAAI,OAAO,CAGpB;IAED;;OAEG;IACH,IAAI,OAAO,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAGrC;IAED;;OAEG;IACH,IAAI,OAAO,CAAC,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAG3C;IAED;;OAEG;IACH,IAAI,QAAQ,IAAI,oBAAoB,CAAC,0BAA0B,CAAC,CAG/D;IAED;;;OAGG;IACH,IAAI,0BAA0B,IAAI,GAAG,CAAC,MAAM,EAAE,eAAe,CAAC,CAG7D;IAED;;OAEG;IACH,KAAK,IAAI,IAAI;IA8Bb;;;;OAIG;IACH,YAAY,IAAI,IAAI;IAmBpB;;OAEG;IACG,IAAI,IAAI,OAAO,CAAC,GAAG,CAAC;IAO1B;;OAEG;IACH,qBAAqB,CAAC,eAAe,EAAE,eAAe,GAAG,IAAI;CAe7D"}

package/node/lib/Worker.js

@@ -81,7 +81,7 @@ class Worker extends EnhancedEventEmitter_1.EnhancedEventEmitter {
         // options
         {
             env: {
-                MEDIASOUP_VERSION: '3.10.7',
+                MEDIASOUP_VERSION: '3.10.8',
                 // Let the worker process inherit all environment variables, useful
                 // if a custom and not in the path GCC is used so the user can set
                 // LD_LIBRARY_PATH environment variable for runtime.

package/node/lib/index.d.ts

@@ -9,7 +9,7 @@ export { types };
 /**
  * Expose mediasoup version.
  */
-export declare const version = "3.10.7";
+export declare const version = "3.10.8";
 /**
  * Expose parseScalabilityMode() function.
  */

package/node/lib/index.js

@@ -11,7 +11,7 @@ exports.types = types;
 /**
  * Expose mediasoup version.
  */
-exports.version = '3.10.7';
+exports.version = '3.10.8';
 /**
  * Expose parseScalabilityMode() function.
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mediasoup",
-  "version": "3.10.7",
+  "version": "3.10.8",
   "description": "Cutting Edge WebRTC Video Conferencing",
   "contributors": [
     "Iñaki Baz Castillo <ibc@aliax.net> (https://inakibaz.me)",
@@ -88,6 +88,6 @@
     "pick-port": "^1.0.1",
     "sctp": "^1.0.0",
     "tsc-watch": "^5.0.3",
-    "typescript": "^4.8.3"
+    "typescript": "^4.8.4"
   }
 }

package/worker/fuzzer/src/RTC/FuzzerRtpStreamSend.cpp

@@ -43,7 +43,7 @@ void Fuzzer::RTC::RtpStreamSend::Fuzz(const uint8_t* data, size_t len)
 	packet->SetSsrc(params.ssrc);
 
 	std::string mid;
-	::RTC::RtpStreamSend* stream = new ::RTC::RtpStreamSend(&testRtpStreamListener, params, mid);
+	auto* stream = new ::RTC::RtpStreamSend(&testRtpStreamListener, params, mid);
 
 	while (len >= 4u)
 	{

package/worker/include/RTC/Consumer.hpp

@@ -187,7 +187,9 @@ namespace RTC
 		struct RTC::RtpHeaderExtensionIds rtpHeaderExtensionIds;
 		const std::vector<uint8_t>* producerRtpStreamScores{ nullptr };
 		// Others.
-		absl::flat_hash_set<uint8_t> supportedCodecPayloadTypes;
+		// Whether a payload type is supported or not is represented in the
+		// corresponding position of the bitset.
+		std::bitset<128u> supportedCodecPayloadTypes;
 		uint64_t lastRtcpSentTime{ 0u };
 		uint16_t maxRtcpInterval{ 0u };
 		bool externallyManagedBitrate{ false };

package/worker/include/RTC/DtlsTransport.hpp

@@ -161,7 +161,7 @@ namespace RTC
 		{
 			return DtlsTransport::localFingerprints;
 		}
-		bool SetRemoteFingerprint(Fingerprint fingerprint);
+		bool SetRemoteFingerprint(const Fingerprint& fingerprint);
 		void ProcessDtlsData(const uint8_t* data, size_t len);
 		DtlsState GetState() const
 		{

package/worker/include/RTC/RtpPacket.hpp

@@ -315,7 +315,7 @@ namespace RTC
 			return true;
 		}
 
-		bool UpdateMid(const std::string& mid);
+		void UpdateMid(const std::string& mid);
 
 		bool ReadRid(std::string& rid) const
 		{

package/worker/src/RTC/ActiveSpeakerObserver.cpp

@@ -308,10 +308,10 @@ namespace RTC
 			dominantSpeaker->EvalActivityScores();
 			double newDominantC2 = C2;
 
-			for (auto it = this->mapProducerSpeaker.begin(); it != this->mapProducerSpeaker.end(); ++it)
+			for (const auto& it : this->mapProducerSpeaker)
 			{
-				Speaker* speaker      = it->second.speaker;
-				const std::string& id = it->second.producer->id;
+				Speaker* speaker      = it.second.speaker;
+				const std::string& id = it.second.producer->id;
 
 				if (id == this->dominantId || speaker->paused)
 				{
@@ -351,10 +351,10 @@ namespace RTC
 	{
 		MS_TRACE();
 
-		for (auto it = this->mapProducerSpeaker.begin(); it != this->mapProducerSpeaker.end(); ++it)
+		for (const auto& it : this->mapProducerSpeaker)
 		{
-			Speaker* speaker      = it->second.speaker;
-			const std::string& id = it->second.producer->id;
+			Speaker* speaker      = it.second.speaker;
+			const std::string& id = it.second.producer->id;
 			uint64_t idle         = now - speaker->lastLevelChangeTime;
 
 			if (SpeakerIdleTimeout < idle && (this->dominantId.empty() || id != this->dominantId))

package/worker/src/RTC/Consumer.cpp

@@ -130,7 +130,7 @@ namespace RTC
 		for (auto& codec : this->rtpParameters.codecs)
 		{
 			if (codec.mimeType.IsMediaCodec())
-				this->supportedCodecPayloadTypes.insert(codec.payloadType);
+				this->supportedCodecPayloadTypes[codec.payloadType] = true;
 		}
 
 		// Fill media SSRCs vector.
@@ -192,7 +192,13 @@ namespace RTC
 		}
 
 		// Add supportedCodecPayloadTypes.
-		jsonObject["supportedCodecPayloadTypes"] = this->supportedCodecPayloadTypes;
+		jsonObject["supportedCodecPayloadTypes"] = json::array();
+
+		for (auto i = 0; i < 128; ++i)
+		{
+			if (this->supportedCodecPayloadTypes[i])
+				jsonObject["supportedCodecPayloadTypes"].push_back(i);
+		}
 
 		// Add paused.
 		jsonObject["paused"] = this->paused;

package/worker/src/RTC/DataConsumer.cpp

@@ -209,7 +209,7 @@ namespace RTC
 				// Trigger 'bufferedamountlow' now.
 				if (this->bufferedAmount <= this->bufferedAmountLowThreshold)
 				{
-					std::string data("{\"bufferedAmount\":\"");
+					std::string data(R"({"bufferedAmount":")");
 
 					data.append(std::to_string(this->bufferedAmount));
 					data.append("\"}");
@@ -350,7 +350,7 @@ namespace RTC
 			this->forceTriggerBufferedAmountLow = false;
 
 			// Notify the Node DataConsumer.
-			std::string data("{\"bufferedAmount\":\"");
+			std::string data(R"({"bufferedAmount":")");
 
 			data.append(std::to_string(this->bufferedAmount));
 			data.append("\"}");

package/worker/src/RTC/DtlsTransport.cpp

@@ -702,7 +702,7 @@ namespace RTC
 		}
 	}
 
-	bool DtlsTransport::SetRemoteFingerprint(Fingerprint fingerprint)
+	bool DtlsTransport::SetRemoteFingerprint(const Fingerprint& fingerprint)
 	{
 		MS_TRACE();
 

package/worker/src/RTC/IceServer.cpp

@@ -46,6 +46,8 @@ namespace RTC
 			// Notify the listener.
 			this->listener->OnIceServerTupleRemoved(this, storedTuple);
 		}
+
+		this->tuples.clear();
 	}
 
 	void IceServer::ProcessStunPacket(RTC::StunPacket* packet, RTC::TransportTuple* tuple)
@@ -294,7 +296,12 @@ namespace RTC
 		if (!removedTuple)
 			return;
 
+		// Notify the listener.
+		this->listener->OnIceServerTupleRemoved(this, removedTuple);
+
 		// Remove it from the list of tuples.
+		// NOTE: Do it after notifying the listener since the listener may need to
+		// use/read the tuple being removed so we cannot free it yet.
 		this->tuples.erase(it);
 
 		// If this is the selected tuple, do things.
@@ -316,9 +323,6 @@ namespace RTC
 				this->listener->OnIceServerDisconnected(this);
 			}
 		}
-
-		// Notify the listener.
-		this->listener->OnIceServerTupleRemoved(this, removedTuple);
 	}
 
 	void IceServer::ForceSelectedTuple(const RTC::TransportTuple* tuple)
@@ -591,13 +595,15 @@ namespace RTC
 			// This should not happen by design.
 			MS_ASSERT(removedTuple, "couldn't find any tuple to be removed");
 
+			// Notify the listener.
+			this->listener->OnIceServerTupleRemoved(this, removedTuple);
+
 			// Remove it from the list of tuples.
+			// NOTE: Do it after notifying the listener since the listener may need to
+			// use/read the tuple being removed so we cannot free it yet.
 			// NOTE: This trick is needed since it is a reverse_iterator and
 			// erase() requires a iterator, const_iterator or bidirectional_iterator.
 			this->tuples.erase(std::next(it).base());
-
-			// Notify the listener.
-			this->listener->OnIceServerTupleRemoved(this, removedTuple);
 		}
 
 		// Return the address of the inserted tuple.

package/worker/src/RTC/PipeConsumer.cpp

@@ -205,7 +205,7 @@ namespace RTC
 
 		// NOTE: This may happen if this Consumer supports just some codecs of those
 		// in the corresponding Producer.
-		if (this->supportedCodecPayloadTypes.find(payloadType) == this->supportedCodecPayloadTypes.end())
+		if (!this->supportedCodecPayloadTypes[payloadType])
 		{
 			MS_DEBUG_DEV("payload type not supported [payloadType:%" PRIu8 "]", payloadType);
 

package/worker/src/RTC/RTCP/FeedbackRtpTransport.cpp

@@ -392,7 +392,7 @@ namespace RTC
 			}
 
 			size_t deltaIdx{ 0u };
-			int64_t currentReceivedAtMs = static_cast<int64_t>(this->referenceTime * 64);
+			auto currentReceivedAtMs = static_cast<int64_t>(this->referenceTime * 64);
 
 			for (size_t idx{ 0u }; idx < packetResults.size(); ++idx)
 			{

package/worker/src/RTC/RtpPacket.cpp

@@ -533,7 +533,7 @@ namespace RTC
 		MS_ASSERT(ptr == this->payload, "wrong ptr calculation");
 	}
 
-	bool RtpPacket::UpdateMid(const std::string& mid)
+	void RtpPacket::UpdateMid(const std::string& mid)
 	{
 		MS_TRACE();
 
@@ -541,25 +541,25 @@ namespace RTC
 		uint8_t* extenValue = GetExtension(this->midExtensionId, extenLen);
 
 		if (!extenValue)
-			return false;
+			return;
+
+		size_t midLen = mid.length();
 
 		// Here we assume that there is MidMaxLength available bytes, even if now
 		// they are padding bytes.
-		if (mid.size() > RTC::MidMaxLength)
+		if (midLen > RTC::MidMaxLength)
 		{
 			MS_ERROR(
 			  "no enough space for MID value [MidMaxLength:%" PRIu8 ", mid:'%s']",
 			  RTC::MidMaxLength,
 			  mid.c_str());
 
-			return false;
+			return;
 		}
 
-		std::memcpy(extenValue, mid.c_str(), mid.size());
-
-		SetExtensionLength(this->midExtensionId, mid.size());
+		std::memcpy(extenValue, mid.c_str(), midLen);
 
-		return true;
+		SetExtensionLength(this->midExtensionId, midLen);
 	}
 
 	/**
@@ -837,7 +837,7 @@ namespace RTC
 			MS_ASSERT(shift <= (this->payloadLength - payloadOffset), "shift too big");
 
 		uint8_t* payloadOffsetPtr = this->payload + payloadOffset;
-		size_t shiftedLen;
+		size_t shiftedLen{ 0 };
 
 		if (expand)
 		{

package/worker/src/RTC/SctpAssociation.cpp

@@ -392,7 +392,7 @@ namespace RTC
 
 		const auto& parameters = dataConsumer->GetSctpStreamParameters();
 
-		// Fill stcp_sendv_spa.
+		// Fill sctp_sendv_spa.
 		struct sctp_sendv_spa spa; // NOLINT(cppcoreguidelines-pro-type-member-init)
 
 		std::memset(&spa, 0, sizeof(spa));

package/worker/src/RTC/SimpleConsumer.cpp

@@ -270,7 +270,7 @@ namespace RTC
 
 		// NOTE: This may happen if this Consumer supports just some codecs of those
 		// in the corresponding Producer.
-		if (this->supportedCodecPayloadTypes.find(payloadType) == this->supportedCodecPayloadTypes.end())
+		if (!this->supportedCodecPayloadTypes[payloadType])
 		{
 			MS_DEBUG_DEV("payload type not supported [payloadType:%" PRIu8 "]", payloadType);
 

package/worker/src/RTC/SimulcastConsumer.cpp

@@ -627,7 +627,7 @@ namespace RTC
 		auto nowMs = DepLibUV::GetTimeMs();
 		uint32_t desiredBitrate{ 0u };
 
-		for (int sIdx{ static_cast<int>(this->producerRtpStreams.size()) - 1 }; sIdx >= 0; --sIdx)
+		for (size_t sIdx{ this->producerRtpStreams.size() - 1 }; sIdx >= 0; --sIdx)
 		{
 			auto* producerRtpStream = this->producerRtpStreams.at(sIdx);
 
@@ -665,7 +665,7 @@ namespace RTC
 
 		// NOTE: This may happen if this Consumer supports just some codecs of those
 		// in the corresponding Producer.
-		if (this->supportedCodecPayloadTypes.find(payloadType) == this->supportedCodecPayloadTypes.end())
+		if (!this->supportedCodecPayloadTypes[payloadType])
 		{
 			MS_DEBUG_DEV("payload type not supported [payloadType:%" PRIu8 "]", payloadType);
 

package/worker/src/RTC/SvcConsumer.cpp

@@ -563,7 +563,7 @@ namespace RTC
 
 		// NOTE: This may happen if this Consumer supports just some codecs of those
 		// in the corresponding Producer.
-		if (this->supportedCodecPayloadTypes.find(payloadType) == this->supportedCodecPayloadTypes.end())
+		if (!this->supportedCodecPayloadTypes[payloadType])
 		{
 			MS_DEBUG_DEV("payload type not supported [payloadType:%" PRIu8 "]", payloadType);
 

package/worker/src/RTC/TcpServer.cpp

@@ -13,7 +13,7 @@ namespace RTC
 	TcpServer::TcpServer(Listener* listener, RTC::TcpConnection::Listener* connListener, std::string& ip)
 	  : // This may throw.
 	    ::TcpServerHandler::TcpServerHandler(RTC::PortManager::BindTcp(ip)), listener(listener),
-	    connListener(connListener), fixedPort(false)
+	    connListener(connListener)
 	{
 		MS_TRACE();
 	}

package/worker/src/RTC/Transport.cpp

@@ -2145,7 +2145,7 @@ namespace RTC
 			case RTC::RTCP::Type::SDES:
 			{
 				// According to RFC 3550 section 6.1 "a CNAME item MUST be included in
-				// in each compound RTCP packet". So this is true even for compound
+				// each compound RTCP packet". So this is true even for compound
 				// packets sent by endpoints that are not sending any RTP stream to us
 				// (thus chunks in such a SDES will have an SSCR does not match with
 				// any Producer created in this Transport).

package/worker/src/RTC/UdpSocket.cpp

@@ -12,8 +12,7 @@ namespace RTC
 
 	UdpSocket::UdpSocket(Listener* listener, std::string& ip)
 	  : // This may throw.
-	    ::UdpSocketHandler::UdpSocketHandler(PortManager::BindUdp(ip)), listener(listener),
-	    fixedPort(false)
+	    ::UdpSocketHandler::UdpSocketHandler(PortManager::BindUdp(ip)), listener(listener)
 	{
 		MS_TRACE();
 	}

package/worker/src/RTC/WebRtcServer.cpp

@@ -94,14 +94,18 @@ namespace RTC
 				listenInfo.announcedIp.assign(jsonAnnouncedIpIt->get<std::string>());
 			}
 
+			uint16_t port{ 0 };
 			auto jsonPortIt = jsonListenInfo.find("port");
 
-			if (jsonPortIt == jsonListenInfo.end())
-				MS_THROW_TYPE_ERROR("missing listenInfo.port");
-			else if (!(jsonPortIt->is_number() && Utils::Json::IsPositiveInteger(*jsonPortIt)))
-				MS_THROW_TYPE_ERROR("wrong listenInfo.port (not a positive number)");
+			if (jsonPortIt != jsonListenInfo.end())
+			{
+				if (!(jsonPortIt->is_number() && Utils::Json::IsPositiveInteger(*jsonPortIt)))
+					MS_THROW_TYPE_ERROR("wrong port (not a positive number)");
+
+				port = jsonPortIt->get<uint16_t>();
+			}
 
-			listenInfo.port = jsonPortIt->get<uint16_t>();
+			listenInfo.port = port;
 		}
 
 		try
@@ -111,14 +115,24 @@ namespace RTC
 				if (listenInfo.protocol == RTC::TransportTuple::Protocol::UDP)
 				{
 					// This may throw.
-					auto* udpSocket = new RTC::UdpSocket(this, listenInfo.ip, listenInfo.port);
+					RTC::UdpSocket* udpSocket;
+
+					if (listenInfo.port != 0)
+						udpSocket = new RTC::UdpSocket(this, listenInfo.ip, listenInfo.port);
+					else
+						udpSocket = new RTC::UdpSocket(this, listenInfo.ip);
 
 					this->udpSocketOrTcpServers.emplace_back(udpSocket, nullptr, listenInfo.announcedIp);
 				}
 				else if (listenInfo.protocol == RTC::TransportTuple::Protocol::TCP)
 				{
 					// This may throw.
-					auto* tcpServer = new RTC::TcpServer(this, this, listenInfo.ip, listenInfo.port);
+					RTC::TcpServer* tcpServer;
+
+					if (listenInfo.port != 0)
+						tcpServer = new RTC::TcpServer(this, this, listenInfo.ip, listenInfo.port);
+					else
+						tcpServer = new RTC::TcpServer(this, this, listenInfo.ip);
 
 					this->udpSocketOrTcpServers.emplace_back(nullptr, tcpServer, listenInfo.announcedIp);
 				}
@@ -347,7 +361,7 @@ namespace RTC
 		// before the ":" symbol.
 
 		auto& username  = packet->GetUsername();
-		size_t colonPos = username.find(":");
+		size_t colonPos = username.find(':');
 
 		// If no colon is found just return the whole USERNAME attribute anyway.
 		if (colonPos == std::string::npos)

package/worker/src/RTC/WebRtcTransport.cpp

@@ -1278,7 +1278,9 @@ namespace RTC
 
 		// If this is a TCP tuple, close its underlaying TCP connection.
 		if (tuple->GetProtocol() == RTC::TransportTuple::Protocol::TCP && !tuple->IsClosed())
+		{
 			tuple->Close();
+		}
 	}
 
 	inline void WebRtcTransport::OnIceServerSelectedTuple(

package/worker/test/src/RTC/RTCP/TestBye.cpp

@@ -31,7 +31,7 @@ namespace TestBye
 	{
 		REQUIRE(packet->GetReason() == reason);
 
-		ByePacket::Iterator it = packet->Begin();
+		auto it = packet->Begin();
 
 		REQUIRE(*it == ssrc1);
 

package/worker/test/src/RTC/RTCP/TestFeedbackPsFir.cpp

@@ -69,7 +69,7 @@ SCENARIO("RTCP Feedback PS FIR parsing", "[parser][rtcp][feedback-ps][fir]")
 	{
 		FeedbackPsFirPacket packet(senderSsrc, mediaSsrc);
 
-		FeedbackPsFirItem* item = new FeedbackPsFirItem(ssrc, seq);
+		auto* item = new FeedbackPsFirItem(ssrc, seq);
 
 		packet.AddItem(item);
 

package/worker/test/src/RTC/RTCP/TestFeedbackPsLei.cpp

@@ -66,7 +66,7 @@ SCENARIO("RTCP Feedback PS LEI parsing", "[parser][rtcp][feedback-ps][lei]")
 	{
 		FeedbackPsLeiPacket packet(senderSsrc, mediaSsrc);
 
-		FeedbackPsLeiItem* item = new FeedbackPsLeiItem(ssrc);
+		auto* item = new FeedbackPsLeiItem(ssrc);
 
 		packet.AddItem(item);
 

package/worker/test/src/RTC/RTCP/TestFeedbackPsTst.cpp

@@ -71,7 +71,7 @@ SCENARIO("RTCP Feedback PS TSTN parsing", "[parser][rtcp][feedback-ps][tstn]")
 	{
 		FeedbackPsTstnPacket packet(senderSsrc, mediaSsrc);
 
-		FeedbackPsTstnItem* item = new FeedbackPsTstnItem(ssrc, seq, TestFeedbackPsTstn::index);
+		auto* item = new FeedbackPsTstnItem(ssrc, seq, TestFeedbackPsTstn::index);
 
 		packet.AddItem(item);
 

package/worker/test/src/RTC/RTCP/TestFeedbackRtpNack.cpp

@@ -69,7 +69,7 @@ SCENARIO("RTCP Feeback RTP NACK parsing", "[parser][rtcp][feedback-rtp][nack]")
 	SECTION("create FeedbackRtpNackPacket")
 	{
 		FeedbackRtpNackPacket packet(senderSsrc, mediaSsrc);
-		FeedbackRtpNackItem* item = new FeedbackRtpNackItem(pid, lostPacketBitmask);
+		auto* item = new FeedbackRtpNackItem(pid, lostPacketBitmask);
 
 		packet.AddItem(item);
 

package/worker/test/src/RTC/RTCP/TestFeedbackRtpTmmb.cpp

@@ -78,7 +78,7 @@ SCENARIO("RTCP Feeback RTP TMMBR parsing", "[parser][rtcp][feedback-rtp][tmmb]")
 	SECTION("create FeedbackRtpTmmbrPacket")
 	{
 		FeedbackRtpTmmbrPacket packet(senderSsrc, mediaSsrc);
-		FeedbackRtpTmmbrItem* item = new FeedbackRtpTmmbrItem();
+		auto* item = new FeedbackRtpTmmbrItem();
 
 		item->SetSsrc(ssrc);
 		item->SetBitrate(bitrate);

package/worker/test/src/RTC/RTCP/TestFeedbackRtpTransport.cpp

@@ -558,9 +558,6 @@ SCENARIO("RTCP Feeback RTP transport", "[parser][rtcp][feedback-rtp][transport]"
 		  FeedbackRtpTransportPacket::TimeWrapPeriod +
 		    static_cast<int64_t>(12408746) * FeedbackRtpTransportPacket::BaseTimeTick);
 
-		// Let's also test the reference time reported by Wireshark.
-		int32_t wiresharkValue{ 12408746 };
-
 		REQUIRE(packet->GetFeedbackPacketCount() == 0);
 
 		SECTION("serialize packet")
@@ -577,7 +574,7 @@ SCENARIO("RTCP Feeback RTP transport", "[parser][rtcp][feedback-rtp][transport]"
 
 	SECTION("parse FeedbackRtpTransportPacket generated by Chrome with libwebrtc as a reference")
 	{
-		typedef struct
+		using FeedbackPacketsMeta = struct
 		{
 			uint32_t baseTimeRaw;
 			uint64_t baseTimeMs;
@@ -585,7 +582,7 @@ SCENARIO("RTCP Feeback RTP transport", "[parser][rtcp][feedback-rtp][transport]"
 			size_t packetStatusCount;
 			std::vector<int16_t> deltas;
 			std::vector<uint8_t> buffer;
-		} FeedbackPacketsMeta;
+		};
 
 		// Metadata collected by parsing buffers with libwebrtc, buffers itself.
 		// were generated by chrome in direction of mediasoup.

package/worker/test/src/RTC/RTCP/TestSdes.cpp

@@ -72,7 +72,7 @@ SCENARIO("RTCP SDES parsing", "[parser][rtcp][sdes]")
 
 	SECTION("create SdesChunk")
 	{
-		SdesItem* item = new SdesItem(type, length, value.c_str());
+		auto* item = new SdesItem(type, length, value.c_str());
 
 		// Create sdes chunk.
 		SdesChunk chunk(ssrc);

package/worker/test/src/RTC/TestNackGenerator.cpp

@@ -37,28 +37,28 @@ class TestPayloadDescriptorHandler : public Codecs::PayloadDescriptorHandler
 {
 public:
 	explicit TestPayloadDescriptorHandler(bool isKeyFrame) : isKeyFrame(isKeyFrame){};
-	~TestPayloadDescriptorHandler() = default;
-	void Dump() const
+	~TestPayloadDescriptorHandler() override = default;
+	void Dump() const override
 	{
 		return;
 	};
-	bool Process(Codecs::EncodingContext* /*context*/, uint8_t* /*data*/, bool& /*marker*/)
+	bool Process(Codecs::EncodingContext* /*context*/, uint8_t* /*data*/, bool& /*marker*/) override
 	{
 		return true;
 	};
-	void Restore(uint8_t* /*data*/)
+	void Restore(uint8_t* /*data*/) override
 	{
 		return;
 	};
-	uint8_t GetSpatialLayer() const
+	uint8_t GetSpatialLayer() const override
 	{
 		return 0;
 	};
-	uint8_t GetTemporalLayer() const
+	uint8_t GetTemporalLayer() const override
 	{
 		return 0;
 	};
-	bool IsKeyFrame() const
+	bool IsKeyFrame() const override
 	{
 		return this->isKeyFrame;
 	};
@@ -129,7 +129,7 @@ void validate(std::vector<TestNackGeneratorInput>& inputs)
 	{
 		listener.Reset(input);
 
-		TestPayloadDescriptorHandler* tpdh = new TestPayloadDescriptorHandler(input.isKeyFrame);
+		auto* tpdh = new TestPayloadDescriptorHandler(input.isKeyFrame);
 
 		packet->SetPayloadDescriptorHandler(tpdh);
 		packet->SetSequenceNumber(input.seq);

package/worker/test/src/RTC/TestRateCalculator.cpp

@@ -15,11 +15,10 @@ struct data
 
 void validate(RateCalculator& rate, uint64_t timeBase, std::vector<data>& input)
 {
-	for (auto it = input.begin(); it != input.end(); ++it)
+	for (auto& item : input)
 	{
-		auto& item = *it;
-
 		rate.Update(item.size, timeBase + item.offset);
+
 		REQUIRE(rate.GetRate(timeBase + item.offset) == item.rate);
 	}
 }

package/worker/test/src/RTC/TestRtpStreamSend.cpp

@@ -99,7 +99,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
 		std::string mid;
-		RtpStreamSend* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
+		auto* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
 
 		// Receive all the packets (some of them not in order and/or duplicated).
 		SendRtpPacket({ { stream, params.ssrc } }, packet1);
@@ -164,7 +164,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
 		std::string mid;
-		RtpStreamSend* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
+		auto* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
 
 		// Receive all the packets (some of them not in order and/or duplicated).
 		SendRtpPacket({ { stream, params.ssrc } }, packet1);
@@ -217,7 +217,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params.mimeType.type = RTC::RtpCodecMimeType::Type::AUDIO;
 
 		std::string mid;
-		RtpStreamSend* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
+		auto* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
 
 		// Receive all the packets (some of them not in order and/or duplicated).
 		SendRtpPacket({ { stream, params.ssrc } }, packet1);
@@ -265,7 +265,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params1.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
 		std::string mid;
-		RtpStreamSend* stream1 = new RtpStreamSend(&testRtpStreamListener1, params1, mid);
+		auto* stream1 = new RtpStreamSend(&testRtpStreamListener1, params1, mid);
 
 		RtpStream::Params params2;
 
@@ -274,7 +274,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params2.useNack       = true;
 		params2.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
-		RtpStreamSend* stream2 = new RtpStreamSend(&testRtpStreamListener2, params2, mid);
+		auto* stream2 = new RtpStreamSend(&testRtpStreamListener2, params2, mid);
 
 		// Receive all the packets in both streams.
 		SendRtpPacket({ { stream1, params1.ssrc }, { stream2, params2.ssrc } }, packet1);
@@ -340,7 +340,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params1.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
 		std::string mid;
-		RtpStreamSend* stream = new RtpStreamSend(&testRtpStreamListener1, params1, mid);
+		auto* stream = new RtpStreamSend(&testRtpStreamListener1, params1, mid);
 
 		// Receive all the packets.
 		SendRtpPacket({ { stream, params1.ssrc } }, packet1);
@@ -392,7 +392,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params1.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
 		std::string mid;
-		RtpStreamSend* stream = new RtpStreamSend(&testRtpStreamListener1, params1, mid);
+		auto* stream = new RtpStreamSend(&testRtpStreamListener1, params1, mid);
 
 		// Receive all the packets.
 		SendRtpPacket({ { stream, params1.ssrc } }, packet1);
@@ -435,7 +435,7 @@ SCENARIO("NACK and RTP packets retransmission", "[rtp][rtcp][nack]")
 		params.mimeType.type = RTC::RtpCodecMimeType::Type::VIDEO;
 
 		std::string mid;
-		RtpStreamSend* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
+		auto* stream = new RtpStreamSend(&testRtpStreamListener, params, mid);
 
 		size_t iterations = 10000000;