mechanical-tolerance-calculator 1.2.2 → 1.2.3

package/index.js

@@ -538,16 +538,18 @@ function checkMultipleMeasurementsFor(materialType, measurements) {
     processIndividualMeasurement(camcoTolerances.type, m, camcoTolerances),
   );
 
-  // 4. Determine most common nominal and farthest measurement
+  // 4. Determine most common nominal
   const mostOccuredNominal = findMostOccuredNominal(results);
-  const mostFarMeasurement = findFarthestMeasurement(
-    measurements,
-    mostOccuredNominal,
-  );
 
   // 5. Base spec for the most common nominal
   const baseSpec = results.find((r) => r.nominal === mostOccuredNominal);
   const baseITValue = baseSpec.matched_spec[baseSpec.IT_grade];
+  // Determine the farthest measurement
+  const mostFarMeasurement = findFarthestMeasurement(
+    measurements,
+    mostOccuredNominal,
+    baseSpec.computed_specification_bounds,
+  );
 
   // 6. Check IT tolerance and spec compliance
   const { meetsIT, itReason } = checkITTolerance(
@@ -610,16 +612,36 @@ function findMostOccuredNominal(results) {
   );
 }
 
-/** Find the measurement farthest from the most common nominal */
-function findFarthestMeasurement(measurements, referenceNominal) {
-  return measurements.reduce(
-    (farthest, current) =>
-      Math.abs(current - referenceNominal) >
-      Math.abs(farthest - referenceNominal)
-        ? current
-        : farthest,
-    measurements[0],
-  );
+/**
+ * Finds the measurement farthest from the nominal that is outside the allowed bounds.
+ * @param {number[]} measurements - Array of measurements
+ * @param {number} nominal - Reference nominal value
+ * @param {object} bounds - Computed bounds { lowerBound, upperBound }
+ * @returns {number|null} - The farthest measurement outside bounds, or null if all within bounds
+ */
+function findFarthestMeasurement(measurements, nominal, bounds) {
+  if (!Array.isArray(measurements) || measurements.length === 0) return null;
+
+  let farthest = null;
+  let maxDistance = -1;
+
+  measurements.forEach((m) => {
+    const isOutside = m < bounds.lowerBound || m > bounds.upperBound;
+    if (isOutside) {
+      const distance = Math.abs(m - nominal);
+      if (distance > maxDistance) {
+        maxDistance = distance;
+        farthest = m;
+      }
+    }
+  });
+
+  // If no measurement is outside bounds, return the largest measurement
+  if (farthest === null) {
+    return Math.max(...measurements);
+  }
+
+  return farthest; // null if all measurements are within bounds
 }
 
 /** Check IT tolerance */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mechanical-tolerance-calculator",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Calculates international standard specification and  tolerances for bores, round bars and metals of mechanical units. For examples; H7, H8, H9, h8, h9 specifications and IT5/IT6 tolerances.",
   "main": "index.js",
   "scripts": {
@@ -25,5 +25,8 @@
   "bugs": {
     "url": "https://github.com/AjayGhimire1998/Mechanical-Tolerances-Calculator/issues"
   },
-  "homepage": "https://github.com/AjayGhimire1998/Mechanical-Tolerances-Calculator#readme"
+  "homepage": "https://github.com/AjayGhimire1998/Mechanical-Tolerances-Calculator#readme",
+  "dependencies": {
+    "mechanical-tolerance-calculator": "^1.2.2"
+  }
 }

package/test.js

@@ -4,5 +4,9 @@ const {
 } = require("./index");
 // console.log(checkMultipleMeasurementsFor("housing", [100.04, 100.05]));
 // console.log(checkMultipleMeasurementsFor("housing", [100.04, 100.05, 95.06]));
-console.log(checkMultipleMeasurementsFor("housing", [99.99, 100.15, 100.2]));
-console.log(checkOneMeasurementFor("shaft", 199.98));
+console.log(
+  checkMultipleMeasurementsFor(
+    "housing",
+    [120, 120.05, 119.98, 119.98, 119.97, 119.98],
+  ),
+);