meadow-integration 1.0.31 → 1.0.33

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meadow-integration",
-    "version": "1.0.31",
+    "version": "1.0.33",
     "description": "Meadow Data Integration",
     "bin": {
         "mdwint": "source/cli/Meadow-Integration-CLI-Run.js"
@@ -43,15 +43,15 @@
         "fable": "^3.1.70",
         "fable-serviceproviderbase": "^3.0.19",
         "fast-xml-parser": "^4.4.1",
-        "meadow": "^2.0.33",
-        "meadow-connection-mssql": "^1.0.16",
-        "meadow-connection-mysql": "^1.0.14",
+        "meadow": "^2.0.35",
+        "meadow-connection-mssql": "^1.0.19",
+        "meadow-connection-mysql": "^1.0.17",
         "orator": "^6.0.4",
         "orator-serviceserver-restify": "^2.0.10",
         "pict-section-flow": "^0.0.17",
         "pict-service-commandlineutility": "^1.0.19",
         "pict-sessionmanager": "^1.0.2",
-        "pict-view": "^1.0.67",
+        "pict-view": "^1.0.68",
         "xlsx": "^0.18.5"
     }
 }

package/source/services/clone/Meadow-Service-Sync-Entity-Initial.js

@@ -86,18 +86,32 @@ class MeadowSyncEntityInitial extends libFableServiceProviderBase
 					this.log.warn(`${this.EntitySchema.TableName}: createTable returned error: ${pCreateError}`);
 				}
 
+				// Sync-entity init intentionally does not create indexes here.
+				// In the DataCloner flow there is no MeadowConnectionManager
+				// service registered, so the legacy createIndex path was dead
+				// code that just logged noise ("No connection manager
+				// available; skipping index creation for X") for every table.
+				// Indexes are created via the provider's own createIndices /
+				// generateCreateIndexStatements methods, invoked by the
+				// DataCloner's dedicated /indices/create endpoint after the
+				// initial sync is complete — that's the point where it makes
+				// sense to build indexes, since they're expensive on populated
+				// tables.
+				//
+				// Preserve the legacy MeadowConnectionManager path for the CLI
+				// Meadow-Integration-Command-DataClone.js flow (which does
+				// register that service), but do it silently when neither
+				// indexable column nor connection manager is available.
 				const tmpGUIDColumn = this.EntitySchema.Columns.find((c) => c.DataType == 'GUID');
 				const tmpDeletedColumn = this.EntitySchema.Columns.find((c) => c.Column == 'Deleted');
 
-				if (!tmpGUIDColumn && !tmpDeletedColumn)
-				{
-					this.log.info(`No GUID or Deleted columns for ${this.EntitySchema.TableName}; skipping index creation`);
-					return fCallback(pCreateError);
-				}
+				let tmpCanCreateIndexes = (tmpGUIDColumn || tmpDeletedColumn)
+					&& this.fable.MeadowConnectionManager
+					&& this.fable.MeadowConnectionManager.ConnectionPool
+					&& typeof(this.fable.MeadowConnectionManager.createIndex) === 'function';
 
-				if (!this.fable.MeadowConnectionManager || !this.fable.MeadowConnectionManager.ConnectionPool)
+				if (!tmpCanCreateIndexes)
 				{
-					this.log.info(`No connection manager available; skipping index creation for ${this.EntitySchema.TableName}`);
 					return fCallback(pCreateError);
 				}
 
@@ -458,7 +472,13 @@ class MeadowSyncEntityInitial extends libFableServiceProviderBase
 				},
 				(fStageComplete) =>
 				{
-					tmpSyncState.EstimatedRecordCount = tmpSyncState.Server.RecordCount - tmpSyncState.Local.RecordCount;
+					// The raw diff can be negative when local has more records
+					// than the server (e.g. records were deleted server-side but
+					// the local copy still has them).  Clamp the estimate to 0
+					// so progress trackers and downstream reports never show a
+					// negative total.
+					let tmpRawEstimate = tmpSyncState.Server.RecordCount - tmpSyncState.Local.RecordCount;
+					tmpSyncState.EstimatedRecordCount = Math.max(0, tmpRawEstimate);
 
 					// Apply MaxRecordsPerEntity cap if configured
 					tmpSyncState.RecordCap = (this.MaxRecordsPerEntity > 0)
@@ -474,6 +494,29 @@ class MeadowSyncEntityInitial extends libFableServiceProviderBase
 					this.operation.createProgressTracker(tmpSyncState.EstimatedRecordCount, `FullSync-${this.EntitySchema.TableName}`);
 					this.operation.printProgressTrackerStatus(`FullSync-${this.EntitySchema.TableName}`);
 
+					// Fast path: if there is nothing new to pull (estimate is
+					// zero or negative), skip the download phase entirely.
+					// Running the paginated loop would otherwise make one or
+					// more requests just to receive an empty response and then
+					// short-circuit with an "Error: Records depleted!" log —
+					// noisy and a waste of round-trips.  Zero out RecordCap
+					// as well so the advanced-ID-pagination loop
+					// (which gates on RecordCap, not URLPartials) also skips.
+					if (tmpSyncState.EstimatedRecordCount <= 0)
+					{
+						tmpSyncState.URLPartials = [];
+						tmpSyncState.RecordCap = 0;
+						if (tmpRawEstimate < 0)
+						{
+							this.fable.log.info(`${this.EntitySchema.TableName}: local has ${-tmpRawEstimate} more record(s) than server (local: ${tmpSyncState.Local.RecordCount}, server: ${tmpSyncState.Server.RecordCount}); nothing to download.`);
+						}
+						else
+						{
+							this.fable.log.info(`${this.EntitySchema.TableName}: record counts match (${tmpSyncState.Server.RecordCount}); nothing to download.`);
+						}
+						return fStageComplete();
+					}
+
 					if (this.UseAdvancedIDPagination)
 					{
 						this.fable.log.info(`${this.EntitySchema.TableName}: using advanced ID pagination (local: ${tmpSyncState.Local.RecordCount}/${tmpSyncState.Local.MaxIDEntity}, server: ${tmpSyncState.Server.RecordCount}/${tmpSyncState.Server.MaxIDEntity}, estimated new: ${tmpSyncState.EstimatedRecordCount}${this.MaxRecordsPerEntity > 0 ? `, capped at ${this.MaxRecordsPerEntity}` : ''})`);

package/source/services/clone/Meadow-Service-Sync-Entity-Ongoing.js

@@ -80,19 +80,23 @@ class MeadowSyncEntityOngoing extends libFableServiceProviderBase
 		{
 			return this.Meadow.provider.getProvider().createTable(this.EntitySchema, (pCreateError) =>
 			{
-
+				// Sync-entity init intentionally does not create indexes here
+				// in the DataCloner flow.  See the comment in
+				// Meadow-Service-Sync-Entity-Initial.js for the rationale —
+				// indexes go through the provider's createIndices path
+				// (triggered by DataCloner's /indices/create endpoint) rather
+				// than via MeadowConnectionManager, which isn't registered in
+				// the DataCloner service container.
 				const tmpGUIDColumn = this.EntitySchema.Columns.find((c) => c.DataType == 'GUID');
 				const tmpDeletedColumn = this.EntitySchema.Columns.find((c) => c.Column == 'Deleted');
 
-				if (!tmpGUIDColumn && !tmpDeletedColumn)
-				{
-					this.log.info(`No GUID or Deleted columns for ${this.EntitySchema.TableName}; skipping index creation`);
-					return fCallback(pCreateError);
-				}
+				let tmpCanCreateIndexes = (tmpGUIDColumn || tmpDeletedColumn)
+					&& this.fable.MeadowConnectionManager
+					&& this.fable.MeadowConnectionManager.ConnectionPool
+					&& typeof(this.fable.MeadowConnectionManager.createIndex) === 'function';
 
-				if (!this.fable.MeadowConnectionManager || !this.fable.MeadowConnectionManager.ConnectionPool)
+				if (!tmpCanCreateIndexes)
 				{
-					this.log.info(`No connection manager available; skipping index creation for ${this.EntitySchema.TableName}`);
 					return fCallback(pCreateError);
 				}