meadow-endpoints 2.0.20 → 2.0.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "meadow-endpoints",
-  "version": "2.0.20",
+  "version": "2.0.21",
   "description": "Automatic API endpoints for Meadow data.",
   "main": "source/Meadow-Endpoints.js",
   "scripts": {

package/source/crud/Meadow-Endpoint-Delete.js

@@ -43,7 +43,7 @@ var doAPIDeleteEndpoint = function(pRequest, pResponse, fNext)
 		tmpIDRecord = pRequest.body[pRequest.DAL.defaultIdentifier];
 	}
 	// Although the delete request does allow multiple deletes, we require an identifier.
-	if (tmpIDRecord < 1)
+	if (!parseInt(tmpIDRecord) || tmpIDRecord < 1)
 	{
 		return pRequest.CommonServices.sendError('Record delete failure - a valid record ID is required in the passed-in record.', pRequest, pResponse, fNext);
 	}

package/source/crud/Meadow-Endpoint-Update.js

@@ -41,7 +41,7 @@ var doAPIUpdateEndpoint = function(pRequest, pResponse, fNext)
 				{
 					return pRequest.CommonServices.sendError('Record update failure - a valid record is required.', pRequest, pResponse, fNext);
 				}
-				if (pRequest.body[pRequest.DAL.defaultIdentifier] < 1)
+				if (!parseInt(pRequest.body[pRequest.DAL.defaultIdentifier]) || pRequest.body[pRequest.DAL.defaultIdentifier] < 1)
 				{
 					return pRequest.CommonServices.sendError('Record update failure - a valid record ID is required in the passed-in record.', pRequest, pResponse, fNext);
 				}

package/source/crud/Meadow-Operation-Update.js

@@ -18,7 +18,7 @@ var doUpdate = function(pRecordToModify, pRequest, pResponse, fCallback, pOption
 	pRequest.MeadowOperation = (typeof(pRequest.MeadowOperation) === 'string') ? pRequest.MeadowOperation : 'Update';
 
 	// If there is not a default identifier or cached record, fail
-	if ((pRecordToModify[pRequest.DAL.defaultIdentifier] < 1) && (typeof(pOptionalCachedUpdatingRecord) === 'undefined'))
+	if ((!parseInt(pRecordToModify[pRequest.DAL.defaultIdentifier]) || pRecordToModify[pRequest.DAL.defaultIdentifier] < 1) && (typeof(pOptionalCachedUpdatingRecord) === 'undefined'))
 	{
 		return fCallback('Record update failure - a valid record ID is required in the passed-in record.');
 	}

package/test/MeadowEndpoints_basic_tests.js

@@ -961,6 +961,48 @@ suite
 					}
 				);
 				test
+				(
+					'update: update a record with a missing ID',
+					function(fDone)
+					{
+						// Update animal but don't provide ID
+						var tmpRecord = { Type:'Corgi' };
+						libSuperTest('http://localhost:9080/')
+						.del('1.0/FableTest')
+						.send(tmpRecord)
+						.end(
+							function(pError, pResponse)
+							{
+								// Expect response to be the count of deleted records.
+								var tmpResult = JSON.parse(pResponse.text);
+								Expect(tmpResult.Error).to.contain('a valid record ID is required');
+								fDone();
+							}
+						);
+					}
+				);
+				test
+				(
+					'update: update a record with a malformed ID',
+					function(fDone)
+					{
+						// Update animal but don't provide ID
+						var tmpRecord = { IDAnimal: { ID: 3 }, Type:'Corgi' };
+						libSuperTest('http://localhost:9080/')
+						.del('1.0/FableTest')
+						.send(tmpRecord)
+						.end(
+							function(pError, pResponse)
+							{
+								// Expect response to be the count of deleted records.
+								var tmpResult = JSON.parse(pResponse.text);
+								Expect(tmpResult.Error).to.contain('a valid record ID is required');
+								fDone();
+							}
+						);
+					}
+				);
+				test
 				(
 					'update: update a record',
 					function(fDone)
@@ -1006,7 +1048,28 @@ suite
 				);
 				test
 				(
-					'delete: delete a record with a bad parameter',
+					'delete: delete a record with a missing ID',
+					function(fDone)
+					{
+						// Delete animal but don't provide ID
+						var tmpRecord = { Type: 'Corgi' };
+						libSuperTest('http://localhost:9080/')
+						.del('1.0/FableTest')
+						.send(tmpRecord)
+						.end(
+							function(pError, pResponse)
+							{
+								// Expect response to be the count of deleted records.
+								var tmpResult = JSON.parse(pResponse.text);
+								Expect(tmpResult.Error).to.contain('a valid record ID is required');
+								fDone();
+							}
+						);
+					}
+				);
+				test
+				(
+					'delete: delete a record with a bad ID',
 					function(fDone)
 					{
 						// Delete animal 3 ("Red")