mcp-server-semgrep 1.0.0 → 1.0.1

package/CHANGELOG.md

@@ -0,0 +1,58 @@
+# Changelog
+
+All notable changes to this project are documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [1.0.1] - 2026-04-18
+
+### Security
+
+- **Fixed CWE-78 (OS Command Injection)** across all tool handlers in
+  `src/index.ts`. User-controlled paths and rule fields are no longer
+  interpolated into shell command strings. Reported by **BruceJin**
+  (`brucejin@zju.edu.cn`) — see [#12](https://github.com/VetCoders/mcp-server-semgrep/issues/12).
+- Replaced `child_process.exec()` with `child_process.execFile()` for every
+  external invocation (`semgrep`, `pip3`). Arguments are now passed as arrays
+  and never reach a shell.
+- Replaced shell `cat`/`echo > file` with `fs.promises.readFile` /
+  `fs.promises.writeFile` in `analyze_results`, `filter_results`,
+  `export_results`, `compare_results`, and `create_rule`.
+- Added defense-in-depth `validateNoShellMetacharacters` invoked from
+  `validateAbsolutePath`. Rejects `;`, `|`, `&`, backticks, `$()`, `<>`, `{}`,
+  `\`, `!`, `#`, `*`, `?`, `[`, `]`, quotes, `~`, and whitespace control
+  characters before any value reaches the filesystem layer.
+- Added structured validation for `create_rule`: `id`, `language`, `severity`
+  are matched against strict allowlists; `pattern` and `message` are
+  YAML-escaped via `JSON.stringify` to defeat YAML injection. (Originally
+  flagged by Gemini Code Assist on PR #14.)
+- Capped `semgrep` stdout buffer at 50 MiB and explicitly redact
+  `SEMGREP_APP_TOKEN` in command-line logs.
+
+### Changed
+
+- Bumped version to `1.0.1`.
+- Repository metadata now points at `VetCoders/mcp-server-semgrep`.
+- Removed unused `axios` runtime dependency.
+- Removed dead `src/config.ts` (was never imported by `src/index.ts`).
+- Replaced stale tests (`tests/handlers.test.ts`, `tests/utils.test.ts` —
+  imported modules that never existed) with `tests/security.test.ts`,
+  including CWE-78 regression coverage and validator unit tests.
+
+### Acknowledgements
+
+- **BruceJin** (`BruceJqs`) — original vulnerability discovery and detailed
+  CodeQL report.
+- **xyaz1313** ([PR #13](https://github.com/VetCoders/mcp-server-semgrep/pull/13))
+  and **karthikeyansundaram2**
+  ([PR #14](https://github.com/VetCoders/mcp-server-semgrep/pull/14)) —
+  independent fix proposals that informed the final patch.
+- **Gemini Code Assist** — flagged token leak regression and YAML injection
+  follow-ups in PR review.
+
+## [1.0.0] - 2025-03-20
+
+Initial public release. Now considered vulnerable — please upgrade to 1.0.1.
+
+VibeCrafted with AI Agents (c)2026 VetCoders

package/Dockerfile

@@ -1,22 +1,37 @@
-FROM node:18-slim
+FROM node:20-slim AS build
 
 WORKDIR /app
 
-# Instalacja zależności systemowych
-RUN apt-get update && apt-get install -y python3 python3-pip git
+COPY package.json package-lock.json ./
+RUN npm ci --omit=optional --ignore-scripts
 
-# Preinstalacja Semgrep z obejściem ograniczeń środowiska zarządzanego
-RUN pip3 install --break-system-packages semgrep
+COPY tsconfig.json ./
+COPY src ./src
+RUN npm run build
 
-# Kopiowanie plików projektu
-COPY . .
+FROM node:20-slim AS runtime
 
-# Instalacja zależności Node i budowanie projektu
-RUN npm install
-RUN npm run build
+ARG SEMGREP_VERSION=1.161.0
+ENV NODE_ENV=production
+ENV MCP_SERVER_SEMGREP_ALLOWED_ROOTS=/workspace:/app
+
+WORKDIR /app
+
+RUN apt-get update \
+  && apt-get install -y --no-install-recommends ca-certificates curl git \
+  && curl -LsSf https://astral.sh/uv/install.sh | UV_INSTALL_DIR="/usr/local/bin" sh \
+  && uv python install 3.12 \
+  && uv tool install --python 3.12 "semgrep==${SEMGREP_VERSION}" \
+  && ln -sf /root/.local/bin/semgrep /usr/local/bin/semgrep \
+  && semgrep --version \
+  && apt-get clean \
+  && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
+
+COPY package.json package-lock.json ./
+RUN npm ci --omit=dev --omit=optional --ignore-scripts \
+  && npm cache clean --force
 
-# Sprawdzenie instalacji Semgrep
-RUN semgrep --version
+COPY --from=build /app/build ./build
+RUN mkdir -p /workspace
 
-# Uruchomienie serwera
-CMD ["node", "build/index.js"]
+CMD ["node", "build/index.js"]

package/README.md

@@ -1,11 +1,12 @@
 # MCP Server Semgrep
-[![smithery badge](https://smithery.ai/badge/@Szowesgad/mcp-server-semgrep)](https://smithery.ai/server/@Szowesgad/mcp-server-semgrep)
+[![smithery badge](https://smithery.ai/badge/@VetCoders/mcp-server-semgrep)](https://smithery.ai/server/@VetCoders/mcp-server-semgrep)
+[![mcp-server-semgrep MCP server](https://glama.ai/mcp/servers/VetCoders/mcp-server-semgrep/badges/card.svg)](https://glama.ai/mcp/servers/VetCoders/mcp-server-semgrep)
 ### POWERED BY:
 [![POWERED BY](https://semgrep.dev/docs/img/semgrep-icon-text-horizontal.svg)](https://semgrep.dev)
 
 
 ## About the Project
-[![MCP Server Semgrep Logo](./logo.svg)](https://github.com/Szowesgad/mcp-server-semgrep)
+[![MCP Server Semgrep Logo](./logo.svg)](https://github.com/VetCoders/mcp-server-semgrep)
 This project was initially inspired by robustness of [Semgrep tool](https://semgrep.dev), [The Replit Team](https://github.com/replit) and their [Agent V2](https://replit.com), as well as the implementation by [stefanskiasan/semgrep-mcp-server](https://github.com/stefanskiasan/semgrep-mcp-server), but has evolved with significant architectural changes for enhanced and easier installation and maintenance.
 
 MCP Server Semgrep is a [Model Context Protocol](https://modelcontextprotocol.io) compliant server that integrates the powerful Semgrep static analysis tool with AI assistants like Anthropic Claude. It enables advanced code analysis, security vulnerability detection, and code quality improvements directly through a conversational interface.
@@ -80,9 +81,9 @@ Semgrep MCP Server provides the following tools:
 
 The easiest way to install and use MCP Server Semgrep is through Smithery.ai:
 
-1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@Szowesgad/mcp-server-semgrep)
+1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@VetCoders/mcp-server-semgrep)
 2. Follow the installation instructions to add it to your MCP-compatible clients
-3. Configure any optional settings like the Semgrep API token
+3. Configure any optional settings like the Semgrep API token and allowed workspace roots
 
 This is the recommended method for Claude Desktop and other MCP clients as it handles all dependencies and configuration automatically.
 
@@ -100,26 +101,26 @@ yarn global add mcp-server-semgrep
 ```
 
 The package is also available on other registries:
-- [MCP.so](https://mcp.so/@Szowesgad/mcp-server-semgrep)
+- [MCP.so](https://mcp.so/@VetCoders/mcp-server-semgrep)
 
 ### Option 3: Install from GitHub
 
 ```bash
 # Using npm
-npm install -g git+https://github.com/Szowesgad/mcp-server-semgrep.git
+npm install -g git+https://github.com/VetCoders/mcp-server-semgrep.git
 
 # Using pnpm
-pnpm add -g git+https://github.com/Szowesgad/mcp-server-semgrep.git
+pnpm add -g git+https://github.com/VetCoders/mcp-server-semgrep.git
 
 # Using yarn
-yarn global add git+https://github.com/Szowesgad/mcp-server-semgrep.git
+yarn global add git+https://github.com/VetCoders/mcp-server-semgrep.git
 ```
 
 ### Option 4: Local Development Setup
 
 1. Clone the repository:
 ```bash
-git clone https://github.com/Szowesgad/mcp-server-semgrep.git
+git clone https://github.com/VetCoders/mcp-server-semgrep.git
 cd mcp-server-semgrep
 ```
 
@@ -149,6 +150,22 @@ yarn build
 
 > **Note**: The installation process will automatically check for Semgrep availability. If Semgrep is not found, you'll receive instructions on how to install it.
 
+### Workspace Root Contract
+
+This server only reads and writes files inside explicitly allowed workspace roots.
+
+- By default, the allowed root is the process working directory (`process.cwd()`).
+- For Claude Desktop, Smithery, or any launcher that does not start the server inside your project root, set `MCP_SERVER_SEMGREP_ALLOWED_ROOTS` to one or more absolute directories.
+- Use your platform path delimiter for multiple roots: `:` on macOS/Linux, `;` on Windows.
+
+### Authentication Modes
+
+This server does not implement its own Semgrep account handling. It shells out to the installed `semgrep` CLI and relies on Semgrep's normal authentication behavior.
+
+- Local terminal and local development runs can often use an existing `semgrep login` session from the current OS account.
+- Managed launches such as Claude Desktop, Smithery, containers, or CI should prefer an explicit `SEMGREP_APP_TOKEN` for deterministic behavior.
+- `SEMGREP_APP_TOKEN` is still the safest option when you need portable configuration across machines or runners.
+
 ### Semgrep Installation Options
 
 Semgrep can be installed in several ways:
@@ -193,14 +210,16 @@ There are two ways to integrate MCP Server Semgrep with Claude Desktop:
 
 ### Method 1: Install via Smithery.ai (Recommended)
 
-1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@Szowesgad/mcp-server-semgrep)
+1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@VetCoders/mcp-server-semgrep)
 2. Click "Install in Claude Desktop"
 3. Follow the on-screen instructions
 
 ### Method 2: Manual Configuration
 
 1. Install Claude Desktop
-2. Update the Claude Desktop configuration file (`claude_desktop_config.json`) and add this to your servers section:
+2. Update the Claude Desktop configuration file (`claude_desktop_config.json`) and add this to your servers section.
+
+For local launches started under a user account that is already authenticated with `semgrep login`, the Semgrep CLI may be able to reuse that login. For desktop-managed or shared environments, we still recommend setting `SEMGREP_APP_TOKEN` explicitly:
 
 ```json
 {
@@ -210,22 +229,25 @@ There are two ways to integrate MCP Server Semgrep with Claude Desktop:
       "args": [
         "/your_path/mcp-server-semgrep/build/index.js"
       ],
-        "env": {
-          "SEMGREP_APP_TOKEN": "your_semgrep_app_token"
+      "env": {
+        "SEMGREP_APP_TOKEN": "your_semgrep_app_token",
+        "MCP_SERVER_SEMGREP_ALLOWED_ROOTS": "/Users/you/projects"
       }
     }
   }
 }
 ```
 
-3. Launch Claude Desktop and start asking questions about code analysis!
+3. Launch Claude Desktop and start asking questions about code analysis.
+
+If you want to scan more than one workspace, set `MCP_SERVER_SEMGREP_ALLOWED_ROOTS` to a platform-delimited list of absolute paths.
 
 ## Usage Examples
 
 ### Project Scanning
 
 ```
-Could you scan my source code in the /projects/my-application directory for potential security issues?
+Could you scan my source code in the /projects/my-application directory for potential security issues? That directory is already included in MCP_SERVER_SEMGREP_ALLOWED_ROOTS.
 ```
 
 ### Style Consistency Analysis
@@ -290,7 +312,6 @@ pnpm test
 
 ```
 ├── src/
-│   ├── config.ts         # Server configuration
 │   └── index.ts          # Main entry point and all handler implementations
 ├── scripts/
 │   └── check-semgrep.js  # Semgrep detection and installation helper

package/README_PL.md

@@ -78,7 +78,7 @@ MCP Server Semgrep zapewnia następujące narzędzia:
 
 1. Sklonuj repozytorium:
 ```bash
-git clone https://github.com/Szowesgad/mcp-server-semgrep.git
+git clone https://github.com/VetCoders/mcp-server-semgrep.git
 cd mcp-server-semgrep
 ```
 
@@ -89,6 +89,14 @@ pnpm install
 
 > **Uwaga**: Proces instalacji automatycznie sprawdzi dostępność Semgrep. Jeśli Semgrep nie zostanie znaleziony, otrzymasz instrukcje dotyczące jego instalacji.
 
+#### Kontrakt katalogów roboczych
+
+Serwer odczytuje i zapisuje pliki tylko wewnątrz jawnie dozwolonych katalogów roboczych.
+
+- Domyślnie dozwolonym katalogiem jest bieżący katalog procesu (`process.cwd()`).
+- Dla Claude Desktop, Smithery i innych launcherów, które nie uruchamiają serwera w katalogu projektu, ustaw `MCP_SERVER_SEMGREP_ALLOWED_ROOTS` na jedną lub więcej ścieżek absolutnych.
+- Dla wielu katalogów użyj separatora właściwego dla platformy: `:` na macOS/Linux, `;` na Windows.
+
 #### Opcje instalacji Semgrep
 
 Semgrep można zainstalować na kilka sposobów:
@@ -125,7 +133,7 @@ pnpm run build
 Aby zintegrować MCP Server Semgrep z Claude Desktop:
 
 1. Zainstaluj Claude Desktop
-2. Zaktualizuj plik konfiguracyjny Claude Desktop (`claude_desktop_config.json`) i dodaj poniższy wpis. Zalecane jest dodanie SEMGREP_APP_TOKEN:
+2. Zaktualizuj plik konfiguracyjny Claude Desktop (`claude_desktop_config.json`) i dodaj poniższy wpis. Zalecane jest dodanie `SEMGREP_APP_TOKEN` oraz `MCP_SERVER_SEMGREP_ALLOWED_ROOTS`:
 
 ```json
 {
@@ -135,22 +143,23 @@ Aby zintegrować MCP Server Semgrep z Claude Desktop:
       "args": [
         "/twoja_ścieżka/mcp-server-semgrep/build/index.js"
       ],
-        "env": {
-          "SEMGREP_APP_TOKEN": "twój_token_semgrep"
+      "env": {
+        "SEMGREP_APP_TOKEN": "twój_token_semgrep",
+        "MCP_SERVER_SEMGREP_ALLOWED_ROOTS": "/Users/you/projects"
       }
     }
   }
 }
 ```
 
-3. Uruchom Claude Desktop i zacznij zadawać pytania dotyczące analizy kodu!
+3. Uruchom Claude Desktop i zacznij zadawać pytania dotyczące analizy kodu.
 
 ## Przykłady użycia
 
 ### Skanowanie projektu
 
 ```
-Mógłbyś przeskanować mój kod źródłowy w katalogu /projekty/moja-aplikacja pod kątem potencjalnych problemów bezpieczeństwa?
+Mógłbyś przeskanować mój kod źródłowy w katalogu /projekty/moja-aplikacja pod kątem potencjalnych problemów bezpieczeństwa? Ten katalog jest już uwzględniony w MCP_SERVER_SEMGREP_ALLOWED_ROOTS.
 ```
 
 ### Analiza spójności stylu
@@ -215,7 +224,6 @@ pnpm test
 
 ```
 ├── src/
-│   ├── config.ts         # Konfiguracja serwera
 │   └── index.ts          # Główny punkt wejścia i wszystkie implementacje handlerów
 ├── scripts/
 │   └── check-semgrep.js  # Helper do wykrywania i instalacji Semgrep

package/SECURITY.md

@@ -0,0 +1,44 @@
+# Security Policy
+
+## Supported Versions
+
+| Version | Supported |
+|---------|-----------|
+| 1.0.1   | ✅ |
+| 1.0.0   | ❌ (CVE candidate — see CHANGELOG) |
+| < 1.0.0 | ❌ |
+
+## Reporting a Vulnerability
+
+We appreciate responsible disclosure. Please report security issues privately
+through one of the following channels:
+
+- **GitHub Security Advisory** (preferred):
+  <https://github.com/VetCoders/mcp-server-semgrep/security/advisories/new>
+- Email: `void@div0.space`
+
+Please include:
+- A clear description of the issue
+- Steps to reproduce (PoC welcome, defanged if possible)
+- Affected version(s)
+- Suggested remediation, if you have one
+
+We will acknowledge within 72 hours and aim to ship a fix within 14 days for
+critical issues. We credit reporters in the changelog and (if you wish) in any
+GHSA we publish.
+
+## Hardening notes for operators
+
+- This server is intended for **local-first** use over `stdio`. Do not expose
+  the MCP transport to untrusted networks without an authenticated proxy in
+  front.
+- All path arguments are restricted to the configured workspace roots. By
+  default this is `process.cwd()`. For desktop launchers and remote-managed
+  installs, set `MCP_SERVER_SEMGREP_ALLOWED_ROOTS` to the smallest set of
+  absolute directories the assistant should touch.
+- `SEMGREP_APP_TOKEN`, when set, is forwarded to `semgrep` via `--oauth-token`
+  using `child_process.execFile` (no shell) and is **redacted** in stderr
+  logs. Treat the token as a secret and rotate it on suspected exposure.
+- The container image installs `semgrep` at build time (`pip3 install
+  --break-system-packages`). When running in production, prefer a pinned
+  semgrep version and rebuild on upstream advisories.

package/USAGE.md

@@ -10,7 +10,7 @@ First, make sure you have Node.js (v18+) installed. The server offers multiple w
 
 The simplest way to install and use MCP Server Semgrep is directly through Smithery.ai:
 
-1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@Szowesgad/mcp-server-semgrep)
+1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@VetCoders/mcp-server-semgrep)
 2. Click the "Install" button for your preferred MCP client
 3. Follow the on-screen instructions to complete the installation
 
@@ -33,7 +33,7 @@ yarn global add mcp-server-semgrep
 
 ```bash
 # Install directly from GitHub repository
-npm install -g git+https://github.com/Szowesgad/mcp-server-semgrep.git
+npm install -g git+https://github.com/VetCoders/mcp-server-semgrep.git
 ```
 
 ### Semgrep Installation Options:
@@ -64,6 +64,14 @@ pip install semgrep
 
 The server will automatically detect your Semgrep installation regardless of how it was installed, and will provide helpful guidance if it's missing.
 
+## Workspace Roots
+
+The server only accepts absolute paths that live inside an allowed workspace root.
+
+- Default behavior: use `process.cwd()` as the only allowed root.
+- Recommended for desktop clients and managed launchers: set `MCP_SERVER_SEMGREP_ALLOWED_ROOTS` to one or more absolute directories.
+- Multiple roots use your platform delimiter: `:` on macOS/Linux, `;` on Windows.
+
 ## Running the Server
 
 ```bash
@@ -118,7 +126,7 @@ The integration enhances developer experience through:
 In Claude Desktop, you might ask:
 
 ```
-Could you scan my project directory at /path/to/code for security vulnerabilities?
+Could you scan my project directory at /path/to/code for security vulnerabilities? That directory is already covered by MCP_SERVER_SEMGREP_ALLOWED_ROOTS.
 ```
 
 Behind the scenes, the MCP server handles requests like:
@@ -369,7 +377,7 @@ There are two ways to integrate with Claude Desktop:
 
 ### Method 1: Install via Smithery.ai (Recommended)
 
-1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@Szowesgad/mcp-server-semgrep)
+1. Visit [MCP Server Semgrep on Smithery.ai](https://smithery.ai/server/@VetCoders/mcp-server-semgrep)
 2. Click "Install in Claude Desktop"
 3. Follow the on-screen instructions to complete the setup
 4. Launch Claude Desktop and the server will be available automatically
@@ -453,4 +461,4 @@ For maximum benefit:
 - Create team-specific rulesets
 - Regular reviews and updates of rules
 - Share and celebrate improvements over time
-- Use humor (like our example rules) to make the process enjoyable
+- Use humor (like our example rules) to make the process enjoyable