mcp-jvm-diagnostics 0.1.6 → 0.1.7

package/build/analyzers/gc-pressure.js

@@ -26,7 +26,16 @@ export function analyzeGcPressure(log) {
     result.maxPauseMs = pauses[pauses.length - 1];
     result.totalPauseMs = pauses.reduce((a, b) => a + b, 0);
     result.avgPauseMs = result.totalPauseMs / pauses.length;
-    result.p95PauseMs = pauses[Math.floor(pauses.length * 0.95)] || result.maxPauseMs;
+    // Linear interpolation for P95: Math.floor(n * 0.95) returns index n-1 whenever
+    // n <= 20, making P95 equal the max. Using (n-1) * 0.95 as the fractional index
+    // and interpolating between adjacent elements gives accurate results at all sizes.
+    const p95Idx = (pauses.length - 1) * 0.95;
+    const p95Lo = Math.floor(p95Idx);
+    const p95Hi = Math.ceil(p95Idx);
+    result.p95PauseMs =
+        p95Lo === p95Hi
+            ? pauses[p95Lo]
+            : pauses[p95Lo] + (pauses[p95Hi] - pauses[p95Lo]) * (p95Idx - p95Lo);
     // GC overhead
     if (log.timeSpanMs > 0) {
         result.gcOverheadPct = (result.totalPauseMs / log.timeSpanMs) * 100;
@@ -70,8 +79,10 @@ function detectIssues(log, result) {
             result.issues.push(`Heap after GC is growing over time (${avgFirst.toFixed(0)}MB → ${avgSecond.toFixed(0)}MB) — possible memory leak.`);
         }
     }
-    // Low reclaim ratio
-    if (result.heapBeforeMb > 0 && result.heapAfterMb > 0) {
+    // Low reclaim ratio — only meaningful when heap actually shrank after GC.
+    // Guard heapAfterMb < heapBeforeMb to avoid a negative reclaim percentage when
+    // averaged heap-after exceeds heap-before (e.g. growing heap events skewing averages).
+    if (result.heapBeforeMb > 0 && result.heapAfterMb > 0 && result.heapAfterMb < result.heapBeforeMb) {
         const reclaimPct = ((result.heapBeforeMb - result.heapAfterMb) / result.heapBeforeMb) * 100;
         if (reclaimPct < 10) {
             result.issues.push(`GC reclaims only ${reclaimPct.toFixed(0)}% of heap per collection — most objects survive. Heap may be too small or there's a memory leak.`);
@@ -97,8 +108,8 @@ function generateRecommendations(log, result) {
     if (fullGcCount > 3) {
         result.recommendations.push("Frequent Full GCs indicate heap pressure. Increase -Xmx or tune -XX:InitiatingHeapOccupancyPercent (G1) to start concurrent marking earlier.");
     }
-    // Low reclaim → check for leaks
-    if (result.heapBeforeMb > 0) {
+    // Low reclaim → check for leaks (same guard as detectIssues: skip when averages are inverted)
+    if (result.heapBeforeMb > 0 && result.heapAfterMb < result.heapBeforeMb) {
         const reclaimPct = ((result.heapBeforeMb - result.heapAfterMb) / result.heapBeforeMb) * 100;
         if (reclaimPct < 10) {
             result.recommendations.push("Very low reclaim ratio suggests most objects are long-lived. Take a heap dump and analyze with Eclipse MAT or jmap -histo to identify memory leaks.");

package/build/index.js

@@ -13,7 +13,7 @@ import { parseJfrSummary } from "./parsers/jfr-summary.js";
 import { generateReportFromThreadDump, analyzeThreadDumpMarkdown, } from "./reporting.js";
 // Handle --help
 if (process.argv.includes("--help") || process.argv.includes("-h")) {
-    console.log(`mcp-jvm-diagnostics v0.1.6 — MCP server for JVM diagnostics
+    console.log(`mcp-jvm-diagnostics v0.1.7 — MCP server for JVM diagnostics
 
 Usage:
   mcp-jvm-diagnostics [options]
@@ -33,7 +33,7 @@ Tools provided:
 }
 const server = new McpServer({
     name: "mcp-jvm-diagnostics",
-    version: "0.1.6",
+    version: "0.1.7",
 });
 // --- Tool: analyze_thread_dump ---
 server.tool("analyze_thread_dump", "Parse a JVM thread dump (jstack output) and analyze thread states, detect deadlocks, identify lock contention hotspots, and find thread starvation patterns. Handles both platform threads and virtual threads (Java 21+).", {
@@ -282,10 +282,10 @@ function formatBytes(bytes) {
     return `${sign}${abs} B`;
 }
 // --- Tool: analyze_jfr ---
-server.tool("analyze_jfr", "Parse JDK Flight Recorder summary output (from `jfr summary <file>`) and analyze event distribution, detect performance hotspots, GC pressure, lock contention, I/O patterns, and excessive allocations.", {
+server.tool("analyze_jfr", "Parse JDK Flight Recorder summary output and analyze event distribution, detect performance hotspots, GC pressure, lock contention, I/O patterns, and excessive allocations. Input must be the text printed to stdout by `jfr summary <recording.jfr>` — not the binary .jfr file itself.", {
     jfr_summary: z
         .string()
-        .describe("The output text from `jfr summary <recording.jfr>`"),
+        .describe("The stdout text from running `jfr summary <recording.jfr>` (a text table of event types, counts, and sizes — not the binary .jfr file)"),
 }, async ({ jfr_summary }) => {
     try {
         const summary = parseJfrSummary(jfr_summary);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mcp-jvm-diagnostics",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "MCP server for JVM diagnostics — analyze thread dumps, detect deadlocks, parse GC logs, and get JVM tuning recommendations",
   "mcpName": "io.github.dmitriusan/mcp-jvm-diagnostics",
   "author": "Dmytro Lisnichenko",
@@ -53,7 +53,7 @@
     "url": "https://github.com/Dmitriusan/mcp-jvm-diagnostics/issues"
   },
   "dependencies": {
-    "@mcp-java-suite/license": "file:../../mcp-suite-license/mcp-suite-license",
+    "@mcp-java-suite/license": "npm:mcp-java-suite-license@^0.1.0",
     "@modelcontextprotocol/sdk": "^1.27.1",
     "zod": "^3.24.2"
   },