mcp-google-ads 1.0.7 → 1.0.9

package/dist/build-info.json

@@ -1 +1 @@
-{"sha":"3490598","builtAt":"2026-04-09T21:18:29.192Z"}
+{"sha":"ac23879","builtAt":"2026-04-09T21:37:02.993Z"}

package/dist/index.js

@@ -8,31 +8,36 @@ import { CallToolRequestSchema, ListToolsRequestSchema, } from "@modelcontextpro
 import { tools } from "./tools.js";
 import { GoogleAdsApi, enums } from "google-ads-api";
 import { readFileSync, existsSync } from "fs";
+// CLI package info
+const __cliPkg = JSON.parse(readFileSync(join(dirname(new URL(import.meta.url).pathname), "..", "package.json"), "utf-8"));
 // Log build fingerprint at startup
 try {
     const __buildInfoDir = dirname(new URL(import.meta.url).pathname);
     const buildInfo = JSON.parse(readFileSync(join(__buildInfoDir, "build-info.json"), "utf-8"));
-    logger.info({ sha: buildInfo.sha, builtAt: buildInfo.builtAt }, "Build fingerprint");
+    console.error(`[build] SHA: ${buildInfo.sha} (${buildInfo.builtAt})`);
 }
 catch {
-    // build-info.json not present (dev mode)
+    console.error(`[build] ${__cliPkg.name}@${__cliPkg.version} (dev mode)`);
 }
 // CLI flags
-const __cliPkg = JSON.parse(readFileSync(join(dirname(new URL(import.meta.url).pathname), "..", "package.json"), "utf-8"));
 if (process.argv.includes("--help") || process.argv.includes("-h")) {
-    console.log(`${__cliPkg.name} v${__cliPkg.version}\n`);
-    console.log(`Usage: ${__cliPkg.name} [options]\n`);
-    console.log("MCP server communicating via stdio. Configure in your .mcp.json.\n");
-    console.log("Options:");
-    console.log("  --help, -h       Show this help message");
-    console.log("  --version, -v    Show version number");
-    console.log(`\nDocumentation: https://github.com/mharnett/mcp-google-ads`);
+    console.error(`${__cliPkg.name} v${__cliPkg.version}\n`);
+    console.error(`Usage: ${__cliPkg.name} [options]\n`);
+    console.error("MCP server communicating via stdio. Configure in your .mcp.json.\n");
+    console.error("Options:");
+    console.error("  --help, -h       Show this help message");
+    console.error("  --version, -v    Show version number");
+    console.error(`\nDocumentation: https://github.com/mharnett/mcp-google-ads`);
     process.exit(0);
 }
 if (process.argv.includes("--version") || process.argv.includes("-v")) {
-    console.log(__cliPkg.version);
+    console.error(__cliPkg.version);
     process.exit(0);
 }
+// ============================================
+// ENV VAR TRIMMING
+// ============================================
+const envTrimmed = (key) => (process.env[key] || "").trim().replace(/^["']|["']$/g, "");
 function loadConfig() {
     // Try config.json first (for multi-client setups)
     const configPath = join(dirname(new URL(import.meta.url).pathname), "..", "config.json");
@@ -40,12 +45,12 @@ function loadConfig() {
         return JSON.parse(readFileSync(configPath, "utf-8"));
     }
     // Fall back to env vars (single-client mode)
-    const clientId = process.env.GOOGLE_ADS_CLIENT_ID;
-    const clientSecret = process.env.GOOGLE_ADS_CLIENT_SECRET;
-    const developerToken = process.env.GOOGLE_ADS_DEVELOPER_TOKEN;
-    const refreshToken = process.env.GOOGLE_ADS_REFRESH_TOKEN;
-    const customerId = process.env.GOOGLE_ADS_CUSTOMER_ID;
-    const mccId = process.env.GOOGLE_ADS_MCC_CUSTOMER_ID;
+    const clientId = envTrimmed("GOOGLE_ADS_CLIENT_ID");
+    const clientSecret = envTrimmed("GOOGLE_ADS_CLIENT_SECRET");
+    const developerToken = envTrimmed("GOOGLE_ADS_DEVELOPER_TOKEN");
+    const refreshToken = envTrimmed("GOOGLE_ADS_REFRESH_TOKEN");
+    const customerId = envTrimmed("GOOGLE_ADS_CUSTOMER_ID");
+    const mccId = envTrimmed("GOOGLE_ADS_MCC_CUSTOMER_ID");
     if (!clientId || !clientSecret || !developerToken || !refreshToken) {
         throw new Error("No configuration found. Either:\n" +
             "  1. Set env vars: GOOGLE_ADS_CLIENT_ID, GOOGLE_ADS_CLIENT_SECRET, GOOGLE_ADS_DEVELOPER_TOKEN, GOOGLE_ADS_REFRESH_TOKEN, GOOGLE_ADS_CUSTOMER_ID\n" +
@@ -112,11 +117,11 @@ class GoogleAdsManager {
             throw new GoogleAdsAuthError(msg);
         }
         logger.info("Credentials validated: all required env vars present");
-        this.defaultRefreshToken = process.env.GOOGLE_ADS_REFRESH_TOKEN;
+        this.defaultRefreshToken = envTrimmed("GOOGLE_ADS_REFRESH_TOKEN");
         this.api = new GoogleAdsApi({
-            client_id: process.env.GOOGLE_ADS_CLIENT_ID,
-            client_secret: process.env.GOOGLE_ADS_CLIENT_SECRET,
-            developer_token: process.env.GOOGLE_ADS_DEVELOPER_TOKEN,
+            client_id: envTrimmed("GOOGLE_ADS_CLIENT_ID"),
+            client_secret: envTrimmed("GOOGLE_ADS_CLIENT_SECRET"),
+            developer_token: envTrimmed("GOOGLE_ADS_DEVELOPER_TOKEN"),
         });
     }
     getClientForCustomerId(customerId) {
@@ -1814,4 +1819,10 @@ process.on("SIGINT", () => {
     console.error("[shutdown] SIGINT received, exiting");
     process.exit(0);
 });
+process.on("SIGPIPE", () => {
+    // Client disconnected -- expected during shutdown
+});
+process.on("unhandledRejection", (reason) => {
+    console.error("[error] Unhandled promise rejection:", reason);
+});
 main().catch((err) => logger.error({ error: err.message, stack: err.stack }, "Fatal startup error"));

package/dist/resilience.js

@@ -5,17 +5,20 @@ import pino from "pino";
 // ============================================
 export const logger = pino({
     level: process.env.LOG_LEVEL || "info",
-    ...(process.env.NODE_ENV !== "test" && {
+    ...(process.env.NODE_ENV !== "test" && process.stderr.isTTY && {
         transport: {
             target: "pino-pretty",
             options: {
                 colorize: true,
                 singleLine: true,
                 translateTime: "SYS:standard",
+                destination: 2, // stderr -- stdout is reserved for MCP JSON-RPC
             },
         },
     }),
-});
+}, 
+// When no transport (test mode), write to stderr directly
+process.env.NODE_ENV === "test" ? pino.destination(2) : undefined);
 // ============================================
 // SAFE RESPONSE (Response Size Limiting)
 // ============================================

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "mcp-google-ads",
   "mcpName": "io.github.mharnett/google-ads",
-  "version": "1.0.7",
+  "version": "1.0.9",
   "description": "MCP server for Google Ads API with MCC support, 35 tools for campaign management, reporting, and optimization. Safe by default — all changes created PAUSED.",
   "main": "dist/index.js",
   "bin": {
@@ -53,7 +53,7 @@
   },
   "homepage": "https://github.com/mharnett/mcp-google-ads#readme",
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.18.0"
   },
   "dependencies": {
     "@anthropic-ai/sdk": "^0.24.0",