mcp-db-analyzer 0.2.5 → 0.2.6

package/build/analyzers/query.js

@@ -10,7 +10,9 @@ export async function explainQuery(sql, analyze = false) {
     // EXPLAIN ANALYZE actually executes the query, so we must reject anything
     // that could modify data — including CTEs with write operations.
     if (analyze) {
-        const upperSql = sql.trim().toUpperCase();
+        // Strip single-quoted string literals before scanning for DML keywords so that
+        // a query like `SELECT ... WHERE status = 'DELETE me'` is not falsely rejected.
+        const upperSql = sql.trim().toUpperCase().replace(/'[^']*'/g, "''");
         const DML_KEYWORDS = ["INSERT", "UPDATE", "DELETE", "DROP", "ALTER", "TRUNCATE", "CREATE", "GRANT", "REVOKE", "COPY"];
         const containsDml = DML_KEYWORDS.some((kw) => upperSql.includes(kw + " ") || upperSql.includes(kw + "\n") || upperSql.includes(kw + "\t") || upperSql.endsWith(kw));
         if (containsDml) {

package/build/analyzers/schema.js

@@ -187,13 +187,16 @@ export async function inspectTable(tableName, schema = "public") {
     return lines.join("\n");
 }
 async function inspectTableSqlite(tableName) {
-    const cols = await query(`PRAGMA table_info("${tableName}")`);
+    // Escape double-quote characters so a table name containing `"` (e.g. `weird"table`)
+    // does not break the PRAGMA queries or the row-count SELECT.
+    const escaped = tableName.replace(/"/g, '""');
+    const cols = await query(`PRAGMA table_info("${escaped}")`);
     if (cols.rows.length === 0) {
         return `Table '${tableName}' not found.`;
     }
     const lines = [`## Table: main.${tableName}\n`];
     // Row count
-    const countResult = await query(`SELECT count(*) as cnt FROM "${tableName}"`);
+    const countResult = await query(`SELECT count(*) as cnt FROM "${escaped}"`);
     lines.push(`- **Rows**: ${countResult.rows[0]?.cnt ?? 0}`);
     lines.push("");
     lines.push("### Columns\n");
@@ -203,7 +206,7 @@ async function inspectTableSqlite(tableName) {
         lines.push(`| ${col.cid + 1} | ${col.name} | ${col.type || 'ANY'} | ${col.notnull ? 'NO' : 'YES'} | ${col.dflt_value ?? '-'} | ${col.pk ? 'YES' : '-'} |`);
     }
     // Foreign keys
-    const fks = await query(`PRAGMA foreign_key_list("${tableName}")`);
+    const fks = await query(`PRAGMA foreign_key_list("${escaped}")`);
     if (fks.rows.length > 0) {
         lines.push("\n### Foreign Keys\n");
         lines.push("| Column | References |");
@@ -213,13 +216,13 @@ async function inspectTableSqlite(tableName) {
         }
     }
     // Indexes
-    const indexes = await query(`PRAGMA index_list("${tableName}")`);
+    const indexes = await query(`PRAGMA index_list("${escaped}")`);
     if (indexes.rows.length > 0) {
         lines.push("\n### Indexes\n");
         lines.push("| Name | Unique | Columns |");
         lines.push("|------|--------|---------|");
         for (const idx of indexes.rows) {
-            const idxCols = await query(`PRAGMA index_info("${idx.name}")`);
+            const idxCols = await query(`PRAGMA index_info("${idx.name.replace(/"/g, '""')}")`);
             const colNames = idxCols.rows.map(c => c.name).join(", ");
             lines.push(`| ${idx.name} | ${idx.unique ? 'YES' : 'NO'} | ${colNames} |`);
         }

package/build/analyzers/slow-queries.js

@@ -119,6 +119,20 @@ async function analyzeMysqlSlowQueries(limit) {
             const truncated = r.DIGEST_TEXT.length > 80 ? r.DIGEST_TEXT.slice(0, 77) + "..." : r.DIGEST_TEXT;
             sections.push(`| ${i + 1} | ${r.AVG_TIMER_WAIT.toFixed(1)}ms | ${r.SUM_TIMER_WAIT.toFixed(0)}ms | ${r.COUNT_STAR} | \`${truncated.replace(/\|/g, "\\|")}\` |`);
         }
+        // Recommendations
+        sections.push("");
+        sections.push("### Recommendations");
+        const highCallSlow = result.rows.filter((r) => r.COUNT_STAR > 100 && r.AVG_TIMER_WAIT > 100);
+        if (highCallSlow.length > 0) {
+            sections.push(`- **${highCallSlow.length} high-impact queries** — called >100 times with >100ms avg. Prioritize these for optimization.`);
+        }
+        const fewRowsSlow = result.rows.filter((r) => r.AVG_TIMER_WAIT > 50 && r.SUM_ROWS_SENT / Math.max(r.COUNT_STAR, 1) < 10);
+        if (fewRowsSlow.length > 0) {
+            sections.push(`- **${fewRowsSlow.length} queries returning few rows but slow** — likely missing indexes. Use \`explain_query\` to check.`);
+        }
+        if (highCallSlow.length === 0 && fewRowsSlow.length === 0) {
+            sections.push("- No critical patterns detected. Monitor trends over time.");
+        }
         return sections.join("\n");
     }
     catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mcp-db-analyzer",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "description": "MCP server for PostgreSQL, MySQL, and SQLite schema analysis, index optimization, and query plan inspection",
   "mcpName": "io.github.dmitriusan/mcp-db-analyzer",
   "author": "Dmytro Lisnichenko",