mcp-agents-memory 0.9.23 → 0.9.24

package/build/index.js

@@ -57524,6 +57524,51 @@ init_users();
 // src/cold_path/project_alias_promoter.ts
 init_db();
 init_users();
+
+// src/cold_path/alias_reject_gate.ts
+function pairKey(a, b) {
+  return a < b ? `${a}:${b}` : `${b}:${a}`;
+}
+function groupPairHistory(rows) {
+  const out = /* @__PURE__ */ new Map();
+  for (const r of rows) {
+    if (r.sourceId === r.targetId) continue;
+    const k = pairKey(r.sourceId, r.targetId);
+    const list = out.get(k);
+    if (list) list.push(r);
+    else out.set(k, [r]);
+  }
+  return out;
+}
+var isUserRejection = (r) => r.status === "rejected" && r.decidedBy === "user";
+function userRejectedDirection(rows, sourceId, targetId) {
+  let hit = null;
+  for (const r of rows ?? []) {
+    if (!isUserRejection(r) || r.sourceId !== sourceId || r.targetId !== targetId) continue;
+    if (!hit || r.decidedAt.getTime() > hit.decidedAt.getTime()) hit = r;
+  }
+  return hit ? hit.id : null;
+}
+function skipBeforeJudge(rows) {
+  const all = rows ?? [];
+  const rejections = all.filter(isUserRejection);
+  if (rejections.length === 0) return false;
+  const { sourceId: a, targetId: b } = rejections[0];
+  if (userRejectedDirection(all, a, b) !== null && userRejectedDirection(all, b, a) !== null) return true;
+  const lastRejection = Math.max(...rejections.map((r) => r.decidedAt.getTime()));
+  return all.some((r) => !isUserRejection(r) && r.createdAt.getTime() > lastRejection);
+}
+function repeatsToSweep(rows) {
+  const out = [];
+  for (const r of rows ?? []) {
+    if (r.status !== "pending" || r.manual) continue;
+    const rejectedId = userRejectedDirection(rows, r.sourceId, r.targetId);
+    if (rejectedId !== null) out.push({ pendingId: r.id, rejectedId });
+  }
+  return out;
+}
+
+// src/cold_path/project_alias_promoter.ts
 var QUALIFYING_RELATIONS = /* @__PURE__ */ new Set([
   "rename",
   "alias",
@@ -57675,9 +57720,6 @@ function nameSimilarity(a, b) {
   const dice = bigramDice(a, b);
   return Math.max(tokenScore, dice);
 }
-function pairKey(a, b) {
-  return a < b ? `${a}:${b}` : `${b}:${a}`;
-}
 function uniqueSortedNumbers(values) {
   return Array.from(new Set(values)).sort((a, b) => a - b);
 }
@@ -58025,7 +58067,7 @@ async function addVectorCandidates(userId, tags, tagsById, pairs) {
     }
   }
 }
-async function buildCandidatePairs(userId, tags, limit2) {
+async function buildCandidatePairs(userId, tags, limit2, exclude = () => false) {
   const tagsById = new Map(tags.map((tag) => [tag.id, tag]));
   const pairs = /* @__PURE__ */ new Map();
   await addExplicitStatementCandidates(userId, tags, tagsById, pairs);
@@ -58040,7 +58082,7 @@ async function buildCandidatePairs(userId, tags, limit2) {
       pair.signals.candidate_sources = Array.from(pair.sources);
     }
   }
-  return Array.from(pairs.values()).sort((a, b) => {
+  return Array.from(pairs.values()).filter((pair) => !exclude(pair)).sort((a, b) => {
     const aExplicit = a.sources.has("explicit_user_statement") ? 1 : 0;
     const bExplicit = b.sources.has("explicit_user_statement") ? 1 : 0;
     if (aExplicit !== bExplicit) return bExplicit - aExplicit;
@@ -58170,10 +58212,8 @@ async function computeAutoApplyEligible(userId, sourceId, targetId, pair, judgme
   if (await hasRecentRejectedPair(userId, sourceId, targetId)) return false;
   return true;
 }
-async function upsertSuggestion(userId, sourceId, targetId, pair, judgment, autoApplyEligible) {
-  const spec = ROLE_REGISTRY.project_alias_judge;
-  const candidateSources = Array.from(pair.sources);
-  const signals = {
+function aliasSignals(pair, judgment, sourceId, targetId) {
+  return {
     ...pair.signals,
     llm: {
       relation: judgment.relation,
@@ -58184,6 +58224,11 @@ async function upsertSuggestion(userId, sourceId, targetId, pair, judgment, auto
       direction_reversed_from_candidate: sourceId !== pair.sourceId || targetId !== pair.targetId
     }
   };
+}
+async function upsertSuggestion(userId, sourceId, targetId, pair, judgment, autoApplyEligible) {
+  const spec = ROLE_REGISTRY.project_alias_judge;
+  const candidateSources = Array.from(pair.sources);
+  const signals = aliasSignals(pair, judgment, sourceId, targetId);
   const result = await db.query(
     `INSERT INTO project_tag_alias_suggestions (
        user_id,
@@ -58245,6 +58290,97 @@ async function upsertSuggestion(userId, sourceId, targetId, pair, judgment, auto
   );
   return Number(result.rows[0].id);
 }
+async function loadPairHistory(userId, onlyPair) {
+  const result = await db.query(
+    `SELECT id, source_root, target_root, status, decided_by, decided, created_at, manual
+       FROM (SELECT id,
+                    canonical_project_tag_id(source_tag_id) AS source_root,
+                    canonical_project_tag_id(target_tag_id) AS target_root,
+                    status,
+                    decided_by,
+                    COALESCE(decided_at, updated_at, created_at) AS decided,
+                    created_at,
+                    'manual_set_alias' = ANY(candidate_sources) AS manual
+               FROM project_tag_alias_suggestions
+              WHERE user_id = $1) h
+      WHERE $2::bigint IS NULL
+         OR (LEAST(source_root, target_root) = LEAST($2::bigint, $3::bigint)
+             AND GREATEST(source_root, target_root) = GREATEST($2::bigint, $3::bigint))`,
+    [userId, onlyPair?.[0] ?? null, onlyPair?.[1] ?? null]
+  );
+  return groupPairHistory(
+    result.rows.filter((row) => row.source_root !== null && row.target_root !== null).map((row) => ({
+      id: Number(row.id),
+      sourceId: Number(row.source_root),
+      targetId: Number(row.target_root),
+      status: String(row.status),
+      decidedBy: row.decided_by === null ? null : String(row.decided_by),
+      decidedAt: toDate(row.decided),
+      createdAt: toDate(row.created_at),
+      manual: row.manual === true
+    }))
+  );
+}
+async function sweepRepeatedRejections(history) {
+  let swept = 0;
+  let errors = 0;
+  for (const rows of history.values()) {
+    for (const { pendingId, rejectedId } of repeatsToSweep(rows)) {
+      try {
+        const result = await db.query(
+          `UPDATE project_tag_alias_suggestions
+              SET status = 'rejected',
+                  decided_by = 'system',
+                  decision_reason = $2,
+                  signals = signals || jsonb_build_object('repeat_of_suggestion_id', $3::bigint),
+                  decided_at = NOW(),
+                  updated_at = NOW()
+            WHERE id = $1
+              AND status = 'pending'
+              AND NOT ('manual_set_alias' = ANY(candidate_sources))`,
+          [pendingId, `repeat of suggestion #${rejectedId} rejected by the user`, rejectedId]
+        );
+        swept += result.rowCount ?? 0;
+      } catch (err3) {
+        errors++;
+        console.error(`[ProjectAliasPromoter] sweep of suggestion ${pendingId} failed:`, err3);
+      }
+    }
+  }
+  return { swept, errors };
+}
+async function recordRepeatOfRejected(userId, sourceId, targetId, pair, judgment, rejectedId) {
+  const spec = ROLE_REGISTRY.project_alias_judge;
+  await db.query(
+    `INSERT INTO project_tag_alias_suggestions (
+       user_id, source_tag_id, target_tag_id, relation, status, confidence,
+       candidate_sources, evidence_memory_ids, conflict_memory_ids, signals,
+       model_provider, model_name, rationale, auto_apply_eligible,
+       decided_by, decision_reason, decided_at
+     )
+     VALUES (
+       $1, $2, $3, $4, 'rejected', $5,
+       $6::text[], $7::bigint[], $8::bigint[], $9::jsonb,
+       $10, $11, $12, FALSE,
+       'system', $13, NOW()
+     )`,
+    [
+      userId,
+      sourceId,
+      targetId,
+      judgment.relation,
+      Number(judgment.confidence.toFixed(4)),
+      Array.from(pair.sources),
+      judgment.evidence_memory_ids,
+      judgment.conflict_memory_ids,
+      JSON.stringify({ ...aliasSignals(pair, judgment, sourceId, targetId), repeat_of_suggestion_id: rejectedId }),
+      spec.provider,
+      spec.model_name,
+      truncate(judgment.rationale, 4e3),
+      `repeat of suggestion #${rejectedId} rejected by the user`
+    ]
+  );
+}
 function qualifiesForPending(judgment, minConfidence) {
   return QUALIFYING_RELATIONS.has(judgment.relation) && judgment.same_project && judgment.confidence >= minConfidence;
 }
@@ -58259,12 +58395,23 @@ async function runProjectAliasPromoter(opts = {}) {
     inserted: 0,
     autoApplied: 0,
     skipped: 0,
-    errors: 0
+    errors: 0,
+    blockedBeforeJudge: 0,
+    blockedAfterJudge: 0,
+    swept: 0
   };
+  const history = await loadPairHistory(userId);
+  const sweep = await sweepRepeatedRejections(history);
+  summary.swept = sweep.swept;
+  summary.errors += sweep.errors;
   const tags = await listCanonicalTags(userId);
   if (tags.length < 2) return summary;
   const tagsById = new Map(tags.map((tag) => [tag.id, tag]));
-  const pairs = await buildCandidatePairs(userId, tags, candidateLimit);
+  const pairs = await buildCandidatePairs(userId, tags, candidateLimit, (pair) => {
+    const skip = skipBeforeJudge(history.get(pairKey(pair.sourceId, pair.targetId)));
+    if (skip) summary.blockedBeforeJudge++;
+    return skip;
+  });
   summary.candidates = pairs.length;
   if (pairs.length === 0) return summary;
   const tagIdsForPrompt = uniqueSortedNumbers(
@@ -58289,6 +58436,14 @@ async function runProjectAliasPromoter(opts = {}) {
         summary.skipped++;
         continue;
       }
+      const key = pairKey(sourceId, targetId);
+      const live = await loadPairHistory(userId, [sourceId, targetId]);
+      const rejectedId = userRejectedDirection(history.get(key), sourceId, targetId) ?? userRejectedDirection(live.get(key), sourceId, targetId);
+      if (rejectedId !== null) {
+        await recordRepeatOfRejected(userId, sourceId, targetId, pair, judgment, rejectedId);
+        summary.blockedAfterJudge++;
+        continue;
+      }
       const autoApplyEligible = await computeAutoApplyEligible(
         userId,
         sourceId,
@@ -58346,9 +58501,9 @@ async function maybeRunProjectAliasPromoter() {
       [userId]
     );
     const summary = await runProjectAliasPromoter({ userId });
-    if (summary.candidates > 0 || summary.inserted > 0 || summary.errors > 0) {
+    if (summary.candidates > 0 || summary.inserted > 0 || summary.errors > 0 || summary.swept > 0 || summary.blockedBeforeJudge > 0) {
       console.error(
-        `\u{1F501} [ProjectAliasPromoter] done \u2014 candidates=${summary.candidates}, judged=${summary.judged}, inserted=${summary.inserted}, autoApplied=${summary.autoApplied}, skipped=${summary.skipped}, errors=${summary.errors}`
+        `\u{1F501} [ProjectAliasPromoter] done \u2014 candidates=${summary.candidates}, judged=${summary.judged}, inserted=${summary.inserted}, autoApplied=${summary.autoApplied}, skipped=${summary.skipped}, errors=${summary.errors}, blockedBeforeJudge=${summary.blockedBeforeJudge}, blockedAfterJudge=${summary.blockedAfterJudge}, swept=${summary.swept}`
       );
     }
   } catch (err3) {
@@ -58444,13 +58599,13 @@ async function applyAliasSuggestion(suggestionId, opts = {}) {
     }
     if (!Number.isInteger(targetRoot) || targetRoot === sourceId) {
       const msg = "alias would point source to itself";
-      await markSuggestionTerminal(client2, suggestionId, "rejected", decidedBy, msg);
+      await markSuggestionTerminal(client2, suggestionId, "rejected", "system", msg);
       await client2.query("COMMIT");
       return { suggestionId, applied: false, status: "rejected", reason: msg };
     }
     if (await targetChainContainsSource(client2, sourceId, targetId)) {
       const msg = "alias would create a project_tag alias cycle";
-      await markSuggestionTerminal(client2, suggestionId, "rejected", decidedBy, msg);
+      await markSuggestionTerminal(client2, suggestionId, "rejected", "system", msg);
       await client2.query("COMMIT");
       return { suggestionId, applied: false, status: "rejected", reason: msg };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mcp-agents-memory",
-  "version": "0.9.23",
+  "version": "0.9.24",
   "description": "Long-term memory for AI agents with provenance tracking",
   "main": "build/index.js",
   "type": "module",
@@ -22,7 +22,8 @@
     "setup": "npm run build && node build/index.js setup",
     "migrate": "npm run build && node build/index.js migrate",
     "bench:tagger": "npx tsx scripts/ab_tagger.ts",
-    "check:envelope": "esbuild scripts/check_buzz_envelope.ts --bundle --platform=node --format=esm --outfile=node_modules/.cache/mcp-agents-memory/check_buzz_envelope.mjs --log-level=warning && node node_modules/.cache/mcp-agents-memory/check_buzz_envelope.mjs"
+    "check:envelope": "esbuild scripts/check_buzz_envelope.ts --bundle --platform=node --format=esm --outfile=node_modules/.cache/mcp-agents-memory/check_buzz_envelope.mjs --log-level=warning && node node_modules/.cache/mcp-agents-memory/check_buzz_envelope.mjs",
+    "check:alias": "esbuild scripts/check_alias_reject.ts --bundle --platform=node --format=esm --outfile=node_modules/.cache/mcp-agents-memory/check_alias_reject.mjs --log-level=warning && node node_modules/.cache/mcp-agents-memory/check_alias_reject.mjs"
   },
   "keywords": [
     "mcp",