mcdev 8.2.1 → 8.3.0

package/lib/util/validations.js

@@ -108,7 +108,13 @@ export default async function validation(definition, item, targetDir, codeExtrac
                     // some types do not support folders
                     return true;
                 }
-                const doNotEvaluate = ['automation', 'attributeSet', 'list'];
+                const doNotEvaluate = [
+                    'automation',
+                    'attributeSet',
+                    'dataFilter',
+                    'list',
+                    'filter',
+                ];
                 if (
                     doNotEvaluate.includes(definition.type) ||
                     (definition.type === 'asset' && item?.assetType?.name === 'webpage') ||

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "mcdev",
-    "version": "8.2.1",
+    "version": "8.3.0",
     "description": "Accenture Salesforce Marketing Cloud DevTools",
     "author": "Accenture: joern.berkefeld, douglas.midgley, robert.zimmermann, maciej.barnas",
     "license": "MIT",
@@ -73,19 +73,19 @@
         "conf": "13.1.0",
         "console.table": "0.10.0",
         "deep-equal": "2.2.3",
-        "fs-extra": "11.3.0",
+        "fs-extra": "11.3.3",
         "inquirer": "12.6.0",
         "json-to-table": "4.2.1",
         "mustache": "4.2.0",
         "p-limit": "6.2.0",
         "prettier": "3.5.3",
-        "prettier-plugin-sql": "0.19.0",
+        "prettier-plugin-sql": "0.19.2",
         "semver": "7.7.3",
         "sfmc-sdk": "2.1.2",
-        "simple-git": "3.29.0",
+        "simple-git": "3.30.0",
         "toposort": "2.0.2",
         "update-notifier": "7.3.1",
-        "winston": "3.17.0",
+        "winston": "3.19.0",
         "yargs": "17.7.2",
         "yocto-spinner": "1.0.0"
     },
@@ -99,23 +99,23 @@
         "assert": "2.1.0",
         "axios-mock-adapter": "2.0.0",
         "c8": "10.1.3",
-        "chai": "5.2.0",
+        "chai": "6.2.2",
         "chai-files": "1.4.0",
         "eslint": "9.28.0",
         "eslint-config-ssjs": "2.0.0",
         "eslint-plugin-jsdoc": "50.7.1",
         "eslint-plugin-mocha": "11.2.0",
-        "eslint-plugin-prettier": "5.4.1",
+        "eslint-plugin-prettier": "5.5.5",
         "eslint-plugin-unicorn": "59.0.1",
-        "fast-xml-parser": "5.3.0",
-        "globals": "16.2.0",
+        "fast-xml-parser": "5.3.4",
+        "globals": "17.3.0",
         "husky": "9.1.7",
         "lint-staged": "16.2.6",
         "mocha": "11.7.4",
         "mock-fs": "5.3.0",
         "npm-run-all": "4.1.5",
         "prettier-eslint": "16.4.2",
-        "typescript": "5.8.3"
+        "typescript": "5.9.3"
     },
     "optionalDependencies": {
         "fsevents": "*"

package/test/general.test.js

@@ -58,10 +58,9 @@ describe('GENERAL', () => {
                     await testUtils.getExpectedJson('9999999', 'senderProfile', 'get-rcb-name'),
                     'returned JSON was not equal expected'
                 );
-
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
-                    44,
+                    46,
                     'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
                 );
                 return;
@@ -107,10 +106,9 @@ describe('GENERAL', () => {
                     await testUtils.getExpectedJson('9999999', 'senderProfile', 'get-rcb-id'),
                     'returned JSON was not equal expected'
                 );
-
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
-                    44,
+                    46,
                     'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
                 );
                 return;
@@ -159,7 +157,7 @@ describe('GENERAL', () => {
 
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
-                    44,
+                    46,
                     'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
                 );
                 return;
@@ -226,7 +224,7 @@ describe('GENERAL', () => {
 
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
-                    80,
+                    82,
                     'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
                 );
                 return;
@@ -286,7 +284,7 @@ describe('GENERAL', () => {
 
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
-                    80,
+                    82,
                     'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
                 );
                 return;
@@ -346,7 +344,7 @@ describe('GENERAL', () => {
 
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
-                    80,
+                    82,
                     'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
                 );
                 return;
@@ -777,7 +775,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU', ['automation', 'query']);
 
-                const expectedApiCallsRetrieve = 35;
+                const expectedApiCallsRetrieve = 36;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -882,7 +880,7 @@ describe('GENERAL', () => {
             });
 
             it('buildTemplate + buildDefinition for multiple types with keys and --retrieve', async () => {
-                const expectedApiCallsRetrieve = 32;
+                const expectedApiCallsRetrieve = 33;
 
                 // preparation
                 const argvMetadata = [
@@ -987,7 +985,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU');
 
-                const expectedApiCallsRetrieve = 101;
+                const expectedApiCallsRetrieve = 108;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1229,7 +1227,7 @@ describe('GENERAL', () => {
                     await testUtils.getActualDeployFile('testTemplated_query', 'query', 'sql')
                 ).to.equal(await testUtils.getExpectedFile('9999999', 'query', 'build', 'sql'));
 
-                const expectedApiCallsRetrieve = 105;
+                const expectedApiCallsRetrieve = 112;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1241,7 +1239,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU', ['automation', 'query']);
 
-                const expectedApiCallsRetrieve = 35;
+                const expectedApiCallsRetrieve = 36;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1433,7 +1431,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU', ['automation', 'query']);
 
-                const expectedApiCallsRetrieve = 35;
+                const expectedApiCallsRetrieve = 36;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1504,7 +1502,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU', ['automation', 'query']);
 
-                const expectedApiCallsRetrieve = 35;
+                const expectedApiCallsRetrieve = 36;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1603,7 +1601,7 @@ describe('GENERAL', () => {
                 // download everything before we test buildTemplate
                 await handler.retrieve('testInstance/testBU');
 
-                const expectedApiCallsRetrieve = 101;
+                const expectedApiCallsRetrieve = 108;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1814,7 +1812,7 @@ describe('GENERAL', () => {
                     await testUtils.getActualDeployFile('testTemplated_query', 'query', 'sql')
                 ).to.equal(await testUtils.getExpectedFile('9999999', 'query', 'build', 'sql'));
 
-                const expectedApiCallsRetrieve = 105;
+                const expectedApiCallsRetrieve = 112;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -1826,7 +1824,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU', ['automation', 'query']);
 
-                const expectedApiCallsRetrieve = 35;
+                const expectedApiCallsRetrieve = 36;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,
@@ -2005,7 +2003,7 @@ describe('GENERAL', () => {
                 // download first before we test buildTemplate
                 await handler.retrieve('testInstance/testBU');
 
-                const expectedApiCallsRetrieve = 101;
+                const expectedApiCallsRetrieve = 108;
                 assert.equal(
                     testUtils.getAPIHistoryLength(),
                     expectedApiCallsRetrieve,

package/test/mockRoot/.mcdevrc.json

@@ -131,11 +131,13 @@
             "automation",
             "dataExtension",
             "dataExtract",
+            "dataFilter",
             "domainVerification",
             "emailSend",
             "event",
             "fileLocation",
             "fileTransfer",
+            "filter",
             "importFile",
             "journey",
             "list",
@@ -157,6 +159,7 @@
             "automation",
             "dataExtension",
             "dataExtract",
+            "dataFilter",
             "emailSend",
             "event",
             "fileTransfer",
@@ -175,5 +178,5 @@
             "verification"
         ]
     },
-    "version": "8.2.1"
+    "version": "8.3.0"
 }

package/test/mockRoot/deploy/testInstance/testBU/dataFilter/testExisting_dataFilter.dataFilter-meta.json

@@ -0,0 +1,19 @@
+{
+    "description": "updated on deploy",
+    "key": "testExisting_dataFilter",
+    "name": "testExisting_dataFilter",
+    "isSendable": true,
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Begins",
+                "Value": "testExisting_",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "testExisting_dataExtension"
+}

package/test/mockRoot/deploy/testInstance/testBU/dataFilter/testNew_dataFilter.dataFilter-meta.json

@@ -0,0 +1,19 @@
+{
+    "description": "created via deploy",
+    "key": "testNew_dataFilter",
+    "name": "testNew_dataFilter",
+    "isSendable": true,
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Begins",
+                "Value": "testNew_",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "testExisting_dataExtension"
+}

package/test/mockRoot/deploy/testInstance/testBU/filter/testExisting_filter.filter-meta.json

@@ -0,0 +1,10 @@
+{
+    "customerKey": "testExisting_filter",
+    "name": "testExisting_filter",
+    "description": "updated on deploy",
+    "statusId": 1,
+    "r__dataFilter_key": "testExisting_dataFilter",
+    "r__destination_dataExtension_key": "testExisting_dataExtension_exclusion",
+    "r__source_dataExtension_key": "testExisting_dataExtension",
+    "r__folder_Path": "Filter"
+}

package/test/mockRoot/deploy/testInstance/testBU/filter/testNew_filter.filter-meta.json

@@ -0,0 +1,11 @@
+{
+    "customerKey": "testNew_filter",
+    "name": "testNew_filter",
+    "description": "created via deploy",
+    "modifiedDate": "2026-01-28T10:14:46.717",
+    "statusId": 1,
+    "r__dataFilter_key": "testExisting_dataFilter",
+    "r__destination_dataExtension_key": "testExisting_dataExtension_exclusion",
+    "r__source_dataExtension_key": "testExisting_dataExtension",
+    "r__folder_Path": "Filter/filterSubfolder"
+}

package/test/mockRoot/deploy/testInstance/testBU/journey/testExisting_journey_updatecontact.journey-meta.json

@@ -0,0 +1,108 @@
+{
+    "key": "testExisting_journey_updatecontact",
+    "name": "testExisting_journey_updatecontact",
+    "lastPublishedDate": "0001-01-01T00:00:00",
+    "description": "",
+    "version": 1,
+    "workflowApiVersion": 1,
+    "createdDate": "2024-05-04T05:54:48.027",
+    "modifiedDate": "2024-05-04T17:25:57.9",
+    "activities": [
+        {
+            "key": "UPDATECONTACTDATAV2-1",
+            "name": "Update Contact - TEST",
+            "description": "",
+            "type": "UPDATECONTACTDATA",
+            "outcomes": [
+                {
+                    "key": "9f21d42b-4679-4561-911a-4bccf84672ba",
+                    "arguments": {},
+                    "metaData": {
+                        "invalid": false
+                    }
+                }
+            ],
+            "arguments": {
+                "activityData": {
+                    "updateContactFields": [
+                        {
+                            "r__dataExtension_key": "testExisting_dataExtension",
+                            "r__dataExtensionField_name": "LastName",
+                            "value": "TEST"
+                        }
+                    ]
+                }
+            },
+            "configurationArguments": {},
+            "metaData": {
+                "isConfigured": true
+            },
+            "schema": {
+                "arguments": {
+                    "activityData": {
+                        "dataType": "Text",
+                        "isNullable": false,
+                        "direction": "In",
+                        "readOnly": false,
+                        "access": "Hidden"
+                    },
+                    "contactKey": {
+                        "dataType": "Text",
+                        "isNullable": false,
+                        "direction": "In",
+                        "readOnly": false,
+                        "access": "Hidden"
+                    }
+                }
+            }
+        }
+    ],
+    "triggers": [
+        {
+            "key": "TRIGGER",
+            "name": "TRIGGER",
+            "description": "",
+            "type": "EmailAudience",
+            "outcomes": [],
+            "arguments": {},
+            "configurationArguments": {},
+            "metaData": {
+                "r__event_key": "DEAudience-2e3c73b6-48cc-2ec0-5522-48636e1a236e",
+                "chainType": "None",
+                "configurationRequired": false,
+                "iconUrl": "/images/icon-data-extension.svg",
+                "title": "Data Extension",
+                "entrySourceGroupConfigUrl": "jb:///data/entry/audience/entrysourcegroupconfig.json",
+                "sourceInteractionId": "00000000-0000-0000-0000-000000000000"
+            }
+        }
+    ],
+    "goals": [],
+    "exits": [],
+    "notifiers": [],
+    "entryMode": "NotSet",
+    "definitionType": "Multistep",
+    "channel": "",
+    "defaults": {
+        "email": [
+            "{{Event.DEAudience-2e3c73b6-48cc-2ec0-5522-48636e1a236e.\"Email\"}}"
+        ],
+        "properties": {
+            "analyticsTracking": {
+                "enabled": true,
+                "analyticsType": "google",
+                "urlDomainsToTrack": []
+            }
+        }
+    },
+    "metaData": {
+        "dataSource": "ContactsModel",
+        "highThroughputSending": {
+            "email": false
+        }
+    },
+    "executionMode": "Production",
+    "status": "Draft",
+    "scheduledStatus": "Draft",
+    "r__folder_Path": "my journeys"
+}

package/test/resources/9999999/automation/v1/filters/a0f1a1bc-4ea1-44b3-8fe1-ce40ef35c1c0/patch-response.json

@@ -0,0 +1,18 @@
+{
+    "categoryId": 37139,
+    "customerKey": "testNew_filter",
+    "description": "created via deploy",
+    "destinationObjectId": "21711373-72c1-ec11-b83b-exclusion",
+    "destinationTypeId": 2,
+    "filterActivityId": "a0f1a1bc-4ea1-44b3-8fe1-ce40ef35c1c0",
+    "filterDefinitionId": "10ef27dd-4be8-4bf6-970a-8acf8e281e55",
+    "name": "testNew_filter",
+    "sourceObjectId": "21711373-72c1-ec11-b83b-48df37d1deb7",
+    "sourceTypeId": 2,
+    "statusId": 1,
+    "resultDEName": "testExisting_dataExtension_exclusion",
+    "resultDEKey": "testExisting_dataExtension_exclusion",
+    "resultDEDescription": "",
+    "createdDate": "2026-02-02T07:34:49.203",
+    "modifiedDate": "2026-02-02T07:34:49.277"
+}

package/test/resources/9999999/automation/v1/filters/f018f237-f7ef-40b0-afc8-39ea2e5dcca4/get-response.json

@@ -0,0 +1,15 @@
+{
+    "categoryId": 37139,
+    "customerKey": "testExisting_filter",
+    "description": "blabla",
+    "destinationObjectId": "21711373-72c1-ec11-b83b-exclusion",
+    "destinationTypeId": 2,
+    "filterActivityId": "f018f237-f7ef-40b0-afc8-39ea2e5dcca4",
+    "filterDefinitionId": "10ef27dd-4be8-4bf6-970a-8acf8e281e55",
+    "name": "testExisting_filter",
+    "sourceObjectId": "21711373-72c1-ec11-b83b-48df37d1deb7",
+    "sourceTypeId": 2,
+    "statusId": 1,
+    "createdDate": "2025-12-01T17:53:39.163",
+    "modifiedDate": "2026-01-28T10:14:46.717"
+}

package/test/resources/9999999/automation/v1/filters/f018f237-f7ef-40b0-afc8-39ea2e5dcca4/patch-response.json

@@ -0,0 +1,15 @@
+{
+    "categoryId": 5319,
+    "customerKey": "testExisting_filter",
+    "description": "updated on deploy",
+    "destinationObjectId": "21711373-72c1-ec11-b83b-exclusion",
+    "destinationTypeId": 2,
+    "filterActivityId": "f018f237-f7ef-40b0-afc8-39ea2e5dcca4",
+    "filterDefinitionId": "10ef27dd-4be8-4bf6-970a-8acf8e281e55",
+    "name": "testExisting_filter",
+    "sourceObjectId": "21711373-72c1-ec11-b83b-48df37d1deb7",
+    "sourceTypeId": 2,
+    "statusId": 1,
+    "createdDate": "2025-12-01T17:53:39.163",
+    "modifiedDate": "2026-01-28T10:14:46.717"
+}

package/test/resources/9999999/automation/v1/filters/get-response.json

@@ -0,0 +1,22 @@
+{
+    "count": 54,
+    "page": 1,
+    "pageSize": 500,
+    "items": [
+        {
+            "categoryId": 37139,
+            "customerKey": "testExisting_filter",
+            "description": "blabla",
+            "destinationObjectId": "21711373-72c1-ec11-b83b-exclusion",
+            "destinationTypeId": 2,
+            "filterActivityId": "f018f237-f7ef-40b0-afc8-39ea2e5dcca4",
+            "filterDefinitionId": "10ef27dd-4be8-4bf6-970a-8acf8e281e55",
+            "name": "testExisting_filter",
+            "sourceObjectId": "21711373-72c1-ec11-b83b-48df37d1deb7",
+            "sourceTypeId": 2,
+            "statusId": 1,
+            "createdDate": "2025-12-01T17:53:39.163",
+            "modifiedDate": "2026-01-28T10:14:46.717"
+        }
+    ]
+}

package/test/resources/9999999/dataFilter/build-expected.json

@@ -0,0 +1,19 @@
+{
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Ends",
+                "Value": "_testTarget",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "description": "test",
+    "isSendable": true,
+    "key": "testTemplated_dataFilter",
+    "name": "testTemplated_dataFilter",
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "testTemplated_dataExtension"
+}

package/test/resources/9999999/dataFilter/get-expected.json

@@ -0,0 +1,23 @@
+{
+    "createdByName": "Jörn Berkefeld",
+    "createdDate": "2025-12-01T16:54:09.813",
+    "lastUpdated": "2025-12-01T17:17:31.827",
+    "lastUpdatedByName": "Jörn Berkefeld",
+    "description": "test",
+    "key": "testExisting_dataFilter",
+    "name": "testExisting_dataFilter",
+    "isSendable": true,
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Ends",
+                "Value": "_test",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "testExisting_dataExtension"
+}

package/test/resources/9999999/dataFilter/patch-expected.json

@@ -0,0 +1,20 @@
+{
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Begins",
+                "Value": "testExisting_",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "createdDate": "2026-01-27T06:24:40.527",
+    "isSendable": true,
+    "key": "testExisting_dataFilter",
+    "lastUpdated": "2026-01-30T10:46:59.777",
+    "name": "testExisting_dataFilter",
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "testExisting_dataExtension"
+}

package/test/resources/9999999/dataFilter/post-expected.json

@@ -0,0 +1,20 @@
+{
+    "createdDate": "2026-01-30T11:04:06.883",
+    "lastUpdated": "2026-01-30T11:04:06.883",
+    "isSendable": false,
+    "key": "testNew_dataFilter",
+    "name": "testNew_dataFilter",
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Ends",
+                "Value": "_test",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "testExisting_dataExtension"
+}

package/test/resources/9999999/dataFilter/template-expected.json

@@ -0,0 +1,19 @@
+{
+    "c__filterDefinition": {
+        "ConditionSet": {
+            "@_ConditionSetName": "Outer Grouping",
+            "@_Operator": "AND",
+            "Condition": {
+                "@_Operator": "Ends",
+                "Value": "{{{suffix}}}",
+                "r__dataExtensionField_name": "LastName"
+            }
+        }
+    },
+    "description": "test",
+    "isSendable": true,
+    "key": "{{{prefix}}}dataFilter",
+    "name": "{{{prefix}}}dataFilter",
+    "r__folder_Path": "Data Filters",
+    "r__source_dataExtension_key": "{{{prefix}}}dataExtension"
+}