mcdev 5.2.0 → 5.3.0

package/test/type.query.test.js

@@ -458,7 +458,7 @@ describe('type: query', () => {
             // check number of API calls
             assert.equal(
                 testUtils.getAPIHistoryLength(),
-                33,
+                34,
                 'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
             );
             return;
@@ -498,7 +498,7 @@ describe('type: query', () => {
             // check number of API calls
             assert.equal(
                 testUtils.getAPIHistoryLength(),
-                35,
+                36,
                 'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
             );
             return;
@@ -656,13 +656,15 @@ describe('type: query', () => {
     describe('Delete ================', () => {
         it('Should delete the item', async () => {
             // WHEN
-            const result = await handler.deleteByKey('testInstance/testBU', 'query', [
-                'testExisting_query',
-            ]);
+            const isDeleted = await handler.deleteByKey(
+                'testInstance/testBU',
+                'query',
+                'testExisting_query'
+            );
             // THEN
             assert.equal(process.exitCode, false, 'delete should not have thrown an error');
 
-            assert.equal(result, true, 'should have deleted the item');
+            assert.equal(isDeleted, true, 'should have deleted the item');
             return;
         });
     });

package/test/type.script.test.js

@@ -358,7 +358,12 @@ describe('type: script', () => {
             assert.equal(
                 fileList[1].split('\\').join('/'),
                 'retrieve/testInstance/testBU/script/testExisting_script.script-meta.ssjs',
-                'wrong JSON path'
+                'wrong SSJS path'
+            );
+            assert.equal(
+                fileList[2].split('\\').join('/'),
+                'retrieve/testInstance/testBU/script/testExisting_script.script-meta.html',
+                'wrong HTML path'
             );
             return;
         });

package/test/type.transactionalEmail.test.js

@@ -142,17 +142,18 @@ describe('type: transactionalEmail', () => {
         });
     });
     describe('Delete ================', () => {
-        // TODO: add this test
-        it('Should delete the item'); // , async () => {
-        //     // WHEN
-        //     const result = await handler.deleteByKey('testInstance/testBU', 'mobileKeyword', [
-        //         'testExisting_keyword',
-        //     ]);
-        //     // THEN
-        //     assert.equal(process.exitCode, false, 'delete should not have thrown an error');
+        it('Should delete the item', async () => {
+            // WHEN
+            const isDeleted = await handler.deleteByKey(
+                'testInstance/testBU',
+                'transactionalEmail',
+                'testExisting_temail'
+            );
+            // THEN
+            assert.equal(process.exitCode, false, 'delete should not have thrown an error');
 
-        //     assert.equal(result, true, 'should have deleted the item');
-        //     return;
-        // });
+            assert.equal(isDeleted, true, 'should have deleted the item');
+            return;
+        });
     });
 });

package/test/type.transactionalPush.test.js

@@ -146,13 +146,11 @@ describe('type: transactionalPush', () => {
         // TODO: add this test
         it('Should delete the item'); // , async () => {
         //     // WHEN
-        //     const result = await handler.deleteByKey('testInstance/testBU', 'mobileKeyword', [
-        //         'testExisting_keyword',
-        //     ]);
+        //     const isDeleted = await handler.deleteByKey('testInstance/testBU', 'mobileKeyword', 'testExisting_keyword');
         //     // THEN
         //     assert.equal(process.exitCode, false, 'delete should not have thrown an error');
 
-        //     assert.equal(result, true, 'should have deleted the item');
+        //     assert.equal(isDeleted, true, 'should have deleted the item');
         //     return;
         // });
     });

package/test/type.transactionalSMS.test.js

@@ -176,13 +176,11 @@ describe('type: transactionalSMS', () => {
         // TODO: add this test
         it('Should delete the item'); // , async () => {
         //     // WHEN
-        //     const result = await handler.deleteByKey('testInstance/testBU', 'mobileKeyword', [
-        //         'testExisting_keyword',
-        //     ]);
+        //     const isDeleted = await handler.deleteByKey('testInstance/testBU', 'mobileKeyword', 'testExisting_keyword');
         //     // THEN
         //     assert.equal(process.exitCode, false, 'delete should not have thrown an error');
 
-        //     assert.equal(result, true, 'should have deleted the item');
+        //     assert.equal(isDeleted, true, 'should have deleted the item');
         //     return;
         // });
     });

package/test/type.triggeredSend.test.js

@@ -130,13 +130,15 @@ describe('type: triggeredSend', () => {
     describe('Delete ================', () => {
         it('Should delete the item', async () => {
             // WHEN
-            const result = await handler.deleteByKey('testInstance/testBU', 'triggeredSend', [
-                'testExisting_triggeredSend',
-            ]);
+            const isDeleted = await handler.deleteByKey(
+                'testInstance/testBU',
+                'triggeredSend',
+                'testExisting_triggeredSend'
+            );
             // THEN
             assert.equal(process.exitCode, false, 'delete should not have thrown an error');
 
-            assert.equal(result, true, 'should have deleted the item');
+            assert.equal(isDeleted, true, 'should have deleted the item');
             return;
         });
     });

package/test/type.verification.test.js

@@ -0,0 +1,173 @@
+const chai = require('chai');
+const chaiFiles = require('chai-files');
+const assert = chai.assert;
+chai.use(chaiFiles);
+const cache = require('../lib/util/cache');
+const testUtils = require('./utils');
+const handler = require('../lib/index');
+
+describe('type: verification', () => {
+    beforeEach(() => {
+        testUtils.mockSetup();
+    });
+    afterEach(() => {
+        testUtils.mockReset();
+    });
+
+    describe('Retrieve ================', () => {
+        it('Should retrieve a verification', async () => {
+            // WHEN
+            const retrieved = await handler.retrieve('testInstance/testBU', ['verification']);
+            // THEN
+            assert.equal(process.exitCode, false, 'retrieve should not have thrown an error');
+            // get results from cache
+            const result = cache.getCache();
+            assert.equal(
+                result.verification ? Object.keys(result.verification).length : 0,
+                1,
+                'only one verification expected'
+            );
+            assert.equal(
+                retrieved['testInstance/testBU']?.verification
+                    ? Object.keys(retrieved['testInstance/testBU']?.verification).length
+                    : 0,
+                1,
+                'one verifications to be retrieved'
+            );
+
+            assert.deepEqual(
+                await testUtils.getActualJson(
+                    'testExisting_39f6a488-20eb-4ba0-b0b9',
+                    'verification'
+                ),
+                await testUtils.getExpectedJson('9999999', 'verification', 'get'),
+                'returned JSON was not equal expected'
+            );
+            assert.equal(
+                testUtils.getAPIHistoryLength(),
+                9,
+                'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
+            );
+            return;
+        });
+    });
+    describe('Deploy ================', () => {
+        beforeEach(() => {
+            testUtils.mockSetup(true);
+        });
+        it('Should create & upsert a verification', async () => {
+            // WHEN
+
+            const deployed = await handler.deploy('testInstance/testBU', ['verification']);
+            // THEN
+            assert.equal(process.exitCode, false, 'deploy should not have thrown an error');
+            // get results from cache
+            const result = cache.getCache();
+            assert.equal(
+                result.verification ? Object.keys(result.verification).length : 0,
+                2,
+                'two verifications expected'
+            );
+            assert.equal(
+                deployed['testInstance/testBU']?.verification
+                    ? Object.keys(deployed['testInstance/testBU']?.verification).length
+                    : 0,
+                2,
+                'two verifications to be deployed'
+            );
+            // confirm created item
+            assert.deepEqual(
+                await testUtils.getActualJson('testNew_RANDOM_NEW_GUID', 'verification'),
+                await testUtils.getExpectedJson('9999999', 'verification', 'post'),
+                'returned new-JSON was not equal expected for insert verification'
+            );
+            // confirm updated item
+            assert.deepEqual(
+                await testUtils.getActualJson(
+                    'testExisting_39f6a488-20eb-4ba0-b0b9',
+                    'verification'
+                ),
+                await testUtils.getExpectedJson('9999999', 'verification', 'patch'),
+                'returned existing-JSON was not equal expected for update verification'
+            );
+            // check number of API calls
+            assert.equal(
+                testUtils.getAPIHistoryLength(),
+                11,
+                'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
+            );
+            return;
+        });
+    });
+    describe('Templating ================', () => {
+        it('Should create a verification template via buildTemplate and build it', async () => {
+            // download first before we test buildTemplate
+            await handler.retrieve('testInstance/testBU', ['verification']);
+            // buildTemplate
+            const result = await handler.buildTemplate(
+                'testInstance/testBU',
+                'verification',
+                ['testExisting_39f6a488-20eb-4ba0-b0b9'],
+                'testSourceMarket'
+            );
+            assert.equal(process.exitCode, false, 'buildTemplate should not have thrown an error');
+            assert.equal(
+                result.verification ? Object.keys(result.verification).length : 0,
+                1,
+                'only one verification expected'
+            );
+            assert.deepEqual(
+                await testUtils.getActualTemplateJson(
+                    'testExisting_39f6a488-20eb-4ba0-b0b9',
+                    'verification'
+                ),
+                await testUtils.getExpectedJson('9999999', 'verification', 'template'),
+                'returned template JSON was not equal expected'
+            );
+            // buildDefinition
+            await handler.buildDefinition(
+                'testInstance/testBU',
+                'verification',
+                'testExisting_39f6a488-20eb-4ba0-b0b9',
+                'testTargetMarket'
+            );
+            assert.equal(
+                process.exitCode,
+                false,
+                'buildDefinition should not have thrown an error'
+            );
+            assert.deepEqual(
+                await testUtils.getActualDeployJson(
+                    'testTemplated_39f6a488-20eb-4ba0-b0b9',
+                    'verification'
+                ),
+                await testUtils.getExpectedJson('9999999', 'verification', 'build'),
+                'returned deployment JSON was not equal expected'
+            );
+            assert.equal(
+                testUtils.getAPIHistoryLength(),
+                9,
+                'Unexpected number of requests made. Run testUtils.logAPIHistoryDebug() to see the requests'
+            );
+            return;
+        });
+    });
+    describe('Delete ================', () => {
+        it('Should delete the item', async () => {
+            // WHEN
+            const isDeleted = await handler.deleteByKey(
+                'testInstance/testBU',
+                'verification',
+                'testExisting_39f6a488-20eb-4ba0-b0b9'
+            );
+            // THEN
+            assert.equal(
+                process.exitCode,
+                0,
+                'deleteByKey should have thrown an error due to lack of support'
+            );
+            assert.equal(isDeleted, true, 'deleteByKey should have returned true for success');
+            return;
+        });
+    });
+});

package/test/utils.js

@@ -208,7 +208,13 @@ exports.getAPIHistory = () => apimock.history;
 function getAPIHistoryDebug() {
     const historyArr = Object.values(apimock.history)
         .flat()
-        .map((item) => ({ url: item.url, data: item.data }));
+        .map((item) => {
+            const log = { method: item.method, url: item.url };
+            if (item.data) {
+                log.body = item.data;
+            }
+            return log;
+        });
     return historyArr;
 }
 exports.getAPIHistoryDebug = getAPIHistoryDebug;

package/types/mcdev.d.js

@@ -251,6 +251,20 @@ const SDK = require('sfmc-sdk');
  * @property {string} r__folder_Path folder path
  * @property {string} [categoryId] holds folder ID, replaced with r__folder_Path during retrieve
  */
+/**
+ * @typedef {object} VerificationItem
+ * @property {string} dataVerificationDefinitionId ID / Key
+ * @property {'IsEqualTo'|'IsLessThan'|'IsGreaterThan'|'IsOutsideRange'|'IsInsideRange'|'IsNotEqualTo'|'IsNotLessThan'|'IsNotGreaterThan'|'IsNotOutsideRange'|'IsNotInsideRange'} verificationType key
+ * @property {number} value1 used for all verificationTypes; lower value for IsOutsideRange, IsInsideRange, IsNotOutsideRange, IsNotInsideRange
+ * @property {number} value2 only used for IsOutsideRange, IsInsideRange, IsNotOutsideRange, IsNotInsideRange; otherwise set to 0
+ * @property {boolean} shouldStopOnFailure flag to stop automation if verification fails
+ * @property {boolean} shouldEmailOnFailure flag to send email if verification fails
+ * @property {string} notificationEmailAddress email address to send notification to; empty string if shouldEmailOnFailure=false
+ * @property {string} notificationEmailMessage email message to send; empty string if shouldEmailOnFailure=false
+ * @property {number} createdBy user id of creator
+ * @property {string} r__dataExtension_CustomerKey key of target data extension
+ */
+
 /**
  * @typedef {Object.<string, AutomationItem>} AutomationMap
  * @typedef {{metadata:AutomationMap,type:string}} AutomationMapObj