mcdev 5.1.0 → 5.3.0

package/.eslintrc.json

@@ -1,8 +1,7 @@
 {
     "env": {
         "es6": true,
-        "node": true,
-        "mocha": true
+        "node": true
     },
     "extends": [
         "eslint:recommended",
@@ -67,7 +66,6 @@
         "unicorn/prefer-set-has": "off",
         "unicorn/prefer-spread": "off",
         "unicorn/prefer-string-replace-all": "error",
-        "unicorn/unicorn/no-lonely-if": "off",
         "arrow-body-style": ["error", "as-needed"],
         "curly": "error",
         "no-console": "error",
@@ -84,6 +82,7 @@
                 }
             }
         ],
+        "jsdoc/require-param-type": "error",
         "jsdoc/tag-lines": ["warn", "any", { "startLines": 1 }],
         "spaced-comment": ["warn", "always", { "block": { "exceptions": ["*"], "balanced": true } }]
     },
@@ -103,7 +102,8 @@
             "extends": ["plugin:mocha/recommended"],
             "plugins": ["mocha"],
             "rules": {
-                "mocha/no-mocha-arrows": "off"
+                "mocha/no-mocha-arrows": "off",
+                "mocha/no-pending-tests": "off"
             }
         }
     ]

package/.fork/custom-commands.json

@@ -22,5 +22,17 @@
       "type": "url",
       "url": "https://github.com/Accenture/sfmc-devtools/compare/hotfix...$shortname?expand=1"
     }
+  },
+  {
+    "name": "Create Release-PR to master branch",
+    "target": "ref",
+    "refTargets": [
+      "localbranch",
+      "remotebranch"
+    ],
+    "action": {
+      "type": "url",
+      "url": "https://github.com/Accenture/sfmc-devtools/compare/main...$shortname?expand=1&template=pr_template_release.md"
+    }
   }
 ]

package/.github/ISSUE_TEMPLATE/bug.yml

@@ -39,6 +39,8 @@ body:
           label: Version
           description: What version of our software are you running? (mcdev --version)
           options:
+              - 5.3.0
+              - 5.2.0
               - 5.1.0
               - 5.0.2
               - 5.0.1

package/.github/PULL_REQUEST_TEMPLATE/pr_template_release.md

@@ -0,0 +1,19 @@
+# Release details
+
+## Checklist
+
+- [ ] Wiki updated with info in ticket listed under **Documentation**
+- [ ] ran `npm audit fix`
+- [ ] ran task version:major/minor/patch
+- [ ] updated [bug template](/.github/ISSUE_TEMPLATE/bug.yml) to include the new version
+- [ ] updated [.mcdevrc](/test/mockRoot/.mcdevrc.json) to the new version
+- [ ] (after merge) moved version tag to merge commit
+- [ ] created [new GitHub Release](https://github.com/Accenture/sfmc-devtools/releases/new) 
+
+## Documentation
+
+- closes #123456
+
+## Issues
+
+- closes #1234567

package/.github/PULL_REQUEST_TEMPLATE.md

@@ -2,9 +2,9 @@
 
 ## What changes did you make? (Give an overview)
 
-...
+- closes #1234
 
-## Is there anything you'd like reviewers to focus on?
+## Further details (optional)
 
 ...
 

package/.github/workflows/coverage-develop-branch.yml

@@ -26,8 +26,6 @@ jobs:
 
             - run: npm ci --ignore-scripts
 
-            - run: npm run lint
-
             - name: Run mcdev-tests with coverage
               run: npm run coverage
 

package/.github/workflows/coverage-main-branch.yml

@@ -26,8 +26,6 @@ jobs:
 
             - run: npm ci --ignore-scripts
 
-            - run: npm run lint
-
             - name: Run mcdev-tests with coverage
               run: npm run coverage
 

package/.github/workflows/coverage.yml

@@ -23,8 +23,6 @@ jobs:
 
             - run: npm ci --ignore-scripts
 
-            - run: npm run lint
-
             - name: Run mcdev-tests with coverage
               run: npm run coverage
 

package/.husky/post-checkout

@@ -32,6 +32,7 @@ if [[ ${PACKAGES[@]} ]]; then
   done
   echo "📦 Running npm install to update your dependencies..."
   npm install
+  npm run lint:fix
 else
   echo "📦 All packages up-to-date. No need to run npm install."
 fi

package/.husky/post-merge

@@ -16,6 +16,7 @@ if [[ ${PACKAGES[@]} ]]; then
   done
   echo "📦 Running npm install to update your dependencies..."
   npm install
+  npm run lint:fix
 else
   echo "📦 All packages up-to-date. No need to run npm install."
 fi

package/.vscode/extensions.json

@@ -15,6 +15,10 @@
         "editorconfig.editorconfig",
         "esbenp.prettier-vscode",
 
+        // mcdev tests
+        "hbenl.vscode-mocha-test-adapter",
+        "IBM.output-colorizer",
+
         // Markdown / Readme.md
         "joernberkefeld.markdown-preview-bitbucket-innersource"
     ]