mcdev 4.2.1 → 4.3.1

package/lib/metadataTypes/Folder.js

@@ -18,21 +18,19 @@ class Folder extends MetadataType {
      *
      * @param {string} retrieveDir Directory where retrieved metadata directory will be saved
      * @param {string[]} [additionalFields] Returns specified fields even if their retrieve definition is not set to true
-     * @param {TYPE.BuObject} buObject properties for auth
-     * @param {void} [___] unused parameter
+     * @param {string[]} [subTypeArr] content type of folder
      * @param {string} [key] customer key of single item to retrieve
-     * @param {string[]} [contentTypeList] content type of folder
      * @returns {Promise} Promise
      */
-    static async retrieve(retrieveDir, additionalFields, buObject, ___, key, contentTypeList) {
+    static async retrieve(retrieveDir, additionalFields, subTypeArr, key) {
         if (key) {
             Util.logger.error(`Folder.retrieve() does not support key parameter`);
         }
-        const queryAllFolders = await this.retrieveHelper(additionalFields, true, contentTypeList);
+        const queryAllFolders = await this.retrieveHelper(additionalFields, true, subTypeArr);
 
-        if (buObject.eid !== buObject.mid) {
+        if (this.buObject.eid !== this.buObject.mid) {
             queryAllFolders.push(
-                ...(await this.retrieveHelper(additionalFields, false, contentTypeList))
+                ...(await this.retrieveHelper(additionalFields, false, subTypeArr))
             );
         }
         const sortPairs = toposort(queryAllFolders.map((a) => [a.ParentFolder.ID, a.ID]));
@@ -45,7 +43,7 @@ class Folder extends MetadataType {
             }
             // by default folders do not have an external key, we set this to ID plus EID as this will be unique
             else if (!val.CustomerKey) {
-                val.CustomerKey = [buObject.eid, val.ID].join('-');
+                val.CustomerKey = [this.buObject.eid, val.ID].join('-');
             }
             // ensure name is a string and not a number (SFMC-SDK workaround)
             val.Name = val.Name + '';
@@ -108,7 +106,7 @@ class Folder extends MetadataType {
             // remove keys which are listed in other BUs and skip root
             if (
                 idMap[id].Client?.ID &&
-                (buObject.mid == idMap[id].Client.ID ||
+                (this.buObject.mid == idMap[id].Client.ID ||
                     this.definition.folderTypesFromParent.includes(
                         idMap[id].ContentType.toLowerCase()
                     ))
@@ -141,7 +139,7 @@ class Folder extends MetadataType {
             }
         }
         if (retrieveDir) {
-            const savedMetadata = await this.saveResults(metadata, retrieveDir, buObject.mid);
+            const savedMetadata = await this.saveResults(metadata, retrieveDir, this.buObject.mid);
             Util.logger.info(
                 `Downloaded: ${this.definition.type} (${Object.keys(savedMetadata).length})`
             );
@@ -152,12 +150,12 @@ class Folder extends MetadataType {
     /**
      * Retrieves folder metadata for caching
      *
-     * @param {TYPE.BuObject} buObject properties for auth
-     * @param {string[]} [contentTypeList] content type of folder
+     * @param {void} _ unused
+     * @param {string[]} [subTypeArr] content type of folder
      * @returns {Promise} Promise
      */
-    static retrieveForCache(buObject, contentTypeList) {
-        return this.retrieve(null, null, buObject, null, null, contentTypeList);
+    static retrieveForCache(_, subTypeArr) {
+        return this.retrieve(null, null, subTypeArr, null);
     }
 
     /**

package/lib/metadataTypes/FtpLocation.js

@@ -16,11 +16,10 @@ class FtpLocation extends MetadataType {
      * @param {string} retrieveDir Directory where retrieved metadata directory will be saved
      * @param {void} [_] unused parameter
      * @param {void} [__] unused parameter
-     * @param {void} [___] unused parameter
      * @param {string} [key] customer key of single item to retrieve
      * @returns {Promise.<TYPE.MetadataTypeMapObj>} Promise
      */
-    static retrieve(retrieveDir, _, __, ___, key) {
+    static retrieve(retrieveDir, _, __, key) {
         return super.retrieveREST(retrieveDir, '/automation/v1/ftplocations/', null, null, key);
     }
 

package/lib/metadataTypes/ImportFile.js

@@ -20,11 +20,10 @@ class ImportFile extends MetadataType {
      * @param {string} retrieveDir Directory where retrieved metadata directory will be saved
      * @param {void} [_] unused parameter
      * @param {void} [__] unused parameter
-     * @param {void} [___] unused parameter
      * @param {string} [key] customer key of single item to retrieve
      * @returns {Promise.<TYPE.MetadataTypeMapObj>} Promise
      */
-    static retrieve(retrieveDir, _, __, ___, key) {
+    static retrieve(retrieveDir, _, __, key) {
         return super.retrieveREST(retrieveDir, '/automation/v1/imports/', null, null, key);
     }