mc-assets 0.2.3 → 0.2.4

package/README.MD

@@ -21,6 +21,8 @@ npm i mc-assets
 
 This module was originally designed as standalone package for [https://mcraft.fun](mcraft.fun) (repo) project so it is easier to maintain, but now it became a library that I think can cover any use case where you need to work with minecraft assets. This library means block states, models data and texture contents, it doesn't cover minecraft-data use cases. With the best block model parser you can build your own renderers, editors, etc.
 
+For contributing & building instructions see [building](#building) section.
+
 > Bundled modules & block states are version-accurate starting from 1.13.0 (post-flattening) version.
 > Tested on Node.js 18 and above.
 
@@ -33,7 +35,6 @@ This packages includes versions for: 1.7.10, 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.
 <summary>Included Block Entities (Additional Block Models) (132):</summary>
 
 - ✅ item_frame
-- ✅ glow_item_frame
 - ✅ sign
 - ✅ wall_sign
 - ✅ acacia_sign
@@ -52,6 +53,7 @@ This packages includes versions for: 1.7.10, 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.
 - ✅ crimson_wall_sign
 - ✅ warped_sign
 - ✅ warped_wall_sign
+- ✅ glow_item_frame
 - ✅ mangrove_sign
 - ✅ mangrove_wall_sign
 - ✅ decorated_pot
@@ -324,3 +326,17 @@ const ButtonHighlighted = styled(Button)`
 ```
 
 Please, don't use json / image files directly as their format is not stable and can change in the future, use the parsers instead.
+
+## Building
+
+```bash
+pnpm i
+# recommended but not required (will speed up build by fetching cache from gh-pages branch)
+pnpm use-cached-datapaths
+pnpm build
+```
+
+Then if you only changing block entities, you can run `pnpm regen-blockentities` to regenerate block entities.
+If you only change consumer code you can run `pnpm watch-dist` to watch for changes and rebuild.
+
+To use in `minecraft-web-client` or your own project just run `pnpm link mc-assets` once or use `file:../mc-assets` in your `package.json` file if you are using other package manager.

package/dist/atlasParser.js

@@ -87,17 +87,18 @@ export class AtlasParser {
             getLoadedImage: (name) => {
                 const texture = newTextures[name];
                 const image = texture.img;
-                const imgSize = image.width;
+                const imgWidth = image.width;
+                const imgHeight = image.height;
                 //@ts-ignore we no longer need the image, remove from atlas
                 delete texture.img;
                 return {
                     image,
-                    renderWidth: texture.su * imgSize,
-                    renderHeight: texture.sv * imgSize,
-                    renderSourceStartX: texture.u * imgSize,
-                    renderSourceStartY: texture.v * imgSize,
-                    renderSourceWidth: texture.su * imgSize,
-                    renderSourceHeight: texture.sv * imgSize,
+                    renderWidth: texture.su * imgWidth,
+                    renderHeight: texture.sv * imgHeight,
+                    renderSourceStartX: texture.u * imgWidth,
+                    renderSourceStartY: texture.v * imgHeight,
+                    renderSourceWidth: texture.su * imgWidth,
+                    renderSourceHeight: texture.sv * imgHeight,
                 };
             },
             tileSize: this.atlas.latest.tileSize,