mbkbucket 4.0.0 → 4.1.0

package/lib/src/controllers/view.controller.js

@@ -1,233 +1,234 @@
-import { downloadFile, getFileMetadata, ensureKeyHasAppPrefix, generateSignedUrl, resolveStorageName, getStorageProvider } from "../services/storage.service.js";
-import { mbkbucketVar } from "../config/index.js";
-import { escapeHtml, getBaseName, getFileExt, getMimeType, normalizeKeyParam, destroyStream, VIEWABLE_TYPES, VIEWABLE_TYPES_SORTED, STATIC_ASSET_TYPES, VIDEO_TYPES, AUDIO_TYPES, buildCacheControl, parseRangeHeader, renderPlayerPage } from "../utils/helpers.js";
-import { createLogger } from "#logger";
-
-const debugView = createLogger('view');
-
-function attachStreamCleanup(req, res, stream, timeoutMs = 120000) {
-  const cleanup = () => destroyStream(stream);
-
-  stream.on('error', (err) => {
-    console.error('Stream error:', err);
-    cleanup();
-    if (!res.headersSent) res.status(500).end('Stream error');
-  });
-
-  req.on('close', cleanup);
-  req.on('aborted', cleanup);
-  req.setTimeout(timeoutMs, () => {
-    console.error('Request timeout for stream');
-    cleanup();
-    if (!res.headersSent) res.status(408).end('Request timeout');
-  });
-  res.on('finish', cleanup);
-  res.on('close', cleanup);
-}
-
-async function serveFileInline(req, res, keyToUse, { noindex = true, bucketName, publicCache = false } = {}) {
-  const fileName = getBaseName(keyToUse);
-  const fileExtension = getFileExt(fileName);
-
-  debugView('Request for %s (type: %s, range: %s)', fileName, fileExtension, req.headers.range || 'none');
-
-  if (!VIEWABLE_TYPES.has(fileExtension)) {
-    return res.status(415).json({
-      message: 'File type not supported for viewing',
-      supportedTypes: VIEWABLE_TYPES_SORTED
-    });
-  }
-
-  const ifNoneMatch = req.headers['if-none-match'];
-  const ifModifiedSince = req.headers['if-modified-since'];
-  const rangeHeader = req.headers.range;
-
-  const isStaticAsset = STATIC_ASSET_TYPES.has(fileExtension);
-  const isVideo = VIDEO_TYPES.has(fileExtension);
-  const isAudio = AUDIO_TYPES.has(fileExtension);
-  const isPdf = fileExtension === 'pdf';
-  const supportsRanges = isVideo || isAudio || isPdf;
-  const contentType = getMimeType(fileName);
-
-  // Fast path for range requests (video / audio / PDF streaming)
-  if (supportsRanges && rangeHeader) {
-    debugView('Processing range request: %s for %s', rangeHeader, fileName);
-    let meta;
-    try {
-      meta = await getFileMetadata(keyToUse, bucketName);
-    } catch (err) {
-      console.error('[mbkbucket] serveFileInline metadata error:', err);
-      return res.status(500).json({ message: 'Failed to fetch file metadata', error: err.message });
-    }
-
-    if (!meta?.exists) return res.status(404).json({ message: 'File not found', key: keyToUse });
-
-    const etag = `"${new Date(meta.LastModified || Date.now()).getTime()}-${meta.ContentLength || 0}"`;
-    if (ifNoneMatch === etag) return res.status(304).end();
-
-    const total = Number(meta.ContentLength);
-    if (total) {
-      const range = parseRangeHeader(rangeHeader, total);
-      if (!range) {
-        res.status(416).setHeader('Content-Range', `bytes */${total}`);
-        return res.end();
-      }
-
-      const { start, end, size: chunksize } = range;
-      try {
-        const rangeResult = await downloadFile(keyToUse, { range: `bytes=${start}-${end}`, bucketName });
-        if (typeof rangeResult.ContentLength === 'number' && rangeResult.ContentLength !== chunksize) {
-          debugView('Range size mismatch for %s: expected=%s got=%s', keyToUse, chunksize, rangeResult.ContentLength);
-        }
-
-        debugView('Serving range bytes %s-%s/%s (%s bytes) for %s', start, end, total, chunksize, fileName);
-
-        res.status(206);
-        res.setHeader('Content-Range', `bytes ${start}-${end}/${total}`);
-        res.setHeader('Content-Length', chunksize);
-        res.setHeader('Content-Type', contentType);
-        res.setHeader('Cache-Control', buildCacheControl(contentType, { supportsRanges: true, publicCache }));
-        res.setHeader('ETag', etag);
-        res.setHeader('Accept-Ranges', 'bytes');
-        if (noindex) res.setHeader('X-Robots-Tag', 'noindex, nofollow');
-        res.setHeader('X-Content-Type-Options', 'nosniff');
-        if (meta.LastModified) res.setHeader('Last-Modified', new Date(meta.LastModified).toUTCString());
-
-        attachStreamCleanup(req, res, rangeResult.Body);
-        return rangeResult.Body.pipe(res);
-      } catch (rangeError) {
-        console.error('Range request failed:', rangeError);
-      }
-    }
-  }
-
-  // Standard path: full-file download
-  const downloadOptions = {
-    ...(ifNoneMatch && { ifNoneMatch }),
-    ...(ifModifiedSince && { ifModifiedSince: new Date(ifModifiedSince) }),
-    bucketName
-  };
-
-  if (isPdf) debugView('Serving full PDF (no range header) for %s', fileName);
-
-  let result;
-  try {
-    result = await downloadFile(keyToUse, downloadOptions);
-  } catch (err) {
-    if (err.name === 'NoSuchKey' || err.name === 'NotFound' || err.message?.includes('File not found')) {
-      return res.status(404).json({ message: 'File not found', key: keyToUse });
-    }
-    if (err.name === 'AccessDenied' || err.message?.includes('Access denied')) {
-      return res.status(403).json({ message: 'Access denied' });
-    }
-    console.error('[mbkbucket] serveFileInline download error:', err);
-    return res.status(500).json({ message: 'Failed to fetch file', error: err.message });
-  }
-
-  if (result?.notModified) return res.status(304).end();
-
-  const etag = `"${new Date(result.LastModified || Date.now()).getTime()}-${result.ContentLength || 0}"`;
-  if (ifNoneMatch === etag) return res.status(304).end();
-
-  res.setHeader('Content-Type', contentType);
-  res.setHeader('Content-Disposition', `inline; filename="${fileName}"`);
-  res.setHeader('ETag', etag);
-  res.setHeader('X-Content-Type-Options', 'nosniff');
-  res.setHeader('X-Frame-Options', 'SAMEORIGIN');
-  if (noindex) res.setHeader('X-Robots-Tag', 'noindex, nofollow');
-  if (result.ContentLength) res.setHeader('Content-Length', result.ContentLength);
-  if (result.LastModified) res.setHeader('Last-Modified', new Date(result.LastModified).toUTCString());
-  if (fileExtension === 'html' || fileExtension === 'htm') {
-    res.setHeader('Content-Security-Policy', "default-src 'self'; script-src 'none'; object-src 'none';");
-  }
-  if (supportsRanges) res.setHeader('Accept-Ranges', 'bytes');
-  res.setHeader('Cache-Control', buildCacheControl(contentType, { isStaticAsset, supportsRanges, publicCache }));
-  res.status(200);
-
-  const timeoutDuration = result.ContentLength > 50 * 1024 * 1024 ? 300000 : 120000;
-  attachStreamCleanup(req, res, result.Body, timeoutDuration);
-  result.Body.pipe(res);
-}
-
-export async function viewFile(req, res) {
-  try {
-    const key = normalizeKeyParam(req.params.key);
-    let keyToUse;
-    try {
-      keyToUse = ensureKeyHasAppPrefix(key);
-    } catch (e) {
-      return res.status(400).json({ message: e.message });
-    }
-
-    await serveFileInline(req, res, keyToUse, { noindex: true, bucketName: req.activeBucket, publicCache: false });
-  } catch (error) {
-    console.error("Error viewing file:", error);
-    if (error.name === 'NoSuchKey' || error.name === 'NotFound' || error.message?.includes('File not found')) {
-      res.status(404).json({ message: "File not found", key: req.params.key });
-    } else if (error.name === 'AccessDenied' || error.message?.includes('Access denied')) {
-      res.status(403).json({ message: "Access denied" });
-    } else {
-      res.status(500).json({ message: "View failed", error: error.message });
-    }
-  }
-}
-
-export async function playerPage(req, res) {
-  try {
-    const key = normalizeKeyParam(req.params.key);
-    let keyToUse;
-    try {
-      keyToUse = ensureKeyHasAppPrefix(key);
-    } catch (e) {
-      return res.status(400).send(e.message);
-    }
-
-    const html = renderPlayerPage(
-      escapeHtml(getBaseName(keyToUse)),
-      encodeURIComponent(keyToUse),
-      `?bucket=${encodeURIComponent(req.activeBucket)}`
-    );
-
-    res.setHeader('Content-Type', 'text/html; charset=utf-8');
-    res.setHeader('X-Content-Type-Options', 'nosniff');
-    return res.status(200).send(html);
-  } catch (err) {
-    console.error('Error rendering player page:', err);
-    return res.status(500).send('Failed to render player');
-  }
-}
-
-export async function publicView(req, res) {
-  try {
-    const bucketName = req.query?.bucket ? resolveStorageName(req.query.bucket) : resolveStorageName();
-    const key = normalizeKeyParam(req.params.key);
-
-    if (!key || key.endsWith('/')) {
-      return res.status(403).json({ message: 'Directory indexing is not allowed' });
-    }
-
-    let keyToUse;
-    try {
-      keyToUse = ensureKeyHasAppPrefix(key);
-    } catch (e) {
-      return res.status(400).json({ message: e.message });
-    }
-
-    if (!mbkbucketVar?.p_view_inline) {
-      try {
-        const provider = getStorageProvider(bucketName);
-        if (provider.capabilities.presignedUrls) {
-          const signed = await generateSignedUrl(keyToUse, 'getObject', 3600, bucketName);
-          return res.redirect(302, signed.url);
-        }
-      } catch (err) {
-        debugView('Signed URL redirection failed, falling back to inline serve: %s', err.message);
-      }
-    }
-
-    await serveFileInline(req, res, keyToUse, { noindex: true, bucketName, publicCache: true });
-  } catch (error) {
-    console.error('[mbkbucket] p_view error:', error);
-    res.status(500).json({ message: 'Internal server error', error: error.message });
-  }
-}
+import { downloadFile, getFileMetadata, ensureKeyHasAppPrefix, resolveStorageName, getStorageProvider } from "../services/storage.service.js";
+import { mbkbucketVar } from "../config/index.js";
+import { escapeHtml, getBaseName, getFileExt, getMimeType, normalizeKeyParam, destroyStream, VIEWABLE_TYPES, VIEWABLE_TYPES_SORTED, STATIC_ASSET_TYPES, VIDEO_TYPES, AUDIO_TYPES, buildCacheControl, parseRangeHeader, renderPlayerPage } from "../utils/helpers.js";
+import { createLogger } from "#logger";
+
+const debugView = createLogger('view');
+
+function attachStreamCleanup(req, res, stream, timeoutMs = 120000) {
+  if (!stream || typeof stream.on !== 'function') return;
+  const cleanup = () => destroyStream(stream);
+
+  stream.on('error', (err) => {
+    console.error('Stream error:', err);
+    cleanup();
+    if (!res.headersSent) res.status(500).end('Stream error');
+  });
+
+  req.on('close', cleanup);
+  req.on('aborted', cleanup);
+  req.setTimeout(timeoutMs, () => {
+    console.error('Request timeout for stream');
+    cleanup();
+    if (!res.headersSent) res.status(408).end('Request timeout');
+  });
+  res.on('finish', cleanup);
+  res.on('close', cleanup);
+}
+
+
+async function serveFileInline(req, res, keyToUse, { noindex = true, bucketName, publicCache = false } = {}) {
+  const fileName = getBaseName(keyToUse);
+  const fileExtension = getFileExt(fileName);
+
+  debugView('Request for %s (type: %s, range: %s)', fileName, fileExtension, req.headers.range || 'none');
+
+  if (!VIEWABLE_TYPES.has(fileExtension)) {
+    return res.status(415).json({
+      message: 'File type not supported for viewing',
+      supportedTypes: VIEWABLE_TYPES_SORTED
+    });
+  }
+
+  const ifNoneMatch = req.headers['if-none-match'];
+  const ifModifiedSince = req.headers['if-modified-since'];
+  const rangeHeader = req.headers.range;
+
+  const isStaticAsset = STATIC_ASSET_TYPES.has(fileExtension);
+  const isVideo = VIDEO_TYPES.has(fileExtension);
+  const isAudio = AUDIO_TYPES.has(fileExtension);
+  const isPdf = fileExtension === 'pdf';
+  const supportsRanges = isVideo || isAudio || isPdf;
+  const contentType = getMimeType(fileName);
+  const safeAsciiName = fileName.replace(/["\\]/g, '').replace(/[^\x20-\x7E]/g, '_');
+  const encodedName = encodeURIComponent(fileName);
+
+  // Fast path for range requests (video / audio / PDF streaming)
+  if (supportsRanges && rangeHeader) {
+    debugView('Processing range request: %s for %s', rangeHeader, fileName);
+    let meta;
+    try {
+      meta = await getFileMetadata(keyToUse, bucketName);
+    } catch (err) {
+      console.error('[mbkbucket] serveFileInline metadata error:', err);
+      return res.status(500).json({ message: 'Failed to fetch file metadata', error: err.message });
+    }
+
+    if (!meta?.exists) return res.status(404).json({ message: 'File not found', key: keyToUse });
+
+    const etag = `"${new Date(meta.LastModified || Date.now()).getTime()}-${meta.ContentLength || 0}"`;
+    if (ifNoneMatch === etag) return res.status(304).end();
+
+    const total = Number(meta.ContentLength);
+    if (total) {
+      const range = parseRangeHeader(rangeHeader, total);
+      if (!range) {
+        res.status(416).setHeader('Content-Range', `bytes */${total}`);
+        return res.end();
+      }
+
+      const { start, end, size: chunksize } = range;
+      try {
+        const rangeResult = await downloadFile(keyToUse, { range: `bytes=${start}-${end}`, bucketName });
+        if (typeof rangeResult.ContentLength === 'number' && rangeResult.ContentLength !== chunksize) {
+          debugView('Range size mismatch for %s: expected=%s got=%s', keyToUse, chunksize, rangeResult.ContentLength);
+        }
+
+        debugView('Serving range bytes %s-%s/%s (%s bytes) for %s', start, end, total, chunksize, fileName);
+
+        res.status(206);
+        res.setHeader('Content-Range', `bytes ${start}-${end}/${total}`);
+        res.setHeader('Content-Length', chunksize);
+        res.setHeader('Content-Type', contentType);
+        res.setHeader('Content-Disposition', `inline; filename="${safeAsciiName}"; filename*=UTF-8''${encodedName}`);
+        res.setHeader('Cache-Control', buildCacheControl(contentType, { supportsRanges: true, publicCache }));
+        res.setHeader('ETag', etag);
+        res.setHeader('Accept-Ranges', 'bytes');
+        res.setHeader('X-Frame-Options', 'SAMEORIGIN');
+        if (noindex) res.setHeader('X-Robots-Tag', 'noindex, nofollow');
+        res.setHeader('X-Content-Type-Options', 'nosniff');
+        const stream = rangeResult.Body || rangeResult.stream;
+        attachStreamCleanup(req, res, stream);
+        return stream.pipe(res);
+      } catch (rangeError) {
+        console.error('[mbkbucket] Range request failed for %s:', keyToUse, rangeError);
+        if (!res.headersSent) {
+          return res.status(500).json({ message: 'Range stream failed', error: rangeError.message });
+        }
+        return;
+      }
+    }
+  }
+
+
+  // Standard path: full-file download
+  const downloadOptions = {
+    ...(ifNoneMatch && { ifNoneMatch }),
+    ...(ifModifiedSince && { ifModifiedSince: new Date(ifModifiedSince) }),
+    bucketName
+  };
+
+  if (isPdf) debugView('Serving full PDF (no range header) for %s', fileName);
+
+  let result;
+  try {
+    result = await downloadFile(keyToUse, downloadOptions);
+  } catch (err) {
+    if (err.name === 'NoSuchKey' || err.name === 'NotFound' || err.message?.includes('File not found')) {
+      return res.status(404).json({ message: 'File not found', key: keyToUse });
+    }
+    if (err.name === 'AccessDenied' || err.message?.includes('Access denied')) {
+      return res.status(403).json({ message: 'Access denied' });
+    }
+    console.error('[mbkbucket] serveFileInline download error:', err);
+    return res.status(500).json({ message: 'Failed to fetch file', error: err.message });
+  }
+
+  if (result?.notModified) return res.status(304).end();
+
+  const etag = `"${new Date(result.LastModified || Date.now()).getTime()}-${result.ContentLength || 0}"`;
+  if (ifNoneMatch === etag) return res.status(304).end();
+
+  res.setHeader('Content-Type', contentType);
+  res.setHeader('Content-Disposition', `inline; filename="${safeAsciiName}"; filename*=UTF-8''${encodedName}`);
+  res.setHeader('ETag', etag);
+  res.setHeader('X-Content-Type-Options', 'nosniff');
+  res.setHeader('X-Frame-Options', 'SAMEORIGIN');
+  if (noindex) res.setHeader('X-Robots-Tag', 'noindex, nofollow');
+  if (result.ContentLength) res.setHeader('Content-Length', result.ContentLength);
+  if (result.LastModified) res.setHeader('Last-Modified', new Date(result.LastModified).toUTCString());
+
+  if (fileExtension === 'html' || fileExtension === 'htm') {
+    res.setHeader('Content-Security-Policy', "default-src 'self'; script-src 'none'; object-src 'none';");
+  }
+  if (supportsRanges) res.setHeader('Accept-Ranges', 'bytes');
+  res.setHeader('Cache-Control', buildCacheControl(contentType, { isStaticAsset, supportsRanges, publicCache }));
+  res.status(200);
+
+  const stream = result.Body || result.stream;
+  const timeoutDuration = result.ContentLength > 50 * 1024 * 1024 ? 300000 : 120000;
+  attachStreamCleanup(req, res, stream, timeoutDuration);
+  stream.pipe(res);
+}
+
+
+export async function viewFile(req, res) {
+  try {
+    const key = normalizeKeyParam(req.params.key);
+    let keyToUse;
+    try {
+      keyToUse = ensureKeyHasAppPrefix(key);
+    } catch (e) {
+      return res.status(400).json({ message: e.message });
+    }
+
+    await serveFileInline(req, res, keyToUse, { noindex: true, bucketName: req.activeBucket, publicCache: false });
+  } catch (error) {
+    console.error("Error viewing file:", error);
+    if (error.name === 'NoSuchKey' || error.name === 'NotFound' || error.message?.includes('File not found')) {
+      res.status(404).json({ message: "File not found", key: req.params.key });
+    } else if (error.name === 'AccessDenied' || error.message?.includes('Access denied')) {
+      res.status(403).json({ message: "Access denied" });
+    } else {
+      res.status(500).json({ message: "View failed", error: error.message });
+    }
+  }
+}
+
+export async function playerPage(req, res) {
+  try {
+    const key = normalizeKeyParam(req.params.key);
+    let keyToUse;
+    try {
+      keyToUse = ensureKeyHasAppPrefix(key);
+    } catch (e) {
+      return res.status(400).send(e.message);
+    }
+
+    const html = renderPlayerPage(
+      escapeHtml(getBaseName(keyToUse)),
+      encodeURIComponent(keyToUse),
+      `?bucket=${encodeURIComponent(req.activeBucket)}`
+    );
+
+    res.setHeader('Content-Type', 'text/html; charset=utf-8');
+    res.setHeader('X-Content-Type-Options', 'nosniff');
+    return res.status(200).send(html);
+  } catch (err) {
+    console.error('Error rendering player page:', err);
+    return res.status(500).send('Failed to render player');
+  }
+}
+
+export async function publicView(req, res) {
+  try {
+    const bucketName = req.query?.bucket ? resolveStorageName(req.query.bucket) : resolveStorageName();
+    const key = normalizeKeyParam(req.params.key);
+
+    if (!key || key.endsWith('/')) {
+      return res.status(403).json({ message: 'Directory indexing is not allowed' });
+    }
+
+    let keyToUse;
+    try {
+      keyToUse = ensureKeyHasAppPrefix(key);
+    } catch (e) {
+      return res.status(400).json({ message: e.message });
+    }
+
+    await serveFileInline(req, res, keyToUse, { noindex: true, bucketName, publicCache: true });
+  } catch (error) {
+    console.error('[mbkbucket] p_view error:', error);
+    res.status(500).json({ message: 'Internal server error', error: error.message });
+  }
+}

package/lib/src/core/metrics.js

@@ -0,0 +1,134 @@
+/**
+ * MBKBucket - Metrics & Observability Registry
+ * Copyright (c) 2026 Muhammad Bin Khalid, MBKTech.org and contributors
+ * Licensed under the MIT License.
+ */
+
+export class MetricsRegistry {
+  constructor() {
+    this.reset();
+  }
+
+  reset() {
+    this.operations = new Map(); // key: "op:provider:status" -> count
+    this.durations = new Map();  // key: "op:provider" -> { totalMs, count, minMs, maxMs }
+    this.bytesTransferred = new Map(); // key: "direction:provider" -> bytes
+    this.errors = new Map(); // key: "op:provider:errorType" -> count
+    this.activeMultipart = 0;
+    this.startedAt = new Date().toISOString();
+  }
+
+  recordOperation(operation, { provider = 'unknown', status = 'success', durationMs = 0, bytes = 0 } = {}) {
+    const opKey = `${operation}:${provider}:${status}`;
+    this.operations.set(opKey, (this.operations.get(opKey) || 0) + 1);
+
+    if (durationMs >= 0) {
+      const durKey = `${operation}:${provider}`;
+      const existing = this.durations.get(durKey) || { totalMs: 0, count: 0, minMs: Infinity, maxMs: 0 };
+      existing.totalMs += durationMs;
+      existing.count += 1;
+      existing.minMs = Math.min(existing.minMs, durationMs);
+      existing.maxMs = Math.max(existing.maxMs, durationMs);
+      this.durations.set(durKey, existing);
+    }
+
+    if (bytes > 0) {
+      const direction = operation.startsWith('download') || operation.startsWith('view') ? 'outbound' : 'inbound';
+      const byteKey = `${direction}:${provider}`;
+      this.bytesTransferred.set(byteKey, (this.bytesTransferred.get(byteKey) || 0) + bytes);
+    }
+  }
+
+  recordError(operation, provider = 'unknown', errorType = 'Error') {
+    const errKey = `${operation}:${provider}:${errorType}`;
+    this.errors.set(errKey, (this.errors.get(errKey) || 0) + 1);
+  }
+
+  incrementActiveMultipart(delta = 1) {
+    this.activeMultipart = Math.max(0, this.activeMultipart + delta);
+  }
+
+  getStats() {
+    const ops = {};
+    for (const [key, count] of this.operations.entries()) {
+      ops[key] = count;
+    }
+
+    const durations = {};
+    for (const [key, d] of this.durations.entries()) {
+      durations[key] = {
+        count: d.count,
+        avgMs: d.count ? Math.round((d.totalMs / d.count) * 100) / 100 : 0,
+        minMs: d.minMs === Infinity ? 0 : d.minMs,
+        maxMs: d.maxMs
+      };
+    }
+
+    const bytes = {};
+    for (const [key, val] of this.bytesTransferred.entries()) {
+      bytes[key] = val;
+    }
+
+    const errs = {};
+    for (const [key, count] of this.errors.entries()) {
+      errs[key] = count;
+    }
+
+    return {
+      startedAt: this.startedAt,
+      activeMultipartUploads: this.activeMultipart,
+      operations: ops,
+      durations,
+      bytesTransferred: bytes,
+      errors: errs,
+      timestamp: new Date().toISOString()
+    };
+  }
+
+  toPrometheusText() {
+    const lines = [
+      '# HELP mbkbucket_operations_total Total number of storage operations executed',
+      '# TYPE mbkbucket_operations_total counter'
+    ];
+
+    for (const [key, count] of this.operations.entries()) {
+      const [operation, provider, status] = key.split(':');
+      lines.push(`mbkbucket_operations_total{operation="${operation}",provider="${provider}",status="${status}"} ${count}`);
+    }
+
+    lines.push('');
+    lines.push('# HELP mbkbucket_operation_duration_seconds Total duration of storage operations');
+    lines.push('# TYPE mbkbucket_operation_duration_seconds summary');
+    for (const [key, d] of this.durations.entries()) {
+      const [operation, provider] = key.split(':');
+      lines.push(`mbkbucket_operation_duration_seconds_count{operation="${operation}",provider="${provider}"} ${d.count}`);
+      lines.push(`mbkbucket_operation_duration_seconds_sum{operation="${operation}",provider="${provider}"} ${(d.totalMs / 1000).toFixed(4)}`);
+    }
+
+    lines.push('');
+    lines.push('# HELP mbkbucket_transferred_bytes_total Total bytes transferred into or out of storage');
+    lines.push('# TYPE mbkbucket_transferred_bytes_total counter');
+    for (const [key, bytes] of this.bytesTransferred.entries()) {
+      const [direction, provider] = key.split(':');
+      lines.push(`mbkbucket_transferred_bytes_total{direction="${direction}",provider="${provider}"} ${bytes}`);
+    }
+
+    lines.push('');
+    lines.push('# HELP mbkbucket_errors_total Total storage errors encountered');
+    lines.push('# TYPE mbkbucket_errors_total counter');
+    for (const [key, count] of this.errors.entries()) {
+      const [operation, provider, errorType] = key.split(':');
+      lines.push(`mbkbucket_errors_total{operation="${operation}",provider="${provider}",error_type="${errorType}"} ${count}`);
+    }
+
+    lines.push('');
+    lines.push('# HELP mbkbucket_active_multipart_uploads Current number of active multipart uploads');
+    lines.push('# TYPE mbkbucket_active_multipart_uploads gauge');
+    lines.push(`mbkbucket_active_multipart_uploads ${this.activeMultipart}`);
+    lines.push('');
+
+    return lines.join('\n');
+  }
+}
+
+export const metricsRegistry = new MetricsRegistry();