mbkbucket 3.3.0 → 3.3.1

package/index.js

@@ -1,8 +1,8 @@
 import dotenv from "dotenv";
-import { createApp } from "./src/app.js";
-import { checkVersion } from "./src/config/index.js";
-import { runHealthCheck } from "./src/services/s3.service.js";
-import { createLogger } from "./src/utils/logger.js";
+import { createApp } from "./lib/src/app.js";
+import { checkVersion } from "./lib/src/config/index.js";
+import { runHealthCheck } from "./lib/src/services/s3.service.js";
+import { createLogger } from "./lib/src/utils/logger.js";
 
 dotenv.config();
 
@@ -26,9 +26,9 @@ if (isDevMode) {
 }
 
 // Re-export the public API for consumers of this package (named exports only)
-export * from "./src/services/s3.service.js";
-export * from "./src/config/index.js";
-export { default as bucket } from "./src/routes/index.js";
+export * from "./lib/src/services/s3.service.js";
+export * from "./lib/src/config/index.js";
+export { default as bucket } from "./lib/src/routes/index.js";
 
 // Default export: the Express application instance
 export default server;

package/{cli.js → lib/cli.js}

@@ -22,7 +22,6 @@
 import dotenv from 'dotenv';
 import path from 'node:path';
 import fs from 'node:fs';
-import os from 'node:os';
 
 // Load .env from cwd first so S3 service can pick up BucketConnection etc.
 dotenv.config();

package/{src → lib/src}/config/index.js

@@ -14,7 +14,7 @@ try {
     packageJson = require("mbkbucket/package.json");
 } catch {
     // Fallback to relative path (for development/testing)
-    packageJson = require("../../package.json");
+    packageJson = require("../../../package.json");
 }
 
 // Parent project version

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mbkbucket",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "description": "Flexible S3/R2 bucket management — library, Express router, and CLI for mbktech.org applications. Provides upload, download, listing, multipart utilities, signed URLs, and a command-line interface with built-in configuration validation and health checks",
   "author": "Muhammad Bin Khalid",
   "homepage": "https://github.com/MIbnEKhalid/mbkbucket#readme",
@@ -9,7 +9,7 @@
   "type": "module",
   "types": "index.d.ts",
   "bin": {
-    "mbkbucket": "./cli.js"
+    "mbkbucket": "./lib/cli.js"
   },
   "scripts": {
     "dev": "cross-env NODE_ENV=dev nodemon index.js",
@@ -44,6 +44,16 @@
   "bugs": {
     "url": "https://github.com/MIbnEKhalid/mbkbucket/issues"
   },
+  "files": [
+    "lib",
+    ".env.example",
+    ".mbkbucket.config.example.json",
+    "cli.js",
+    "index.js",
+    "LICENSE",
+    "package.json",
+    "README.md"
+  ],
   "keywords": [
     "mbkbucket",
     "s3-bucket",
@@ -62,4 +72,4 @@
     "file-upload",
     "file-download"
   ]
-}
+}

package/.github/PACKAGE.md

@@ -1,19 +0,0 @@
-# Package Information
-
-This package is published on npm: [mbkbucket](https://www.npmjs.com/package/mbkbucket)
-
-## Installation
-
-```bash
-npm install mbkbucket
-```
-
-## What's Included
-
-- **Library** — Full S3/R2 bucket management API (upload, download, list, delete, multipart, signed URLs)
-- **Express Router** — Ready-to-use admin dashboard with Handlebars templates
-- **CLI** — Command-line interface for managing buckets from the terminal ⚠️ *under development*
-
-## Registry
-
-Published to: npm Registry (https://registry.npmjs.org/)

package/.github/workflows/publish.yml

@@ -1,88 +0,0 @@
-name: Publish to npm and GitHub Packages
-on:
-  push:
-    branches:
-      - main
-      - master
-
-permissions:
-  contents: read
-  packages: write
-
-jobs:
-  publish:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      packages: write
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v3
-
-      - name: Setup Node.js for npm
-        uses: actions/setup-node@v3
-        with:
-          node-version: '18'
-          registry-url: 'https://registry.npmjs.org'
-
-      - name: Cache Node.js modules
-        uses: actions/cache@v3
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
-
-      - name: Install dependencies
-        run: |
-          for i in {1..3}; do npm install && break || sleep 10; done
-
-      - name: Check if version exists on npm
-        id: check_version
-        run: |
-          PACKAGE_NAME=$(node -p "require('./package.json').name")
-          VERSION=$(node -p "require('./package.json').version")
-          if npm view $PACKAGE_NAME@$VERSION version 2>/dev/null; then
-            echo "exists=true" >> $GITHUB_OUTPUT
-            echo "Version $VERSION already exists on npm"
-          else
-            echo "exists=false" >> $GITHUB_OUTPUT
-            echo "Version $VERSION does not exist, will publish"
-          fi
-
-      - name: Publish to npm
-        if: steps.check_version.outputs.exists == 'false'
-        run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-
-      - name: Check if version exists on GitHub Packages
-        id: check_github_version
-        run: |
-          VERSION=$(node -p "require('./package.json').version")
-          if curl -f -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-            https://npm.pkg.github.com/@mibnekhalid/mbkbucket/$VERSION 2>/dev/null; then
-            echo "exists=true" >> $GITHUB_OUTPUT
-            echo "Version $VERSION already exists on GitHub Packages"
-          else
-            echo "exists=false" >> $GITHUB_OUTPUT
-            echo "Version $VERSION does not exist on GitHub Packages, will publish"
-          fi
-
-      - name: Modify package.json for GitHub Packages
-        if: steps.check_github_version.outputs.exists == 'false'
-        run: |
-          node -e "const pkg = require('./package.json'); pkg.name = '@mibnekhalid/mbkbucket'; pkg.publishConfig = { registry: 'https://npm.pkg.github.com' }; require('fs').writeFileSync('package.json', JSON.stringify(pkg, null, 2));"
-
-      - name: Setup Node.js for GitHub Packages
-        if: steps.check_github_version.outputs.exists == 'false'
-        uses: actions/setup-node@v3
-        with:
-          node-version: '18'
-          registry-url: 'https://npm.pkg.github.com'
-
-      - name: Publish to GitHub Packages
-        if: steps.check_github_version.outputs.exists == 'false'
-        run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

package/index.d.ts

@@ -1,444 +0,0 @@
-// Type definitions for mbkbucket
-// Project: https://github.com/MIbnEKhalid/mbkbucket
-
-import { Readable } from "stream";
-import { Router, Application } from "express";
-
-/**
- * Shared types used across the package
- */
-export interface BucketConfig {
-  BUCKET_NAME: string;
-  ENDPOINT?: string;
-  ACCESS_KEY_ID?: string;
-  SECRET_ACCESS_KEY?: string;
-  region?: string;
-  [key: string]: any;
-}
-
-export type BucketConnectionMap = Record<string, BucketConfig>;
-
-export interface S3ObjectResult {
-  Body: Readable;
-  ContentLength?: number;
-  ContentType?: string;
-  LastModified?: Date;
-  Key?: string;
-  [key: string]: any;
-}
-
-export interface UploadOptions {
-  metadata?: Record<string, string>;
-  cacheControl?: string;
-  storageClass?: string;
-  serverSideEncryption?: string;
-  bucketName?: string;
-  preventOverwrite?: boolean;
-  [key: string]: any;
-}
-
-export interface ListFilesOptions {
-  maxKeys?: number;
-  continuationToken?: string | null;
-  delimiter?: string | null;
-  fetchOwner?: boolean;
-  startAfter?: string | null;
-  bucketName?: string;
-  [key: string]: any;
-}
-
-export interface ListFilesResult extends Record<string, any> {
-  requestedAt: string;
-  totalFiles: number;
-  hasMore: boolean;
-  nextToken: string | null;
-}
-
-export interface IncompleteMultipartUpload {
-  Key?: string;
-  UploadId?: string;
-  Initiated?: string;
-  Initiator?: { DisplayName?: string; [key: string]: any };
-  [key: string]: any;
-}
-
-export interface CleanupResult {
-  abortedCount: number;
-  uploads: Array<{ key: string; uploadId: string; initiated?: string }>;
-  cleanedAt?: string;
-  [key: string]: any;
-}
-
-export interface ConfigVars {
-  publiView_enabled: boolean;
-  p_view_inline: boolean;
-  [key: string]: any;
-}
-
-/**
- * S3 exports (re-exported from lib/s3.js at package root)
- */
-export function getAvailableBucketNames(): string[];
-export function resolveBucketName(bucketName?: string | null): string;
-export function getBucketConfig(bucketName?: string): BucketConfig;
-export const bucketClient: any;
-export function getAppName(): string;
-export function ensureKeyHasAppPrefix(key?: string): string;
-export function ensurePrefix(prefix?: string): string;
-export function getBucketClient(bucketName?: string): any;
-export function checkHealth(): Promise<{ status: string; responseTime?: number; bucket?: string; error?: string; checkedAt: string; region?: string; }>;
-
-export function uploadFile(
-  key: string,
-  fileBuffer: Buffer | Uint8Array,
-  contentType: string,
-  options?: UploadOptions
-): Promise<{ fileSize?: number; key: string; contentType?: string; uploadedAt?: string; } & Record<string, any>>;
-
-export function downloadFile(
-  key: string,
-  options?: {
-    range?: string | null;
-    ifNoneMatch?: string | null;
-    ifModifiedSince?: Date | string | null;
-    responseCacheControl?: string | null;
-    responseContentType?: string | null;
-    bucketName?: string;
-    [key: string]: any;
-  }
-): Promise<S3ObjectResult>;
-
-export function deleteFile(key: string, bucketName?: string): Promise<{ key: string; deletedAt?: string } & Record<string, any>>;
-
-export function deleteFiles(keys: string[], bucketName?: string): Promise<{
-  results: any[];
-  deletedCount: number;
-  errors: any[];
-  deletedAt: string;
-}>;
-
-export function deleteFolder(prefix: string, bucketName?: string): Promise<{
-  results?: any[];
-  deletedCount: number;
-  errors?: any[];
-  deletedAt: string;
-  prefix?: string;
-}>;
-
-export function listfiles(prefix?: string, options?: ListFilesOptions): Promise<ListFilesResult>;
-
-export function getFileMetadata(key: string, bucketName?: string): Promise<{
-  key: string;
-  exists: boolean;
-  queriedAt: string;
-  ContentLength?: number;
-  ContentType?: string;
-  LastModified?: Date;
-  [key: string]: any;
-}>;
-
-export function fileExists(key: string, bucketName?: string): Promise<boolean>;
-export function getFileSize(key: string, bucketName?: string): Promise<number | null>;
-
-export function generateSignedUrl(
-  key: string,
-  operation?: "getObject" | "putObject" | string,
-  expiresIn?: number,
-  bucketName?: string
-): Promise<{
-  url: string;
-  key: string;
-  operation: string;
-  expiresIn: number;
-  expiresAt: string;
-  generatedAt: string;
-}>;
-
-export function createMultipartUpload(
-  key: string,
-  contentType?: string,
-  metadata?: Record<string, string>,
-  bucketName?: string
-): Promise<{ uploadId: string; key: string }>;
-
-export function uploadPart(
-  key: string,
-  uploadId: string,
-  partNumber: number,
-  buffer: Buffer | Uint8Array,
-  bucketName?: string
-): Promise<{ ETag: string; partNumber: number }>;
-
-export function completeMultipartUpload(
-  key: string,
-  uploadId: string,
-  parts: Array<{ partNumber: number; ETag: string }>,
-  bucketName?: string
-): Promise<{ key: string }>;
-
-export function abortMultipartUpload(
-  key: string,
-  uploadId: string,
-  bucketName?: string
-): Promise<{ key: string; abortedAt: string }>;
-
-export function listIncompleteMultipartUploads(
-  prefix?: string,
-  bucketName?: string
-): Promise<IncompleteMultipartUpload[]>;
-
-export function cleanupIncompleteMultipartUploads(
-  olderThanDays?: number,
-  prefix?: string,
-  bucketName?: string
-): Promise<CleanupResult>;
-
-/**
- * Config exports (re-exported from lib/config/index.js at package root)
- */
-export const packageJson: Record<string, any>;
-export const appVersion: string;
-export const mbkbucketVar: ConfigVars;
-export function getLatestVersion(): Promise<string | null>;
-export function checkVersion(): Promise<void>;
-export function parseAndValidateMbkbucketVar(rawValue?: string): ConfigVars;
-export function parseAndValidateBucketConnection(rawValue?: string): BucketConnectionMap | null;
-
-/**
- * Router export (re-exported from lib/routes/index.js at package root as `bucket`)
- */
-export const bucket: Router;
-
-/**
- * Root default export from index.js: configured Express application
- */
-declare const server: Application;
-export default server;
-
-/**
- * Subpath module declarations
- */
-declare module "mbkbucket/lib/s3" {
-  import { Readable } from "stream";
-
-  export interface BucketConfig {
-    BUCKET_NAME: string;
-    ENDPOINT?: string;
-    ACCESS_KEY_ID?: string;
-    SECRET_ACCESS_KEY?: string;
-    region?: string;
-    [key: string]: any;
-  }
-
-  export type BucketConnectionMap = Record<string, BucketConfig>;
-
-  export interface S3ObjectResult {
-    Body: Readable;
-    ContentLength?: number;
-    ContentType?: string;
-    LastModified?: Date;
-    Key?: string;
-    [key: string]: any;
-  }
-
-  export interface UploadOptions {
-    metadata?: Record<string, string>;
-    cacheControl?: string;
-    storageClass?: string;
-    serverSideEncryption?: string;
-    bucketName?: string;
-    preventOverwrite?: boolean;
-    [key: string]: any;
-  }
-
-  export interface ListFilesOptions {
-    maxKeys?: number;
-    continuationToken?: string | null;
-    delimiter?: string | null;
-    fetchOwner?: boolean;
-    startAfter?: string | null;
-    bucketName?: string;
-    [key: string]: any;
-  }
-
-  export interface ListFilesResult extends Record<string, any> {
-    requestedAt: string;
-    totalFiles: number;
-    hasMore: boolean;
-    nextToken: string | null;
-  }
-
-  export interface IncompleteMultipartUpload {
-    Key?: string;
-    UploadId?: string;
-    Initiated?: string;
-    Initiator?: { DisplayName?: string; [key: string]: any };
-    [key: string]: any;
-  }
-
-  export interface CleanupResult {
-    abortedCount: number;
-    uploads: Array<{ key: string; uploadId: string; initiated?: string }>;
-    cleanedAt?: string;
-    [key: string]: any;
-  }
-
-  export function getAvailableBucketNames(): string[];
-  export function resolveBucketName(bucketName?: string | null): string;
-  export function getBucketConfig(bucketName?: string): BucketConfig;
-  export const bucketClient: any;
-  export function getAppName(): string;
-  export function ensureKeyHasAppPrefix(key?: string): string;
-  export function ensurePrefix(prefix?: string): string;
-  export function getBucketClient(bucketName?: string): any;
-  export function checkHealth(): Promise<{ status: string; responseTime?: number; bucket?: string; error?: string; checkedAt: string; region?: string; }>;
-
-  export function uploadFile(
-    key: string,
-    fileBuffer: Buffer | Uint8Array,
-    contentType: string,
-    options?: UploadOptions
-  ): Promise<{ fileSize?: number; key: string; contentType?: string; uploadedAt?: string } & Record<string, any>>;
-
-  export function downloadFile(
-    key: string,
-    options?: {
-      range?: string | null;
-      ifNoneMatch?: string | null;
-      ifModifiedSince?: Date | string | null;
-      responseCacheControl?: string | null;
-      responseContentType?: string | null;
-      bucketName?: string;
-      [key: string]: any;
-    }
-  ): Promise<S3ObjectResult>;
-
-  export function deleteFile(key: string, bucketName?: string): Promise<{ key: string; deletedAt?: string } & Record<string, any>>;
-  export function deleteFiles(keys: string[], bucketName?: string): Promise<{
-    results: any[];
-    deletedCount: number;
-    errors: any[];
-    deletedAt: string;
-  }>;
-
-  export function deleteFolder(prefix: string, bucketName?: string): Promise<{
-    results?: any[];
-    deletedCount: number;
-    errors?: any[];
-    deletedAt: string;
-    prefix?: string;
-  }>;
-
-  export function listfiles(prefix?: string, options?: ListFilesOptions): Promise<ListFilesResult>;
-
-  export function getFileMetadata(key: string, bucketName?: string): Promise<{
-    key: string;
-    exists: boolean;
-    queriedAt: string;
-    ContentLength?: number;
-    ContentType?: string;
-    LastModified?: Date;
-    [key: string]: any;
-  }>;
-
-  export function fileExists(key: string, bucketName?: string): Promise<boolean>;
-  export function getFileSize(key: string, bucketName?: string): Promise<number | null>;
-
-  export function generateSignedUrl(
-    key: string,
-    operation?: "getObject" | "putObject" | string,
-    expiresIn?: number,
-    bucketName?: string
-  ): Promise<{
-    url: string;
-    key: string;
-    operation: string;
-    expiresIn: number;
-    expiresAt: string;
-    generatedAt: string;
-  }>;
-
-  export function createMultipartUpload(
-    key: string,
-    contentType?: string,
-    metadata?: Record<string, string>,
-    bucketName?: string
-  ): Promise<{ uploadId: string; key: string }>;
-
-  export function uploadPart(
-    key: string,
-    uploadId: string,
-    partNumber: number,
-    buffer: Buffer | Uint8Array,
-    bucketName?: string
-  ): Promise<{ ETag: string; partNumber: number }>;
-
-  export function completeMultipartUpload(
-    key: string,
-    uploadId: string,
-    parts: Array<{ partNumber: number; ETag: string }>,
-    bucketName?: string
-  ): Promise<{ key: string }>;
-
-  export function abortMultipartUpload(
-    key: string,
-    uploadId: string,
-    bucketName?: string
-  ): Promise<{ key: string; abortedAt: string }>;
-
-  export function listIncompleteMultipartUploads(
-    prefix?: string,
-    bucketName?: string
-  ): Promise<IncompleteMultipartUpload[]>;
-
-  export function cleanupIncompleteMultipartUploads(
-    olderThanDays?: number,
-    prefix?: string,
-    bucketName?: string
-  ): Promise<CleanupResult>;
-}
-
-declare module "mbkbucket/lib/config/index" {
-  export interface ConfigVars {
-    publiView_enabled: boolean;
-    p_view_inline: boolean;
-    [key: string]: any;
-  }
-
-  export interface BucketConfig {
-    BUCKET_NAME: string;
-    ENDPOINT?: string;
-    ACCESS_KEY_ID?: string;
-    SECRET_ACCESS_KEY?: string;
-    region?: string;
-    [key: string]: any;
-  }
-
-  export type BucketConnectionMap = Record<string, BucketConfig>;
-
-  export const packageJson: Record<string, any>;
-  export const appVersion: string;
-  export const mbkbucketVar: ConfigVars;
-  export function getLatestVersion(): Promise<string | null>;
-  export function checkVersion(): Promise<void>;
-  export function parseAndValidateMbkbucketVar(rawValue?: string): ConfigVars;
-  export function parseAndValidateBucketConnection(rawValue?: string): BucketConnectionMap | null;
-}
-
-declare module "mbkbucket/lib/config/validation" {
-  export function normalizeBooleanLike(value: any): any;
-  export function parseAndValidateMbkbucketVar(rawValue?: string): { [key: string]: any };
-  export function parseAndValidateBucketConnection(rawValue?: string): Record<string, any> | null;
-}
-
-declare module "mbkbucket/lib/routes/index" {
-  import { Router } from "express";
-  const router: Router;
-  export default router;
-}
-
-declare module "mbkbucket/lib/bucket" {
-  import { Router } from "express";
-  const router: Router;
-  export default router;
-}

package/lib/index.js

@@ -1,17 +0,0 @@
-// Barrel file: re-export all public items from the restructured src/ directory
-export * from '../src/services/s3.service.js';
-export * from '../src/config/index.js';
-export { default as bucket } from '../src/routes/index.js';
-
-import * as s3 from '../src/services/s3.service.js';
-import * as config from '../src/config/index.js';
-import bucket from '../src/routes/index.js';
-
-// Default aggregate export for convenience
-const defaultExport = {
-  ...s3,
-  ...config,
-  bucket,
-};
-
-export default defaultExport;

package/test/config-validation.test.js

@@ -1,116 +0,0 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import { parseAndValidateMbkbucketVar, parseAndValidateBucketConnection, normalizeBooleanLike } from '../src/config/validation.js';
-
-test('parseAndValidateMbkbucketVar applies defaults when empty', () => {
-  const cfg = parseAndValidateMbkbucketVar(undefined);
-  assert.equal(cfg.p_view_inline, true);
-  assert.equal(cfg.publiView_enabled, false);
-});
-
-test('parseAndValidateMbkbucketVar normalizes boolean-like strings', () => {
-  const cfg = parseAndValidateMbkbucketVar(JSON.stringify({
-    p_view_inline: 'false',
-    publiView_enabled: 'true'
-  }));
-
-  assert.equal(cfg.p_view_inline, false);
-  assert.equal(cfg.publiView_enabled, true);
-});
-
-test('parseAndValidateMbkbucketVar rejects invalid JSON', () => {
-  assert.throws(() => parseAndValidateMbkbucketVar('{oops'), /Invalid JSON/);
-});
-
-test('parseAndValidateMbkbucketVar rejects invalid boolean values', () => {
-  assert.throws(() => parseAndValidateMbkbucketVar(JSON.stringify({
-    p_view_inline: 'not-bool'
-  })), /must be a boolean/);
-});
-
-test('parseAndValidateMbkbucketVar accepts common boolean aliases', () => {
-  const cfg = parseAndValidateMbkbucketVar(JSON.stringify({
-    p_view_inline: ' ON ',
-    publiView_enabled: '0'
-  }));
-
-  assert.equal(cfg.p_view_inline, true);
-  assert.equal(cfg.publiView_enabled, false);
-});
-
-test('parseAndValidateMbkbucketVar rejects non-object values', () => {
-  assert.throws(() => parseAndValidateMbkbucketVar('null'), /must be a valid object/);
-  assert.throws(() => parseAndValidateMbkbucketVar('[]'), /must be a valid object/);
-});
-
-test('normalizeBooleanLike returns untouched for unsupported values', () => {
-  assert.equal(normalizeBooleanLike('maybe'), 'maybe');
-  assert.equal(normalizeBooleanLike(123), 123);
-});
-
-test('parseAndValidateBucketConnection accepts multi-bucket config', () => {
-  const raw = JSON.stringify({
-    R2_Bucket: {
-      BUCKET_NAME: 'my-r2-bucket',
-      ACCESS_KEY_ID: 'abc',
-      SECRET_ACCESS_KEY: 'def',
-      ENDPOINT: 'https://example.r2.cloudflarestorage.com'
-    },
-    S3_Bucket: {
-      BUCKET_NAME: 'my-s3-bucket',
-      ACCESS_KEY_ID: 'ghi',
-      SECRET_ACCESS_KEY: 'jkl',
-      ENDPOINT: 'https://s3.ap-southeast-1.amazonaws.com'
-    }
-  });
-
-  const cfg = parseAndValidateBucketConnection(raw);
-  assert.deepEqual(Object.keys(cfg), ['R2_Bucket', 'S3_Bucket']);
-});
-
-test('parseAndValidateBucketConnection returns null when unset', () => {
-  assert.equal(parseAndValidateBucketConnection(undefined), null);
-  assert.equal(parseAndValidateBucketConnection(''), null);
-});
-
-test('parseAndValidateBucketConnection rejects invalid JSON', () => {
-  assert.throws(() => parseAndValidateBucketConnection('{oops'), /not valid JSON/);
-});
-
-test('parseAndValidateBucketConnection rejects empty object and array', () => {
-  assert.throws(() => parseAndValidateBucketConnection('{}'), /non-empty object/);
-  assert.throws(() => parseAndValidateBucketConnection('[]'), /non-empty object/);
-});
-
-test('parseAndValidateBucketConnection rejects missing required fields', () => {
-  const raw = JSON.stringify({
-    bad: {
-      BUCKET_NAME: 'x',
-      ACCESS_KEY_ID: 'y',
-      ENDPOINT: 'https://example.com'
-    }
-  });
-
-  assert.throws(() => parseAndValidateBucketConnection(raw), /missing required fields/);
-});
-
-test('parseAndValidateBucketConnection rejects quoted inner object shape', () => {
-  const raw = JSON.stringify({
-    bad: '{"BUCKET_NAME":"x"}'
-  });
-
-  assert.throws(() => parseAndValidateBucketConnection(raw), /must be an object/);
-});
-
-test('parseAndValidateBucketConnection rejects empty required fields', () => {
-  const raw = JSON.stringify({
-    bad: {
-      BUCKET_NAME: '',
-      ACCESS_KEY_ID: 'abc',
-      SECRET_ACCESS_KEY: 'def',
-      ENDPOINT: 'https://example.com'
-    }
-  });
-
-  assert.throws(() => parseAndValidateBucketConnection(raw), /missing required fields/);
-});