maxsimcli 4.16.0 → 5.0.0

package/dist/install.cjs

@@ -7290,6 +7290,7 @@ const builtInSkills = [
 	"commit-conventions",
 	"evidence-collection",
 	"github-artifact-protocol",
+	"github-tools-guide",
 	"handoff-contract",
 	"input-validation",
 	"research-methodology",
@@ -7581,6 +7582,8 @@ function configureSettingsHooks(targetDir) {
 	const statuslineCommand = "node " + dirName + "/hooks/maxsim-statusline.js";
 	const updateCheckCommand = "node " + dirName + "/hooks/maxsim-check-update.js";
 	const syncReminderCommand = "node " + dirName + "/hooks/maxsim-sync-reminder.js";
+	const notificationSoundCommand = "node " + dirName + "/hooks/maxsim-notification-sound.js";
+	const stopSoundCommand = "node " + dirName + "/hooks/maxsim-stop-sound.js";
 	if (!settings.hooks) settings.hooks = {};
 	const installHooks = settings.hooks;
 	if (!installHooks.SessionStart) installHooks.SessionStart = [];
@@ -7602,12 +7605,32 @@ function configureSettingsHooks(targetDir) {
 		});
 		console.log(`  ${chalk.green("✓")} Configured sync reminder hook`);
 	}
+	if (!installHooks.PostToolUse.some((entry) => entry.hooks && entry.hooks.some((h) => h.command && h.command.includes("maxsim-notification-sound")))) {
+		installHooks.PostToolUse.push({
+			matcher: "AskUserQuestion",
+			hooks: [{
+				type: "command",
+				command: notificationSoundCommand
+			}]
+		});
+		console.log(`  ${chalk.green("✓")} Configured notification sound hook`);
+	}
+	if (!installHooks.Stop) installHooks.Stop = [];
+	if (!installHooks.Stop.some((entry) => entry.hooks && entry.hooks.some((h) => h.command && h.command.includes("maxsim-stop-sound")))) {
+		installHooks.Stop.push({ hooks: [{
+			type: "command",
+			command: stopSoundCommand
+		}] });
+		console.log(`  ${chalk.green("✓")} Configured stop sound hook`);
+	}
 	return {
 		settingsPath,
 		settings,
 		statuslineCommand,
 		updateCheckCommand,
-		syncReminderCommand
+		syncReminderCommand,
+		notificationSoundCommand,
+		stopSoundCommand
 	};
 }
 /**
@@ -8002,6 +8025,25 @@ function uninstall(isGlobal, explicitConfigDir = null) {
 			console.log(`  ${chalk.green("✓")} Removed MAXSIM package.json`);
 		}
 	} catch {}
+	const mcpJsonPath = node_path.join(process.cwd(), ".mcp.json");
+	if (node_fs.existsSync(mcpJsonPath)) try {
+		const mcpConfig = JSON.parse(node_fs.readFileSync(mcpJsonPath, "utf-8"));
+		const mcpServers = mcpConfig.mcpServers;
+		if (mcpServers && mcpServers["maxsim"]) {
+			delete mcpServers["maxsim"];
+			if (Object.keys(mcpServers).length === 0) delete mcpConfig.mcpServers;
+			if (Object.keys(mcpConfig).length === 0) node_fs.unlinkSync(mcpJsonPath);
+			else node_fs.writeFileSync(mcpJsonPath, JSON.stringify(mcpConfig, null, 2) + "\n", "utf-8");
+			removedCount++;
+			console.log(`  ${chalk.green("✓")} Removed MAXSIM MCP entry from .mcp.json`);
+		}
+	} catch {}
+	const mcpBinPath = node_path.join(targetDir, "maxsim", "bin", "mcp-server.cjs");
+	if (node_fs.existsSync(mcpBinPath)) {
+		node_fs.unlinkSync(mcpBinPath);
+		removedCount++;
+		console.log(`  ${chalk.green("✓")} Removed mcp-server.cjs binary`);
+	}
 	const settingsPath = node_path.join(targetDir, "settings.json");
 	if (node_fs.existsSync(settingsPath)) {
 		const settings = readSettings(settingsPath);
@@ -8281,46 +8323,27 @@ async function install() {
 		console.warn(`  ${chalk.yellow("!")} cli.cjs not found at ${toolSrc} -- maxsim-tools.cjs not installed`);
 		failures.push("maxsim-tools.cjs");
 	}
-	const mcpSrc = node_path.resolve(__dirname, "mcp-server.cjs");
-	const mcpDest = node_path.join(binDir, "mcp-server.cjs");
-	if (node_fs.existsSync(mcpSrc)) {
-		node_fs.mkdirSync(binDir, { recursive: true });
-		node_fs.copyFileSync(mcpSrc, mcpDest);
-		console.log(`  ${chalk.green("✓")} Installed mcp-server.cjs`);
-	} else console.warn(`  ${chalk.yellow("!")} mcp-server.cjs not found -- MCP server not installed`);
 	installHookFiles(targetDir, failures);
 	const mcpJsonPath = node_path.join(process.cwd(), ".mcp.json");
-	let mcpConfig = {};
-	let skipMcpConfig = false;
-	if (node_fs.existsSync(mcpJsonPath)) {
-		node_fs.copyFileSync(mcpJsonPath, mcpJsonPath + ".bak");
-		try {
-			mcpConfig = JSON.parse(node_fs.readFileSync(mcpJsonPath, "utf-8"));
-		} catch {
-			console.warn(`  ${chalk.yellow("!")} .mcp.json is corrupted (invalid JSON). Backup saved to .mcp.json.bak`);
-			let startFresh = true;
-			try {
-				startFresh = await dist_default({
-					message: ".mcp.json is corrupted. Start with a fresh config? (No = abort MCP setup)",
-					default: true
-				});
-			} catch {}
-			if (!startFresh) {
-				console.log(`  ${chalk.yellow("!")} Skipping .mcp.json configuration`);
-				skipMcpConfig = true;
+	if (node_fs.existsSync(mcpJsonPath)) try {
+		const mcpConfig = JSON.parse(node_fs.readFileSync(mcpJsonPath, "utf-8"));
+		const mcpServers = mcpConfig.mcpServers;
+		if (mcpServers && mcpServers["maxsim"]) {
+			delete mcpServers["maxsim"];
+			if (Object.keys(mcpServers).length === 0) delete mcpConfig.mcpServers;
+			if (Object.keys(mcpConfig).length === 0) {
+				node_fs.unlinkSync(mcpJsonPath);
+				console.log(`  ${chalk.green("✓")} Removed .mcp.json (no remaining MCP servers)`);
+			} else {
+				node_fs.writeFileSync(mcpJsonPath, JSON.stringify(mcpConfig, null, 2) + "\n", "utf-8");
+				console.log(`  ${chalk.green("✓")} Removed MAXSIM MCP entry from .mcp.json`);
 			}
 		}
-	}
-	if (!skipMcpConfig) {
-		const mcpServers = mcpConfig.mcpServers ?? {};
-		mcpServers["maxsim"] = {
-			command: "node",
-			args: [".claude/maxsim/bin/mcp-server.cjs"],
-			env: {}
-		};
-		mcpConfig.mcpServers = mcpServers;
-		node_fs.writeFileSync(mcpJsonPath, JSON.stringify(mcpConfig, null, 2) + "\n", "utf-8");
-		console.log(`  ${chalk.green("✓")} Configured .mcp.json for MCP server auto-discovery`);
+	} catch {}
+	const oldMcpBin = node_path.join(binDir, "mcp-server.cjs");
+	if (node_fs.existsSync(oldMcpBin)) {
+		node_fs.unlinkSync(oldMcpBin);
+		console.log(`  ${chalk.green("✓")} Removed legacy mcp-server.cjs`);
 	}
 	if (failures.length > 0) {
 		console.error(`\n  ${chalk.yellow("Installation incomplete!")} Failed: ${failures.join(", ")}`);