matterbridge-roborock-vacuum-plugin 1.1.0-rc04 → 1.1.0-rc05

package/dist/platform.js

@@ -82,7 +82,7 @@ export class RoborockMatterbridgePlatform extends MatterbridgeDynamicPlatform {
             this.log.error('Initializing: No device found');
             return;
         }
-        if (!this.enableExperimentalFeature || !this.enableExperimentalFeature.advancedFeature.enableServerMode) {
+        if (!this.enableExperimentalFeature?.enableExperimentalFeature || !this.enableExperimentalFeature?.advancedFeature?.enableServerMode) {
             vacuums = [vacuums[0]];
         }
         for (const vacuum of vacuums) {

package/matterbridge-roborock-vacuum-plugin.config.json

@@ -1,7 +1,7 @@
 {
   "name": "matterbridge-roborock-vacuum-plugin",
   "type": "DynamicPlatform",
-  "version": "1.1.0-rc04",
+  "version": "1.1.0-rc05",
   "whiteList": [],
   "blackList": [],
   "useInterval": true,

package/matterbridge-roborock-vacuum-plugin.schema.json

@@ -1,6 +1,6 @@
 {
   "title": "Matterbridge Roborock Vacuum Plugin",
-  "description": "matterbridge-roborock-vacuum-plugin v. 1.1.0-rc04 by https://github.com/RinDevJunior",
+  "description": "matterbridge-roborock-vacuum-plugin v. 1.1.0-rc05 by https://github.com/RinDevJunior",
   "type": "object",
   "required": [
     "username",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "matterbridge-roborock-vacuum-plugin",
-  "version": "1.1.0-rc04",
+  "version": "1.1.0-rc05",
   "description": "Matterbridge Roborock Vacuum Plugin",
   "author": "https://github.com/RinDevJunior",
   "license": "MIT",

package/src/platform.ts

@@ -111,7 +111,7 @@ export class RoborockMatterbridgePlatform extends MatterbridgeDynamicPlatform {
       return;
     }
 
-    if (!this.enableExperimentalFeature || !this.enableExperimentalFeature.advancedFeature.enableServerMode) {
+    if (!this.enableExperimentalFeature?.enableExperimentalFeature || !this.enableExperimentalFeature?.advancedFeature?.enableServerMode) {
       vacuums = [vacuums[0]]; // If server mode is not enabled, only use the first vacuum
     }
     // else {

package/src/tests/roborockService.test.ts

@@ -2,6 +2,7 @@ import { AnsiLogger } from 'matterbridge/logger';
 import { ServiceArea } from 'matterbridge/matter/clusters';
 import RoborockService from '../roborockService';
 import { MessageProcessor } from '../roborockCommunication/broadcast/messageProcessor';
+import { Device } from '../roborockCommunication';
 
 describe('RoborockService - startClean', () => {
   let roborockService: RoborockService;
@@ -152,7 +153,15 @@ describe('RoborockService - startClean', () => {
     expect(mockLogger.debug).toHaveBeenCalledWith('RoborockService - startRoomClean', expect.anything());
     expect(mockMessageProcessor.startRoomClean).toHaveBeenCalledWith(duid, [1, 3], 1);
   });
+
+  it('should initialize and store MessageProcessor for the given duid', () => {
+    const duid = 'test-duid';
+    roborockService.initializeMessageClientForLocal({ duid } as Device);
+    const storedProcessor = roborockService['messageProcessorMap'].get(duid);
+    expect(storedProcessor).not.toBeUndefined();
+  });
 });
+
 describe('RoborockService - basic setters/getters', () => {
   let roborockService: RoborockService;
   let mockLogger: AnsiLogger;

package/src/tests/roborockService2.test.ts

@@ -0,0 +1,69 @@
+import { AnsiLogger } from 'matterbridge/logger';
+import RoborockService from '../roborockService';
+import { MessageProcessor } from '../roborockCommunication/broadcast/messageProcessor';
+import { Device, DeviceStatus } from '../roborockCommunication';
+
+jest.useFakeTimers();
+
+describe('RoborockService - activateDeviceNotify', () => {
+  let roborockService: RoborockService;
+  let mockLogger: AnsiLogger;
+  let mockMessageProcessor: jest.Mocked<MessageProcessor>;
+  let mockDeviceNotify: jest.Mock;
+
+  beforeEach(() => {
+    mockLogger = {
+      debug: jest.fn(),
+      notice: jest.fn(),
+      error: jest.fn(),
+      warn: jest.fn(),
+    } as any;
+
+    mockMessageProcessor = {
+      getDeviceStatus: jest.fn(),
+    } as any;
+
+    mockDeviceNotify = jest.fn(() => {
+      jest.fn();
+    });
+
+    roborockService = new RoborockService(jest.fn(), jest.fn(), 1, {} as any, mockLogger); // refreshInterval = 1
+    roborockService['deviceNotify'] = mockDeviceNotify;
+    roborockService['getMessageProcessor'] = jest.fn().mockReturnValue(mockMessageProcessor);
+    roborockService['refreshInterval'] = 1;
+  });
+
+  it('should call getDeviceStatus periodically and notify with status message', async () => {
+    const duid = 'test-duid';
+    const device: Device = { duid } as Device;
+
+    const fakeStatus: DeviceStatus = {
+      errorStatus: { errorCode: 0 },
+      message: { battery: 80 },
+    } as any;
+
+    (roborockService['getMessageProcessor'] as jest.Mock).mockReturnValue(mockMessageProcessor);
+    mockMessageProcessor.getDeviceStatus.mockResolvedValue(fakeStatus);
+
+    await roborockService.activateDeviceNotify(device);
+
+    jest.advanceTimersByTime(2000); // 1s = 1 cycle
+
+    expect(mockLogger.debug).toHaveBeenCalledWith('Requesting device info for device', duid);
+    expect(mockMessageProcessor.getDeviceStatus).toHaveBeenCalledWith(duid);
+  });
+
+  it('should log error if message processor is not found', async () => {
+    const duid = 'not-found-duid';
+    const device: Device = { duid } as Device;
+
+    (roborockService['getMessageProcessor'] as jest.Mock).mockReturnValue(undefined);
+
+    await roborockService.activateDeviceNotify(device);
+
+    jest.advanceTimersByTime(1000); // trigger the interval
+
+    expect(mockLogger.error).toHaveBeenCalledWith('Local client not initialized');
+    expect(mockDeviceNotify).not.toHaveBeenCalled();
+  });
+});