material-icon-theme 4.23.1 → 4.24.0

package/CONTRIBUTING.md

@@ -1,62 +1,232 @@
-<h1>Contributing</h1>
+<h1>How to contribute</h1>
+
+Glad you're here and interested in expanding this project 🎉 In order to make this work in the best possible way, there are hints and tips for successful contributors on this page. Please read everything carefully and your contributions will be valuable and gratefully received.
 
 <!-- TOC -->
 
-- [Create issues](#create-issues)
+- [Icon Requests](#icon-requests)
 - [Add new icons](#add-new-icons)
-  - [Icon color](#icon-color)
-  - [Free software to create/edit SVG icons](#free-software-to-createedit-svg-icons)
-  - [Use icons from here](#use-icons-from-here)
+- [How-To's](#how-tos)
+  - [Create icon as SVG](#create-icon-as-svg)
+  - [Use Material Design colors](#material-design-colors)
+  - [Design folder icons](#design-folder-icons)
+  - [Icon spacing](#icon-spacing)
+  - [Icons for color themes](#icons-for-color-themes)
+  - [Unique assignment to file and folder names](#icon-assignments)
+  - [Create icon packs](#icon-packs)
 - [Add translations](#add-translations)
 - [Update API](#update-api)
 
 <!-- /TOC -->
 
-## Create issues
+## Icon Requests
 
-You need an icon for a specific file ending? No problem, just follow these guidelines:
+A new icon for a file name, file extension or folder name is needed? Please create an issue and follow the rules below:
 
-- describe the file ending (e.g. '.xml') and the language (e.g. XML)
-- show an example image of the icon or link to official website
+- Describe if a file and/or folder icon is needed
+- List the file names/endings and folder names
+- Mention some graphic ideas (how can the icon look like)
+- Show an example image of the icon or provide a link to the related website
 
 ## Add new icons
 
-1. Create icon as SVG
-2. Copy icon to `icons`-folder
-3. Edit the icon configuration files under `src/icons` folder:
-   - fileIcons.ts
-   - folderIcons.ts
-   - languageIcons.ts
+It is always welcome to add new icons to the extension. However, there are a few things you should take into account so that the icon can be included in the extension.
+
+**Checklist**
 
-### Icon color
+1. [ ] Create icon as SVG ([how to](#create-icon-as-svg))
+2. [ ] Icon color fits to Material Design ([how to](#material-design-colors))
+3. [ ] SVG has some space around the icon ([how to](#spacing))
+4. [ ] Unique assignment to file and folder names ([how to](#icon-assignments))
+5. [ ] Provide separate icons for color themes if necessary ([how to](#icons-for-color-themes))
 
-Choose your icon colors from the [material design colors](https://material.io/design/color/the-color-system.html#tools-for-picking-colors). Alternatively, the [Material Color Converter](https://pkief.github.io/material-color-converter/) allows you to pick the correct color by matching a custom color code with the colors of the Material Design color palette.
+## How tos
 
-### Free software to create/edit SVG icons
+<h3 id="create-icon-as-svg">Create icon as SVG</h3>
+
+These free tools are recommended to create or edit new SVG icons:
 
 - [Inkscape](https://inkscape.org/en/) is a free, open source SVG editor
 - There are tools available to convert PNG/JPG images to SVG - [Autotracer.org](https://autotracer.org) and [Vectorizer.io](https://vectorizer.io) are two examples.
-- It's important to produce fully _vectorized_ graphic (don't include a base64 image string in the svg).
 
-### Use icons from here
+> **Note**
+> It's important to produce fully _vectorized_ graphic (don't include a base64 image string in the svg).
+
+When you create a folder icon, please keep in mind that two SVG files are needed here: one that represents the folder closed and another that represents it open.
+
+```
+📁 folder-example.svg
+📂 folder-example-open.svg
+```
+
+Of course, there is also the possibility to add existing SVGs. Mostly, however, the color has to be adjusted or the styling has to be changed, so that the other points from the above checklist are also fulfilled.
+
+<h4>Known icon sources</h4>
 
 - [Material Design Icons](https://materialdesignicons.com/)
-  - download them as SVG and edit the icons e.g. with Inkscape
-- you can use any other source **as long as the icons are free to use!** This icon theme is absolutely non-commercial, but you should always check the license of your sources!
 
-### Test your icons before submitting
-- Preview your own custom icons locally before submitting a Pull Request. See [Custom icon associations](README.md#custom-icon-associations) in README.md for instructions.
+<h3 id="material-design-colors">Use Material Design colors</h3>
+
+An important success factor of this icon extension is the fact that all colors fit together harmoniously. This is due to the fact that all icons exist only from colors of the [Material Design color palette](https://material.io/design/color/the-color-system.html#tools-for-picking-colors). This creates nice contrasts and the icons are easily recognizable.
+
+Now it often happens that many programming languages already have icons with their own colors. To find the matching color from the Material Design color palette based on a known color, there is the [Material Color Converter](https://pkief.github.io/material-color-converter/). With its help any color can be converted into a Material Design color.
+
+Continue reading [here](#design-folder-icons) to find out about colors for the folder icons.
+
+| ✅                                                                | ❌                                                                    |
+| ----------------------------------------------------------------- | --------------------------------------------------------------------- |
+| <img src="./images/how-tos/svg-with-spacing.png" width="200px" /> | <img src="./images/how-tos/svg-with-wrong-color.png" width="200px" /> |
+
+<h3 id="design-folder-icons">Design folder icons</h3>
+
+When designing folder icons there are also a few points to consider. A folder icon always consists of two icons - the folder in the background and a motive in the foreground:
+
+<img src="./images/how-tos/folder-icon-parts.png" width="300px" />
+
+For the motive, only colors from the second row in the [color palette](https://pkief.com/material-color-converter/) are allowed. For the background choose a slightly darker hue (mostly in rows 4-6 in the palette).
+
+<img src="./images/how-tos/pick-folder-colors.png" width="500px" />
+
+This uniform color selection makes the folder icons look more consistent and fit well together. This ensures a good quality of the icons.
+
+| ✅                                                                                   | ❌                                                                                 |
+| ------------------------------------------------------------------------------------ | ---------------------------------------------------------------------------------- |
+| <img src="./images/how-tos/svg-folder-icon-with-correct-colors.png" width="200px" /> | <img src="./images/how-tos/svg-folder-icon-with-wrong-colors.png" width="200px" /> |
+
+<h3 id="icon-spacing">Icon spacing</h3>
+
+All icons have a small distance to the edge. This way they don't seem so pressed together and have a little more air. It is not defined how much margin you have to leave them, because this is always a bit different. Just make sure that there is a space to the outside.
+
+| ✅                                                                | ❌                                                                   |
+| ----------------------------------------------------------------- | -------------------------------------------------------------------- |
+| <img src="./images/how-tos/svg-with-spacing.png" width="200px" /> | <img src="./images/how-tos/svg-without-spacing.png" width="200px" /> |
+
+<h3 id="icon-assignments">Assignment to file and folder names and language ids</h3>
+
+Icons are assigned to file names, folder names or registered languages of VS Code in these files:
+
+- [fileIcons.ts](src/icons/fileIcons.ts)
+- [folderIcons.ts](src/icons/folderIcons.ts)
+- [languageIcons.ts](src/icons/languageIcons.ts)
+
+> **Note**
+> It is very important that icons are only assigned to the file and folder names that really apply to them. This means that you should be careful which files and folders you assign icons to. There are many people with different projects all over the world and not everyone expects that e.g. a file name will have a special framework based icon even though the framework is not used at all by this one user.
+>
+> A solution for this can be [icon packs](#icon-packs).
+
+#### File icons
+
+Here's an example of how the SVG icon 'sample.svg' is assigned to file names and extensions:
+
+```ts
+{
+  name: 'sample',
+  fileNames: ['sample.js', 'sample.ts', 'sample.html'],
+  fileExtensions: ['sample'],
+}
+```
+
+This will apply an icon for the files 'sample.js', 'sample.ts' and 'sample.html' as well as for files that end with 'sample' like 'another-file.sample'.
 
+#### Folder icons
+
+Here's an example of how a folder icon can be assigned to folder icons:
+
+```ts
+{
+  name: 'folder-sample',
+  folderNames: ['sample', 'samples'],
+}
+```
+
+This will apply a folder icon for the folders 'sample' and 'samples'.
+
+#### Language icons
+
+Here's an example of how a file icon can be assigned to language ids:
+
+```ts
+{ icon: { name: 'sample' }, ids: ['css'] },
+```
+
+This will apply the sample.svg icon to all files which could be associated by VS Code with the CSS programming language.
+
+<h3 id="icons-for-color-themes">Icons for color themes</h3>
+
+VS Code can be customized so that the background color is either light or dark. This must also be considered for the icons, because a dark icon on a dark background does not provide the necessary contrast it needs to be recognizable.
+
+| ✅                                                                    | ❌                                                                       |
+| --------------------------------------------------------------------- | ------------------------------------------------------------------------ |
+| <img src="./images/how-tos/svg-with-light-color.png" width="200px" /> | <img src="./images/how-tos/svg-with-too-dark-color.png" width="200px" /> |
+
+Preferably, the icon has a color that looks good on both backgrounds. If this is ever not possible because it would otherwise no longer match the icon's branding, different icons can be provided for the respective color scheme.
+
+This separation is possible by using the `light` attribute in the icon configuration:
+
+```ts
+{ name: 'sample', fileNames: ['sample.txt'], light: true },
+```
+
+If the `light` attribute is set to `true`, it is necessary to provide two icon files:
+
+- sample.svg
+- sample_light.svg
+
+The icon with the ending '\_light' will be automatically chosen when VS Code is using a light background color. So the icon should then look a bit darker to have a good contrast on the lighter background.
+
+In addition, there's also the possibility to provide a separate icon for high contrast backgrounds like this:
+
+```ts
+{ name: 'sample', fileNames: ['sample.txt'], highContrast: true },
+```
+
+If the `highContrast` attribute is set to `true`, it is necessary to provide two icon files:
+
+- sample.svg
+- sample_highContrast.svg
+
+<h3 id="icon-packs">Create icon packs</h3>
+
+Sometimes it can happen that certain files or folders need an icon, but you cannot avoid that there could be different icons for them. An icon pack can bundle different icons and as an end user you can decide which icons to display.
+
+Here's an example that shows how two icons can be assigned to the same file name by using icon packs:
+
+```ts
+{
+  name: 'sample-blue',
+  fileNames: ['sample.txt'],
+  enabledFor: [IconPack.Blue],
+},
+{
+  name: 'sample-red',
+  fileNames: ['sample.txt'],
+  enabledFor: [IconPack.Red],
+}
+```
+
+To create an icon pack, the following steps have to be completed:
+
+1. Add the name of the icon pack to the enum in [iconPack.ts](src/models/icons/iconPack.ts)
+2. Add translations to the package.nls.\*.json files under the section `configuration.activeIconPack` (at least to [package.nls.json](package.nls.json), the English translation file)
+3. Adjust [package.json](package.json) under `configuration.properties.material-icon-theme.activeIconPack`
+4. Use the icon pack inside the [fileIcons.ts](src/icons/fileIcons.ts),[folderIcons.ts](src/icons/folderIcons.ts) or [languageIcons.ts](src/icons/languageIcons.ts) files in the `enabledFor` attribute
 
 ## Add translations
 
+This project offers translations into different languages. If you notice an error here, please help to fix it. You can do this as follows:
+
 - Create or edit the translations in the `src/i18n` directory.
 - Create or edit the `package.nls.*.json` files in the root folder
 
-## Update API
+## Debug extension locally
+
+This icon extension consists not only of icons but also brings some code. This is necessary to simplify various things and enable multiple functionalities. If you want to change something here, the following steps are to be considered:
 
-1. Install node dependencies with `npm install`
-2. Open project with VS Code
-3. Press `F5` or run `Launch Extension` in the debug window
-4. Run tests with `Launch Tests`
+1. Install [Node.js](https://nodejs.org/en/) on your machine
+2. Install node dependencies with `npm install`
+3. Open project with VS Code
+4. Install required [VS Code extensions](.vscode/extensions.json)
+5. Press `F5` or run `Launch Extension` in the debug window
+6. Run tests with `Launch Tests`
 
+You will find more information about the official extension API in the [extension guides of VS Code](https://code.visualstudio.com/api/extension-guides/file-icon-theme).