masterrecord 0.3.34 → 0.3.35

package/Migrations/migrations.js

@@ -15,10 +15,21 @@ class Migrations{
 
     #organizeSchemaByTables(oldSchema, newSchema){
             var tables = []
+            var seenTableNames = new Set();  // Track processed table names to prevent duplicates
+
             if(oldSchema.length === 0){
                 newSchema.forEach(function (item, index) {
+                    var tableName = item["__name"];
+
+                    // Skip if we've already processed this table name
+                    if(seenTableNames.has(tableName)){
+                        console.warn(`Warning: Duplicate table definition detected for "${tableName}" - using first occurrence only`);
+                        return;
+                    }
+                    seenTableNames.add(tableName);
+
                     var table = {
-                        name: item["__name"],
+                        name: tableName,
                         new :item,
                         old : {},
                         newColumns : [],
@@ -36,8 +47,17 @@ class Migrations{
             }
             else{
                 newSchema.forEach(function (item, index) {
+                    var tableName = item["__name"];
+
+                    // Skip if we've already processed this table name
+                    if(seenTableNames.has(tableName)){
+                        console.warn(`Warning: Duplicate table definition detected for "${tableName}" - using first occurrence only`);
+                        return;
+                    }
+                    seenTableNames.add(tableName);
+
                     var table = {
-                        name: item["__name"],
+                        name: tableName,
                         old: null,
                         new :item,
                         newColumns : [],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "masterrecord",
-  "version": "0.3.34",
+  "version": "0.3.35",
   "description": "An Object-relational mapping for the Master framework. Master Record connects classes to relational database tables to establish a database with almost zero-configuration ",
   "main": "MasterRecord.js",
   "bin": {

package/readme.md

@@ -3369,18 +3369,43 @@ user.name = null;  // Error if name is { nullable: false }
 
 ## Changelog
 
-### Version 0.3.34 (2026-02-05)
+### Version 0.3.35 (2026-02-05) - CRITICAL FIX
+
+#### Critical Bug Fix
+- **FIXED**: Duplicate table operations in migrations when snapshots contain duplicate table definitions
+  - **Root Cause**: If a context registered the same entity twice (via multiple `dbset()` calls), the snapshot would contain duplicate table definitions with the same `__name`
+  - **Impact**: Migrations would generate duplicate `createTable()` and `seed()` calls, causing duplicate records in the database
+  - **Examples**:
+    - ragContext: Settings table appeared twice → 2x seed insertions
+    - qaContext: TaxonomyTemplate appeared twice → 18 template records instead of 9
+  - **Fix**: Added deduplication in `#organizeSchemaByTables()` using a `Set` to track processed table names
+  - **User Impact**: If you ran migrations from v0.3.34 or earlier and have duplicate records:
+    1. Manually remove duplicates from your database
+    2. Regenerate migrations with v0.3.35: `masterrecord add-migration YourContext "regenerate"`
+    3. Future migrations will not create duplicates
+
+#### Technical Details
+- Modified `Migrations/migrations.js` - `#organizeSchemaByTables()` method
+- Added `seenTableNames` Set to track processed tables and prevent duplicates
+- Emits warning: `"Warning: Duplicate table definition detected for 'TableName' - using first occurrence only"`
+- Works for both initial migrations (`oldSchema.length === 0`) and subsequent migrations
+
+#### Testing
+- Added 2 new tests for duplicate table scenarios (13 total tests)
+- All tests passing with duplicate detection and deduplication verified
+
+### Version 0.3.34 (2026-02-05) - PARTIALLY EFFECTIVE
+
+⚠️ **Note**: This version fixed the seed API bug but did NOT fix duplicate operations. Use v0.3.35 instead.
 
 #### Bug Fixes
 - **Fixed**: Seed API migration generation - resolved `table.EntityName.create is not a function` error
   - Migrations now use `this.seed('TableName', data)` instead of `table.TableName.create(data)`
   - Ensures compatibility with the migration schema base class
-- **Fixed**: Eliminated duplicate table creation statements in generated migrations
-- **Fixed**: Eliminated duplicate seed insertion statements in generated migrations
-- **Fixed**: Duplicate index creation when using `.index()` in column definitions
-  - Index operations now properly deduplicated during migration generation
 - **Fixed**: Missing `await` keywords on `createIndex()`, `dropIndex()`, `createCompositeIndex()`, and `dropCompositeIndex()` calls in migrations
   - All async index operations now properly awaited for consistency
+- ~~**Fixed**: Eliminated duplicate table creation statements~~ ❌ **NOT ACTUALLY FIXED** - see v0.3.35
+- ~~**Fixed**: Eliminated duplicate seed insertion statements~~ ❌ **NOT ACTUALLY FIXED** - see v0.3.35
 
 #### Improvements
 - **Enhanced**: Query builders now use whitelist validation for column definitions
@@ -3408,7 +3433,7 @@ user.name = null;  // Error if name is { nullable: false }
 
 | Component     | Version       | Notes                                    |
 |---------------|---------------|------------------------------------------|
-| MasterRecord  | 0.3.34        | Current version with bug fixes and improvements |
+| MasterRecord  | 0.3.35        | Current version - fixes critical duplicate table bug |
 | Node.js       | 14+           | Async/await support required             |
 | PostgreSQL    | 9.6+ (12+)    | Tested with 12, 13, 14, 15, 16          |
 | MySQL         | 5.7+ (8.0+)   | Tested with 8.0+                        |

package/test/v0.3.34-bug-fixes-test.js

@@ -291,6 +291,86 @@ test('Complex scenario: Multiple tables with seed data, indexes, and composite i
     assert(migrationCode.includes('await this.createCompositeIndex'), 'Composite indexes should have await');
 });
 
+// =============================================================================
+// Test Suite 4: Duplicate Table Deduplication (v0.3.35)
+// =============================================================================
+console.log("\n📋 Test Suite 4: Duplicate Table Deduplication\n");
+
+test('Deduplicates when snapshot has duplicate table definitions', () => {
+    const migrations = new Migrations();
+
+    // Simulate snapshot with duplicate Settings table (real-world bug from ragContext)
+    const oldSchema = [];
+    const newSchema = [
+        {
+            __name: 'Settings',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            disable_rag: { name: 'disable_rag', type: 'integer' }
+        },
+        {
+            __name: 'Document',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        },
+        {
+            __name: 'Settings',  // DUPLICATE - this caused the bug
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            disable_rag: { name: 'disable_rag', type: 'integer' }
+        }
+    ];
+
+    const seedData = {
+        Settings: [{ disable_rag: 0 }]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const createTableCount = (migrationCode.match(/createTable\(table\.Settings\)/g) || []).length;
+    const seedCount = (migrationCode.match(/this\.seed\('Settings'/g) || []).length;
+
+    assert(createTableCount === 1, `Expected 1 createTable for Settings, got ${createTableCount}`);
+    assert(seedCount === 1, `Expected 1 seed call for Settings, got ${seedCount}`);
+});
+
+test('Deduplicates multiple tables with multiple seeds (qaContext scenario)', () => {
+    const migrations = new Migrations();
+
+    const oldSchema = [];
+    const newSchema = [
+        {
+            __name: 'TaxonomyTemplate',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            template_id: { name: 'template_id', type: 'string' }
+        },
+        {
+            __name: 'Document',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        },
+        {
+            __name: 'TaxonomyTemplate',  // DUPLICATE
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            template_id: { name: 'template_id', type: 'string' }
+        }
+    ];
+
+    const seedData = {
+        TaxonomyTemplate: [
+            { template_id: 'template1' },
+            { template_id: 'template2' },
+            { template_id: 'template3' },
+            { template_id: 'template4' },
+            { template_id: 'template5' }
+        ]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const createTableCount = (migrationCode.match(/createTable\(table\.TaxonomyTemplate\)/g) || []).length;
+    const seedCount = (migrationCode.match(/this\.seed\('TaxonomyTemplate'/g) || []).length;
+
+    assert(createTableCount === 1, `Expected 1 createTable for TaxonomyTemplate, got ${createTableCount}`);
+    assert(seedCount === 5, `Expected 5 seed calls for TaxonomyTemplate, got ${seedCount}`);
+});
+
 // =============================================================================
 // Test Results Summary
 // =============================================================================
@@ -298,7 +378,7 @@ console.log("\n" + "=".repeat(68));
 console.log(`\n📊 Test Results: ${passed} passed, ${failed} failed\n`);
 
 if (failed === 0) {
-    console.log("✅ All tests passed! v0.3.34 fixes are working correctly.\n");
+    console.log("✅ All tests passed! v0.3.34/0.3.35 fixes are working correctly.\n");
     process.exit(0);
 } else {
     console.log(`⚠️  ${failed} test(s) failed. Please review the output above.\n`);