masterrecord 0.3.33 → 0.3.35

package/.claude/settings.local.json

@@ -59,7 +59,8 @@
       "Bash(npm link)",
       "Bash(npm link:*)",
       "Bash(1)",
-      "Bash(masterrecord update-database:*)"
+      "Bash(masterrecord update-database:*)",
+      "Bash(npx mocha:*)"
     ],
     "deny": [],
     "ask": []

package/.github/FUTURE_IMPROVEMENTS.md

@@ -0,0 +1,138 @@
+# Future Improvements for MasterRecord
+
+## Metadata Property Handling
+
+### Context
+The `.index()` bug fix (commit 6e774a7) introduced a blacklist approach to skip metadata properties during schema processing. While this solves the immediate problem, there are architectural improvements to consider for future versions.
+
+### Current Solution (v0.3.33)
+```javascript
+for (var key in table) {
+    // Skip metadata properties (indexes, __compositeIndexes, __name, etc.)
+    if(key === 'indexes' || key.startsWith('__')){
+        continue;
+    }
+    // ... process columns
+}
+```
+
+**Status:** ✅ Shipped - Works well, well-tested, solves the problem
+
+### Future Considerations
+
+#### 1. Document the Metadata Convention
+**Priority:** Medium
+**Effort:** Low
+
+Add clear documentation explaining that properties starting with `__` are reserved for internal metadata and will be skipped during schema processing. This should be documented in:
+- README.md (Entity Model section)
+- Code comments in `entityModel.js`
+- Migration guide if breaking changes are made
+
+**Example documentation:**
+```markdown
+## Reserved Property Names
+- Properties starting with `__` (double underscore) are reserved for internal metadata
+- `indexes` property is reserved for index definitions
+- These properties are automatically skipped during table creation
+```
+
+#### 2. Whitelist Approach (Long-term)
+**Priority:** Low
+**Effort:** Medium
+**Breaking Change:** Potentially
+
+Instead of blacklisting specific properties, consider only processing properties that are actually column definitions.
+
+**Pros:**
+- More robust if new metadata properties are added
+- Explicit about what gets processed
+- Self-documenting code
+
+**Cons:**
+- Requires careful design to not break existing functionality
+- More complex validation logic
+- Could impact performance
+
+**Example approach:**
+```javascript
+for (var key in table) {
+    if(typeof table[key] !== "object") continue;
+
+    var col = table[key];
+
+    // Only process objects that have column-like properties
+    if(!col.name || !col.type) continue;
+
+    // Skip relationship types
+    if(col.type === 'hasOne' || col.type === 'hasMany' || col.type === 'hasManyThrough'){
+        continue;
+    }
+
+    queryVar += `${this.#columnMapping(col)}, `;
+}
+```
+
+#### 3. Use JavaScript Symbols for Metadata (v1.0+)
+**Priority:** Low
+**Effort:** High
+**Breaking Change:** Yes
+
+For future major versions, consider using JavaScript Symbols for all internal metadata. Symbols don't appear in `for...in` loops or `Object.keys()`, eliminating this entire class of bugs.
+
+**Benefits:**
+- Metadata becomes truly invisible to iteration
+- No special-case filtering needed
+- Cleaner separation of concerns
+- More idiomatic JavaScript
+
+**Migration path:**
+```javascript
+// Current (v0.x)
+table.__name = 'Users';
+table.indexes = ['idx_name'];
+
+// Future (v1.0+)
+const META_NAME = Symbol('name');
+const META_INDEXES = Symbol('indexes');
+
+table[META_NAME] = 'Users';
+table[META_INDEXES] = ['idx_name'];
+```
+
+**Challenges:**
+- Requires refactoring all metadata access
+- Breaks existing code that accesses `__name`, `__compositeIndexes`, etc.
+- Would need comprehensive migration guide
+- Testing burden is significant
+
+**When to consider:**
+- During a major version bump (v1.0)
+- When other breaking changes are planned
+- After gathering user feedback on current metadata usage patterns
+
+---
+
+## Implementation Notes
+
+### Current Fix is Good to Ship ✅
+The blacklist approach (`indexes` and `__*` properties) is:
+- Practical and solves the immediate problem
+- Well-tested (5 comprehensive tests)
+- Easy to understand and maintain
+- Not over-engineered
+
+### Recommendation
+1. **Ship the current fix** (already committed)
+2. **Add documentation** about the `__` convention in next minor release
+3. **Track whitelist approach** as a potential v0.4+ enhancement
+4. **Consider Symbols** only for v1.0 major version
+
+---
+
+## Related Issues
+- Index bug fix: commit 6e774a7
+- Test suite: `test/index-bug-fix-test.js`
+
+## Feedback Credit
+These suggestions came from code review feedback on the index bug fix implementation.

package/Entity/entityModel.js

@@ -1,5 +1,6 @@
 /*
 
+Supported column types:
 :binary
 :boolean
 :date
@@ -15,6 +16,11 @@
 :time
 :timestamp
 
+Reserved Property Names:
+- Properties starting with '__' (double underscore) are reserved for internal metadata
+- 'indexes' property is reserved for index definitions
+- These properties are automatically skipped during table creation in migration queries
+
 */
 
 // version 0.0.5
@@ -115,6 +121,17 @@ class EntityModel {
 
     }
 
+    /**
+     * Adds an index to this column definition.
+     *
+     * Note: The 'indexes' property is metadata and will be automatically skipped
+     * during table creation. Properties starting with '__' are also reserved for
+     * internal metadata and filtered during schema processing.
+     *
+     * @param {string} indexName - Optional custom name for the index. If not provided,
+     *                              a default name will be generated.
+     * @returns {EntityModel} Returns this for method chaining
+     */
     index(indexName){
         if(!this.obj.indexes){
             this.obj.indexes = [];

package/Migrations/migrationMySQLQuery.js

@@ -199,9 +199,16 @@ class migrationMySQLQuery {
             }
 
             if(typeof table[key] === "object"){
+                var col = table[key];
+
+                if(col.type !== "hasOne" && col.type  !== "hasMany" && col.type  !== "hasManyThrough"){
+                    // Whitelist: Only process objects that look like column definitions
+                    // Valid columns must have 'name' and 'type' properties
+                    if(!col.name || !col.type){
+                        continue;
+                    }
 
-                if(table[key].type !== "hasOne" && table[key].type  !== "hasMany" && table[key].type  !== "hasManyThrough"){
-                    queryVar += `${this.#columnMapping(table[key])}, `;
+                    queryVar += `${this.#columnMapping(col)}, `;
                 }
             }
         }

package/Migrations/migrationPostgresQuery.js

@@ -202,8 +202,16 @@ class migrationPostgresQuery {
             }
 
             if(typeof table[key] === "object"){
-                if(table[key].type !== "hasOne" && table[key].type !== "hasMany" && table[key].type !== "hasManyThrough"){
-                    queryVar += `${this.#columnMapping(table[key])}, `;
+                var col = table[key];
+
+                if(col.type !== "hasOne" && col.type !== "hasMany" && col.type !== "hasManyThrough"){
+                    // Whitelist: Only process objects that look like column definitions
+                    // Valid columns must have 'name' and 'type' properties
+                    if(!col.name || !col.type){
+                        continue;
+                    }
+
+                    queryVar += `${this.#columnMapping(col)}, `;
                 }
             }
         }

package/Migrations/migrationSQLiteQuery.js

@@ -158,6 +158,13 @@ class migrationSQLiteQuery {
                 if(col.type === 'hasOne' || col.type === 'hasMany' || col.type === 'hasManyThrough'){
                     continue;
                 }
+
+                // Whitelist: Only process objects that look like column definitions
+                // Valid columns must have 'name' and 'type' properties
+                if(!col.name || !col.type){
+                    continue;
+                }
+
                 queryVar += `${this.#columnMapping(col)}, `;
             }
         }

package/Migrations/migrationTemplate.js

@@ -94,10 +94,10 @@ module.exports = ${this.name};
         });
 
         if(type === "up"){
-            this.#up += os.EOL + `     this.createIndex(${indexInfoStr});`
+            this.#up += os.EOL + `     await this.createIndex(${indexInfoStr});`
         }
         else{
-            this.#down += os.EOL + `     this.dropIndex(${indexInfoStr});`
+            this.#down += os.EOL + `     await this.dropIndex(${indexInfoStr});`
         }
     }
 
@@ -113,10 +113,10 @@ module.exports = ${this.name};
         });
 
         if(type === "up"){
-            this.#up += os.EOL + `     this.dropIndex(${indexInfoStr});`
+            this.#up += os.EOL + `     await this.dropIndex(${indexInfoStr});`
         }
         else{
-            this.#down += os.EOL + `     this.createIndex(${indexInfoStr});`
+            this.#down += os.EOL + `     await this.createIndex(${indexInfoStr});`
         }
     }
 
@@ -129,10 +129,10 @@ module.exports = ${this.name};
         });
 
         if(type === "up"){
-            this.#up += os.EOL + `     this.createCompositeIndex(${indexInfoStr});`
+            this.#up += os.EOL + `     await this.createCompositeIndex(${indexInfoStr});`
         }
         else{
-            this.#down += os.EOL + `     this.dropCompositeIndex(${indexInfoStr});`
+            this.#down += os.EOL + `     await this.dropCompositeIndex(${indexInfoStr});`
         }
     }
 
@@ -145,10 +145,10 @@ module.exports = ${this.name};
         });
 
         if(type === "up"){
-            this.#up += os.EOL + `     this.dropCompositeIndex(${indexInfoStr});`
+            this.#up += os.EOL + `     await this.dropCompositeIndex(${indexInfoStr});`
         }
         else{
-            this.#down += os.EOL + `     this.createCompositeIndex(${indexInfoStr});`
+            this.#down += os.EOL + `     await this.createCompositeIndex(${indexInfoStr});`
         }
     }
 
@@ -187,7 +187,7 @@ module.exports = ${this.name};
 
                 this.#up += os.EOL + `     ];`;
                 this.#up += os.EOL + `     for (const record of factoryRecords) {`;
-                this.#up += os.EOL + `         await table.${tableName}.create(record);`;
+                this.#up += os.EOL + `         this.seed('${tableName}', record);`;
                 this.#up += os.EOL + `     }`;
             } else {
                 // Standard individual inserts for non-factory or small batches
@@ -214,10 +214,10 @@ module.exports = ${this.name};
                             const formattedRecord = JSON.stringify(cleanRecord, null, 12)
                                 .split('\n')
                                 .join(os.EOL + '            ');
-                            this.#up += os.EOL + `     await table.${tableName}.create(${formattedRecord});`;
+                            this.#up += os.EOL + `     this.seed('${tableName}', ${formattedRecord});`;
                         } else {
                             // Single-line format
-                            this.#up += os.EOL + `     await table.${tableName}.create(${recordStr});`;
+                            this.#up += os.EOL + `     this.seed('${tableName}', ${recordStr});`;
                         }
                     }
                 });
@@ -236,7 +236,7 @@ module.exports = ${this.name};
         }
 
         this.#up += os.EOL + `     {`;
-        this.#up += os.EOL + `         const existing = await table.${tableName}.where(r => r.${conflictKey} == ${JSON.stringify(conflictValue)}).single();`;
+        this.#up += os.EOL + `         const existing = await this.context.${tableName}.where(r => r.${conflictKey} == ${JSON.stringify(conflictValue)}).single();`;
         this.#up += os.EOL + `         if (existing) {`;
 
         // Update logic
@@ -257,7 +257,7 @@ module.exports = ${this.name};
 
         this.#up += os.EOL + `             await existing.save();`;
         this.#up += os.EOL + `         } else {`;
-        this.#up += os.EOL + `             await table.${tableName}.create(${JSON.stringify(cleanRecord)});`;
+        this.#up += os.EOL + `             this.seed('${tableName}', ${JSON.stringify(cleanRecord)});`;
         this.#up += os.EOL + `         }`;
         this.#up += os.EOL + `     }`;
     }

package/Migrations/migrations.js

@@ -15,10 +15,21 @@ class Migrations{
 
     #organizeSchemaByTables(oldSchema, newSchema){
             var tables = []
+            var seenTableNames = new Set();  // Track processed table names to prevent duplicates
+
             if(oldSchema.length === 0){
                 newSchema.forEach(function (item, index) {
+                    var tableName = item["__name"];
+
+                    // Skip if we've already processed this table name
+                    if(seenTableNames.has(tableName)){
+                        console.warn(`Warning: Duplicate table definition detected for "${tableName}" - using first occurrence only`);
+                        return;
+                    }
+                    seenTableNames.add(tableName);
+
                     var table = {
-                        name: item["__name"],
+                        name: tableName,
                         new :item,
                         old : {},
                         newColumns : [],
@@ -36,8 +47,17 @@ class Migrations{
             }
             else{
                 newSchema.forEach(function (item, index) {
+                    var tableName = item["__name"];
+
+                    // Skip if we've already processed this table name
+                    if(seenTableNames.has(tableName)){
+                        console.warn(`Warning: Duplicate table definition detected for "${tableName}" - using first occurrence only`);
+                        return;
+                    }
+                    seenTableNames.add(tableName);
+
                     var table = {
-                        name: item["__name"],
+                        name: tableName,
                         old: null,
                         new :item,
                         newColumns : [],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "masterrecord",
-  "version": "0.3.33",
+  "version": "0.3.35",
   "description": "An Object-relational mapping for the Master framework. Master Record connects classes to relational database tables to establish a database with almost zero-configuration ",
   "main": "MasterRecord.js",
   "bin": {

package/readme.md

@@ -3367,11 +3367,73 @@ if (ids.length > 0) {
 user.name = null;  // Error if name is { nullable: false }
 ```
 
+## Changelog
+
+### Version 0.3.35 (2026-02-05) - CRITICAL FIX
+
+#### Critical Bug Fix
+- **FIXED**: Duplicate table operations in migrations when snapshots contain duplicate table definitions
+  - **Root Cause**: If a context registered the same entity twice (via multiple `dbset()` calls), the snapshot would contain duplicate table definitions with the same `__name`
+  - **Impact**: Migrations would generate duplicate `createTable()` and `seed()` calls, causing duplicate records in the database
+  - **Examples**:
+    - ragContext: Settings table appeared twice → 2x seed insertions
+    - qaContext: TaxonomyTemplate appeared twice → 18 template records instead of 9
+  - **Fix**: Added deduplication in `#organizeSchemaByTables()` using a `Set` to track processed table names
+  - **User Impact**: If you ran migrations from v0.3.34 or earlier and have duplicate records:
+    1. Manually remove duplicates from your database
+    2. Regenerate migrations with v0.3.35: `masterrecord add-migration YourContext "regenerate"`
+    3. Future migrations will not create duplicates
+
+#### Technical Details
+- Modified `Migrations/migrations.js` - `#organizeSchemaByTables()` method
+- Added `seenTableNames` Set to track processed tables and prevent duplicates
+- Emits warning: `"Warning: Duplicate table definition detected for 'TableName' - using first occurrence only"`
+- Works for both initial migrations (`oldSchema.length === 0`) and subsequent migrations
+
+#### Testing
+- Added 2 new tests for duplicate table scenarios (13 total tests)
+- All tests passing with duplicate detection and deduplication verified
+
+### Version 0.3.34 (2026-02-05) - PARTIALLY EFFECTIVE
+
+⚠️ **Note**: This version fixed the seed API bug but did NOT fix duplicate operations. Use v0.3.35 instead.
+
+#### Bug Fixes
+- **Fixed**: Seed API migration generation - resolved `table.EntityName.create is not a function` error
+  - Migrations now use `this.seed('TableName', data)` instead of `table.TableName.create(data)`
+  - Ensures compatibility with the migration schema base class
+- **Fixed**: Missing `await` keywords on `createIndex()`, `dropIndex()`, `createCompositeIndex()`, and `dropCompositeIndex()` calls in migrations
+  - All async index operations now properly awaited for consistency
+- ~~**Fixed**: Eliminated duplicate table creation statements~~ ❌ **NOT ACTUALLY FIXED** - see v0.3.35
+- ~~**Fixed**: Eliminated duplicate seed insertion statements~~ ❌ **NOT ACTUALLY FIXED** - see v0.3.35
+
+#### Improvements
+- **Enhanced**: Query builders now use whitelist validation for column definitions
+  - Validates that objects have both `name` and `type` properties before processing as columns
+  - More robust metadata property filtering in schema processing
+  - Combines blacklist (skip `indexes`, `__*` prefixed) with whitelist (require `name` and `type`) for comprehensive validation
+- **Documentation**: Enhanced migration generation documentation
+- **Testing**: Added comprehensive test suite for v0.3.34 bug fixes
+  - Tests whitelist validation across all three database backends
+  - Tests async/await consistency in index operations
+  - Tests seed API correctness and deduplication
+
+#### Technical Details
+- Query builders (SQLite, MySQL, PostgreSQL) validate column definitions have required `name` and `type` properties
+- Migration template generates proper ORM API calls for seed data using `this.seed()` method
+- Index deduplication logic prevents duplicate CREATE INDEX statements
+- All migration operations consistently use `await` for async consistency
+
+#### Migration Notes
+- Existing migrations generated with older versions will continue to work
+- New migrations will use the corrected seed API syntax
+- If you have migrations with `table.EntityName.create()` that haven't been run, regenerate them with this version
+
 ## Version Compatibility
 
 | Component     | Version       | Notes                                    |
 |---------------|---------------|------------------------------------------|
-| MasterRecord  | 0.3.13        | Current version with PostgreSQL support  |
+| MasterRecord  | 0.3.35        | Current version - fixes critical duplicate table bug |
 | Node.js       | 14+           | Async/await support required             |
 | PostgreSQL    | 9.6+ (12+)    | Tested with 12, 13, 14, 15, 16          |
 | MySQL         | 5.7+ (8.0+)   | Tested with 8.0+                        |

package/test/v0.3.34-bug-fixes-test.js

@@ -0,0 +1,386 @@
+/**
+ * Comprehensive Tests for v0.3.34 Bug Fixes
+ *
+ * Tests:
+ * 1. Whitelist validation in query builders
+ * 2. No duplicate index creation
+ * 3. Seed API migration generation (no duplicates, correct API usage)
+ * 4. All async operations have await keywords
+ */
+
+console.log("╔════════════════════════════════════════════════════════════════╗");
+console.log("║            MasterRecord v0.3.34 Bug Fixes Test                ║");
+console.log("╚════════════════════════════════════════════════════════════════╝\n");
+
+const Migrations = require('../Migrations/migrations');
+const MigrationSQLiteQuery = require('../Migrations/migrationSQLiteQuery');
+const MigrationMySQLQuery = require('../Migrations/migrationMySQLQuery');
+const MigrationPostgresQuery = require('../Migrations/migrationPostgresQuery');
+
+let passed = 0;
+let failed = 0;
+
+function assert(condition, message) {
+    if (!condition) {
+        console.log(`❌ FAIL: ${message}`);
+        failed++;
+        return false;
+    }
+    return true;
+}
+
+function test(description, fn) {
+    try {
+        fn();
+        console.log(`✓ ${description}`);
+        passed++;
+    } catch (e) {
+        console.log(`❌ FAIL: ${description}`);
+        console.log(`   Error: ${e.message}`);
+        failed++;
+    }
+}
+
+// =============================================================================
+// Test Suite 1: Whitelist Validation
+// =============================================================================
+console.log("\n📋 Test Suite 1: Whitelist Validation in Query Builders\n");
+
+test('SQLite query builder skips objects without name property', () => {
+    const queryBuilder = new MigrationSQLiteQuery();
+    const table = {
+        __name: 'TestTable',
+        id: { name: 'id', type: 'integer', primaryKey: true },
+        weirdMetadata: { foo: 'bar' },  // No name or type - should be skipped
+        name: { name: 'name', type: 'string' }
+    };
+
+    const query = queryBuilder.createTable(table);
+
+    assert(!query.includes('undefined'), 'SQLite: Should not contain undefined');
+    assert(query.includes('id'), 'SQLite: Should contain id column');
+    assert(query.includes('name'), 'SQLite: Should contain name column');
+    assert(!query.includes('foo'), 'SQLite: Should not process metadata without name/type');
+});
+
+test('MySQL query builder skips objects without name property', () => {
+    const queryBuilder = new MigrationMySQLQuery();
+    const table = {
+        __name: 'TestTable',
+        id: { name: 'id', type: 'integer', primaryKey: true },
+        weirdMetadata: { foo: 'bar' },
+        name: { name: 'name', type: 'string' }
+    };
+
+    const query = queryBuilder.createTable(table);
+
+    assert(!query.includes('undefined'), 'MySQL: Should not contain undefined');
+    assert(query.includes('id'), 'MySQL: Should contain id column');
+    assert(query.includes('name'), 'MySQL: Should contain name column');
+});
+
+test('PostgreSQL query builder skips objects without name property', () => {
+    const queryBuilder = new MigrationPostgresQuery();
+    const table = {
+        __name: 'TestTable',
+        id: { name: 'id', type: 'integer', primaryKey: true },
+        weirdMetadata: { foo: 'bar' },
+        name: { name: 'name', type: 'string' }
+    };
+
+    const query = queryBuilder.createTable(table);
+
+    assert(!query.includes('undefined'), 'PostgreSQL: Should not contain undefined');
+    assert(query.includes('id'), 'PostgreSQL: Should contain id column');
+    assert(query.includes('name'), 'PostgreSQL: Should contain name column');
+});
+
+test('Query builders correctly skip indexes property', () => {
+    const queryBuilder = new MigrationSQLiteQuery();
+    const table = {
+        __name: 'TestTable',
+        id: { name: 'id', type: 'integer', primaryKey: true },
+        email: { name: 'email', type: 'string', indexes: ['idx_email'] },
+        indexes: ['some', 'array']  // This is metadata, should be skipped
+    };
+
+    const query = queryBuilder.createTable(table);
+
+    assert(!query.includes('undefined'), 'Should not contain undefined');
+    assert(query.includes('email'), 'Should contain email column');
+    assert(!query.match(/some.*NOT NULL/), 'Should not process indexes array as column');
+});
+
+// =============================================================================
+// Test Suite 2: Index Creation with Await
+// =============================================================================
+console.log("\n📋 Test Suite 2: Index Creation with Await Keywords\n");
+
+test('createIndex generates code with await keyword', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [{
+        __name: 'User',
+        id: { name: 'id', type: 'integer', primaryKey: true },
+        email: { name: 'email', type: 'text', indexes: ['idx_user_email'] }
+    }];
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema);
+
+    const createIndexMatches = migrationCode.match(/await this\.createIndex/g);
+    assert(createIndexMatches && createIndexMatches.length > 0, 'createIndex should have await keyword');
+    assert(!migrationCode.match(/\n\s+this\.createIndex\(/), 'Should not have createIndex without await');
+});
+
+test('createCompositeIndex generates code with await keyword', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [{
+        __name: 'User',
+        id: { name: 'id', type: 'integer' },
+        __compositeIndexes: [{
+            name: 'idx_composite',
+            columns: ['col1', 'col2'],
+            unique: false
+        }]
+    }];
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema);
+
+    const compositeMatches = migrationCode.match(/await this\.createCompositeIndex/g);
+    assert(compositeMatches && compositeMatches.length > 0, 'createCompositeIndex should have await keyword');
+});
+
+// =============================================================================
+// Test Suite 3: Seed API Migration Generation
+// =============================================================================
+console.log("\n📋 Test Suite 3: Seed API Migration Generation\n");
+
+test('Seed data uses correct API (this.seed instead of table.EntityName.create)', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [{
+        __name: 'Settings',
+        id: { name: 'id', type: 'integer', primaryKey: true },
+        disable_rag: { name: 'disable_rag', type: 'integer' }
+    }];
+    const seedData = {
+        Settings: [{ disable_rag: 0 }]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    assert(migrationCode.includes("this.seed('Settings'"), 'Should use this.seed() method');
+    assert(!migrationCode.includes('table.Settings.create'), 'Should NOT use table.Settings.create()');
+});
+
+test('No duplicate createTable calls for tables with seed data', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [
+        {
+            __name: 'Document',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        },
+        {
+            __name: 'Settings',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        }
+    ];
+    const seedData = {
+        Settings: [{ id: 1 }]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const settingsCreateMatches = migrationCode.match(/createTable\(table\.Settings\)/g);
+    const settingsCreateCount = settingsCreateMatches ? settingsCreateMatches.length : 0;
+
+    assert(settingsCreateCount === 1, `Expected 1 createTable for Settings, got ${settingsCreateCount}`);
+});
+
+test('No duplicate seed insertion calls', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [{
+        __name: 'Settings',
+        id: { name: 'id', type: 'integer', primaryKey: true }
+    }];
+    const seedData = {
+        Settings: [{ id: 1, value: 'test' }]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const seedMatches = migrationCode.match(/this\.seed\('Settings'/g);
+    const seedCount = seedMatches ? seedMatches.length : 0;
+
+    assert(seedCount === 1, `Expected 1 seed call, got ${seedCount}`);
+});
+
+test('No duplicate dropTable calls in down migration', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [{
+        __name: 'Settings',
+        id: { name: 'id', type: 'integer', primaryKey: true }
+    }];
+    const seedData = {
+        Settings: [{ id: 1 }]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const dropMatches = migrationCode.match(/dropTable\(table\.Settings\)/g);
+    const dropCount = dropMatches ? dropMatches.length : 0;
+
+    assert(dropCount === 1, `Expected 1 dropTable call, got ${dropCount}`);
+});
+
+test('Complex scenario: Multiple tables with seed data, indexes, and composite indexes', () => {
+    const migrations = new Migrations();
+    const oldSchema = [];
+    const newSchema = [
+        {
+            __name: 'Document',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            embedding_model_id: { name: 'embedding_model_id', type: 'integer', indexes: ['idx_doc_embed'] }
+        },
+        {
+            __name: 'DocumentChunk',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            __compositeIndexes: [{
+                name: 'idx_chunk_unique',
+                columns: ['doc_id', 'chunk_index'],
+                unique: true
+            }]
+        },
+        {
+            __name: 'Settings',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            disable_rag: { name: 'disable_rag', type: 'integer' }
+        },
+        {
+            __name: 'Job',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        }
+    ];
+    const seedData = {
+        Settings: [{ disable_rag: 0 }]
+    };
+
+    const migrationCode = migrations.template('InitialCreate', oldSchema, newSchema, seedData);
+
+    // Check each table appears exactly once
+    const docCreate = (migrationCode.match(/createTable\(table\.Document\)/g) || []).length;
+    const chunkCreate = (migrationCode.match(/createTable\(table\.DocumentChunk\)/g) || []).length;
+    const settingsCreate = (migrationCode.match(/createTable\(table\.Settings\)/g) || []).length;
+    const jobCreate = (migrationCode.match(/createTable\(table\.Job\)/g) || []).length;
+
+    assert(docCreate === 1, `Document: Expected 1 createTable, got ${docCreate}`);
+    assert(chunkCreate === 1, `DocumentChunk: Expected 1 createTable, got ${chunkCreate}`);
+    assert(settingsCreate === 1, `Settings: Expected 1 createTable, got ${settingsCreate}`);
+    assert(jobCreate === 1, `Job: Expected 1 createTable, got ${jobCreate}`);
+
+    // Check seed uses correct API
+    assert(migrationCode.includes("this.seed('Settings'"), 'Should use this.seed() for Settings');
+    assert(!migrationCode.includes('table.Settings.create'), 'Should NOT use table.Settings.create');
+
+    // Check indexes have await
+    assert(migrationCode.includes('await this.createIndex'), 'Indexes should have await');
+    assert(migrationCode.includes('await this.createCompositeIndex'), 'Composite indexes should have await');
+});
+
+// =============================================================================
+// Test Suite 4: Duplicate Table Deduplication (v0.3.35)
+// =============================================================================
+console.log("\n📋 Test Suite 4: Duplicate Table Deduplication\n");
+
+test('Deduplicates when snapshot has duplicate table definitions', () => {
+    const migrations = new Migrations();
+
+    // Simulate snapshot with duplicate Settings table (real-world bug from ragContext)
+    const oldSchema = [];
+    const newSchema = [
+        {
+            __name: 'Settings',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            disable_rag: { name: 'disable_rag', type: 'integer' }
+        },
+        {
+            __name: 'Document',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        },
+        {
+            __name: 'Settings',  // DUPLICATE - this caused the bug
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            disable_rag: { name: 'disable_rag', type: 'integer' }
+        }
+    ];
+
+    const seedData = {
+        Settings: [{ disable_rag: 0 }]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const createTableCount = (migrationCode.match(/createTable\(table\.Settings\)/g) || []).length;
+    const seedCount = (migrationCode.match(/this\.seed\('Settings'/g) || []).length;
+
+    assert(createTableCount === 1, `Expected 1 createTable for Settings, got ${createTableCount}`);
+    assert(seedCount === 1, `Expected 1 seed call for Settings, got ${seedCount}`);
+});
+
+test('Deduplicates multiple tables with multiple seeds (qaContext scenario)', () => {
+    const migrations = new Migrations();
+
+    const oldSchema = [];
+    const newSchema = [
+        {
+            __name: 'TaxonomyTemplate',
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            template_id: { name: 'template_id', type: 'string' }
+        },
+        {
+            __name: 'Document',
+            id: { name: 'id', type: 'integer', primaryKey: true }
+        },
+        {
+            __name: 'TaxonomyTemplate',  // DUPLICATE
+            id: { name: 'id', type: 'integer', primaryKey: true },
+            template_id: { name: 'template_id', type: 'string' }
+        }
+    ];
+
+    const seedData = {
+        TaxonomyTemplate: [
+            { template_id: 'template1' },
+            { template_id: 'template2' },
+            { template_id: 'template3' },
+            { template_id: 'template4' },
+            { template_id: 'template5' }
+        ]
+    };
+
+    const migrationCode = migrations.template('TestMigration', oldSchema, newSchema, seedData);
+
+    const createTableCount = (migrationCode.match(/createTable\(table\.TaxonomyTemplate\)/g) || []).length;
+    const seedCount = (migrationCode.match(/this\.seed\('TaxonomyTemplate'/g) || []).length;
+
+    assert(createTableCount === 1, `Expected 1 createTable for TaxonomyTemplate, got ${createTableCount}`);
+    assert(seedCount === 5, `Expected 5 seed calls for TaxonomyTemplate, got ${seedCount}`);
+});
+
+// =============================================================================
+// Test Results Summary
+// =============================================================================
+console.log("\n" + "=".repeat(68));
+console.log(`\n📊 Test Results: ${passed} passed, ${failed} failed\n`);
+
+if (failed === 0) {
+    console.log("✅ All tests passed! v0.3.34/0.3.35 fixes are working correctly.\n");
+    process.exit(0);
+} else {
+    console.log(`⚠️  ${failed} test(s) failed. Please review the output above.\n`);
+    process.exit(1);
+}

package/test/debug-id-test.js

@@ -1,63 +0,0 @@
-/**
- * Debug test to trace ID setting
- */
-
-const masterrecord = require('../MasterRecord.js');
-const path = require('path');
-const fs = require('fs');
-
-class User {
-    id(db) {
-        db.integer().primary().auto();
-    }
-    name(db) {
-        db.string();
-    }
-}
-
-class TestContext extends masterrecord.context {
-    constructor() {
-        super();
-        this.database = path.join(__dirname, '..', 'database', 'debugIdTest.db');
-    }
-    onConfig(db) {
-        this.dbset(User);
-    }
-}
-
-// Clean
-if (fs.existsSync(path.join(__dirname, '..', 'database', 'debugIdTest.db'))) {
-    fs.unlinkSync(path.join(__dirname, '..', 'database', 'debugIdTest.db'));
-}
-
-async function test() {
-    const db = new TestContext();
-    db.onConfig();
-
-    const user = db.User.new();
-    user.name = 'Test';
-
-    console.log('\n=== Manual ID set test ===');
-    console.log('Before manual set - user.id:', user.id);
-
-    user.id = 123;
-    console.log('After user.id = 123 - user.id:', user.id);
-    console.log('After manual set - user.__proto__._id:', user.__proto__._id);
-
-    user.id = 456;
-    console.log('After user.id = 456 - user.id:', user.id);
-
-    console.log('\n=== Now test with save ===');
-    const user2 = db.User.new();
-    user2.name = 'Test2';
-
-    console.log('Before save - tracked entities:', db.__trackedEntities.length);
-    console.log('Before save - user2.__state:', user2.__state);
-
-    await user2.save();
-
-    console.log('After save - user2.id:', user2.id);
-    console.log('After save - user2.__proto__._id:', user2.__proto__._id);
-}
-
-test().catch(console.error);