mastercontroller 1.3.17 → 1.3.19

package/MasterRouter.js

@@ -763,16 +763,36 @@ class MasterRouter {
              try{
                  Control = require(path.join(currentRoute.root, 'app', 'controllers', `${tools.firstLetterlowercase(requestObject.toController)}Controller`));
              }catch(e){
+                 // Check if this is a "file not found" error vs a loading error
+                 const isModuleNotFound = e.code === 'MODULE_NOT_FOUND' &&
+                     e.message.includes(`${tools.firstLetterlowercase(requestObject.toController)}Controller`);
+
+                 if (!isModuleNotFound) {
+                     // Controller file exists but has an error (syntax error, bad require, etc.)
+                     // Surface the actual error
+                     throw e;
+                 }
+
+                 // Try uppercase variant
                  try{
                      Control = require(path.join(currentRoute.root, 'app', 'controllers', `${tools.firstLetterUppercase(requestObject.toController)}Controller`));
                  }catch(e2){
-                     // Controller not found - handle error
+                     // Check if this is also a "file not found" error
+                     const isModuleNotFound2 = e2.code === 'MODULE_NOT_FOUND' &&
+                         e2.message.includes(`${tools.firstLetterUppercase(requestObject.toController)}Controller`);
+
+                     if (!isModuleNotFound2) {
+                         // Controller file exists but has an error - surface it
+                         throw e2;
+                     }
+
+                     // Controller truly not found - show generic error
                      const error = handleControllerError(
                          new Error(`Controller not found: ${requestObject.toController}Controller`),
                          requestObject.toController,
                          requestObject.toAction,
                          requestObject.pathName,
-                         currentRoute.routeDef // Pass route definition
+                         currentRoute.routeDef
                      );
 
                      sendErrorResponse(requestObject.response, error, requestObject.pathName);
@@ -908,7 +928,32 @@ class MasterRouter {
                 throw new TypeError('Request object must have a valid response property');
             }
 
+            // Normalize pathName from various request object formats
             if (!rr.pathName || typeof rr.pathName !== 'string') {
+                // Try to extract pathName from standard HTTP request properties
+                if (rr.request.url) {
+                    // Handle full URL or path with query string (Node.js http, Express)
+                    try {
+                        // Try parsing as full URL first
+                        const url = new URL(rr.request.url, `http://${rr.request.headers?.host || 'localhost'}`);
+                        rr.pathName = url.pathname;
+                    } catch (e) {
+                        // Fallback: treat as relative path, strip query string
+                        rr.pathName = rr.request.url.split('?')[0];
+                    }
+                } else if (rr.request.path) {
+                    // Express-style request.path
+                    rr.pathName = rr.request.path;
+                } else if (rr.request.pathname) {
+                    // Alternative property name
+                    rr.pathName = rr.request.pathname;
+                } else {
+                    throw new TypeError('Request object must have a valid path (url, path, pathname, or pathName property)');
+                }
+            }
+
+            // Validate that we now have a valid pathName
+            if (typeof rr.pathName !== 'string') {
                 throw new TypeError('Request object must have a valid pathName');
             }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mastercontroller",
-  "version": "1.3.17",
+  "version": "1.3.19",
   "description": "Fortune 500 ready Node.js MVC framework with enterprise security, monitoring, and horizontal scaling",
   "main": "MasterControl.js",
   "license": "MIT",