mastercontroller 1.2.8 → 1.2.10

package/MasterAction.js

@@ -1,5 +1,5 @@
 
-// version 0.0.21
+// version 0.0.22
 
 var master = require('./MasterControl');
 var fileserver = require('fs');
@@ -133,18 +133,6 @@ class MasterAction{
 		}
 	}
 
-	returnReact(data, location){
-		
-			var masterView = null;
-			data = data === undefined ? {} : data;
-			this.params = this.params === undefined ? {} : this.params;
-			this.params = tools.combineObjects(data, this.params);
-			var func = master.viewList;
-			this.params = tools.combineObjects(this.params, func);
-			var html = master.reactView.compile(this.__currentRoute.toController, this.__currentRoute.toAction, this.__currentRoute.root);
-		
-	}
-
 	returnView(data, location){
 		
 		var masterView = null;

package/MasterRouter.js

@@ -131,7 +131,7 @@ class MasterRouter {
                     constraint : constraint
                 };
         
-                $that._routes[$that.currentRouteName].routes.push(route);   
+                $that._routes[$that.currentRouteName].routes.push(route);
         
             },
         

package/README.md

@@ -49,6 +49,50 @@ Use `setupServer('https', credentials)` or configure via environment TLS; see do
 - `docs/server-setup-nginx-reverse-proxy.md`
 - `docs/environment-tls-reference.md`
 
+### How File Uploads Work
+
+MasterController handles file uploads through the `formidable` library (v3.5.4+) integrated into the request parsing pipeline in `MasterRequest.js`.
+
+**Processing Flow:**
+
+1. **Content-Type Detection** - When a request arrives, the framework parses the `Content-Type` header to determine how to handle the request body (`MasterRequest.js:34-36`)
+
+2. **Multipart Form Data** - For `multipart/form-data` requests (file uploads), the framework uses formidable's `IncomingForm` to parse the request (`MasterRequest.js:43-78`)
+
+3. **Event-Based Parsing** - Formidable emits events during parsing:
+   - `field` event: Captures regular form fields and adds them to `parsedURL.formData.fields`
+   - `file` event: Captures uploaded files and stores them in `parsedURL.formData.files` as arrays (supporting multiple file uploads per field)
+   - `end` event: Signals completion and resolves the promise with parsed data
+
+4. **File Metadata** - Each uploaded file object includes:
+   - `name` or `originalFilename`: The original filename
+   - `extension`: Extracted file extension (e.g., `.jpg`, `.pdf`)
+   - `filepath`: Temporary location where formidable stored the file
+   - Other formidable metadata (size, mimetype, etc.)
+
+5. **Accessing Uploads in Controllers** - In your controller actions, access uploaded files via:
+   ```js
+   this.params.formData.files['fieldName'][0]  // First file for 'fieldName'
+   this.params.formData.fields['textField']     // Regular form fields
+   ```
+
+6. **Multiple Files** - Files are always stored as arrays in `parsedURL.formData.files[field]`, allowing multiple files to be uploaded with the same field name (`MasterRequest.js:59-65`)
+
+7. **Cleanup** - Use `this.request.deleteFileBuffer(filePath)` to remove temporary files after processing (`MasterRequest.js:162-169`)
+
+**Configuration Options:**
+
+You can configure file upload behavior via `master.request.init()`:
+- `disableFormidableMultipartFormData`: Set to `true` to skip file upload parsing
+- `formidable`: Pass options directly to formidable (upload directory, max file size, etc.)
+
+**Supported Content Types:**
+- `multipart/form-data` - File uploads
+- `application/x-www-form-urlencoded` - Standard forms
+- `application/json` - JSON payloads
+- `text/plain` - Plain text (1MB limit)
+- `text/html` - HTML content
+
 ### Production tips
 - Prefer a reverse proxy for TLS and serve Node on a high port.
 - If keeping TLS in Node, harden TLS and manage cert rotation.

package/package.json

@@ -18,5 +18,5 @@
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   },
-  "version": "1.2.8"
+  "version": "1.2.10"
 }