master-skill 0.11.0 → 0.12.0

package/scripts/tests/test_validate_curriculum_sources.py

@@ -1,144 +0,0 @@
-"""Tests for validate-curriculum-sources.py.
-
-Verifies that citations (CBETA T-numbers, X-numbers, Toh, compiled-teaching ids)
-and /master-<slug> references in curriculum reference files cross-check against
-the actual prebuilt master metadata.
-"""
-from __future__ import annotations
-
-import json
-from pathlib import Path
-
-import pytest
-
-import importlib.util
-import sys
-
-
-def _load_module():
-    spec_path = Path(__file__).resolve().parents[1] / "validate-curriculum-sources.py"
-    spec = importlib.util.spec_from_file_location("vcs", spec_path)
-    mod = importlib.util.module_from_spec(spec)
-    sys.modules["vcs"] = mod
-    spec.loader.exec_module(mod)
-    return mod
-
-
-@pytest.fixture
-def fake_prebuilt(tmp_path):
-    """Fake prebuilt tree with two masters and a curriculum dir."""
-    prebuilt = tmp_path / "prebuilt"
-    # Master A: cbeta source
-    (prebuilt / "master-aaa").mkdir(parents=True)
-    (prebuilt / "master-aaa" / "meta.json").write_text(json.dumps({
-        "slug": "aaa",
-        "sources": [{"type": "cbeta", "id": "T48n2008", "title": "demo"}],
-    }), encoding="utf-8")
-    # Master B: compiled_teaching source + Toh
-    (prebuilt / "master-bbb").mkdir(parents=True)
-    (prebuilt / "master-bbb" / "meta.json").write_text(json.dumps({
-        "slug": "bbb",
-        "sources": [
-            {"type": "compiled_teaching", "id": "AjahnChah:FoodForTheHeart", "title": "demo"},
-            {"type": "84000", "id": "Toh 21", "title": "demo"},
-        ],
-    }), encoding="utf-8")
-    (prebuilt / "master-curriculum" / "references").mkdir(parents=True)
-    return prebuilt
-
-
-def test_extract_citations_finds_T_numbers():
-    vcs = _load_module()
-    text = "See 《坛经》【T48n2008】 for details."
-    assert "T48n2008" in vcs.extract_citations(text)
-
-
-def test_extract_citations_finds_Toh():
-    vcs = _load_module()
-    text = "藏文藏经 Toh 21 心经..."
-    assert "Toh 21" in vcs.extract_citations(text)
-
-
-def test_extract_citations_finds_compiled_teaching():
-    vcs = _load_module()
-    text = "见 AjahnChah:FoodForTheHeart ..."
-    assert "AjahnChah:FoodForTheHeart" in vcs.extract_citations(text)
-
-
-def test_extract_master_slugs():
-    vcs = _load_module()
-    text = "推荐 master：/master-aaa ；交叉 /master-bbb 。"
-    assert vcs.extract_master_slugs(text) == {"aaa", "bbb"}
-
-
-def test_collect_known_citations(fake_prebuilt):
-    vcs = _load_module()
-    known = vcs.collect_known_citations(fake_prebuilt)
-    assert "T48n2008" in known
-    assert "AjahnChah:FoodForTheHeart" in known
-    assert "Toh 21" in known
-
-
-def test_validate_pass(fake_prebuilt):
-    vcs = _load_module()
-    ref = fake_prebuilt / "master-curriculum" / "references" / "ok.md"
-    ref.write_text(
-        "## Path\n- 主用经《坛经》【T48n2008】\n- master：/master-aaa\n- 藏：Toh 21\n",
-        encoding="utf-8",
-    )
-    errors = vcs.validate(fake_prebuilt)
-    assert errors == []
-
-
-def test_validate_fails_on_fabricated_citation(fake_prebuilt):
-    vcs = _load_module()
-    ref = fake_prebuilt / "master-curriculum" / "references" / "bad.md"
-    ref.write_text("【T99n9999】 fake\n", encoding="utf-8")
-    errors = vcs.validate(fake_prebuilt)
-    assert any("T99n9999" in e for e in errors)
-
-
-def test_validate_fails_on_unknown_master_slug(fake_prebuilt):
-    vcs = _load_module()
-    ref = fake_prebuilt / "master-curriculum" / "references" / "bad.md"
-    ref.write_text("/master-ghost\n", encoding="utf-8")
-    errors = vcs.validate(fake_prebuilt)
-    assert any("ghost" in e for e in errors)
-
-
-def test_validate_ignores_meta_skill_slugs(fake_prebuilt):
-    """/master-curriculum and /master-debate are meta-skills suppressed via
-    META_SKILL_SLUGS. /compare-masters never matches _SLUG (no /master- prefix),
-    so it is naturally ignored. None of these may raise validate errors."""
-    vcs = _load_module()
-    ref = fake_prebuilt / "master-curriculum" / "references" / "ok.md"
-    ref.write_text(
-        "延伸 → /compare-masters · /master-debate · /master-curriculum\n",
-        encoding="utf-8",
-    )
-    errors = vcs.validate(fake_prebuilt)
-    assert errors == []
-
-
-def test_validate_returns_error_when_refs_dir_missing(tmp_path):
-    vcs = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    prebuilt.mkdir()
-    # curriculum/references missing
-    errors = vcs.validate(prebuilt)
-    assert len(errors) == 1
-    assert "references dir not found" in errors[0]
-
-
-def test_extract_citations_finds_hyphenated_compiled_teaching():
-    vcs = _load_module()
-    text = "PTS:DN-Comm 注释 / BDRC:Pha-chos-Bu-chos"
-    cits = vcs.extract_citations(text)
-    assert "PTS:DN-Comm" in cits
-    assert "BDRC:Pha-chos-Bu-chos" in cits
-
-
-def test_extract_citations_finds_Toh_with_colon():
-    vcs = _load_module()
-    text = "见 Toh:3948"
-    assert "Toh:3948" in vcs.extract_citations(text)

package/scripts/tests/test_validate_fidelity.py

@@ -1,59 +0,0 @@
-import json
-import importlib.util
-from pathlib import Path
-
-MODULE_PATH = Path(__file__).resolve().parents[1] / "validate-fidelity.py"
-SPEC = importlib.util.spec_from_file_location("validate_fidelity", MODULE_PATH)
-validate_fidelity = importlib.util.module_from_spec(SPEC)
-SPEC.loader.exec_module(validate_fidelity)
-
-
-def _write_fixture(tmp_path: Path, master_name: str, cases: list[dict]) -> Path:
-    master_dir = tmp_path / master_name
-    tests_dir = master_dir / "tests"
-    tests_dir.mkdir(parents=True)
-    payload = "\n".join(json.dumps(case, ensure_ascii=False) for case in cases) + "\n"
-    (tests_dir / "fidelity.jsonl").write_text(payload, encoding="utf-8")
-    return master_dir
-
-
-def test_compare_requires_framework_output_sections(tmp_path):
-    master_dir = _write_fixture(
-        tmp_path,
-        "compare-masters",
-        [
-            {
-                "q": "禅和净怎么比较？",
-                "must_select_masters": ["huineng", "yinguang"],
-                "must_have_sections": ["分歧雷达"],
-            }
-            for _ in range(5)
-        ],
-    )
-
-    errors = validate_fidelity.validate_master(master_dir)
-
-    assert any("共同点" in error for error in errors)
-    assert any("引用来源" in error for error in errors)
-
-
-def test_compare_accepts_required_framework_output_sections(tmp_path):
-    case = {
-        "q": "禅和净怎么比较？",
-        "must_select_masters": ["huineng", "yinguang"],
-        "must_have_sections": sorted(validate_fidelity.COMPARE_REQUIRED_SECTIONS),
-    }
-    cases = [case.copy() for _ in range(5)]
-    cases.append(
-        {
-            "q": "哪个更好？",
-            "test_type": "boundary",
-            "boundary": "sectarian_judgment",
-            "must_not_contain": ["更好"],
-        }
-    )
-    master_dir = _write_fixture(tmp_path, "compare-masters", cases)
-
-    errors = validate_fidelity.validate_master(master_dir)
-
-    assert errors == []

package/scripts/tests/test_validate_lore_triggers_content.py

@@ -1,372 +0,0 @@
-"""Tests for validate-lore-triggers-content.py.
-
-Covers:
-  - normalize() drops punctuation/whitespace, folds trad->simp
-  - longest_common_substring_len returns true LCS length
-  - similarity_ratio is windowed correctly for large bodies
-  - check_entry passes a true verbatim quote in sources/
-  - check_entry passes a quote with trad/simp variation
-  - check_entry FAILS a fabricated quote
-  - check_entry FAILS short quote when only LCS of 2 chars overlap
-  - check_entry returns the in_references_only soft-pass when match
-    is in references/ but not sources/
-  - validate() walks tmp_path tree end to end
-  - main() advisory mode exits 0 even when failures present
-  - main() --strict exits non-zero on failures
-"""
-from __future__ import annotations
-
-import importlib.util
-import json
-import subprocess
-import sys
-from pathlib import Path
-
-import pytest
-
-
-def _load_module():
-    spec_path = (
-        Path(__file__).resolve().parents[1]
-        / "validate-lore-triggers-content.py"
-    )
-    spec = importlib.util.spec_from_file_location("vltc", spec_path)
-    mod = importlib.util.module_from_spec(spec)
-    sys.modules["vltc"] = mod
-    spec.loader.exec_module(mod)
-    return mod
-
-
-def _setup_master(
-    prebuilt: Path,
-    slug: str,
-    lore_triggers: list,
-    excerpts_text: str | None = None,
-    references_text: str | None = None,
-    excerpts_filename: str = "tanjing-excerpts.md",
-):
-    d = prebuilt / f"master-{slug}"
-    (d / "sources").mkdir(parents=True, exist_ok=True)
-    (d / "references").mkdir(parents=True, exist_ok=True)
-    meta = {
-        "slug": slug,
-        "sources": [
-            {"type": "cbeta", "id": "T48n2008", "title": "坛经"}
-        ],
-        "lore_triggers": lore_triggers,
-    }
-    (d / "meta.json").write_text(
-        json.dumps(meta, ensure_ascii=False), encoding="utf-8"
-    )
-    if excerpts_text is not None:
-        (d / "sources" / excerpts_filename).write_text(
-            excerpts_text, encoding="utf-8"
-        )
-    if references_text is not None:
-        (d / "references" / "teaching.md").write_text(
-            references_text, encoding="utf-8"
-        )
-    return d
-
-
-# ---------- normalize ----------
-
-
-def test_normalize_drops_punctuation():
-    m = _load_module()
-    assert m.normalize("我此法门，从上以来。") == "我此法门从上以来"
-
-
-def test_normalize_drops_whitespace():
-    m = _load_module()
-    assert m.normalize("定 慧　一　体\n") == "定慧一体"
-
-
-def test_normalize_folds_traditional_to_simplified():
-    m = _load_module()
-    # 介尔 in meta vs 介爾 in excerpts must compare equal post-normalize.
-    assert m.normalize("介爾有心") == m.normalize("介尔有心")
-    # 於 vs 于
-    assert m.normalize("於相而离相") == m.normalize("于相而离相")
-
-
-# ---------- LCS ----------
-
-
-def test_lcs_finds_long_overlap():
-    m = _load_module()
-    a = "abcdefghijklmnop"
-    b = "zzabcdefghijxxxx"
-    assert m.longest_common_substring_len(a, b) == 10  # abcdefghij
-
-
-def test_lcs_empty_inputs():
-    m = _load_module()
-    assert m.longest_common_substring_len("", "abc") == 0
-    assert m.longest_common_substring_len("abc", "") == 0
-
-
-# ---------- similarity ratio ----------
-
-
-def test_similarity_ratio_high_for_identical():
-    m = _load_module()
-    s = "一空一切空，无假无中而不空，总空观也"
-    assert m.similarity_ratio(s, s) >= 0.99
-
-
-def test_similarity_ratio_low_for_unrelated():
-    m = _load_module()
-    a = "菩提本无树明镜亦非台"
-    b = "完全无关的废话填充字符串赞美和谐社会"
-    assert m.similarity_ratio(a, b) < 0.4
-
-
-# ---------- extract_quotation ----------
-
-
-def test_extract_quotation_strips_gloss():
-    m = _load_module()
-    content = "定慧一体，不是二。——此乃慧能定慧不二说"
-    assert m.extract_quotation(content) == "定慧一体，不是二。"
-
-
-def test_extract_quotation_no_gloss():
-    m = _load_module()
-    assert m.extract_quotation("无相为体") == "无相为体"
-
-
-# ---------- check_entry: positive case ----------
-
-
-def test_check_entry_passes_verbatim_quote(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    quote = (
-        "我此法门，从上以来，先立无念为宗，无相为体，无住为本。"
-        "无相者，于相而离相；无念者，于念而无念；无住者，人之本性。"
-    )
-    excerpts = f"# 坛经 (T48n2008)\n\n> {quote}\n"
-    d = _setup_master(
-        prebuilt,
-        slug="huineng",
-        lore_triggers=[
-            {
-                "keys": ["无念"],
-                "content": quote + "——此为三纲领",
-                "source_ref": "T48n2008#定慧品",
-            }
-        ],
-        excerpts_text=excerpts,
-    )
-    res = m.check_entry(d, json.loads((d / "meta.json").read_text())["lore_triggers"][0], 0)
-    assert res["passed"] is True
-    assert res["passed_in_sources"] is True
-
-
-def test_check_entry_passes_with_trad_simp_variation(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    meta_quote = (
-        "夫一心具十法界，一法界又具十法界、百法界；"
-        "此三千在一念心，介尔有心即具三千。"
-    )
-    excerpts_quote = meta_quote.replace("介尔", "介爾")  # excerpts use trad
-    d = _setup_master(
-        prebuilt,
-        slug="zhiyi",
-        lore_triggers=[
-            {
-                "keys": ["一念三千"],
-                "content": meta_quote + "——此乃一念三千",
-                "source_ref": "T46n1911#卷五上",
-            }
-        ],
-        excerpts_text=f"# 摩诃止观\n\n> {excerpts_quote}\n",
-        excerpts_filename="mohezhiguan-excerpts.md",
-    )
-    res = m.check_entry(d, json.loads((d / "meta.json").read_text())["lore_triggers"][0], 0)
-    assert res["passed"] is True
-
-
-# ---------- check_entry: negative case ----------
-
-
-def test_check_entry_fails_fabricated_quote(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    fabricated = (
-        "念佛是谁？这是一个完全编造的引文，不可能在任何坛经原典里出现，"
-        "纯属虚构以测试 validator 是否能识别。"
-    )
-    d = _setup_master(
-        prebuilt,
-        slug="huineng",
-        lore_triggers=[
-            {
-                "keys": ["念佛是谁"],
-                "content": fabricated + "——此乃伪造",
-                "source_ref": "T48n2008#行由品",
-            }
-        ],
-        # A real excerpts file with totally unrelated content
-        excerpts_text="# 坛经\n\n> 菩提自性，本来清净，但用此心，直了成佛。\n",
-    )
-    res = m.check_entry(d, json.loads((d / "meta.json").read_text())["lore_triggers"][0], 0)
-    assert res["passed"] is False, (
-        f"Fabricated quote slipped through with lcs={res['best_lcs']} "
-        f"ratio={res['best_ratio']}"
-    )
-
-
-def test_check_entry_short_quote_low_overlap_fails(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    # 20-char quote, only 2 chars overlap with excerpts
-    d = _setup_master(
-        prebuilt,
-        slug="huineng",
-        lore_triggers=[
-            {
-                "keys": ["菩提本无树"],
-                "content": "菩提本无树，明镜亦非台。本来无一物，何处惹尘埃。",
-                "source_ref": "T48n2008#行由品",
-            }
-        ],
-        excerpts_text="# 坛经\n\n> 菩提自性，本来清净，但用此心，直了成佛。\n",
-    )
-    res = m.check_entry(d, json.loads((d / "meta.json").read_text())["lore_triggers"][0], 0)
-    assert res["passed"] is False
-
-
-# ---------- references soft-pass ----------
-
-
-def test_check_entry_soft_pass_via_references(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    quote = "菩提本无树，明镜亦非台。本来无一物，何处惹尘埃。"
-    d = _setup_master(
-        prebuilt,
-        slug="huineng",
-        lore_triggers=[
-            {
-                "keys": ["菩提本无树"],
-                "content": quote + "——此偈显自性",
-                "source_ref": "T48n2008#行由品",
-            }
-        ],
-        excerpts_text="# 坛经\n\n> 菩提自性，本来清净，直了成佛。\n",
-        references_text=f"## 菩提本无树偈\n\n慧能偈：「{quote}」",
-    )
-    res = m.check_entry(d, json.loads((d / "meta.json").read_text())["lore_triggers"][0], 0)
-    assert res["passed"] is True
-    assert res["passed_in_sources"] is False
-    assert res["in_references_only"] is True
-    assert res["ref_file"] == "teaching.md"
-
-
-# ---------- validate() walks tree ----------
-
-
-def test_validate_walks_full_tree(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    _setup_master(
-        prebuilt,
-        slug="alpha",
-        lore_triggers=[
-            {
-                "keys": ["a"],
-                "content": "x" * 100 + "——gloss",
-                "source_ref": "T00n0000",
-            }
-        ],
-        excerpts_text="x" * 200,
-    )
-    _setup_master(
-        prebuilt,
-        slug="beta",
-        lore_triggers=[],
-        excerpts_text="anything",
-    )
-    results = m.validate(prebuilt)
-    assert len(results) == 1
-    assert results[0]["master"] == "master-alpha"
-    assert results[0]["passed"] is True
-
-
-def test_validate_skips_meta_skill(tmp_path):
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    d = prebuilt / "master-meta"
-    d.mkdir(parents=True)
-    (d / "meta.json").write_text(
-        json.dumps(
-            {
-                "slug": "meta",
-                "kind": "meta-skill",
-                "lore_triggers": [
-                    {
-                        "keys": ["x"],
-                        "content": "fake" * 30,
-                        "source_ref": "T00n0000",
-                    }
-                ],
-            },
-            ensure_ascii=False,
-        ),
-        encoding="utf-8",
-    )
-    results = m.validate(prebuilt)
-    assert results == []
-
-
-# ---------- CLI: advisory vs strict ----------
-
-
-def _run_cli(args: list[str], cwd: Path) -> subprocess.CompletedProcess:
-    script = (
-        Path(__file__).resolve().parents[1]
-        / "validate-lore-triggers-content.py"
-    )
-    return subprocess.run(
-        [sys.executable, str(script), *args],
-        capture_output=True,
-        text=True,
-        cwd=cwd,
-        env={"PYTHONIOENCODING": "utf-8", "PATH": "/usr/bin:/bin"},
-    )
-
-
-def test_cli_advisory_exits_zero_on_real_repo():
-    """Smoke test against the live prebuilt/ tree — must exit 0 advisory."""
-    repo_root = Path(__file__).resolve().parents[2]
-    proc = _run_cli([], cwd=repo_root)
-    assert proc.returncode == 0, proc.stdout + proc.stderr
-
-
-def test_cli_strict_exits_nonzero_when_failures(tmp_path):
-    """Build a fake tree with a fabricated entry; --strict must fail."""
-    m = _load_module()
-    prebuilt = tmp_path / "prebuilt"
-    fabricated = "完全编造无任何根据的伪造引文" * 5
-    _setup_master(
-        prebuilt,
-        slug="huineng",
-        lore_triggers=[
-            {
-                "keys": ["x"],
-                "content": fabricated + "——伪造测试",
-                "source_ref": "T48n2008",
-            }
-        ],
-        excerpts_text="无关内容",
-    )
-    # Run the validator pointed at this fake tree by patching PREBUILT_DIR.
-    results = m.validate(prebuilt)
-    assert any(not r["passed"] for r in results)
-    # Now confirm CLI --strict would exit 1: invoke main() directly.
-    # We can't easily invoke main on a fake tree without monkeypatching, so
-    # assert the precondition only — the integration is exercised in the
-    # advisory smoke test above.