markuplint 5.3.0 → 5.4.0

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.4.0](https://github.com/markuplint/markuplint/compare/v5.3.0...v5.4.0) (2026-10-29)
+
+### Bug Fixes
+
+* **markuplint:** skip the config search when it is disabled ([e2e8da9](https://github.com/markuplint/markuplint/commit/e2e8da9a81fb113b726fc30877b16cfab4d53736)), closes [#4409](https://github.com/markuplint/markuplint/issues/4409)
+* **markuplint:** watch a config file the search found broken ([1a51145](https://github.com/markuplint/markuplint/commit/1a51145b3eb34c18c0475205466b608787352b66)), closes [#4413](https://github.com/markuplint/markuplint/issues/4413)
+
+
 # [5.3.0](https://github.com/markuplint/markuplint/compare/v5.2.0...v5.3.0) (2026-10-21)
 
 ### Bug Fixes

package/lib/api/ml-engine.js

@@ -1,4 +1,4 @@
-import { ConfigProvider, createPretenderResolver, disambiguatePretendersForFile, invalidatePretenderResolutionCaches, resolveFiles, resolveParser, resolveRules, resolveSpecs, } from '@markuplint/file-resolver';
+import { ConfigProvider, configLoadErrorFiles, createPretenderResolver, disambiguatePretendersForFile, invalidatePretenderResolutionCaches, resolveFiles, resolveParser, resolveRules, resolveSpecs, } from '@markuplint/file-resolver';
 import path from 'node:path';
 import { applyRuleAliasesToConfig, mergeConfig } from '@markuplint/ml-config';
 import { CONFIG_ERROR_RULE_ID, MLCore, convertRuleset } from '@markuplint/ml-core';
@@ -620,7 +620,7 @@ export class MLEngine extends Emitter {
         // in the middle of this one's `set()`/`search()` calls, which would
         // wipe the keys just registered below before `resolve()` gets to use
         // them. See #4015.
-        const resolvedConfigSet = await this.#configProvider.runExclusive(async () => {
+        const resolvedConfigSet = await this.#runResolution(async () => {
             if (!cache) {
                 // Must run before any `set()` call below — `ConfigProvider#resolve()`
                 // no longer clears its own store on `cache: false`, so invalidating
@@ -632,17 +632,24 @@ export class MLEngine extends Emitter {
                 this.#configProvider.set(mergeConfig(this.#options.defaultConfig), undefined, this.#options.defaultConfig);
             configLog('defaultConfigKey: %s', defaultConfigKey ?? 'N/A');
             this.emit('log', 'defaultConfigKey', defaultConfigKey ?? 'N/A');
-            const targetConfig = await this.#configProvider.search(this.#file);
-            this.emit('log', 'targetConfig', targetConfig ?? 'N/A');
-            const configFilePathsFromTarget = this.#options?.noSearchConfig || this.#options?.configFile
-                ? (defaultConfigKey ?? null)
-                : (targetConfig ?? defaultConfigKey);
+            // Skipped, not run and discarded: the search reads and parses every
+            // config file it reaches, so a malformed one would still surface as a
+            // `config-error` in a run that asked not to search. See #4409.
+            let targetConfig = null;
+            if (this.#options?.noSearchConfig || this.#options?.configFile) {
+                this.emit('log', 'targetConfig', 'skipped (search is disabled)');
+            }
+            else {
+                targetConfig = await this.#configProvider.search(this.#file);
+                this.emit('log', 'targetConfig', targetConfig ?? 'N/A');
+            }
+            const configFilePathsFromTarget = targetConfig ?? defaultConfigKey ?? null;
             configLog('configFilePathsFromTarget: %s', configFilePathsFromTarget ?? 'N/A');
             this.emit('log', 'configFilePathsFromTarget', configFilePathsFromTarget ?? 'N/A');
             const configKey = this.#options?.config &&
                 this.#configProvider.set(mergeConfig(this.#options.config), undefined, this.#options.config);
             configLog('option.config: %s', configKey ?? 'N/A');
-            this.emit('log', 'option.config', configFilePathsFromTarget ?? 'N/A');
+            this.emit('log', 'option.config', configKey ?? 'N/A');
             let defaultRecommended = null;
             if (!defaultConfigKey && !configFilePathsFromTarget && !configKey && !this.#options?.configFile) {
                 // No configured
@@ -675,6 +682,38 @@ export class MLEngine extends Emitter {
         await this.#syncWatch();
         return configSet;
     }
+    /**
+     * Runs `resolve` exclusively on the provider (see {@link resolveConfig}).
+     * When it throws a `ConfigLoadError` (a config file that the search found
+     * cannot be loaded, or a preset that is not found), the files whose change
+     * can fix it ({@link configLoadErrorFiles}: the file it names, and a
+     * `$import` target that does not exist yet) are added to the watched files
+     * before the error goes on: there is no config set to take
+     * {@link ConfigSet.files} from, and the files of the previous resolution
+     * alone would miss the fix of a file that was broken from the start. They
+     * stay watched, as the error names only the first thing that failed, not
+     * every file the config depends on. A directory that the search cannot
+     * examine is not among them, as the shared watcher takes file paths (see
+     * its module JSDoc in `shared-watcher.ts`).
+     *
+     * @param resolve - The resolution, which runs inside `runExclusive`
+     * @returns The config set that `resolve` returns
+     */
+    async #runResolution(resolve) {
+        try {
+            return await this.#configProvider.runExclusive(resolve);
+        }
+        catch (error) {
+            if (isFatalError(error)) {
+                throw error;
+            }
+            if (error instanceof ConfigLoadError) {
+                this.#configFiles = new Set([...this.#configFiles, ...configLoadErrorFiles(error)]);
+                await this.#syncWatch();
+            }
+            throw error;
+        }
+    }
     async #resolveParser(
     // eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
     configSet) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "markuplint",
-	"version": "5.3.0",
+	"version": "5.4.0",
 	"description": "An HTML linter for all markup developers",
 	"author": "Yusuke Hirao",
 	"license": "MIT",
@@ -35,16 +35,16 @@
 	},
 	"dependencies": {
 		"@markuplint/cli-utils": "5.3.0",
-		"@markuplint/file-resolver": "5.3.0",
-		"@markuplint/html-parser": "5.3.0",
-		"@markuplint/html-spec": "5.3.0",
+		"@markuplint/file-resolver": "5.4.0",
+		"@markuplint/html-parser": "5.4.0",
+		"@markuplint/html-spec": "5.4.0",
 		"@markuplint/i18n": "5.3.0",
 		"@markuplint/ml-ast": "5.3.0",
-		"@markuplint/ml-config": "5.3.0",
-		"@markuplint/ml-core": "5.3.0",
-		"@markuplint/ml-spec": "5.3.0",
-		"@markuplint/rules": "5.3.0",
-		"@markuplint/shared": "5.3.0",
+		"@markuplint/ml-config": "5.4.0",
+		"@markuplint/ml-core": "5.4.0",
+		"@markuplint/ml-spec": "5.4.0",
+		"@markuplint/rules": "5.4.0",
+		"@markuplint/shared": "5.4.0",
 		"@types/debug": "^4.1.13",
 		"chokidar": "^5.0.0",
 		"debug": "^4.4.3",
@@ -54,5 +54,5 @@
 		"strip-ansi": "^7.2.0",
 		"type-fest": "^5.10.0"
 	},
-	"gitHead": "f587cf0206c8426e57369a48d6d5fb22306eafde"
+	"gitHead": "647f6fb5d5743f060678599c97e9c84b58970747"
 }