markdownlint 0.37.2 → 0.37.4

package/lib/constants.mjs

@@ -10,4 +10,4 @@ export const fixableRuleNames = [
   "MD058"
 ];
 export const homepage = "https://github.com/DavidAnson/markdownlint";
-export const version = "0.37.2";
+export const version = "0.37.4";

package/lib/defer-require.cjs

@@ -0,0 +1,16 @@
+// @ts-check
+
+"use strict";
+
+/**
+ * Calls require for markdownit.cjs. Used to synchronously defer loading because module.createRequire is buggy under webpack (https://github.com/webpack/webpack/issues/16724).
+ *
+ * @returns {any} Exported module content.
+ */
+function requireMarkdownItCjs() {
+  return require("./markdownit.cjs");
+}
+
+module.exports = {
+  requireMarkdownItCjs
+};

package/lib/exports.d.mts

@@ -1,3 +1,4 @@
+export { resolveModule } from "./resolve-module.cjs";
 export type Configuration = import("./markdownlint.mjs").Configuration;
 export type ConfigurationParser = import("./markdownlint.mjs").ConfigurationParser;
 export type ConfigurationStrict = import("./markdownlint.mjs").ConfigurationStrict;

package/lib/exports.mjs

@@ -1,6 +1,7 @@
 // @ts-check
 
 export { applyFix, applyFixes, getVersion } from "./markdownlint.mjs";
+export { resolveModule } from "./resolve-module.cjs";
 
 /** @typedef {import("./markdownlint.mjs").Configuration} Configuration */
 /** @typedef {import("./markdownlint.mjs").ConfigurationParser} ConfigurationParser */

package/lib/markdownlint.mjs

@@ -1,10 +1,11 @@
 // @ts-check
 
 // @ts-ignore
-import { fs as nodeFs, module, os, path } from "#node-imports";
-const dynamicRequire = module.createRequire(import.meta.url);
+import { fs as nodeFs, os, path } from "#node-imports";
 import { initialize as cacheInitialize } from "./cache.mjs";
 import { version } from "./constants.mjs";
+import { requireMarkdownItCjs } from "./defer-require.cjs";
+import { resolveModule } from "./resolve-module.cjs";
 import rules from "./rules.mjs";
 import { parse as micromarkParse } from "./micromark-parse.mjs";
 import * as helpers from "../helpers/helpers.cjs";
@@ -501,7 +502,7 @@ function lintContent(
   // Parse content into lines and get markdown-it tokens
   const lines = content.split(helpers.newLineRe);
   const markdownitTokens = needMarkdownItTokens ?
-    dynamicRequire("./markdownit.cjs").getMarkdownItTokens(markdownItPlugins, preClearedContent, lines) :
+    requireMarkdownItCjs().getMarkdownItTokens(markdownItPlugins, preClearedContent, lines) :
     [];
   // Create (frozen) parameters for rules
   /** @type {MarkdownParsers} */
@@ -1010,10 +1011,10 @@ function resolveConfigExtends(configFile, referenceId, fs, callback) {
     if (err) {
       // Not a file, try require.resolve
       try {
-        return callback(null, dynamicRequire.resolve(
-          referenceId,
-          { "paths": [ configFileDirname ] }
-        ));
+        return callback(
+          null,
+          resolveModule(referenceId, [ configFileDirname ])
+        );
       } catch {
         // Unable to resolve, use resolvedExtendsFile
       }
@@ -1041,10 +1042,7 @@ function resolveConfigExtendsSync(configFile, referenceId, fs) {
     // Not a file, try require.resolve
   }
   try {
-    return dynamicRequire.resolve(
-      referenceId,
-      { "paths": [ configFileDirname ] }
-    );
+    return resolveModule(referenceId, [ configFileDirname ]);
   } catch {
     // Unable to resolve, return resolvedExtendsFile
   }

package/lib/md039.mjs

@@ -1,7 +1,7 @@
 // @ts-check
 
 import { addErrorContext } from "../helpers/helpers.cjs";
-import { getReferenceLinkImageData, filterByTypesCached } from "./cache.mjs";
+import { filterByTypesCached } from "./cache.mjs";
 
 /**
  * Adds an error for a label space issue.
@@ -35,18 +35,6 @@ function addLabelSpaceError(onError, label, labelText, isStart) {
   );
 }
 
-/**
- * Determines if a link is a valid link (and not a fake shortcut link due to parser tricks).
- *
- * @param {import("markdownlint").MicromarkToken} label Label token.
- * @param {import("markdownlint").MicromarkToken} labelText LabelText token.
- * @param {Map<string, any>} definitions Map of link definitions.
- * @returns {boolean} True iff the link is valid.
- */
-function validLink(label, labelText, definitions) {
-  return (label.parent?.children.length !== 1) || definitions.has(labelText.text.trim());
-}
-
 /** @type {import("markdownlint").Rule} */
 export default {
   "names": [ "MD039", "no-space-in-links" ],
@@ -54,22 +42,15 @@ export default {
   "tags": [ "whitespace", "links" ],
   "parser": "micromark",
   "function": function MD039(params, onError) {
-    const { definitions } = getReferenceLinkImageData();
     const labels = filterByTypesCached([ "label" ])
       .filter((label) => label.parent?.type === "link");
     for (const label of labels) {
       const labelTexts = label.children.filter((child) => child.type === "labelText");
       for (const labelText of labelTexts) {
-        if (
-          (labelText.text.trimStart().length !== labelText.text.length) &&
-          validLink(label, labelText, definitions)
-        ) {
+        if (labelText.text.trimStart().length !== labelText.text.length) {
           addLabelSpaceError(onError, label, labelText, true);
         }
-        if (
-          (labelText.text.trimEnd().length !== labelText.text.length) &&
-          validLink(label, labelText, definitions)
-        ) {
+        if (labelText.text.trimEnd().length !== labelText.text.length) {
           addLabelSpaceError(onError, label, labelText, false);
         }
       }

package/lib/micromark-parse.mjs

@@ -6,8 +6,8 @@ import { gfmFootnote } from "micromark-extension-gfm-footnote";
 import { gfmTable } from "micromark-extension-gfm-table";
 import { math } from "micromark-extension-math";
 import { parse as micromarkParse, postprocess as micromarkPostprocess, preprocess as micromarkPreprocess } from "micromark";
-// micromark-core-commonmark is not a dependency because this instance must match what's used by micromark
-// eslint-disable-next-line n/no-extraneous-import
+// micromark-core-commonmark must exactly match what's used by micromark for the shim below to work correctly
+// Unfortunately, omitting this dependency from package.json breaks strict dependency resolution (e.g., pnpm)
 import { labelEnd } from "micromark-core-commonmark";
 import { isHtmlFlowComment } from "../helpers/micromark-helpers.cjs";
 import { flatTokensSymbol, htmlFlowSymbol, newLineRe } from "../helpers/shared.cjs";

package/lib/node-imports-browser.mjs

@@ -12,8 +12,6 @@ export const fs = {
   "readFileSync": throwForSync
 };
 
-export { default as module } from "./node-imports-browser-module.cjs";
-
 export const os = {};
 
 export const path = {

package/lib/node-imports-node.mjs

@@ -3,9 +3,6 @@
 import { access, accessSync, readFile, readFileSync } from "node:fs";
 export const fs = { access, accessSync, readFile, readFileSync };
 
-import { createRequire } from "node:module";
-export const module = { createRequire };
-
 import { EOL, homedir } from "node:os";
 export const os = { EOL, homedir };
 

package/lib/resolve-module.cjs

@@ -0,0 +1,52 @@
+// @ts-check
+
+"use strict";
+
+// @ts-ignore
+// eslint-disable-next-line camelcase, no-inline-comments, no-undef
+const nativeRequire = (typeof __non_webpack_require__ === "undefined") ? require : /* c8 ignore next */ __non_webpack_require__;
+// Captures the native require implementation (even under webpack).
+
+/**
+ * @typedef RequireResolveOptions
+ * @property {string[]} [paths] Additional paths to resolve from.
+ */
+
+/**
+ * @callback RequireResolve
+ * @param {string} id Module name or path.
+ * @param {RequireResolveOptions} options Options to apply.
+ * @returns {string} Resolved module path.
+ */
+
+/**
+ * Resolves modules according to Node's resolution rules.
+ *
+ * @param {RequireResolve} resolve Node-like require.resolve implementation.
+ * @param {string} id Module name or path.
+ * @param {string[]} [paths] Additional paths to resolve from.
+ * @returns {string} Resolved module path.
+ */
+const resolveModuleCustomResolve = (resolve, id, paths = []) => {
+  // resolve.paths is sometimes not present under webpack or VS Code
+  // @ts-ignore
+  const resolvePaths = resolve.paths?.("") || [];
+  const allPaths = [ ...paths, ...resolvePaths ];
+  return resolve(id, { "paths": allPaths });
+};
+
+/**
+ * Resolves modules according to Node's resolution rules.
+ *
+ * @param {string} id Module name or path.
+ * @param {string[]} [paths] Additional paths to resolve from.
+ * @returns {string} Resolved module path.
+ */
+const resolveModule = (id, paths) => (
+  resolveModuleCustomResolve(nativeRequire.resolve, id, paths)
+);
+
+module.exports = {
+  resolveModule,
+  resolveModuleCustomResolve
+};

package/lib/resolve-module.d.cts

@@ -0,0 +1,34 @@
+export type RequireResolveOptions = {
+    /**
+     * Additional paths to resolve from.
+     */
+    paths?: string[];
+};
+export type RequireResolve = (id: string, options: RequireResolveOptions) => string;
+/**
+ * Resolves modules according to Node's resolution rules.
+ *
+ * @param {string} id Module name or path.
+ * @param {string[]} [paths] Additional paths to resolve from.
+ * @returns {string} Resolved module path.
+ */
+export function resolveModule(id: string, paths?: string[]): string;
+/**
+ * @typedef RequireResolveOptions
+ * @property {string[]} [paths] Additional paths to resolve from.
+ */
+/**
+ * @callback RequireResolve
+ * @param {string} id Module name or path.
+ * @param {RequireResolveOptions} options Options to apply.
+ * @returns {string} Resolved module path.
+ */
+/**
+ * Resolves modules according to Node's resolution rules.
+ *
+ * @param {RequireResolve} resolve Node-like require.resolve implementation.
+ * @param {string} id Module name or path.
+ * @param {string[]} [paths] Additional paths to resolve from.
+ * @returns {string} Resolved module path.
+ */
+export function resolveModuleCustomResolve(resolve: RequireResolve, id: string, paths?: string[]): string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "markdownlint",
-  "version": "0.37.2",
+  "version": "0.37.4",
   "description": "A Node.js style checker and lint tool for Markdown/CommonMark files.",
   "type": "module",
   "exports": {
@@ -36,7 +36,7 @@
     "build-config": "npm run build-config-schema && npm run build-config-example",
     "build-config-example": "node schema/build-config-example.mjs",
     "build-config-schema": "node schema/build-config-schema.mjs",
-    "build-declaration": "tsc --allowJs --checkJs --declaration --emitDeclarationOnly --module nodenext --outDir dts --rootDir . --target es2015 lib/exports.mjs lib/exports-async.mjs lib/exports-promise.mjs lib/exports-sync.mjs lib/markdownlint.mjs && node scripts/index.mjs copy dts/lib/exports.d.mts lib/exports.d.mts && node scripts/index.mjs copy dts/lib/exports-async.d.mts lib/exports-async.d.mts && node scripts/index.mjs copy dts/lib/exports-promise.d.mts lib/exports-promise.d.mts && node scripts/index.mjs copy dts/lib/exports-sync.d.mts lib/exports-sync.d.mts && node scripts/index.mjs copy dts/lib/markdownlint.d.mts lib/markdownlint.d.mts && node scripts/index.mjs remove dts",
+    "build-declaration": "tsc --allowJs --checkJs --declaration --emitDeclarationOnly --module nodenext --outDir dts --rootDir . --target es2015 lib/exports.mjs lib/exports-async.mjs lib/exports-promise.mjs lib/exports-sync.mjs lib/markdownlint.mjs lib/resolve-module.cjs && node scripts/index.mjs copy dts/lib/exports.d.mts lib/exports.d.mts && node scripts/index.mjs copy dts/lib/exports-async.d.mts lib/exports-async.d.mts && node scripts/index.mjs copy dts/lib/exports-promise.d.mts lib/exports-promise.d.mts && node scripts/index.mjs copy dts/lib/exports-sync.d.mts lib/exports-sync.d.mts && node scripts/index.mjs copy dts/lib/markdownlint.d.mts lib/markdownlint.d.mts && node scripts/index.mjs copy dts/lib/resolve-module.d.cts lib/resolve-module.d.cts && node scripts/index.mjs remove dts",
     "build-demo": "node scripts/index.mjs copy node_modules/markdown-it/dist/markdown-it.min.js demo/markdown-it.min.js && cd demo && webpack --no-stats",
     "build-docs": "node doc-build/build-rules.mjs",
     "build-example": "npm install --no-save --ignore-scripts grunt grunt-cli gulp through2",
@@ -59,7 +59,7 @@
     "lint-test-repos": "ava --timeout=10m test/markdownlint-test-repos-*.mjs",
     "serial-config-docs": "npm run build-config && npm run build-docs",
     "serial-declaration-demo": "npm run build-declaration && npm-run-all --continue-on-error --parallel build-demo test-declaration",
-    "test": "ava --timeout=30s test/markdownlint-test.mjs test/markdownlint-test-config.mjs test/markdownlint-test-custom-rules.mjs test/markdownlint-test-fixes.mjs test/markdownlint-test-helpers.mjs test/markdownlint-test-micromark.mjs test/markdownlint-test-result-object.mjs test/markdownlint-test-scenarios.mjs helpers/test.cjs",
+    "test": "ava --timeout=30s test/markdownlint-test.mjs test/markdownlint-test-config.mjs test/markdownlint-test-custom-rules.mjs test/markdownlint-test-fixes.mjs test/markdownlint-test-helpers.mjs test/markdownlint-test-micromark.mjs test/markdownlint-test-result-object.mjs test/markdownlint-test-scenarios.mjs test/resolve-module-test.mjs helpers/test.cjs",
     "test-cover": "c8 --100 npm test",
     "test-declaration": "cd example/typescript && tsc --module commonjs && tsc --module nodenext && node type-check.js",
     "test-extra": "ava --timeout=10m test/markdownlint-test-extra-parse.mjs test/markdownlint-test-extra-type.mjs",
@@ -73,6 +73,7 @@
   "dependencies": {
     "markdown-it": "14.1.0",
     "micromark": "4.0.1",
+    "micromark-core-commonmark": "2.0.2",
     "micromark-extension-directive": "3.0.2",
     "micromark-extension-gfm-autolink-literal": "2.1.0",
     "micromark-extension-gfm-footnote": "2.1.0",
@@ -81,21 +82,21 @@
     "micromark-util-types": "2.0.1"
   },
   "devDependencies": {
-    "@eslint/js": "9.17.0",
-    "@stylistic/eslint-plugin": "2.12.1",
+    "@eslint/js": "9.18.0",
+    "@stylistic/eslint-plugin": "2.13.0",
     "ajv": "8.17.1",
     "ava": "6.2.0",
     "c8": "10.1.3",
     "character-entities": "2.0.2",
-    "eslint": "9.17.0",
+    "eslint": "9.18.0",
     "eslint-plugin-jsdoc": "50.6.1",
-    "eslint-plugin-n": "17.15.0",
+    "eslint-plugin-n": "17.15.1",
     "eslint-plugin-regexp": "2.7.0",
     "eslint-plugin-unicorn": "56.0.1",
     "gemoji": "8.1.0",
     "globby": "14.0.2",
     "js-yaml": "4.1.0",
-    "json-schema-to-typescript": "15.0.3",
+    "json-schema-to-typescript": "15.0.4",
     "jsonc-parser": "3.3.1",
     "markdown-it-for-inline": "2.0.1",
     "markdown-it-sub": "2.0.0",
@@ -105,9 +106,9 @@
     "npm-run-all": "4.1.5",
     "terser-webpack-plugin": "5.3.11",
     "toml": "3.0.0",
-    "typescript": "5.7.2",
+    "typescript": "5.7.3",
     "webpack": "5.97.1",
-    "webpack-cli": "5.1.4"
+    "webpack-cli": "6.0.1"
   },
   "keywords": [
     "markdown",