march-cli 0.1.23 → 0.1.24

package/README.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="docs/assets/march-banner.png" alt="March CLI banner" width="800">
+  <img src="docs/assets/march-banner.svg" alt="March CLI banner" width="800">
 </p>
 
 <p align="center"><strong>Forget Skills. Embrace Memory. Keep your model in the sweet spot.</strong></p>

package/README.zh.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="docs/assets/march-banner.png" alt="March CLI banner" width="800">
+  <img src="docs/assets/march-banner.svg" alt="March CLI banner" width="800">
 </p>
 
 <p align="center"><strong>忘记 Skill，拥抱记忆，让你的模型永远工作在甜点区。</strong></p>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "march-cli",
-  "version": "0.1.23",
+  "version": "0.1.24",
   "description": "March CLI — terminal-native coding agent with context reconstruction",
   "type": "module",
   "main": "./src/main.mjs",
@@ -19,6 +19,9 @@
     "test:shell-runtime-real": "node test/shell-real-runtime.acceptance.mjs",
     "test:shell-tui-real": "node test/shell-tui-real.acceptance.mjs",
     "test:tui-key-real": "node test/tui-key-real.acceptance.mjs",
+    "docs:dev": "vitepress dev docs --host 127.0.0.1",
+    "docs:build": "vitepress build docs",
+    "docs:preview": "vitepress preview docs --host 127.0.0.1",
     "context": "cd .. && node march-cli/bin/march.mjs --dump-context",
     "notify:experiment": "node scripts/notify-experiment.mjs",
     "publish:env": "node scripts/npm-publish-from-env.mjs"
@@ -39,5 +42,8 @@
   },
   "optionalDependencies": {
     "@vscode/ripgrep": "^1.18.0"
+  },
+  "devDependencies": {
+    "vitepress": "^1.6.4"
   }
 }

package/src/agent/editing/cohesion-warning.mjs

@@ -0,0 +1,57 @@
+import { extname, normalize } from "node:path";
+
+const MAX_COHESIVE_LINES = 300;
+const MIN_ADDED_LINES = 40;
+
+const CODE_EXTENSIONS = new Set([
+  ".cjs",
+  ".go",
+  ".js",
+  ".jsx",
+  ".mjs",
+  ".py",
+  ".rs",
+  ".ts",
+  ".tsx",
+]);
+
+const IGNORED_SEGMENTS = new Set([
+  "build",
+  "coverage",
+  "dist",
+  "fixture",
+  "fixtures",
+  "node_modules",
+  "vendor",
+]);
+
+export function buildCohesionWarning({ path, oldText, newText }) {
+  if (!shouldCheckPath(path)) return null;
+
+  const oldLines = countLines(oldText);
+  const newLines = countLines(newText);
+  const addedLines = Math.max(0, newLines - oldLines);
+  if (newLines <= MAX_COHESIVE_LINES || addedLines < MIN_ADDED_LINES) return null;
+
+  return [
+    "[cohesion]",
+    `${formatPath(path)} is now ${newLines} lines after a +${addedLines} line edit.`,
+    "If the added logic is a separate responsibility, extract it into a cohesive module before continuing.",
+  ].join("\n");
+}
+
+function shouldCheckPath(path) {
+  const normalized = normalize(path).replaceAll("\\", "/");
+  if (normalized.includes(".generated.")) return false;
+  if (!CODE_EXTENSIONS.has(extname(normalized))) return false;
+  return !normalized.split("/").some((segment) => IGNORED_SEGMENTS.has(segment));
+}
+
+function countLines(text) {
+  if (!text) return 0;
+  return String(text).split("\n").length;
+}
+
+function formatPath(path) {
+  return String(path).replaceAll("\\", "/");
+}

package/src/agent/file-edit-tool.mjs

@@ -4,8 +4,9 @@ import { defineTool } from "@earendil-works/pi-coding-agent";
 import { Type } from "typebox";
 import { toolText } from "./tool-result.mjs";
 import { applyReplaceTextPatch, applyReplaceRangePatch } from "./editing/diff-apply.mjs";
-import { formatAppliedDiff, formatDiff } from "./editing/diff-format.mjs";
-import { waitForLspReport } from "./editing/lsp-report.mjs";
+import { buildCohesionWarning } from "./editing/cohesion-warning.mjs";
+import { formatAppliedDiff, formatDiff } from "./editing/diff-format.mjs";
+import { waitForLspReport } from "./editing/lsp-report.mjs";
 
 export { formatDiff } from "./editing/diff-format.mjs";
 
@@ -67,8 +68,9 @@ async function writeFullFile({ absPath, path, content, mode, engine, ui, lspServ
   if (mode === WRITE_MODE && existsSync(absPath)) {
     return toolText(`Error: ${absPath} already exists. Use mode=overwrite to replace it.`, { error: true });
   }
-  const oldText = mode === OVERWRITE_MODE && existsSync(absPath) ? readFileSync(absPath, "utf8") : "";
-  const diffLines = formatDiff(oldText, content, { startLine: 1 });
+  const oldText = mode === OVERWRITE_MODE && existsSync(absPath) ? readFileSync(absPath, "utf8") : "";
+  const cohesionWarning = buildCohesionWarning({ path: absPath, oldText, newText: content });
+  const diffLines = formatDiff(oldText, content, { startLine: 1 });
   try {
     mkdirSync(dirname(absPath), { recursive: true });
     writeFileSync(absPath, content, "utf8");
@@ -76,7 +78,8 @@ async function writeFullFile({ absPath, path, content, mode, engine, ui, lspServ
     const lspResult = await lspService?.touchFile?.(absPath);
     ui.editDiff(absPath, diffLines);
 
-    return await toolTextWithDiagnostics(`${mode === WRITE_MODE ? "Wrote" : "Overwrote"} ${path}\n\n${formatAppliedDiff([{ oldText, newText: content, startLine: 1 }])}`, { path: absPath }, { lspService, path: absPath, lspResult, since: lspTouchedAt });
+    const baseText = `${mode === WRITE_MODE ? "Wrote" : "Overwrote"} ${path}\n\n${formatAppliedDiff([{ oldText, newText: content, startLine: 1 }])}`;
+    return await toolTextWithDiagnostics(appendSections(baseText, [cohesionWarning]), withWarnings({ path: absPath }, cohesionWarning), { lspService, path: absPath, lspResult, since: lspTouchedAt });
   } catch (err) {
     return toolText(`Error writing ${absPath}: ${err.message}`, { error: true });
   }
@@ -97,23 +100,35 @@ async function patchFile({ absPath, path, edits, engine, ui, lspService }) {
   const prepared = preparePatchEdits(content, edits, absPath);
   if (prepared.error) return toolText(prepared.error, { error: true });
 
-  const newContent = applyPreparedEdits(content, prepared.edits);
-  try {
+  const newContent = applyPreparedEdits(content, prepared.edits);
+  const cohesionWarning = buildCohesionWarning({ path: absPath, oldText: content, newText: newContent });
+  try {
     mkdirSync(dirname(absPath), { recursive: true });
     writeFileSync(absPath, newContent, "utf8");
     const lspTouchedAt = Date.now();
     const lspResult = await lspService?.touchFile?.(absPath);
     ui.editDiff(absPath, prepared.edits.flatMap((edit) => formatDiff(edit.oldText, edit.newText, { startLine: edit.startLine })));
-    return await toolTextWithDiagnostics(`Edited ${absPath}\n\n${formatAppliedDiff(prepared.edits)}`, { path: absPath, edits: prepared.edits.length }, { lspService, path: absPath, lspResult, since: lspTouchedAt });
+    const baseText = `Edited ${absPath}\n\n${formatAppliedDiff(prepared.edits)}`;
+    const details = withWarnings({ path: absPath, edits: prepared.edits.length }, cohesionWarning);
+    return await toolTextWithDiagnostics(appendSections(baseText, [cohesionWarning]), details, { lspService, path: absPath, lspResult, since: lspTouchedAt });
   } catch (err) {
     return toolText(`Error writing ${absPath}: ${err.message}`, { error: true });
   }
 }
 
-async function toolTextWithDiagnostics(text, details, { lspService, path, lspResult, since = Date.now(), timeoutMs = 3000, intervalMs = 150 } = {}) {
-  const lspReport = await waitForLspReport({ lspService, path, lspResult, since, timeoutMs, intervalMs });
-  return toolText(lspReport ? `${text}\n\n${lspReport}` : text, details);
-}
+async function toolTextWithDiagnostics(text, details, { lspService, path, lspResult, since = Date.now(), timeoutMs = 3000, intervalMs = 150 } = {}) {
+  const lspReport = await waitForLspReport({ lspService, path, lspResult, since, timeoutMs, intervalMs });
+  return toolText(lspReport ? `${text}\n\n${lspReport}` : text, details);
+}
+
+function appendSections(text, sections) {
+  return [text, ...sections.filter(Boolean)].join("\n\n");
+}
+
+function withWarnings(details, cohesionWarning) {
+  if (!cohesionWarning) return details;
+  return { ...details, warnings: ["cohesion"] };
+}
 
 export function preparePatchEdits(content, edits, path = "file") {
   const prepared = [];