maplibre-gl 2.2.1 → 2.3.1-pre.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "maplibre-gl",
   "description": "BSD licensed community fork of mapbox-gl, a WebGL interactive maps library",
-  "version": "2.2.1",
+  "version": "2.3.1-pre.2",
   "main": "dist/maplibre-gl.js",
   "style": "dist/maplibre-gl.css",
   "license": "BSD-3-Clause",
@@ -28,6 +28,7 @@
     "earcut": "^2.2.4",
     "geojson-vt": "^3.2.1",
     "gl-matrix": "^3.4.3",
+    "global-prefix": "^3.0.0",
     "murmurhash-js": "^1.0.0",
     "pbf": "^3.2.1",
     "potpack": "^1.0.2",
@@ -39,7 +40,7 @@
   "devDependencies": {
     "@mapbox/gazetteer": "^5.1.0",
     "@mapbox/mapbox-gl-rtl-text": "^0.2.3",
-    "@mapbox/mvt-fixtures": "^3.9.0",
+    "@mapbox/mvt-fixtures": "^3.10.0",
     "@rollup/plugin-commonjs": "^22.0.2",
     "@rollup/plugin-json": "^4.1.0",
     "@rollup/plugin-node-resolve": "^13.3.0",
@@ -47,7 +48,6 @@
     "@rollup/plugin-strip": "^2.1.0",
     "@rollup/plugin-typescript": "^8.3.4",
     "@types/benchmark": "^2.1.1",
-    "@types/browserify": "^12.0.37",
     "@types/cssnano": "^5.0.0",
     "@types/d3": "^7.4.0",
     "@types/diff": "^5.0.2",
@@ -63,7 +63,7 @@
     "@types/offscreencanvas": "^2019.7.0",
     "@types/pixelmatch": "^5.2.4",
     "@types/pngjs": "^6.0.1",
-    "@types/react": "^18.0.15",
+    "@types/react": "^18.0.17",
     "@types/react-dom": "^18.0.6",
     "@types/request": "^2.48.8",
     "@types/rollup-plugin-json": "^3.0.3",
@@ -75,15 +75,14 @@
     "acorn-import-assertions": "^1.8.0",
     "address": "^1.2.0",
     "benchmark": "^2.1.4",
-    "browserify": "^17.0.0",
     "canvas": "^2.9.3",
-    "cssnano": "^5.1.12",
+    "cssnano": "^5.1.13",
     "d3": "^7.6.1",
     "d3-queue": "^3.0.7",
     "diff": "^5.1.0",
     "documentation": "14.0.0-alpha.1",
     "dts-bundle-generator": "^6.12.0",
-    "eslint": "^8.21.0",
+    "eslint": "^8.22.0",
     "eslint-config-mourner": "^3.0.0",
     "eslint-plugin-html": "^7.1.0",
     "eslint-plugin-import": "^2.26.0",
@@ -106,9 +105,9 @@
     "node-plantuml": "^0.9.0",
     "npm-font-open-sans": "^1.1.0",
     "npm-run-all": "^4.1.5",
-    "pdf-merger-js": "^3.4.0",
+    "pdf-merger-js": "^4.0.0",
     "pixelmatch": "^5.3.0",
-    "playwright": "^1.24.2",
+    "playwright": "^1.25.0",
     "pngjs": "^6.0.0",
     "postcss": "^8.4.14",
     "postcss-cli": "^10.0.0",
@@ -117,7 +116,7 @@
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "request": "^2.88.0",
-    "rollup": "^2.77.2",
+    "rollup": "^2.78.0",
     "rollup-plugin-import-assert": "^2.1.0",
     "rollup-plugin-sourcemaps": "^0.6.3",
     "rollup-plugin-terser": "^7.0.2",
@@ -126,12 +125,11 @@
     "shuffle-seed": "^1.1.6",
     "source-map-explorer": "^2.5.2",
     "st": "^3.0.0",
-    "stylelint": "^14.9.1",
-    "stylelint-config-standard": "^26.0.0",
-    "ts-jest": "^28.0.7",
+    "stylelint": "^14.10.0",
+    "stylelint-config-standard": "^27.0.0",
+    "ts-jest": "^28.0.8",
     "ts-node": "^10.9.1",
-    "typescript": "^4.7.4",
-    "unassert-rollup-plugin": "^2.0.0"
+    "typescript": "^4.7.4"
   },
   "scripts": {
     "generate-shaders": "node --loader ts-node/esm --experimental-specifier-resolution=node build/generate-shaders.ts",
@@ -167,7 +165,7 @@
     "test-render": "node --loader ts-node/esm --experimental-specifier-resolution=node --max-old-space-size=2048 test/integration/render/render.test.ts",
     "test-query": "jest -c ./jest.config.e2e.ts --roots ./test/integration/query",
     "test-expression": "jest --roots ./test/integration/expression",
-    "test-unit": "jest  -c ./jest.config.ts --roots ./src",
+    "test-unit": "jest --roots ./src  -c ./jest.config.ts ",
     "codegen": "npm run generate-style-code && npm run generate-struct-arrays && npm run generate-style-spec && npm run generate-shaders && npm run generate-debug-index-file",
     "benchmark": "node --loader ts-node/esm --experimental-specifier-resolution=node test/bench/run-benchmarks.ts",
     "gl-stats": "node --loader ts-node/esm --experimental-specifier-resolution=node test/bench/gl-stats.ts",

package/src/data/array_types.g.ts

@@ -1,6 +1,5 @@
 // This file is generated. Edit build/generate-struct-arrays.ts, then run `npm run codegen`.
 
-import assert from 'assert';
 import {Struct, StructArray} from '../util/struct_array';
 import {register} from '../util/web_worker_transfer';
 import Point from '@mapbox/point-geometry';
@@ -877,7 +876,6 @@ export class CollisionBoxArray extends StructArrayLayout6i1ul2ui20 {
      * @private
      */
     get(index: number): CollisionBoxStruct {
-        assert(!this.isTransferred);
         return new CollisionBoxStruct(this, index);
     }
 }
@@ -922,7 +920,6 @@ export class PlacedSymbolArray extends StructArrayLayout2i2ui3ul3ui2f3ub1ul1i48
      * @private
      */
     get(index: number): PlacedSymbolStruct {
-        assert(!this.isTransferred);
         return new PlacedSymbolStruct(this, index);
     }
 }
@@ -976,7 +973,6 @@ export class SymbolInstanceArray extends StructArrayLayout8i15ui1ul4f68 {
      * @private
      */
     get(index: number): SymbolInstanceStruct {
-        assert(!this.isTransferred);
         return new SymbolInstanceStruct(this, index);
     }
 }
@@ -1024,7 +1020,6 @@ export class FeatureIndexArray extends StructArrayLayout1ul2ui8 {
      * @private
      */
     get(index: number): FeatureIndexStruct {
-        assert(!this.isTransferred);
         return new FeatureIndexStruct(this, index);
     }
 }

package/src/data/bucket/fill_bucket.ts

@@ -6,7 +6,6 @@ import {ProgramConfigurationSet} from '../program_configuration';
 import {LineIndexArray, TriangleIndexArray} from '../index_array_type';
 import earcut from 'earcut';
 import classifyRings from '../../util/classify_rings';
-import assert from 'assert';
 const EARCUT_MAX_RINGS = 500;
 import {register} from '../../util/web_worker_transfer';
 import {hasPattern, addPatternDependencies} from './pattern_bucket_features';
@@ -211,7 +210,6 @@ class FillBucket implements Bucket {
             }
 
             const indices = earcut(flattened, holeIndices);
-            assert(indices.length % 3 === 0);
 
             for (let i = 0; i < indices.length; i += 3) {
                 this.indexArray.emplaceBack(

package/src/data/bucket/fill_extrusion_bucket.ts

@@ -9,7 +9,6 @@ import earcut from 'earcut';
 import mvt from '@mapbox/vector-tile';
 const vectorTileFeatureTypes = mvt.VectorTileFeature.types;
 import classifyRings from '../../util/classify_rings';
-import assert from 'assert';
 const EARCUT_MAX_RINGS = 500;
 import {register} from '../../util/web_worker_transfer';
 import {hasPattern, addPatternDependencies} from './pattern_bucket_features';
@@ -264,7 +263,6 @@ class FillExtrusionBucket implements Bucket {
             }
 
             const indices = earcut(flattened, holeIndices);
-            assert(indices.length % 3 === 0);
 
             for (let j = 0; j < indices.length; j += 3) {
                 // Counter-clockwise winding order.

package/src/data/bucket/symbol_bucket.test.ts

@@ -1,5 +1,3 @@
-// @ts-nocheck
-
 import fs from 'fs';
 import path from 'path';
 import Protobuf from 'pbf';
@@ -9,7 +7,7 @@ import {CollisionBoxArray} from '../../data/array_types.g';
 import {performSymbolLayout} from '../../symbol/symbol_layout';
 import {Placement} from '../../symbol/placement';
 import Transform from '../../geo/transform';
-import {OverscaledTileID} from '../../source/tile_id';
+import {CanonicalTileID, OverscaledTileID} from '../../source/tile_id';
 import Tile from '../../source/tile';
 import CrossTileSymbolIndex from '../../symbol/cross_tile_symbol_index';
 import FeatureIndex from '../../data/feature_index';
@@ -66,26 +64,33 @@ describe('SymbolBucket', () => {
         const bucketA = bucketSetup() as any as SymbolBucket;
         const bucketB = bucketSetup() as any as SymbolBucket;
         const options = {iconDependencies: {}, glyphDependencies: {}} as PopulateParameters;
-        const placement = new Placement(transform, 0, true);
+        const placement = new Placement(transform, undefined as any, 0, true);
         const tileID = new OverscaledTileID(0, 0, 0, 0, 0);
         const crossTileSymbolIndex = new CrossTileSymbolIndex();
 
         // add feature from bucket A
-        bucketA.populate([{feature} as IndexedFeature], options, undefined);
-        performSymbolLayout(bucketA, stacks, {}, undefined, undefined, undefined, undefined);
+        bucketA.populate([{feature} as IndexedFeature], options, undefined as any);
+        performSymbolLayout(
+            {
+                bucket: bucketA,
+                glyphMap: stacks,
+                glyphPositions: {}
+            } as any);
         const tileA = new Tile(tileID, 512);
         tileA.latestFeatureIndex = new FeatureIndex(tileID);
         tileA.buckets = {test: bucketA};
         tileA.collisionBoxArray = collisionBoxArray;
 
         // add same feature from bucket B
-        bucketB.populate([{feature} as IndexedFeature], options, undefined);
-        performSymbolLayout(bucketB, stacks, {}, undefined, undefined, undefined, undefined);
+        bucketB.populate([{feature} as IndexedFeature], options, undefined as any);
+        performSymbolLayout({
+            bucket: bucketB, glyphMap: stacks, glyphPositions: {}
+        } as any);
         const tileB = new Tile(tileID, 512);
         tileB.buckets = {test: bucketB};
         tileB.collisionBoxArray = collisionBoxArray;
 
-        crossTileSymbolIndex.addLayer(bucketA.layers[0], [tileA, tileB], undefined);
+        crossTileSymbolIndex.addLayer(bucketA.layers[0], [tileA, tileB], undefined as any);
 
         const place = (layer, tile) => {
             const parts = [];
@@ -112,9 +117,13 @@ describe('SymbolBucket', () => {
         const bucket = bucketSetup() as any as SymbolBucket;
         const options = {iconDependencies: {}, glyphDependencies: {}} as PopulateParameters;
 
-        bucket.populate([{feature} as IndexedFeature], options, undefined);
+        bucket.populate([{feature} as IndexedFeature], options, undefined as any);
         const fakeGlyph = {rect: {w: 10, h: 10}, metrics: {left: 10, top: 10, advance: 10}};
-        performSymbolLayout(bucket, stacks, {'Test': {97: fakeGlyph, 98: fakeGlyph, 99: fakeGlyph, 100: fakeGlyph, 101: fakeGlyph, 102: fakeGlyph} as any}, undefined, undefined, undefined, undefined);
+        performSymbolLayout({
+            bucket,
+            glyphMap: stacks,
+            glyphPositions: {'Test': {97: fakeGlyph, 98: fakeGlyph, 99: fakeGlyph, 100: fakeGlyph, 101: fakeGlyph, 102: fakeGlyph} as any}
+        } as any);
 
         expect(spy).toHaveBeenCalledTimes(1);
         expect(spy.mock.calls[0][0].includes('Too many glyphs being rendered in a tile.')).toBeTruthy();
@@ -146,14 +155,16 @@ describe('SymbolBucket', () => {
                 createIndexedFeature(1, 1, 'b'),
                 createIndexedFeature(2, 2, 'a')
             ] as any as IndexedFeature[],
-            options, undefined
+            options, undefined as any
         );
 
         const icons = options.iconDependencies as any;
         expect(icons.a).toBe(true);
         expect(icons.b).toBe(true);
 
-        performSymbolLayout(bucket, null, null, imageMap, imagePos, undefined, undefined);
+        performSymbolLayout({
+            bucket, imageMap, imagePositions: imagePos
+        } as any);
 
         // undefined SDF should be treated the same as false SDF - no warning raised
         expect(spy).not.toHaveBeenCalledTimes(1);
@@ -186,14 +197,14 @@ describe('SymbolBucket', () => {
                 createIndexedFeature(1, 1, 'b'),
                 createIndexedFeature(2, 2, 'a')
             ] as any as IndexedFeature[],
-            options, undefined
+            options, undefined as unknown as CanonicalTileID
         );
 
         const icons = options.iconDependencies as any;
         expect(icons.a).toBe(true);
         expect(icons.b).toBe(true);
 
-        performSymbolLayout(bucket, null, null, imageMap, imagePos, undefined, undefined);
+        performSymbolLayout({bucket, imageMap, imagePositions: imagePos} as any);
 
         // true SDF and false SDF in same bucket should trigger warning
         expect(spy).toHaveBeenCalledTimes(1);
@@ -203,8 +214,8 @@ describe('SymbolBucket', () => {
         const rtlBucket = bucketSetup('مرحبا');
         const ltrBucket = bucketSetup('hello');
         const options = {iconDependencies: {}, glyphDependencies: {}} as PopulateParameters;
-        rtlBucket.populate([{feature} as IndexedFeature], options, undefined);
-        ltrBucket.populate([{feature} as IndexedFeature], options, undefined);
+        rtlBucket.populate([{feature} as IndexedFeature], options, undefined as any);
+        ltrBucket.populate([{feature} as IndexedFeature], options, undefined as any);
 
         expect(rtlBucket.hasRTLText).toBeTruthy();
         expect(ltrBucket.hasRTLText).toBeFalsy();
@@ -215,7 +226,7 @@ describe('SymbolBucket', () => {
         const rtlBucket = bucketSetup('مرحبا');
         const options = {iconDependencies: {}, glyphDependencies: {}} as PopulateParameters;
         rtlBucket.createArrays();
-        rtlBucket.populate([{feature} as IndexedFeature], options, undefined);
+        rtlBucket.populate([{feature} as IndexedFeature], options, undefined as any);
 
         expect(rtlBucket.isEmpty()).toBeFalsy();
         expect(rtlBucket.symbolInstances).toHaveLength(0);
@@ -224,7 +235,7 @@ describe('SymbolBucket', () => {
     test('SymbolBucket detects rtl text mixed with ltr text', () => {
         const mixedBucket = bucketSetup('مرحبا translates to hello');
         const options = {iconDependencies: {}, glyphDependencies: {}} as PopulateParameters;
-        mixedBucket.populate([{feature} as IndexedFeature], options, undefined);
+        mixedBucket.populate([{feature} as IndexedFeature], options, undefined as any);
 
         expect(mixedBucket.hasRTLText).toBeTruthy();
     });

package/src/data/feature_position_map.ts

@@ -1,6 +1,5 @@
 import murmur3 from 'murmurhash-js';
 import {register} from '../util/web_worker_transfer';
-import assert from 'assert';
 
 type SerializedFeaturePositionMap = {
     ids: Float64Array;
@@ -31,7 +30,7 @@ export default class FeaturePositionMap {
     }
 
     getPositions(id: unknown): Array<FeaturePosition> {
-        assert(this.indexed);
+        if (!this.indexed) throw new Error('Trying to get index, but feature positions are not indexed');
 
         const intId = getNumericId(id);
 

package/src/gl/framebuffer.ts

@@ -1,5 +1,4 @@
 import {ColorAttachment, DepthAttachment} from './value';
-import assert from 'assert';
 
 import type Context from './context';
 
@@ -22,7 +21,9 @@ class Framebuffer {
         if (hasDepth) {
             this.depthAttachment = new DepthAttachment(context, fbo);
         }
-        assert(gl.checkFramebufferStatus(gl.FRAMEBUFFER) === gl.FRAMEBUFFER_COMPLETE);
+        if (gl.checkFramebufferStatus(gl.FRAMEBUFFER) !== gl.FRAMEBUFFER_COMPLETE) {
+            throw new Error('Framebuffer is not complete');
+        }
     }
 
     destroy() {

package/src/gl/index_buffer.ts

@@ -1,4 +1,3 @@
-import assert from 'assert';
 
 import type {StructArray} from '../util/struct_array';
 import type {TriangleIndexArray, LineIndexArray, LineStripIndexArray} from '../data/index_array_type';
@@ -34,7 +33,7 @@ class IndexBuffer {
 
     updateData(array: StructArray) {
         const gl = this.context.gl;
-        assert(this.dynamicDraw);
+        if (!this.dynamicDraw) throw new Error('Attempted to update data while not in dynamic mode.');
         // The right VAO will get this buffer re-bound later in VertexArrayObject#bind
         // See https://github.com/mapbox/mapbox-gl-js/issues/5620
         this.context.unbindVAO();

package/src/gl/vertex_buffer.ts

@@ -1,4 +1,3 @@
-import assert from 'assert';
 
 import type {
     StructArray,
@@ -62,7 +61,7 @@ class VertexBuffer {
     }
 
     updateData(array: StructArray) {
-        assert(array.length === this.length);
+        if (array.length !== this.length) throw new Error(`Length of new data is ${array.length}, which doesn't match current length of ${this.length}`);
         const gl = this.context.gl;
         this.bind();
         gl.bufferSubData(gl.ARRAY_BUFFER, 0, array.arrayBuffer);

package/src/index.test.ts

@@ -4,4 +4,13 @@ describe('maplibre', () => {
     test('workerCount', () => {
         expect(typeof maplibre.workerCount === 'number').toBeTruthy();
     });
+
+    test('version', () => {
+        expect(typeof maplibre.version === 'string').toBeTruthy();
+
+        // Semver regex: https://gist.github.com/jhorsman/62eeea161a13b80e39f5249281e17c39
+        // Backslashes are doubled to escape them
+        const regexp = new RegExp('^([0-9]+)\\.([0-9]+)\\.([0-9]+)(?:-([0-9A-Za-z-]+(?:\\.[0-9A-Za-z-]+)*))?(?:\\+[0-9A-Za-z-]+)?$');
+        expect(regexp.test(maplibre.version)).toBeTruthy();
+    });
 });

package/src/index.ts

@@ -1,6 +1,5 @@
-import assert from 'assert';
 import {supported} from '@mapbox/mapbox-gl-supported';
-
+import packageJSON from '../package.json' assert {type: 'json'};
 import Map from './ui/map';
 import NavigationControl from './ui/control/navigation_control';
 import GeolocateControl from './ui/control/geolocate_control';
@@ -36,6 +35,8 @@ import RasterTileSource from './source/raster_tile_source';
 import VectorTileSource from './source/vector_tile_source';
 import VideoSource from './source/video_source';
 
+const version = packageJSON.version;
+
 const exported = {
     supported,
     setRTLTextPlugin,
@@ -99,6 +100,14 @@ const exported = {
      */
     clearPrewarmedResources,
 
+    /**
+     * Returns the package version of the library
+     * @returns {string} Package version of the library
+     */
+    get version(): string {
+        return version;
+    },
+
     /**
      * Gets and sets the number of web workers instantiated on a page with GL JS maps.
      * By default, it is set to half the number of CPU cores (capped at 6).
@@ -252,5 +261,4 @@ Debug.extend(exported, {isSafari, getPerformanceMetrics: PerformanceUtils.getPer
  */
 
 export default exported;
-// canary assert: used to confirm that asserts have been removed from production build
-assert(true, 'canary assert');
+

package/src/render/image_manager.ts

@@ -5,7 +5,6 @@ import {Event, ErrorEvent, Evented} from '../util/evented';
 import {RGBAImage} from '../util/image';
 import {ImagePosition} from './image_atlas';
 import Texture from './texture';
-import assert from 'assert';
 import {renderStyleImage} from '../style/style_image';
 import {warnOnce} from '../util/util';
 
@@ -88,7 +87,7 @@ class ImageManager extends Evented {
     }
 
     addImage(id: string, image: StyleImage) {
-        assert(!this.images[id]);
+        if (this.images[id]) throw new Error(`Image id ${id} already exist, use updateImage instead`);
         if (this._validate(id, image)) {
             this.images[id] = image;
         }
@@ -135,16 +134,15 @@ class ImageManager extends Evented {
 
     updateImage(id: string, image: StyleImage) {
         const oldImage = this.images[id];
-        assert(oldImage);
-        assert(oldImage.data.width === image.data.width);
-        assert(oldImage.data.height === image.data.height);
+        if (oldImage.data.width !== image.data.width || oldImage.data.height !== image.data.height) {
+            throw new Error(`size mismatch between old image (${oldImage.data.width}x${oldImage.data.height}) and new image (${image.data.width}x${image.data.height}).`);
+        }
         image.version = oldImage.version + 1;
         this.images[id] = image;
         this.updatedImages[id] = true;
     }
 
     removeImage(id: string) {
-        assert(this.images[id]);
         const image = this.images[id];
         delete this.images[id];
         delete this.patterns[id];
@@ -295,7 +293,7 @@ class ImageManager extends Evented {
             this.callbackDispatchedThisFrame[id] = true;
 
             const image = this.images[id];
-            assert(image);
+            if (!image) warnOnce(`Image with ID: "${id}" was not found`);
 
             const updated = renderStyleImage(image);
             if (updated) {

package/src/render/program/pattern.ts

@@ -1,4 +1,3 @@
-import assert from 'assert';
 import {
     Uniform1i,
     Uniform1f,
@@ -74,7 +73,6 @@ function bgPatternUniformValues(
 ): UniformValues<BackgroundPatternUniformsType> {
     const imagePosA = painter.imageManager.getPattern(image.from.toString());
     const imagePosB = painter.imageManager.getPattern(image.to.toString());
-    assert(imagePosA && imagePosB);
     const {width, height} = painter.imageManager.getPixelSize();
 
     const numTiles = Math.pow(2, tile.tileID.overscaledZ);

package/src/render/program.ts

@@ -1,5 +1,4 @@
 import shaders from '../shaders/shaders';
-import assert from 'assert';
 import ProgramConfiguration from '../data/program_configuration';
 import VertexArrayObject from './vertex_array_object';
 import Context from '../gl/context';
@@ -84,7 +83,6 @@ class Program<Us extends UniformBindings> {
         }
         gl.shaderSource(fragmentShader, fragmentSource);
         gl.compileShader(fragmentShader);
-        assert(gl.getShaderParameter(fragmentShader, gl.COMPILE_STATUS), (gl.getShaderInfoLog(fragmentShader) as any));
         gl.attachShader(this.program, fragmentShader);
 
         const vertexShader = gl.createShader(gl.VERTEX_SHADER);
@@ -94,7 +92,6 @@ class Program<Us extends UniformBindings> {
         }
         gl.shaderSource(vertexShader, vertexSource);
         gl.compileShader(vertexShader);
-        assert(gl.getShaderParameter(vertexShader, gl.COMPILE_STATUS), (gl.getShaderInfoLog(vertexShader) as any));
         gl.attachShader(this.program, vertexShader);
 
         this.attributes = {};
@@ -110,7 +107,6 @@ class Program<Us extends UniformBindings> {
         }
 
         gl.linkProgram(this.program);
-        assert(gl.getProgramParameter(this.program, gl.LINK_STATUS), (gl.getProgramInfoLog(this.program) as any));
 
         gl.deleteShader(vertexShader);
         gl.deleteShader(fragmentShader);
@@ -178,11 +174,18 @@ class Program<Us extends UniformBindings> {
             configuration.setUniforms(context, this.binderUniforms, currentProperties, {zoom: (zoom as any)});
         }
 
-        const primitiveSize = {
-            [gl.LINES]: 2,
-            [gl.TRIANGLES]: 3,
-            [gl.LINE_STRIP]: 1
-        }[drawMode];
+        let primitiveSize = 0;
+        switch (drawMode) {
+            case gl.LINES:
+                primitiveSize = 2;
+                break;
+            case gl.TRIANGLES:
+                primitiveSize = 3;
+                break;
+            case gl.LINE_STRIP:
+                primitiveSize = 1;
+                break;
+        }
 
         for (const segment of segments.get()) {
             const vaos = segment.vaos || (segment.vaos = {});

package/src/render/vertex_array_object.ts

@@ -1,4 +1,3 @@
-import assert from 'assert';
 
 import type Program from './program';
 import type VertexBuffer from '../gl/vertex_buffer';
@@ -119,9 +118,8 @@ class VertexArrayObject {
             // Disable all attributes from the previous program that aren't used in
             // the new program. Note: attribute indices are *not* program specific!
             for (let i = numNextAttributes; i < numPrevAttributes; i++) {
-                // WebGL breaks if you disable attribute 0.
+                // WebGL breaks if you disable attribute 0, so if i == 0.
                 // http://stackoverflow.com/questions/20305231
-                assert(i !== 0);
                 gl.disableVertexAttribArray(i);
             }
         }

package/src/source/geojson_worker_source.ts

@@ -6,7 +6,6 @@ import GeoJSONWrapper from './geojson_wrapper';
 import vtpbf from 'vt-pbf';
 import Supercluster from 'supercluster';
 import geojsonvt from 'geojson-vt';
-import assert from 'assert';
 import VectorTileWorkerSource from './vector_tile_worker_source';
 import {createExpression} from '../style-spec/expression';
 
@@ -292,9 +291,6 @@ function getSuperclusterOptions({superclusterOptions, clusterProperties}: { supe
         const reduceExpressionParsed = createExpression(
             typeof operator === 'string' ? [operator, ['accumulated'], ['get', key]] : operator);
 
-        assert(mapExpressionParsed.result === 'success');
-        assert(reduceExpressionParsed.result === 'success');
-
         mapExpressions[key] = mapExpressionParsed.value;
         reduceExpressions[key] = reduceExpressionParsed.value;
     }

package/src/source/query_features.ts

@@ -6,7 +6,6 @@ import type {RetainedQueryData} from '../symbol/placement';
 import type {FilterSpecification} from '../style-spec/types.g';
 import type {MapGeoJSONFeature} from '../util/vectortile_to_geojson';
 import type Point from '@mapbox/point-geometry';
-import assert from 'assert';
 import {mat4} from 'gl-matrix';
 
 /*
@@ -137,8 +136,6 @@ export function queryRenderedSymbols(styleLayers: {[_: string]: StyleLayer},
                     // we sort each feature based on the first matching symbol instance.
                     const sortedA = featureSortOrder.indexOf(a.featureIndex);
                     const sortedB = featureSortOrder.indexOf(b.featureIndex);
-                    assert(sortedA >= 0);
-                    assert(sortedB >= 0);
                     return sortedB - sortedA;
                 } else {
                     // Bucket hasn't been re-sorted based on angle, so use the

package/src/source/rtl_text_plugin.ts

@@ -1,7 +1,6 @@
 import {Event, Evented} from '../util/evented';
 import {getArrayBuffer} from '../util/ajax';
 import browser from '../util/browser';
-import assert from 'assert';
 import {isWorker} from '../util/util';
 
 const status = {
@@ -113,20 +112,20 @@ export const plugin: {
         return pluginStatus === status.loading;
     },
     setState(state: PluginState) { // Worker thread only: this tells the worker threads that the plugin is available on the Main thread
-        assert(isWorker(), 'Cannot set the state of the rtl-text-plugin when not in the web-worker context');
+        if (!isWorker()) throw new Error('Cannot set the state of the rtl-text-plugin when not in the web-worker context');
 
         pluginStatus = state.pluginStatus;
         pluginURL = state.pluginURL;
     },
     isParsed(): boolean {
-        assert(isWorker(), 'rtl-text-plugin is only parsed on the worker-threads');
+        if (!isWorker()) throw new Error('rtl-text-plugin is only parsed on the worker-threads');
 
         return plugin.applyArabicShaping != null &&
             plugin.processBidirectionalText != null &&
             plugin.processStyledBidirectionalText != null;
     },
     getPluginURL(): string {
-        assert(isWorker(), 'rtl-text-plugin url can only be queried from the worker threads');
+        if (!isWorker()) throw new Error('rtl-text-plugin url can only be queried from the worker threads');
         return pluginURL;
     }
 };

package/src/source/source_cache.ts

@@ -10,7 +10,6 @@ import Context from '../gl/context';
 import Point from '@mapbox/point-geometry';
 import browser from '../util/browser';
 import {OverscaledTileID} from './tile_id';
-import assert from 'assert';
 import SourceFeatureState from './source_state';
 
 import type {Source} from './source';
@@ -556,7 +555,6 @@ class SourceCache extends Evented {
             const ids = Object.keys(retain);
             for (const id of ids) {
                 const tileID = retain[id];
-                assert(tileID.key === id);
 
                 const tile = this._tiles[id];
                 if (!tile || tile.fadeEndTime && tile.fadeEndTime <= browser.now()) continue;