mandrel 2.64.0 → 2.66.0

package/.agents/scripts/lib/orchestration/review-providers/review-provider-factory.js

@@ -14,6 +14,8 @@
  * @typedef {import('./types.js').ProviderChain}         ProviderChain
  */
 
+import { DEFAULT_REVIEW_PROVIDERS } from '../../config/review-chain-default.js';
+import { createCodeReviewProviderForRegistry } from './code-review.js';
 import { createCodexProviderForRegistry } from './codex.js';
 import { mergeChainDegradations } from './degraded-gates.js';
 import { createNativeProviderForRegistry } from './native.js';
@@ -22,6 +24,7 @@ import { createUltrareviewProviderForRegistry } from './ultrareview.js';
 
 /** @type {Readonly<Record<string, () => ReviewProvider>>} */
 const INLINE_PROVIDERS = Object.freeze({
+  'code-review': createCodeReviewProviderForRegistry,
   codex: createCodexProviderForRegistry,
   native: createNativeProviderForRegistry,
   'security-review': createSecurityReviewProviderForRegistry,
@@ -36,8 +39,6 @@ const PROMPT_PROVIDERS = Object.freeze({
   ultrareview: createUltrareviewProviderForRegistry,
 });
 
-export const DEFAULT_PROVIDER_NAME = 'native';
-
 /**
  * Gate predicate from a `when` clause (`label` / `labelAny`); absent → always true.
  *
@@ -79,7 +80,8 @@ export function isScopeApplicable(declaredScopes, currentScope) {
 }
 
 /**
- * Takes the `codeReview` sub-object; unset/empty `providers` defaults to native.
+ * Takes the `codeReview` sub-object; unset/empty `providers` falls back to
+ * `DEFAULT_REVIEW_PROVIDERS`.
  *
  * @param {{
  *   providers?: Array<object>,
@@ -105,7 +107,7 @@ export function createReviewProvider(codeReviewConfig, opts = {}) {
     Array.isArray(codeReviewConfig.providers) &&
     codeReviewConfig.providers.length > 0
       ? codeReviewConfig.providers
-      : [{ name: DEFAULT_PROVIDER_NAME }];
+      : DEFAULT_REVIEW_PROVIDERS;
 
   const chain = buildProviderChain(entries, {
     inlineRegistry,
@@ -193,6 +195,16 @@ export function buildProviderChain(entries, ctx) {
   return { inline, prompts };
 }
 
+/**
+ * @param {Record<string, number>} tally
+ * @param {string} name
+ * @param {Finding[]} findings
+ */
+function recordCritical(tally, name, findings) {
+  const critical = findings.filter((f) => f?.severity === 'critical').length;
+  if (critical > 0) tally[name] = critical;
+}
+
 /**
  * Inline findings merge in declaration order; prompt entries render via
  * `getPromptMessages`.
@@ -201,11 +213,14 @@ export function buildProviderChain(entries, ctx) {
  * @param {{ logger?: { info?: Function, warn?: Function } }} [opts]
  * @returns {ReviewProvider & {
  *   getPromptMessages: (input: ReviewInput) => Promise<string[]>,
+ *   getCriticalByProvider: () => Record<string, number>,
  *   chain: ProviderChain,
  * }}
  */
 export function createChainProvider(chain, opts = {}) {
   const logger = opts.logger;
+  /** Critical findings per entry from the last `runReview`, for attribution. */
+  let criticalByProvider = {};
 
   return {
     chain,
@@ -216,6 +231,7 @@ export function createChainProvider(chain, opts = {}) {
     async runReview(input) {
       /** @type {Finding[]} */
       const merged = [];
+      criticalByProvider = {};
       const ctx = {
         scope: input?.scope,
         labels: /** @type {ReadonlyArray<string>} */ (
@@ -236,9 +252,18 @@ export function createChainProvider(chain, opts = {}) {
           );
         }
         for (const f of findings) merged.push(f);
+        recordCritical(criticalByProvider, entry.name, findings);
       }
       return merged;
     },
+    /**
+     * Which entries raised the last run's critical findings, and how many.
+     *
+     * @returns {Record<string, number>}
+     */
+    getCriticalByProvider() {
+      return { ...criticalByProvider };
+    },
     /**
      * Called after `runReview`.
      *

package/.agents/scripts/lib/orchestration/review-providers/security-review.js

@@ -24,11 +24,12 @@ export const SECURITY_REVIEW_REMEDIATIONS = Object.freeze({
 
 /**
  * Synchronous so a missing CLI surfaces at construction, not mid-review.
+ * Shared by every `claude --print` provider.
  *
  * @param {{ spawnFn?: typeof spawnSync }} [opts]
  * @returns {boolean}
  */
-function defaultProbeClaudeCli(opts = {}) {
+export function probeClaudeCli(opts = {}) {
   const spawnFn = opts.spawnFn ?? spawnSync;
   try {
     const result = spawnFn('claude', ['--version'], {
@@ -173,7 +174,7 @@ export function buildUnparseableFallbackFinding() {
  * @returns {ReviewProvider}
  */
 export function createSecurityReviewProvider(deps = {}) {
-  const probeFn = deps.probeFn ?? defaultProbeClaudeCli;
+  const probeFn = deps.probeFn ?? probeClaudeCli;
   if (!probeFn()) {
     throw buildSecurityReviewUnavailableError();
   }

package/.agents/scripts/lib/orchestration/run-epilogue.js

@@ -10,6 +10,7 @@ import { selectAudits } from '../audit-suite/index.js';
 import { graduateRetroProposals } from '../feedback-loop/retro-proposals-graduator.js';
 import { gitSpawn } from '../git-utils.js';
 import { Logger } from '../Logger.js';
+import { gatherRunTelemetry } from '../observability/close-telemetry.js';
 import { isEpicTicket } from './epic-container.js';
 import { composeRoutedProposals } from './retro-proposals.js';
 import {
@@ -657,6 +658,8 @@ async function executeFollowUpRollup({
     graduateFn,
   });
   const categories = summarizeSignalCategories(signals);
+  // Step result only, never the roll-up comment: telemetry stays local.
+  const telemetry = await gatherRunTelemetry(stories, config);
   const proposalCount = proposals.framework.length + proposals.consumer.length;
   const outcome = assessRollupOutcome({
     signalCount: signals.length,
@@ -687,6 +690,7 @@ async function executeFollowUpRollup({
     categories,
     outcome,
     frictionWindow,
+    telemetry,
   });
 }
 
@@ -743,6 +747,7 @@ function buildRollupStepResult({
   categories,
   outcome,
   frictionWindow,
+  telemetry = null,
 }) {
   return {
     kind: 'follow-up-rollup',
@@ -766,6 +771,7 @@ function buildRollupStepResult({
       fingerprint: item.fingerprint ?? null,
     })),
     emptyRollupSuspect: signals.length === 0 && storyCount > 1,
+    telemetry,
   };
 }
 

package/.agents/scripts/lib/orchestration/single-story-close/failed-terminal.js

@@ -107,6 +107,7 @@ export function failedTerminalFor(err, args = {}) {
       failure: { reason: String(err?.message ?? err) },
       nextCommand: NEXT_COMMANDS.recover(storyId),
       elapsedSeconds: 0,
+      phaseDurations: err?.closePhaseDurations ?? undefined,
     });
   } catch (buildErr) {
     Logger.error(

package/.agents/scripts/lib/orchestration/single-story-close/phases/code-review.js

@@ -56,8 +56,6 @@ async function invokeStoryReviewCore({
   prNumber,
   provider,
   runCodeReviewFn,
-  runLocalLensReviewFn,
-  appendFindingsYieldFn,
   gitSpawnFn,
   progress,
 }) {
@@ -71,8 +69,6 @@ async function invokeStoryReviewCore({
     progressTag: 'REVIEW',
     runCodeReviewFn,
     gitSpawnFn,
-    ...(runLocalLensReviewFn ? { runLocalLensReviewFn } : {}),
-    ...(appendFindingsYieldFn ? { appendFindingsYieldFn } : {}),
   });
 }
 
@@ -131,8 +127,6 @@ async function postStoryReviewCrossRef({
  *   prNumber: number|null,
  *   provider: object,
  *   runCodeReviewFn: Function,
- *   runLocalLensReviewFn?: Function,
- *   appendFindingsYieldFn?: Function,
  *   gitSpawnFn?: Function,
  *   progress: (tag: string, msg: string) => void,
  * }} args
@@ -140,12 +134,12 @@ async function postStoryReviewCrossRef({
  *   halted: boolean,
  *   skipped?: boolean,
  *   severity?: { critical: number, high: number, medium: number, suggestion: number },
+ *   criticalByProvider?: Record<string, number>,
  *   posted?: boolean,
  *   postedCommentId?: number|null,
  *   degraded?: boolean,
  *   degradations?: Array<object>,
  *   crossRefPosted?: boolean,
- *   localLensReview?: object,
  * }>}
  */
 export async function runStoryScopeReview({
@@ -157,8 +151,6 @@ export async function runStoryScopeReview({
   prNumber,
   provider,
   runCodeReviewFn,
-  runLocalLensReviewFn,
-  appendFindingsYieldFn,
   gitSpawnFn,
   progress,
 }) {
@@ -192,8 +184,6 @@ export async function runStoryScopeReview({
     prNumber,
     provider,
     runCodeReviewFn,
-    runLocalLensReviewFn,
-    appendFindingsYieldFn,
     gitSpawnFn,
     progress,
   });
@@ -225,10 +215,10 @@ export async function runStoryScopeReview({
   return {
     halted: !!result.halted,
     severity: sev,
+    criticalByProvider: result.criticalByProvider,
     posted: result.posted,
     postedCommentId: result.postedCommentId ?? null,
     ...degradationEnvelope(result.degradations),
     crossRefPosted,
-    localLensReview: result.localLensReview,
   };
 }