mandrel 2.56.0 → 2.58.0

package/docs/CHANGELOG.md

@@ -15,6 +15,42 @@ All notable changes to this project will be documented in this file.
 -->
 <!-- markdownlint-disable-file MD004 MD012 MD037 -->
 
+## [2.58.0](https://github.com/dsj1984/mandrel/compare/mandrel-v2.57.0...mandrel-v2.58.0) (2026-09-12)
+
+
+### Added
+
+* make the close test credit earnable on any test runner, and surface the gap at setup instead of mid-close ([#5324](https://github.com/dsj1984/mandrel/issues/5324)) ([#5329](https://github.com/dsj1984/mandrel/issues/5329)) ([04db145](https://github.com/dsj1984/mandrel/commit/04db145b8f1017121e129897f9207ab51db1c3f8))
+* tickets-mode planning re-derives the Story instead of carrying the source ticket's shape: acceptance handles, tier suffixes, generated-artifact footprints and pinned identifiers ([#5323](https://github.com/dsj1984/mandrel/issues/5323)) ([#5326](https://github.com/dsj1984/mandrel/issues/5326)) ([5563e7a](https://github.com/dsj1984/mandrel/commit/5563e7a264864f78001beb19ce58160a1b483cda))
+
+
+### Fixed
+
+* give base-sync and the Story-scope code review one base ref, so a stale local base branch cannot raise false blockers ([#5325](https://github.com/dsj1984/mandrel/issues/5325)) ([#5328](https://github.com/dsj1984/mandrel/issues/5328)) ([c4032b6](https://github.com/dsj1984/mandrel/commit/c4032b63a63c4cb8cc3f9c9956b6c646e5acd460))
+
+## [2.57.0](https://github.com/dsj1984/mandrel/compare/mandrel-v2.56.0...mandrel-v2.57.0) (2026-09-12)
+
+
+### ⚠ BREAKING CHANGES
+
+* the .agentrc keys delivery.routing.freshCriticSampleRate, delivery.codeReview.maxFixScopeFiles, delivery.signals and delivery.quality.codingGuardrails.cyclomaticMustFix are removed; a 2.57.0 migration step strips them on upgrade.
+* the .agentrc.json keys planning.complexityGate, planning.riskHeuristics, planning.failOnSharedEditors, planning.requireExplicitCrossStoryDeps, planning.failOnRegistryConflicts, planning.failOnLargeFanOut, planning.largeFanOutThreshold, planning.crossCuttingRegistries, planning.memoryPool.staleAfterDays and planning.memoryPool.growthDelta are removed; the planning block is strict, so a config still carrying one fails validation until the 2.57.0 migration step strips it on `mandrel update`. plan-persist.js no longer accepts --route-downgrade-reason, --allow-over-budget or --allow-large-fan-out, and a verify[] entry is a bare command with no tier suffix.
+
+### Added
+
+* delivery diet: drop the sampling, round-ceiling, fix-scope, signal and cyclomatic knobs, script the ceremony derivation, let a bare test run earn credit, and make the light gate and footprint guard read the diff ([#5313](https://github.com/dsj1984/mandrel/issues/5313)) ([#5319](https://github.com/dsj1984/mandrel/issues/5319)) ([33fa9db](https://github.com/dsj1984/mandrel/commit/33fa9db4d01d8932bd886d380fe32b29db9a7bce))
+* planning diet: delete the sizing, spec, lite-route and verify-tier limits, demote the footprint probes to warnings, and render the author prompt for the one-Story default ([#5312](https://github.com/dsj1984/mandrel/issues/5312)) ([#5318](https://github.com/dsj1984/mandrel/issues/5318)) ([cbcfdac](https://github.com/dsj1984/mandrel/commit/cbcfdacbca2cce9731e12c6cdfdab095d23b3e12))
+
+
+### Fixed
+
+* score the CRAP worker path through the escomplex AST shim, and report an unscorable file as unscorable ([#5311](https://github.com/dsj1984/mandrel/issues/5311)) ([#5314](https://github.com/dsj1984/mandrel/issues/5314)) ([0a8e8c8](https://github.com/dsj1984/mandrel/commit/0a8e8c8cd8afb7af88b3d0d5a49e6359a91f3524))
+
+
+### Changed
+
+* free the CLI entrypoints' logic from `main` so it can be tested, and tighten the CRAP floor back to 2 ([#5316](https://github.com/dsj1984/mandrel/issues/5316)) ([#5317](https://github.com/dsj1984/mandrel/issues/5317)) ([f67cfb3](https://github.com/dsj1984/mandrel/commit/f67cfb3b6e531c38300690e4dcd16a4de7dd18f8))
+
 ## [2.56.0](https://github.com/dsj1984/mandrel/compare/mandrel-v2.55.0...mandrel-v2.56.0) (2026-09-11)
 
 

package/lib/cli/registry.js

@@ -4,8 +4,11 @@
  *
  * Exports an ordered array of check objects each shaped `{ name, run() }`.
  * `run()` returns `{ ok, detail, remedy? }` — `remedy` is present and
- * non-empty only when `ok` is false. The registry is the single source of
- * truth for which checks the doctor command runs and in what order.
+ * non-empty whenever `ok` is false, and on an `advisory` check that passes
+ * while still having something actionable to say (`test-credit-path`), which
+ * repeats it in `detail` because that is the field the doctor prints for a
+ * passing check. The registry is the single source of truth for which checks
+ * the doctor command runs and in what order.
  *
  * Checks run sequentially in the doctor runner (not in parallel) because
  * some checks are meaningless without a prerequisite having passed first
@@ -1176,6 +1179,90 @@ function probeConfiguredDriver(command, runner, projectRoot) {
   };
 }
 
+// ---------------------------------------------------------------------------
+// check: test-credit-path
+// ---------------------------------------------------------------------------
+
+/**
+ * The runner whose own green full run deposits the close `test` credit as a
+ * side effect (`.agents/scripts/run-tests.js` → `lib/test-run-credit.js`).
+ */
+const MANDREL_TEST_RUNNER = 'run-tests.js';
+
+/**
+ * The deposit that works whatever `npm test` resolves to: it spawns the
+ * project's own suite and stamps the result, so it is honest by construction.
+ */
+const TEST_CREDIT_DEPOSIT_COMMAND =
+  'node .agents/scripts/evidence-gate.js --standalone --scope-id <storyId> --gate test --worktree <workCwd> -- npm test';
+
+/** Remedy shared by every shape that does not earn the credit on its own. */
+const TEST_CREDIT_REMEDY = `run the suite through the depositor instead of bare \`npm test\`: ${TEST_CREDIT_DEPOSIT_COMMAND}`;
+
+/**
+ * The project's `test` script — what `npm test` runs, and therefore what the
+ * close `test` gate spawns. Deliberately read from `package.json` rather than
+ * `project.commands.test`: the close gate's argv is the literal `npm test`, so
+ * the npm script is the command whose shape decides whether a bare run
+ * deposits anything.
+ *
+ * @param {string} projectRoot
+ * @param {typeof fs.readFileSync} readFileImpl
+ * @returns {string|null} The trimmed script, or null when there is none.
+ */
+function readProjectTestScript(projectRoot, readFileImpl) {
+  try {
+    const raw = readFileImpl(path.join(projectRoot, 'package.json'), 'utf8');
+    const script = JSON.parse(raw)?.scripts?.test;
+    return typeof script === 'string' && script.trim().length > 0
+      ? script.trim()
+      : null;
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Report whether this project's test command reaches mandrel's own runner,
+ * and therefore whether a bare `npm test` deposits the close `test` credit
+ * by itself (Story #5324).
+ *
+ * **Always `ok: true`.** A project on `vitest`, `jest` or any other runner is
+ * a supported setup, not a broken install — the only thing it lacks is the
+ * runner-side bonus deposit, and the remedy command covers it. So the check
+ * informs rather than gates, and (unlike every other entry here) carries its
+ * `remedy` alongside a passing verdict; the same guidance also rides in
+ * `detail`, which is the field the doctor prints for a passing check.
+ *
+ * The runner is detected by name, never by executing anything: a script that
+ * reaches `run-tests.js` indirectly reads as "own runner", which errs toward
+ * naming the deposit command — correct on either shape.
+ *
+ * @param {{ projectRoot?: string, readFile?: typeof fs.readFileSync }} [opts]
+ * @returns {{ ok: boolean, detail: string, remedy?: string }}
+ */
+function runTestCreditPath({ projectRoot, readFile = fs.readFileSync } = {}) {
+  const script = readProjectTestScript(projectRoot ?? process.cwd(), readFile);
+  if (script === null) {
+    return {
+      ok: true,
+      detail: `no \`test\` script in package.json — close still spawns \`npm test\`, so ${TEST_CREDIT_REMEDY}`,
+      remedy: TEST_CREDIT_REMEDY,
+    };
+  }
+  if (script.includes(MANDREL_TEST_RUNNER)) {
+    return {
+      ok: true,
+      detail: `\`npm test\` → \`${script}\` reaches mandrel's runner — a green full run on a story branch deposits the close \`test\` credit itself`,
+    };
+  }
+  return {
+    ok: true,
+    detail: `\`npm test\` → \`${script}\` is this project's own runner and never reaches \`${MANDREL_TEST_RUNNER}\`, so it deposits no close \`test\` credit and prints nothing — ${TEST_CREDIT_REMEDY}`,
+    remedy: TEST_CREDIT_REMEDY,
+  };
+}
+
 /**
  * Ordered array of doctor checks. Each entry follows the
  * `{ name: string, run(opts?): { ok: boolean, detail: string, remedy?: string } }` contract.
@@ -1243,6 +1330,15 @@ export const registry = [
     advisory: true,
     run: (opts) => runVersionCurrent(opts),
   },
+  {
+    name: 'test-credit-path',
+    // Non-fatal: `run()` always returns ok:true. A project on its own test
+    // runner is a supported setup that simply has to deposit the close
+    // `test` credit explicitly, so this reports a condition rather than
+    // failing the install (Story #5324).
+    advisory: true,
+    run: (opts) => runTestCreditPath(opts),
+  },
 ];
 
 export default registry;

package/lib/migrations/index.js

@@ -59,6 +59,8 @@ import { retireEpicAcTags } from './steps/2.2.0-retire-epic-ac-tags.js';
 import { retireMaxSeedWords } from './steps/2.11.0-retire-max-seed-words.js';
 import { retireCodebaseSnapshot } from './steps/2.20.0-retire-codebase-snapshot.js';
 import { retireLintBaselineCommand } from './steps/2.32.0-retire-lint-baseline-command.js';
+import { retireDeliveryLimitKnobs } from './steps/2.57.0-retire-delivery-limit-knobs.js';
+import { retirePlanningLimitKnobs } from './steps/2.57.0-retire-planning-limit-knobs.js';
 
 /**
  * Ordered registry of migration steps. MUST stay sorted ascending by
@@ -78,6 +80,8 @@ export const migrations = [
   retireMaxSeedWords,
   retireCodebaseSnapshot,
   retireLintBaselineCommand,
+  retirePlanningLimitKnobs,
+  retireDeliveryLimitKnobs,
 ];
 
 /**

package/lib/migrations/steps/2.57.0-retire-delivery-limit-knobs.js

@@ -0,0 +1,45 @@
+// lib/migrations/steps/2.57.0-retire-delivery-limit-knobs.js
+/**
+ * Story #5313 — the delivery diet. Strip the retired `delivery.*` keys from a
+ * consumer's config:
+ *
+ *   - `delivery.routing.freshCriticSampleRate` — the maker-checker sampling
+ *     floor is gone; the standard profile routes purely off the derived
+ *     change level (high or underivable → fresh critic, low → inline).
+ *   - `delivery.codeReview.maxFixScopeFiles` — the auto-fix file-count
+ *     ceiling bounded remediation by count rather than by risk.
+ *   - `delivery.signals` (`rework.editsPerFile`, `retry.repeatCount`) — the
+ *     detector thresholds and `SIGNALS_DEFAULTS` are retired wholesale.
+ *   - `delivery.quality.codingGuardrails.cyclomaticMustFix` — the cyclomatic
+ *     ratchet keeps its fixed ceiling of 12; `cyclomaticFlag` stays advisory.
+ *
+ * Every affected block carries `additionalProperties: false`, so a config
+ * still setting any of them fails validation on upgrade rather than warning.
+ * It sweeps **both** config surfaces (`.agentrc.json` and the gitignored
+ * `.agentrc.local.json`), because `config-resolver.js` deep-merges the
+ * overlay before the AJV gate runs.
+ *
+ * Pruning: `delivery.signals` is removed whole (`pruneDepth: 1` prunes an
+ * emptied `delivery`); the nested keys prune their emptied ancestors up to
+ * `delivery` itself. `delivery` is optional, so an emptied block is removed
+ * rather than left as `{}`. A sibling key that survives keeps its block.
+ */
+
+import { createRetireAgentrcKeyStep } from '../helpers/retire-agentrc-key.js';
+
+export const retireDeliveryLimitKnobs = createRetireAgentrcKeyStep({
+  version: '2.57.0',
+  description:
+    'strip the retired delivery.* limit knobs from .agentrc.json — ' +
+    'routing.freshCriticSampleRate, codeReview.maxFixScopeFiles, signals, ' +
+    'and quality.codingGuardrails.cyclomaticMustFix (Story #5313)',
+  keys: [
+    { path: ['delivery', 'routing', 'freshCriticSampleRate'], pruneDepth: 2 },
+    { path: ['delivery', 'codeReview', 'maxFixScopeFiles'], pruneDepth: 2 },
+    { path: ['delivery', 'signals'], pruneDepth: 1 },
+    {
+      path: ['delivery', 'quality', 'codingGuardrails', 'cyclomaticMustFix'],
+      pruneDepth: 3,
+    },
+  ],
+});

package/lib/migrations/steps/2.57.0-retire-planning-limit-knobs.js

@@ -0,0 +1,59 @@
+// lib/migrations/steps/2.57.0-retire-planning-limit-knobs.js
+/**
+ * Story #5312 — the planning diet. Strip the ten retired `planning.*` keys
+ * from a consumer's config:
+ *
+ *   - `planning.complexityGate` — the plan-side lite claim and its persist
+ *     backstop are gone; nothing reads the switch.
+ *   - `planning.riskHeuristics` — the phrase list was empty in every consumer
+ *     that resolved it, and the critic trigger that matched it went with the
+ *     consolidation critic.
+ *   - `planning.failOnSharedEditors`, `planning.requireExplicitCrossStoryDeps`,
+ *     `planning.failOnRegistryConflicts`, `planning.failOnLargeFanOut`,
+ *     `planning.largeFanOutThreshold`, `planning.crossCuttingRegistries` —
+ *     every conflict finding is advisory now, and the registry and fan-out
+ *     findings no longer exist.
+ *   - `planning.memoryPool.staleAfterDays`, `planning.memoryPool.growthDelta`
+ *     — the memory-hygiene advisory keeps only its index-byte arm.
+ *
+ * The `planning` block carries `additionalProperties: false`, so a config
+ * still setting any of them fails validation on upgrade rather than warning.
+ * It sweeps **both** config surfaces (`.agentrc.json` and the gitignored
+ * `.agentrc.local.json`), because `config-resolver.js` deep-merges the
+ * overlay before the AJV gate runs.
+ *
+ * Pruning: the two `memoryPool` keys prune the `memoryPool` object when it
+ * empties and then `planning` itself (`pruneDepth: 2`); the top-level keys
+ * prune `planning` (`pruneDepth: 1`). `planning` is optional, so an emptied
+ * block is removed rather than left as `{}`. A `memoryPool` that still
+ * carries `indexByteCeiling` survives untouched.
+ */
+
+import { createRetireAgentrcKeyStep } from '../helpers/retire-agentrc-key.js';
+
+const TOP_LEVEL_KEYS = [
+  'complexityGate',
+  'riskHeuristics',
+  'failOnSharedEditors',
+  'requireExplicitCrossStoryDeps',
+  'failOnRegistryConflicts',
+  'failOnLargeFanOut',
+  'largeFanOutThreshold',
+  'crossCuttingRegistries',
+];
+
+export const retirePlanningLimitKnobs = createRetireAgentrcKeyStep({
+  version: '2.57.0',
+  description:
+    'strip the retired planning.* limit knobs from .agentrc.json — ' +
+    'complexityGate, riskHeuristics, the conflict-severity and fan-out ' +
+    'knobs, and memoryPool.{staleAfterDays, growthDelta} (Story #5312)',
+  keys: [
+    ...TOP_LEVEL_KEYS.map((key) => ({
+      path: ['planning', key],
+      pruneDepth: 1,
+    })),
+    { path: ['planning', 'memoryPool', 'staleAfterDays'], pruneDepth: 2 },
+    { path: ['planning', 'memoryPool', 'growthDelta'], pruneDepth: 2 },
+  ],
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mandrel",
-  "version": "2.56.0",
+  "version": "2.58.0",
   "description": "Claude Code-first opinionated workflow framework: instructions, skills, rules, and SDLC workflows that govern AI coding assistants.",
   "files": [
     ".agents/",

package/.agents/scripts/lib/framework-version.js

@@ -1,39 +0,0 @@
-// .agents/scripts/lib/framework-version.js
-/**
- * framework-version.js — the visible authoring-marker surface for the legacy
- * ticket-body provenance stamp.
- *
- * Tickets authored under v1 carry a hybrid stamp: a hidden
- * `<!-- meta: {"mandrel_version":"…","authored_at":"…"} -->` block plus a
- * single visible footer line
- * `> 🏷️ Authored with Mandrel v<version> · <YYYY-MM-DD>`. The producer of
- * new stamps was retired with the Epic write surface (#4574) — nothing stamps
- * a new ticket — but bodies already stamped are live in the backlog, so the
- * Story-body serializer/parser must keep round-tripping them:
- *
- * - {@link AUTHORED_MARKER_LINE_RE} lets the parser skip the marker line during
- *   section parsing so it never pollutes the last structured section.
- * - {@link authoredMarkerLine} lets the serializer re-emit a byte-identical
- *   marker line for a stamp it parsed, preserving provenance verbatim.
- *
- * This module imports nothing so it can be pulled in from the story-body
- * serializer without risking an import cycle.
- */
-
-/**
- * The visible authoring marker line. A blockquote so GitHub renders it as a
- * callout. Used in the Story-body parser to skip the line during section
- * parsing so it never pollutes the last structured section.
- */
-export const AUTHORED_MARKER_LINE_RE = /^\s*>\s*🏷️\s+Authored with Mandrel\b/;
-
-/**
- * Build the visible authoring marker line for a given stamp. The Story-body
- * serializer uses this to re-emit a legacy stamp it parsed, byte-identically.
- *
- * @param {{ version: string, authoredAt: string }} stamp
- * @returns {string}
- */
-export function authoredMarkerLine({ version, authoredAt }) {
-  return `> 🏷️ Authored with Mandrel v${version} · ${authoredAt}`;
-}

package/.agents/scripts/lib/orchestration/consolidation-precondition.js

@@ -1,223 +0,0 @@
-/**
- * consolidation-precondition.js — deterministic dispatch gate for the Phase
- * 8.3 Holistic Consolidation sub-agent (Story #4431, Epic #4429).
- *
- * The Phase 8.3 consolidation critic (`epic-plan-consolidate`) is a genuine
- * fresh-context `Agent` dispatch — every call re-pays the full always-loaded
- * context (`.agents/instructions.md` and its always-on rules, § 4). When the
- * decomposer's draft `tickets.json` already matches the Tech Spec's `##
- * Delivery Slicing` target 1:1 (same shippable-Story count, and the
- * `depends_on` shape already agrees with each slice's declared
- * "Independent?" answer), there is nothing left for the critic to
- * reconcile — dispatching it is pure token spend for a no-op. This module
- * computes that decision **deterministically**, off the same two inputs the
- * critic itself reads (the draft array and the Epic body's Delivery Slicing
- * table), so the planning workflow can skip the sub-agent
- * dispatch when it is provably safe to.
- *
- * **Fail-open by design.** Every ambiguous case — a missing or unparseable
- * Delivery Slicing section, an unparseable "Independent?" cell — resolves to
- * `dispatch: true`. This gate can only ever *save* a dispatch when it is
- * confident the critic has nothing to do; it never disables the critic's
- * ability to catch a real divergence. Since Epic #4474 PR6 this precondition
- * is one input to the risk/size-conditional dispatch layer
- * (`plan-critic-conditions.js`): reachability (8.4) is a deterministic
- * persist-side check (`plan-reachability.js`) and the pre-mortem critic
- * (8.5) is risk/size-gated; the deterministic ticket validator remains
- * unconditional.
- *
- * Pure, synchronous, no I/O — callers own reading `tickets.json` and the
- * Epic body off disk / the GitHub API.
- */
-
-import { DELIVERY_SLICING_RE as DELIVERY_SLICING_HEADING_RE } from '../ticket-body-sections.js';
-
-/** A row is a markdown table line: starts with `|` once trimmed. */
-const TABLE_ROW_RE = /^\|/;
-
-/** A markdown table separator row: `|---|:---:|---:|` (dashes, colons, pipes only). */
-const TABLE_SEPARATOR_RE = /^\|?\s*:?-+:?\s*(\|\s*:?-+:?\s*)*\|?$/;
-
-/** The literal goal-section token that marks the wave-0 BDD scaffold Story. */
-const BDD_SCAFFOLD_GOAL_TOKEN = 'bdd-scaffold';
-
-/**
- * Split one markdown table row into trimmed cell strings.
- *
- * @param {string} line
- * @returns {string[]}
- */
-function splitTableRow(line) {
-  let trimmed = line.trim();
-  if (trimmed.startsWith('|')) trimmed = trimmed.slice(1);
-  if (trimmed.endsWith('|')) trimmed = trimmed.slice(0, -1);
-  return trimmed.split('|').map((cell) => cell.trim());
-}
-
-/**
- * Parse an "Independent?" cell per the pinned rule: match the cell's
- * leading word case-insensitively as `Yes` or `No`. Any other leading word
- * (or an empty cell) is unparseable and returns `null` — the caller must
- * fail open (`dispatch: true`) rather than guess.
- *
- * @param {string} cell
- * @returns {boolean|null} `true` for Yes, `false` for No, `null` when unparseable.
- */
-function parseIndependentCell(cell) {
-  const match = String(cell ?? '')
-    .trim()
-    .match(/^[A-Za-z]+/);
-  if (!match) return null;
-  const word = match[0].toLowerCase();
-  if (word === 'yes') return true;
-  if (word === 'no') return false;
-  return null;
-}
-
-/**
- * Locate and parse the `## Delivery Slicing` markdown table out of the Epic
- * body (which carries the folded Tech Spec sections — Story #4324). Returns
- * `null` when the heading is absent, no table follows it, the table has no
- * "Independent?" column, or any data row's "Independent?" cell is
- * unparseable — every one of those is a fail-open signal for the caller.
- *
- * @param {string} epicBody
- * @returns {{ slice: string, independent: boolean }[] | null}
- */
-export function parseDeliverySlicingTable(epicBody) {
-  if (typeof epicBody !== 'string' || epicBody.length === 0) return null;
-
-  const lines = epicBody.split(/\r?\n/);
-  const headingIdx = lines.findIndex((line) =>
-    DELIVERY_SLICING_HEADING_RE.test(line.trim()),
-  );
-  if (headingIdx === -1) return null;
-
-  let i = headingIdx + 1;
-  while (i < lines.length && lines[i].trim() === '') i++;
-  if (i >= lines.length || !TABLE_ROW_RE.test(lines[i].trim())) return null;
-
-  const headerCells = splitTableRow(lines[i]);
-  i++;
-  if (i >= lines.length || !TABLE_SEPARATOR_RE.test(lines[i].trim())) {
-    return null;
-  }
-  i++;
-
-  const independentIdx = headerCells.findIndex((cell) =>
-    /independent/i.test(cell),
-  );
-  if (independentIdx === -1) return null;
-
-  const rows = [];
-  while (i < lines.length && TABLE_ROW_RE.test(lines[i].trim())) {
-    const cells = splitTableRow(lines[i]);
-    const independent = parseIndependentCell(cells[independentIdx]);
-    if (independent === null) return null; // unparseable cell → fail open
-    rows.push({ slice: (cells[0] ?? '').trim(), independent });
-    i++;
-  }
-
-  return rows.length > 0 ? rows : null;
-}
-
-/**
- * True when `story` is the recognized wave-0 BDD scaffold Story — identified
- * by the literal `bdd-scaffold` goal token the decomposer prompt
- * skill's WAVE-0 BDD SCAFFOLD STORY section requires. Scaffold Stories are
- * not a Delivery Slicing slice, so they are excluded from the count
- * comparison — BDD-adopting consumer repos still benefit from the
- * precondition gate rather than always paying the 8.3 dispatch.
- *
- * @param {{ body?: unknown }} story
- * @returns {boolean}
- */
-function isBddScaffoldStory(story) {
-  const body = story?.body;
-  return (
-    typeof body === 'string' &&
-    body.toLowerCase().includes(BDD_SCAFFOLD_GOAL_TOKEN)
-  );
-}
-
-/**
- * Evaluate whether the Phase 8.3 consolidation sub-agent needs to run.
- *
- * @param {object} input
- * @param {object[]} input.draftStories - The draft `tickets.json` array
- *   (the decomposer's output) — raw Story ticket objects with
- *   top-level `slug` / `depends_on` / `body` (serialized string).
- * @param {string} input.epicBody - The Epic body carrying the folded Tech
- *   Spec sections (`## Delivery Slicing` onward).
- * @returns {{ dispatch: boolean, cause: 'match'|'divergence'|'fail-open', reasons: string[] }}
- *   `dispatch: false` only when the draft matches the Delivery Slicing table
- *   1:1 in count and dependency shape; `dispatch: true` (with `reasons`)
- *   otherwise, including every fail-open case. `cause` distinguishes a
- *   **confirmed** divergence (count or dependency-shape mismatch) from the
- *   fail-open ambiguity (missing/unparseable table) — the #4474 PR6
- *   conditional-dispatch layer treats only the former as a firing condition
- *   on small drafts.
- */
-export function evaluateConsolidationPrecondition({ draftStories, epicBody }) {
-  if (!Array.isArray(draftStories)) {
-    throw new TypeError(
-      'evaluateConsolidationPrecondition: draftStories must be an array',
-    );
-  }
-
-  const slicing = parseDeliverySlicingTable(epicBody);
-  if (!slicing) {
-    return {
-      dispatch: true,
-      cause: 'fail-open',
-      reasons: [
-        'Delivery Slicing section is missing or unparseable — fail-open to the critic.',
-      ],
-    };
-  }
-
-  const slicedStories = draftStories.filter(
-    (story) => !isBddScaffoldStory(story),
-  );
-
-  if (slicedStories.length !== slicing.length) {
-    return {
-      dispatch: true,
-      cause: 'divergence',
-      reasons: [
-        `Story count diverges from Delivery Slicing: ${slicing.length} proposed slice(s) vs ${slicedStories.length} non-scaffold draft Story(ies).`,
-      ],
-    };
-  }
-
-  const reasons = [];
-  for (let idx = 0; idx < slicing.length; idx++) {
-    const slice = slicing[idx];
-    const story = slicedStories[idx];
-    const dependsOn = Array.isArray(story?.depends_on) ? story.depends_on : [];
-    const hasDeps = dependsOn.length > 0;
-    const storyLabel = story?.slug ?? story?.title ?? `<story ${idx + 1}>`;
-
-    if (slice.independent === false && !hasDeps) {
-      reasons.push(
-        `Slice "${slice.slice}" (position ${idx + 1}) is marked Independent: No but draft Story "${storyLabel}" declares no depends_on.`,
-      );
-    } else if (slice.independent === true && hasDeps) {
-      reasons.push(
-        `Slice "${slice.slice}" (position ${idx + 1}) is marked Independent: Yes but draft Story "${storyLabel}" declares depends_on [${dependsOn.join(', ')}].`,
-      );
-    }
-  }
-
-  if (reasons.length > 0) {
-    return { dispatch: true, cause: 'divergence', reasons };
-  }
-
-  return {
-    dispatch: false,
-    cause: 'match',
-    reasons: [
-      `Draft matches Delivery Slicing 1:1 in count and dependency shape (${slicing.length} slice(s)) — skipping the 8.3 consolidation dispatch.`,
-    ],
-  };
-}

package/.agents/scripts/lib/orchestration/plan-persist/fan-out-gate.js

@@ -1,97 +0,0 @@
-/**
- * Fan-out / soft-conflict gates used by plan-persist (extracted from the
- * retired epic-plan-decompose persist phase in Stage 5).
- *
- * @module lib/orchestration/plan-persist/fan-out-gate
- */
-
-import { Logger } from '../../Logger.js';
-import {
-  CONFLICT_KINDS,
-  renderFanOutEvidence,
-  renderFanOutRemedy,
-  renderHardConflictError,
-} from '../ticket-validator-conflicts.js';
-
-/**
- * @param {object[]} findings
- * @param {boolean} allowLargeFanOut
- * @param {string} [tag]
- */
-export function enforceFanOutGate(
-  findings,
-  allowLargeFanOut,
-  tag = 'plan-persist',
-) {
-  const fanOut = (findings ?? []).filter((f) => f.kind === 'fan-out-warning');
-  if (fanOut.length === 0) return;
-  if (allowLargeFanOut) {
-    for (const f of fanOut) {
-      Logger.warn(
-        `[${tag}] Persisting a large-fan-out deletion: ` +
-          `Story "${f.storySlug}" deletes "${f.path}" with ${f.callSiteCount} ` +
-          `importer(s) (threshold ${f.threshold}). Operator override --allow-large-fan-out.` +
-          renderFanOutEvidence(f),
-      );
-    }
-    return;
-  }
-  const lines = fanOut
-    .map(
-      (f) =>
-        `  - Story "${f.storySlug}" deletes "${f.path}" — ` +
-        `${f.callSiteCount} importer(s) (threshold ${f.threshold})` +
-        renderFanOutEvidence(f),
-    )
-    .join('\n');
-  // Each finding carries its own remedy — a rename-shaped deletion has no
-  // subsystems to split across, so a blanket "split it up" footer would be
-  // wrong advice for it (Story #4547).
-  const remedies = [...new Set(fanOut.map((f) => renderFanOutRemedy(f)))];
-  throw new Error(
-    `[${tag}] ${fanOut.length} Task(s) declare large-fan-out deletions:\n${lines}\n\n` +
-      remedies.join('\n\n'),
-  );
-}
-
-/**
- * Report every soft finding the validator produced, each under its own kind.
- *
- * Only the {@link CONFLICT_KINDS} are cross-Story conflicts. The advisory
- * kinds — `spec-word-budget` and the sizing findings — are single-Story
- * nudges, and announcing them as conflicts overstated them and taught readers
- * to discount the whole channel (Story #4907). `fan-out-warning` is excluded
- * throughout: {@link enforceFanOutGate} owns it and has already either thrown
- * or logged the override.
- *
- * @param {object[]} findings
- * @param {string} [tag]
- */
-export function surfaceSoftConflictFindings(findings, tag = 'plan-persist') {
-  const soft = (findings ?? []).filter(
-    (f) => f?.severity === 'soft' && f?.kind !== 'fan-out-warning',
-  );
-  if (soft.length === 0) return;
-  const conflicts = soft.filter((f) => CONFLICT_KINDS.has(f?.kind));
-  const advisories = soft.filter((f) => !CONFLICT_KINDS.has(f?.kind));
-  if (conflicts.length > 0) {
-    Logger.warn(
-      `[${tag}] ${conflicts.length} soft cross-Story conflict finding(s) — review before approving the plan:`,
-    );
-    for (const finding of conflicts) {
-      Logger.warn(
-        `[${tag}] soft conflict: ${renderHardConflictError(finding)}`,
-      );
-    }
-  }
-  if (advisories.length > 0) {
-    Logger.warn(
-      `[${tag}] ${advisories.length} advisory finding(s) — the persist proceeds:`,
-    );
-    for (const finding of advisories) {
-      Logger.warn(
-        `[${tag}] advisory (${finding.kind}): ${renderHardConflictError(finding)}`,
-      );
-    }
-  }
-}