mandrel 2.110.0 → 2.112.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/agents/acceptance-critic.md +14 -0
- package/.agents/agents/auditor.md +14 -0
- package/.agents/agents/plan-critic.md +5 -0
- package/.agents/agents/story-worker.md +4 -1
- package/.agents/audit-checklists/state-machines.md +21 -0
- package/.agents/docs/agentrc-reference.json +23 -10
- package/.agents/docs/configuration.md +362 -15
- package/.agents/docs/execution-reference.md +11 -0
- package/.agents/docs/workflows.md +2 -1
- package/.agents/rules/ci-remediation.md +28 -4
- package/.agents/rules/git-conventions-reference.md +7 -0
- package/.agents/schemas/agentrc.schema.json +179 -13
- package/.agents/schemas/audit-rules.json +28 -0
- package/.agents/schemas/baselines/baseline-envelope.schema.json +16 -4
- package/.agents/schemas/baselines/bundle-size.schema.json +1 -0
- package/.agents/schemas/baselines/coverage.schema.json +1 -0
- package/.agents/schemas/baselines/crap.schema.json +37 -10
- package/.agents/schemas/baselines/duplication.schema.json +1 -0
- package/.agents/schemas/baselines/maintainability.schema.json +1 -0
- package/.agents/schemas/baselines/mutation.schema.json +1 -0
- package/.agents/schemas/crap-report.schema.json +6 -5
- package/.agents/schemas/story-deliver-terminal.schema.json +49 -3
- package/.agents/schemas/story-progress.schema.json +1 -1
- package/.agents/schemas/validation-evidence.schema.json +2 -2
- package/.agents/scripts/boot-sweep.js +41 -3
- package/.agents/scripts/coverage-capture.js +39 -3
- package/.agents/scripts/coverage-ratchet.js +106 -0
- package/.agents/scripts/evidence-gate.js +84 -21
- package/.agents/scripts/file-ci-gap.js +220 -10
- package/.agents/scripts/lib/audit-baselines/read.js +8 -1
- package/.agents/scripts/lib/audit-baselines/trend.js +2 -1
- package/.agents/scripts/lib/audit-to-stories/audit-lenses.js +1 -0
- package/.agents/scripts/lib/baseline-loader.js +4 -2
- package/.agents/scripts/lib/baselines/codec.js +57 -0
- package/.agents/scripts/lib/baselines/crap-preview-incremental.js +8 -3
- package/.agents/scripts/lib/baselines/crap-preview-scan.js +10 -16
- package/.agents/scripts/lib/baselines/crap-updater-cli.js +4 -13
- package/.agents/scripts/lib/baselines/kernel.js +19 -1
- package/.agents/scripts/lib/baselines/kinds/_crap-codec.js +171 -0
- package/.agents/scripts/lib/baselines/kinds/_crap-read.js +56 -16
- package/.agents/scripts/lib/baselines/kinds/_shared-metric.js +0 -59
- package/.agents/scripts/lib/baselines/kinds/crap.js +283 -319
- package/.agents/scripts/lib/baselines/preview-gates.js +29 -10
- package/.agents/scripts/lib/baselines/reader.js +36 -9
- package/.agents/scripts/lib/baselines/refresh-service.js +79 -18
- package/.agents/scripts/lib/baselines/seat-missing.js +173 -7
- package/.agents/scripts/lib/baselines/writer.js +36 -21
- package/.agents/scripts/lib/changed-files.js +70 -6
- package/.agents/scripts/lib/child-exec.js +10 -0
- package/.agents/scripts/lib/claude/agents-projection.js +5 -5
- package/.agents/scripts/lib/close-lock-events.js +8 -3
- package/.agents/scripts/lib/close-validation/ci-deferral.js +40 -0
- package/.agents/scripts/lib/close-validation/gates.js +156 -32
- package/.agents/scripts/lib/close-validation/process.js +16 -7
- package/.agents/scripts/lib/close-validation/projections/crap.js +43 -10
- package/.agents/scripts/lib/close-validation/runner.js +160 -41
- package/.agents/scripts/lib/close-validation/skip-branch-test.js +144 -0
- package/.agents/scripts/lib/close-validation/test-delta.js +33 -8
- package/.agents/scripts/lib/codex/agents-projection.js +6 -0
- package/.agents/scripts/lib/config/agentrc-overlay.js +9 -5
- package/.agents/scripts/lib/config/explain.js +5 -2
- package/.agents/scripts/lib/config/gates/coverage.schema.js +53 -0
- package/.agents/scripts/lib/config/gates/crap-incremental-coverage.schema.js +1 -1
- package/.agents/scripts/lib/config/git-roots.js +38 -4
- package/.agents/scripts/lib/config/handoff.js +24 -0
- package/.agents/scripts/lib/config/quality.js +28 -12
- package/.agents/scripts/lib/config/worktree-isolation.js +2 -5
- package/.agents/scripts/lib/config-resolver.js +22 -2
- package/.agents/scripts/lib/config-settings-schema-delivery.js +87 -4
- package/.agents/scripts/lib/config-settings-schema-quality.js +36 -1
- package/.agents/scripts/lib/config-settings-schema.js +1 -1
- package/.agents/scripts/lib/coverage-capture-affected.js +1 -0
- package/.agents/scripts/lib/coverage-capture-delta.js +164 -32
- package/.agents/scripts/lib/coverage-capture-own-fix.js +232 -0
- package/.agents/scripts/lib/coverage-capture-usage.js +2 -2
- package/.agents/scripts/lib/coverage-capture.js +31 -0
- package/.agents/scripts/lib/coverage-deferral.js +96 -0
- package/.agents/scripts/lib/coverage-ratchet.js +187 -0
- package/.agents/scripts/lib/crap-baseline-join.js +5 -5
- package/.agents/scripts/lib/crap-engine.js +3 -3
- package/.agents/scripts/lib/crap-method-identity.js +104 -48
- package/.agents/scripts/lib/escomplex-anchor.js +135 -0
- package/.agents/scripts/lib/escomplex-kernel.js +30 -1
- package/.agents/scripts/lib/failure-rows.js +121 -0
- package/.agents/scripts/lib/full-suite-lock.js +44 -4
- package/.agents/scripts/lib/full-suite-queue.js +89 -13
- package/.agents/scripts/lib/generated/agentrc-validator.js +8 -2
- package/.agents/scripts/lib/gh-env.js +3 -6
- package/.agents/scripts/lib/gh-pr-rest.js +1 -0
- package/.agents/scripts/lib/git/base-sync-probe.js +182 -0
- package/.agents/scripts/lib/git-branch-lifecycle.js +9 -0
- package/.agents/scripts/lib/observability/close-telemetry.js +37 -2
- package/.agents/scripts/lib/observability/handoff-telemetry.js +170 -0
- package/.agents/scripts/lib/observability/review-dispositions.js +23 -6
- package/.agents/scripts/lib/observability/runtime-friction.js +17 -4
- package/.agents/scripts/lib/observability/source-classifier.js +3 -0
- package/.agents/scripts/lib/observability/story-outcome.js +393 -0
- package/.agents/scripts/lib/orchestration/check-baselines/phases/compare.js +2 -1
- package/.agents/scripts/lib/orchestration/check-baselines/phases/evaluate.js +19 -1
- package/.agents/scripts/lib/orchestration/check-baselines/phases/fail-detail.js +84 -0
- package/.agents/scripts/lib/orchestration/check-baselines/phases/pipeline.js +14 -5
- package/.agents/scripts/lib/orchestration/check-baselines/phases/refresh-ack.js +3 -2
- package/.agents/scripts/lib/orchestration/check-baselines/phases/report.js +26 -6
- package/.agents/scripts/lib/orchestration/ci-rerun-guard.js +124 -23
- package/.agents/scripts/lib/orchestration/code-review.js +223 -19
- package/.agents/scripts/lib/orchestration/handoff-gates.js +217 -44
- package/.agents/scripts/lib/orchestration/handoff-rescore.js +169 -0
- package/.agents/scripts/lib/orchestration/handoff-suite-of-record.js +45 -0
- package/.agents/scripts/lib/orchestration/plan-persist/run-plan-persist.js +5 -1
- package/.agents/scripts/lib/orchestration/plan-persist/source-rewrite.js +76 -4
- package/.agents/scripts/lib/orchestration/plan-persist/story-ops.js +2 -2
- package/.agents/scripts/lib/orchestration/preflight-lanes.js +208 -0
- package/.agents/scripts/lib/orchestration/review-base-ref.js +40 -17
- package/.agents/scripts/lib/orchestration/review-deposit.js +38 -12
- package/.agents/scripts/lib/orchestration/review-depth.js +21 -0
- package/.agents/scripts/lib/orchestration/review-history.js +124 -20
- package/.agents/scripts/lib/orchestration/review-providers/claude-verdict.js +23 -8
- package/.agents/scripts/lib/orchestration/review-providers/code-review.js +82 -39
- package/.agents/scripts/lib/orchestration/review-providers/critical-verifier.js +64 -11
- package/.agents/scripts/lib/orchestration/review-providers/degraded-gates.js +98 -3
- package/.agents/scripts/lib/orchestration/review-providers/finding-identity.js +6 -2
- package/.agents/scripts/lib/orchestration/review-providers/findings-renderer.js +55 -8
- package/.agents/scripts/lib/orchestration/review-providers/review-guidance.js +1 -0
- package/.agents/scripts/lib/orchestration/review-providers/review-provider-factory.js +42 -15
- package/.agents/scripts/lib/orchestration/review-providers/types.js +6 -0
- package/.agents/scripts/lib/orchestration/single-story-close/failed-terminal.js +10 -1
- package/.agents/scripts/lib/orchestration/single-story-close/gate-log.js +10 -0
- package/.agents/scripts/lib/orchestration/single-story-close/phases/base-sync.js +7 -4
- package/.agents/scripts/lib/orchestration/single-story-close/phases/close-validation.js +17 -2
- package/.agents/scripts/lib/orchestration/single-story-close/phases/code-review.js +59 -2
- package/.agents/scripts/lib/orchestration/single-story-close/phases/confirm-merge.js +13 -1
- package/.agents/scripts/lib/orchestration/single-story-close/phases/finish.js +15 -4
- package/.agents/scripts/lib/orchestration/single-story-close/phases/land-review-record.js +213 -0
- package/.agents/scripts/lib/orchestration/single-story-close/phases/normalize-pr-title.js +17 -2
- package/.agents/scripts/lib/orchestration/single-story-close/phases/open-pr.js +42 -20
- package/.agents/scripts/lib/orchestration/single-story-close/phases/post-land.js +51 -26
- package/.agents/scripts/lib/orchestration/single-story-close/phases/pre-push.js +3 -1
- package/.agents/scripts/lib/orchestration/single-story-close/phases/pull-request.js +51 -15
- package/.agents/scripts/lib/orchestration/single-story-close/phases/push.js +59 -11
- package/.agents/scripts/lib/orchestration/single-story-close/phases/reconcile-done.js +1 -0
- package/.agents/scripts/lib/orchestration/single-story-close/phases/review-block.js +31 -13
- package/.agents/scripts/lib/orchestration/single-story-close/phases/review-halt.js +29 -6
- package/.agents/scripts/lib/orchestration/single-story-close/phases/review-outcome.js +10 -12
- package/.agents/scripts/lib/orchestration/single-story-close/phases/review-override.js +19 -4
- package/.agents/scripts/lib/orchestration/single-story-close/result.js +43 -13
- package/.agents/scripts/lib/orchestration/single-story-close/review-overlap.js +73 -39
- package/.agents/scripts/lib/orchestration/single-story-close/runner.js +11 -2
- package/.agents/scripts/lib/orchestration/story-close/baseline-upward-writeback.js +3 -2
- package/.agents/scripts/lib/orchestration/story-close/duplication-close-rescore.js +20 -8
- package/.agents/scripts/lib/orchestration/story-deliver-terminal.js +7 -0
- package/.agents/scripts/lib/orchestration/story-handoff.js +789 -196
- package/.agents/scripts/lib/orchestration/ticketing/reads.js +2 -0
- package/.agents/scripts/lib/pr-body-lines.js +32 -0
- package/.agents/scripts/lib/single-story/ci-ratchet-gate.js +140 -0
- package/.agents/scripts/lib/single-story/confirm-and-land.js +17 -7
- package/.agents/scripts/lib/single-story/confirm-merge.js +12 -3
- package/.agents/scripts/lib/single-story-sweep/report-stalled-executing.js +202 -0
- package/.agents/scripts/lib/standalone-ratchets.js +37 -0
- package/.agents/scripts/lib/suite-admission.js +20 -8
- package/.agents/scripts/lib/suite-sizing.js +146 -0
- package/.agents/scripts/lib/workspace-provisioner.js +2 -2
- package/.agents/scripts/merge-baseline.js +14 -3
- package/.agents/scripts/providers/github/comments.js +19 -3
- package/.agents/scripts/providers/github.js +1 -0
- package/.agents/scripts/review-dispositions-report.js +1 -1
- package/.agents/scripts/role-scope-guard.js +267 -0
- package/.agents/scripts/single-story-close.js +4 -4
- package/.agents/scripts/single-story-confirm-merge.js +31 -5
- package/.agents/scripts/single-story-init.js +24 -4
- package/.agents/scripts/story-handoff.js +3 -3
- package/.agents/scripts/story-outcomes-report.js +231 -0
- package/.agents/scripts/story-review-compute.js +9 -5
- package/.agents/scripts/update-coverage-baseline.js +12 -2
- package/.agents/scripts/update-crap-baseline.js +9 -1
- package/.agents/workflows/audit-state-machines.md +213 -0
- package/.agents/workflows/helpers/code-review.md +63 -9
- package/.agents/workflows/helpers/deliver-digest.md +53 -54
- package/.agents/workflows/helpers/deliver-reference.md +236 -63
- package/.agents/workflows/helpers/deliver-story-reference.md +19 -8
- package/.agents/workflows/helpers/deliver-story.md +7 -2
- package/.agents/workflows/helpers/parallel-tooling.md +29 -0
- package/.agents/workflows/helpers/plan-reference.md +10 -2
- package/docs/CHANGELOG.md +56 -0
- package/lib/cli/doctor-checks/coverage-ratchet.js +54 -0
- package/lib/cli/doctor-checks/effective-agentrc.js +23 -0
- package/lib/cli/doctor-checks/llm-review.js +2 -11
- package/lib/cli/doctor-checks/sync-parity.js +5 -1
- package/lib/cli/doctor-checks/test-credit-path.js +7 -2
- package/lib/cli/registry.js +5 -0
- package/package.json +1 -1
|
@@ -6,34 +6,82 @@
|
|
|
6
6
|
* `core.hooksPath` is relative, so the invocation directory decides which
|
|
7
7
|
* tree `pre-push` measures (the main checkout gave false greens). With no
|
|
8
8
|
* worktree, the main checkout is the pushed tree.
|
|
9
|
+
* A no-op push still starts `pre-push`, so origin already at the tip skips.
|
|
9
10
|
*/
|
|
10
11
|
|
|
11
|
-
import {
|
|
12
|
+
import { remoteBranchSha } from '../../../git-branch-lifecycle.js';
|
|
13
|
+
import {
|
|
14
|
+
gitSpawn as defaultGitSpawn,
|
|
15
|
+
gitSync as defaultGitSync,
|
|
16
|
+
} from '../../../git-utils.js';
|
|
17
|
+
|
|
18
|
+
function localTip(cwd, branch, gitSpawn) {
|
|
19
|
+
const res = gitSpawn(cwd, 'rev-parse', `refs/heads/${branch}`);
|
|
20
|
+
return res?.status === 0 ? `${res.stdout ?? ''}`.trim() || null : null;
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
function originAtLocalTip(cwd, branch, gitSpawn) {
|
|
24
|
+
try {
|
|
25
|
+
const sha = localTip(cwd, branch, gitSpawn);
|
|
26
|
+
const remote = sha && remoteBranchSha(cwd, branch, gitSpawn);
|
|
27
|
+
return Boolean(remote?.reachable && remote.sha === sha);
|
|
28
|
+
} catch {
|
|
29
|
+
return false;
|
|
30
|
+
}
|
|
31
|
+
}
|
|
32
|
+
|
|
33
|
+
function push(cwd, storyBranch, gitSync, progress) {
|
|
34
|
+
progress('GIT', `Pushing ${storyBranch} to origin...`);
|
|
35
|
+
try {
|
|
36
|
+
// Never bypass hooks: under `--skip-validation`, `pre-push` is the only gate.
|
|
37
|
+
gitSync(cwd, 'push', '-u', 'origin', storyBranch);
|
|
38
|
+
progress('GIT', `✅ Pushed ${storyBranch}.`);
|
|
39
|
+
} catch (err) {
|
|
40
|
+
throw new Error(
|
|
41
|
+
`[single-story-close] git push failed for ${storyBranch}: ${err?.message ?? err}`,
|
|
42
|
+
);
|
|
43
|
+
}
|
|
44
|
+
return { outcome: 'pushed' };
|
|
45
|
+
}
|
|
46
|
+
|
|
47
|
+
function settlePush({ pushCwd, storyBranch, skipValidation, ...git }) {
|
|
48
|
+
if (skipValidation || !originAtLocalTip(pushCwd, storyBranch, git.gitSpawn)) {
|
|
49
|
+
return push(pushCwd, storyBranch, git.gitSync, git.progress);
|
|
50
|
+
}
|
|
51
|
+
git.progress(
|
|
52
|
+
'GIT',
|
|
53
|
+
`⏭ origin/${storyBranch} already at HEAD — push skipped.`,
|
|
54
|
+
);
|
|
55
|
+
return { outcome: 'skipped-already-at-head' };
|
|
56
|
+
}
|
|
12
57
|
|
|
13
58
|
/**
|
|
14
59
|
* @param {{
|
|
15
60
|
* cwd: string,
|
|
16
61
|
* worktreePath?: string|null,
|
|
17
62
|
* storyBranch: string,
|
|
63
|
+
* skipValidation?: boolean,
|
|
18
64
|
* gitSync?: typeof defaultGitSync,
|
|
65
|
+
* gitSpawn?: typeof defaultGitSpawn,
|
|
19
66
|
* progress: (tag: string, msg: string) => void,
|
|
20
67
|
* }} args
|
|
68
|
+
* @returns {{ outcome: 'pushed'|'skipped-already-at-head' }}
|
|
21
69
|
*/
|
|
22
70
|
export function pushStoryBranch({
|
|
23
71
|
cwd,
|
|
24
72
|
worktreePath = null,
|
|
25
73
|
storyBranch,
|
|
74
|
+
skipValidation = false,
|
|
26
75
|
gitSync = defaultGitSync,
|
|
76
|
+
gitSpawn = defaultGitSpawn,
|
|
27
77
|
progress,
|
|
28
78
|
}) {
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
);
|
|
38
|
-
}
|
|
79
|
+
return settlePush({
|
|
80
|
+
pushCwd: worktreePath ?? cwd,
|
|
81
|
+
storyBranch,
|
|
82
|
+
skipValidation,
|
|
83
|
+
gitSync,
|
|
84
|
+
gitSpawn,
|
|
85
|
+
progress,
|
|
86
|
+
});
|
|
39
87
|
}
|
|
@@ -5,27 +5,45 @@ import {
|
|
|
5
5
|
upsertStructuredComment,
|
|
6
6
|
} from '../../ticketing.js';
|
|
7
7
|
|
|
8
|
-
/**
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
const body = [
|
|
19
|
-
'### Code review blocked delivery',
|
|
20
|
-
'',
|
|
8
|
+
/** What halted: a critical count, or the no-verdict cause and its fix. */
|
|
9
|
+
function haltLines({ prUrl, criticalCount, noVerdictReason }) {
|
|
10
|
+
if (noVerdictReason) {
|
|
11
|
+
return [
|
|
12
|
+
`The Story-scope review on ${prUrl} produced **no verdict** for part or all of the diff, and \`delivery.codeReview.onNoVerdict\` is \`block\`.`,
|
|
13
|
+
'',
|
|
14
|
+
noVerdictReason,
|
|
15
|
+
];
|
|
16
|
+
}
|
|
17
|
+
return [
|
|
21
18
|
`The Story-scope review reported **${criticalCount} critical blocker(s)** on ${prUrl}.`,
|
|
22
19
|
'Remediate the posted findings, then re-run `/mandrel-deliver`.',
|
|
20
|
+
];
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
/** @param {{ prUrl: string, criticalCount: number, noVerdictReason?: string|null }} halt */
|
|
24
|
+
function blockBody(halt) {
|
|
25
|
+
return [
|
|
26
|
+
'### Code review blocked delivery',
|
|
27
|
+
'',
|
|
28
|
+
...haltLines(halt),
|
|
23
29
|
'',
|
|
24
30
|
'If you have reviewed a finding and judged it wrong, re-run close with',
|
|
25
31
|
'`--override-review-block "<reason>"` rather than merging by hand — see',
|
|
26
32
|
'`phases/review-override.js`. The override is recorded on the Story, on the',
|
|
27
33
|
'PR, and as friction telemetry.',
|
|
28
34
|
].join('\n');
|
|
35
|
+
}
|
|
36
|
+
|
|
37
|
+
/**
|
|
38
|
+
* Record a code-review halt (critical or no-verdict) as authoritative
|
|
39
|
+
* blocked state before close releases the Story lease and returns non-zero.
|
|
40
|
+
*/
|
|
41
|
+
export async function handleCriticalReviewBlock({
|
|
42
|
+
provider,
|
|
43
|
+
storyId,
|
|
44
|
+
...halt
|
|
45
|
+
}) {
|
|
46
|
+
const body = blockBody(halt);
|
|
29
47
|
try {
|
|
30
48
|
await upsertStructuredComment(provider, storyId, 'friction', body);
|
|
31
49
|
} catch (err) {
|
|
@@ -2,6 +2,31 @@ import { emitReviewBlockedFriction } from '../../../observability/close-telemetr
|
|
|
2
2
|
import { handleCriticalReviewBlock } from './review-block.js';
|
|
3
3
|
import { handleOverriddenReviewBlock } from './review-override.js';
|
|
4
4
|
|
|
5
|
+
/**
|
|
6
|
+
* The thrown message for a halt: a critical count, or the no-verdict blocker.
|
|
7
|
+
*
|
|
8
|
+
* @param {{ prUrl: string, criticalCount: number, noVerdictReason: string|null }} args
|
|
9
|
+
* @returns {string}
|
|
10
|
+
*/
|
|
11
|
+
function haltMessage({ prUrl, criticalCount, noVerdictReason }) {
|
|
12
|
+
const head = noVerdictReason
|
|
13
|
+
? `[single-story-close] Story-scope review produced no verdict on PR ${prUrl}: ${noVerdictReason} ` +
|
|
14
|
+
'Auto-merge was not enabled. '
|
|
15
|
+
: `[single-story-close] Story-scope review reported ${criticalCount} critical blocker(s) on PR ${prUrl}. ` +
|
|
16
|
+
'Auto-merge was not enabled. Remediate the findings posted to the PR and re-run `/mandrel-deliver`. ';
|
|
17
|
+
return (
|
|
18
|
+
head +
|
|
19
|
+
'If you have reviewed a finding and judged it wrong, re-run with ' +
|
|
20
|
+
'`--override-review-block "<reason>"` rather than merging by hand.'
|
|
21
|
+
);
|
|
22
|
+
}
|
|
23
|
+
|
|
24
|
+
/** @param {{ haltCause?: string, blockerReason?: string|null }} outcome */
|
|
25
|
+
function noVerdictReasonOf({ haltCause, blockerReason }) {
|
|
26
|
+
if (haltCause !== 'no-verdict') return null;
|
|
27
|
+
return blockerReason ?? 'no verdict';
|
|
28
|
+
}
|
|
29
|
+
|
|
5
30
|
/**
|
|
6
31
|
* An overridden Story proceeds; anything else emits friction, blocks, throws.
|
|
7
32
|
*
|
|
@@ -17,6 +42,7 @@ export async function resolveReviewHalt(
|
|
|
17
42
|
) {
|
|
18
43
|
const { storyId } = ctx;
|
|
19
44
|
const criticalCount = reviewOutcome.severity?.critical ?? 0;
|
|
45
|
+
const noVerdictReason = noVerdictReasonOf(reviewOutcome);
|
|
20
46
|
// Checked before the blocked transition: an overridden Story proceeds.
|
|
21
47
|
if (ctx.options.overrideReviewBlock) {
|
|
22
48
|
return await handleOverriddenReviewBlock({
|
|
@@ -27,6 +53,7 @@ export async function resolveReviewHalt(
|
|
|
27
53
|
criticalCount,
|
|
28
54
|
criticalByProvider: reviewOutcome.criticalByProvider,
|
|
29
55
|
reason: ctx.options.overrideReviewBlock,
|
|
56
|
+
noVerdictReason,
|
|
30
57
|
findings: reviewOutcome.findings ?? [],
|
|
31
58
|
config: deps.config,
|
|
32
59
|
});
|
|
@@ -43,11 +70,7 @@ export async function resolveReviewHalt(
|
|
|
43
70
|
storyId,
|
|
44
71
|
prUrl,
|
|
45
72
|
criticalCount,
|
|
73
|
+
noVerdictReason,
|
|
46
74
|
});
|
|
47
|
-
throw new Error(
|
|
48
|
-
`[single-story-close] Story-scope review reported ${criticalCount} critical blocker(s) on PR ${prUrl}. ` +
|
|
49
|
-
'Auto-merge was not enabled. Remediate the findings posted to the PR and re-run `/mandrel-deliver`. ' +
|
|
50
|
-
'If you have reviewed a finding and judged it wrong, re-run with ' +
|
|
51
|
-
'`--override-review-block "<reason>"` rather than merging by hand.',
|
|
52
|
-
);
|
|
75
|
+
throw new Error(haltMessage({ prUrl, criticalCount, noVerdictReason }));
|
|
53
76
|
}
|
|
@@ -1,11 +1,14 @@
|
|
|
1
1
|
/**
|
|
2
2
|
* phases/review-outcome.js — renders the review outcome, always stating the
|
|
3
3
|
* degraded gates (`none` when healthy) so "never ran" cannot read as
|
|
4
|
-
* "found nothing".
|
|
5
|
-
*
|
|
4
|
+
* "found nothing". It never claims another gate covered the surface; this
|
|
5
|
+
* module cannot see that.
|
|
6
6
|
*/
|
|
7
7
|
|
|
8
|
-
import {
|
|
8
|
+
import {
|
|
9
|
+
reviewGapLines,
|
|
10
|
+
summarizeDegradations,
|
|
11
|
+
} from '../../review-providers/degraded-gates.js';
|
|
9
12
|
|
|
10
13
|
/**
|
|
11
14
|
* @param {{ severity: { critical: number, high: number, medium: number, suggestion: number }, degradations?: unknown }} args
|
|
@@ -35,13 +38,8 @@ export function formatReviewOutcomeLines({
|
|
|
35
38
|
posted,
|
|
36
39
|
}) {
|
|
37
40
|
const tally = buildOutcomeTally({ severity, degradations });
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
'is not blocked — a secondary review does not gate the merge — but ' +
|
|
43
|
-
'nothing here vouches for those surfaces.',
|
|
44
|
-
);
|
|
45
|
-
}
|
|
46
|
-
return lines;
|
|
41
|
+
return [
|
|
42
|
+
`Findings — ${tally}. Posted to PR #${prNumber}: ${posted}.`,
|
|
43
|
+
...reviewGapLines(degradations),
|
|
44
|
+
];
|
|
47
45
|
}
|
|
@@ -18,15 +18,23 @@ import {
|
|
|
18
18
|
|
|
19
19
|
const REASON_SIGNAL_LIMIT = 500;
|
|
20
20
|
|
|
21
|
+
/** The halt being overridden, as one sentence. */
|
|
22
|
+
function haltSummary({ prUrl, criticalCount, noVerdictReason }) {
|
|
23
|
+
if (noVerdictReason) {
|
|
24
|
+
return `The Story-scope review produced **no verdict** on ${prUrl}: ${noVerdictReason}`;
|
|
25
|
+
}
|
|
26
|
+
return `The Story-scope review reported **${criticalCount} critical blocker(s)** on ${prUrl}.`;
|
|
27
|
+
}
|
|
28
|
+
|
|
21
29
|
/**
|
|
22
|
-
* @param {{ prUrl: string, criticalCount: number, reason: string }} args
|
|
30
|
+
* @param {{ prUrl: string, criticalCount: number, reason: string, noVerdictReason?: string|null }} args
|
|
23
31
|
* @returns {string}
|
|
24
32
|
*/
|
|
25
|
-
function buildReviewOverrideBody({
|
|
33
|
+
function buildReviewOverrideBody({ reason, ...halt }) {
|
|
26
34
|
return [
|
|
27
35
|
'### Code-review blocker overridden by operator',
|
|
28
36
|
'',
|
|
29
|
-
|
|
37
|
+
haltSummary(halt),
|
|
30
38
|
'The operator reviewed and rejected the finding(s) and authorized delivery',
|
|
31
39
|
'with `--override-review-block`; auto-merge was armed.',
|
|
32
40
|
'',
|
|
@@ -87,6 +95,7 @@ function recordOverrides({ storyId, findings, ...deps }) {
|
|
|
87
95
|
* criticalCount: number,
|
|
88
96
|
* criticalByProvider?: Record<string, number>,
|
|
89
97
|
* reason: string,
|
|
98
|
+
* noVerdictReason?: string|null,
|
|
90
99
|
* findings?: Array<object>,
|
|
91
100
|
* config?: object,
|
|
92
101
|
* emitFrictionFn?: typeof emitRuntimeFriction,
|
|
@@ -101,11 +110,17 @@ export async function handleOverriddenReviewBlock({
|
|
|
101
110
|
criticalCount,
|
|
102
111
|
criticalByProvider = {},
|
|
103
112
|
reason,
|
|
113
|
+
noVerdictReason = null,
|
|
104
114
|
findings = [],
|
|
105
115
|
config,
|
|
106
116
|
emitFrictionFn = emitRuntimeFriction,
|
|
107
117
|
}) {
|
|
108
|
-
const body = buildReviewOverrideBody({
|
|
118
|
+
const body = buildReviewOverrideBody({
|
|
119
|
+
prUrl,
|
|
120
|
+
criticalCount,
|
|
121
|
+
reason,
|
|
122
|
+
noVerdictReason,
|
|
123
|
+
});
|
|
109
124
|
Logger.warn(
|
|
110
125
|
`[single-story-close] ⚠️ Story-scope review reported ${criticalCount} critical blocker(s) on ` +
|
|
111
126
|
`PR ${prUrl} — OVERRIDDEN by operator: ${reason}`,
|
|
@@ -1,9 +1,10 @@
|
|
|
1
1
|
import { BASELINES_GATE_NAMES } from '../../close-validation/gates.js';
|
|
2
2
|
import { Logger } from '../../Logger.js';
|
|
3
3
|
import { recordCloseTelemetry } from '../../observability/close-telemetry.js';
|
|
4
|
-
import {
|
|
4
|
+
import { finishCloseTerminal } from '../../observability/story-outcome.js';
|
|
5
5
|
import { emitTerseResult } from '../../observability/terse-result.js';
|
|
6
6
|
import { MERGED_FLIP_FAILED_BLOCK_CLASS } from '../lifecycle/emit-merge-flip-failed.js';
|
|
7
|
+
import { reviewGateValue } from '../review-providers/degraded-gates.js';
|
|
7
8
|
import {
|
|
8
9
|
buildTerminalEnvelope,
|
|
9
10
|
emitTerminalEnvelope,
|
|
@@ -34,6 +35,7 @@ export async function emitTerminal({
|
|
|
34
35
|
config,
|
|
35
36
|
phaseTimer = UNTIMED,
|
|
36
37
|
worker = NO_WORKER,
|
|
38
|
+
provider,
|
|
37
39
|
}) {
|
|
38
40
|
phaseTimer.stamp(terminal);
|
|
39
41
|
await recordCloseTelemetry({ terminal, result, config, ...worker });
|
|
@@ -52,7 +54,7 @@ export async function emitTerminal({
|
|
|
52
54
|
});
|
|
53
55
|
}
|
|
54
56
|
emitTerminalEnvelope(terminal, { config });
|
|
55
|
-
await
|
|
57
|
+
await finishCloseTerminal({ terminal, result, config, worker, provider });
|
|
56
58
|
}
|
|
57
59
|
|
|
58
60
|
/**
|
|
@@ -168,37 +170,63 @@ function baselinesEnvelopeGates(validationGates) {
|
|
|
168
170
|
}
|
|
169
171
|
|
|
170
172
|
/**
|
|
171
|
-
*
|
|
172
|
-
*
|
|
173
|
-
*
|
|
173
|
+
* A capture deferred to CI is the one capture outcome a reviewer must see.
|
|
174
|
+
*
|
|
175
|
+
* @param {Record<string, string>|null|undefined} validationGates
|
|
176
|
+
* @returns {Record<string, string>}
|
|
177
|
+
*/
|
|
178
|
+
function deferredCaptureGate(validationGates) {
|
|
179
|
+
return validationGates?.['coverage-capture'] === 'deferred'
|
|
180
|
+
? { 'coverage-capture': 'deferred' }
|
|
181
|
+
: {};
|
|
182
|
+
}
|
|
183
|
+
|
|
184
|
+
/**
|
|
185
|
+
* Derived from the review's degradation kinds, never the bare `degraded` flag;
|
|
186
|
+
* `skipped` when this run reviewed nothing (an already-merged PR).
|
|
174
187
|
*
|
|
175
188
|
* @param {object|null} reviewOverride
|
|
176
|
-
* @param {
|
|
177
|
-
* @
|
|
189
|
+
* @param {ReadonlyArray<object>} [reviewDegradations]
|
|
190
|
+
* @param {boolean} [reviewSkipped]
|
|
191
|
+
* @returns {string}
|
|
178
192
|
*/
|
|
179
|
-
function codeReviewGate(reviewOverride,
|
|
180
|
-
if (reviewOverride) return '
|
|
181
|
-
return
|
|
193
|
+
function codeReviewGate(reviewOverride, reviewDegradations, reviewSkipped) {
|
|
194
|
+
if (isUnreviewed(reviewOverride, reviewSkipped)) return 'skipped';
|
|
195
|
+
return reviewGateValue(reviewDegradations, { overridden: !!reviewOverride });
|
|
182
196
|
}
|
|
183
197
|
|
|
198
|
+
/**
|
|
199
|
+
* @param {object|null} reviewOverride
|
|
200
|
+
* @param {boolean} [reviewSkipped]
|
|
201
|
+
*/
|
|
202
|
+
const isUnreviewed = (reviewOverride, reviewSkipped) =>
|
|
203
|
+
!reviewOverride && !!reviewSkipped;
|
|
204
|
+
|
|
184
205
|
/**
|
|
185
206
|
* @param {{ skipValidation?: boolean, skipSync?: boolean }} options
|
|
186
207
|
* @param {Record<string, string>|null} validationGates
|
|
187
208
|
* @param {object|null} reviewOverride
|
|
188
|
-
* @param {
|
|
209
|
+
* @param {ReadonlyArray<object>} [reviewDegradations]
|
|
210
|
+
* @param {{ reviewSkipped?: boolean }} [review]
|
|
189
211
|
* @returns {Record<string, string>}
|
|
190
212
|
*/
|
|
191
213
|
export function closeEnvelopeGates(
|
|
192
214
|
options,
|
|
193
215
|
validationGates,
|
|
194
216
|
reviewOverride,
|
|
195
|
-
|
|
217
|
+
reviewDegradations,
|
|
218
|
+
{ reviewSkipped = false } = {},
|
|
196
219
|
) {
|
|
197
220
|
return {
|
|
198
221
|
validation: options.skipValidation ? 'skipped' : 'passed',
|
|
199
222
|
...baselinesEnvelopeGates(validationGates),
|
|
223
|
+
...deferredCaptureGate(validationGates),
|
|
200
224
|
baseSync: options.skipSync ? 'skipped' : 'passed',
|
|
201
|
-
codeReview: codeReviewGate(
|
|
225
|
+
codeReview: codeReviewGate(
|
|
226
|
+
reviewOverride,
|
|
227
|
+
reviewDegradations,
|
|
228
|
+
reviewSkipped,
|
|
229
|
+
),
|
|
202
230
|
};
|
|
203
231
|
}
|
|
204
232
|
|
|
@@ -235,6 +263,7 @@ export function closeResult({
|
|
|
235
263
|
waitedForMerge = false,
|
|
236
264
|
merged = false,
|
|
237
265
|
landCompleted = merged,
|
|
266
|
+
pushOutcome,
|
|
238
267
|
}) {
|
|
239
268
|
return {
|
|
240
269
|
storyId,
|
|
@@ -244,6 +273,7 @@ export function closeResult({
|
|
|
244
273
|
prUrl,
|
|
245
274
|
prNumber,
|
|
246
275
|
pushed: true,
|
|
276
|
+
pushOutcome,
|
|
247
277
|
autoMergeEnabled,
|
|
248
278
|
autoMergeReason,
|
|
249
279
|
worktreeReaped,
|
|
@@ -1,19 +1,23 @@
|
|
|
1
1
|
/**
|
|
2
2
|
* The Story-scope review, overlapped with the close-validation gates: started
|
|
3
3
|
* once the pre-gate self-heal commits land and held (computed, never posted)
|
|
4
|
-
* until the PR exists. A
|
|
5
|
-
*
|
|
6
|
-
* pushed diff with a different digest discards it for a serial review
|
|
7
|
-
*
|
|
8
|
-
*
|
|
4
|
+
* until the PR exists. A deposit whose diff digest matches the diff at that
|
|
5
|
+
* point **is** the held result, so nothing is computed. After PR-open a
|
|
6
|
+
* pushed diff with a different digest discards it for a serial review of the
|
|
7
|
+
* pushed SHA — a base-sync merge that moves only offsets keeps the digest.
|
|
8
|
+
* Every non-degraded review close computes is deposited when it settles, so a
|
|
9
|
+
* retry on the same diff adopts it. The held promise never rejects, so an
|
|
10
|
+
* abandoned review leaves no unhandled rejection.
|
|
9
11
|
*/
|
|
10
12
|
|
|
11
13
|
import { postReviewComment } from '../code-review.js';
|
|
12
14
|
import {
|
|
15
|
+
buildReviewDeposit,
|
|
13
16
|
computeReviewDiffDigest,
|
|
14
17
|
depositAsComputedReview,
|
|
15
18
|
probeHeldReviewDiff,
|
|
16
19
|
resolveRefSha,
|
|
20
|
+
writeReviewDeposit,
|
|
17
21
|
} from '../review-deposit.js';
|
|
18
22
|
import { upsertStructuredComment } from '../ticketing.js';
|
|
19
23
|
import {
|
|
@@ -29,33 +33,76 @@ function resolveBranchSha({ cwd, storyBranch, gitSpawnFn }) {
|
|
|
29
33
|
return resolveRefSha({ cwd, ref: storyBranch, gitSpawnFn });
|
|
30
34
|
}
|
|
31
35
|
|
|
32
|
-
/** A held result already in hand: the
|
|
36
|
+
/** A held result already in hand: the deposit. */
|
|
33
37
|
function adoptedSettlement(deposit, atMs) {
|
|
34
38
|
const value = depositAsComputedReview(deposit);
|
|
35
39
|
return Promise.resolve({ ok: true, value, endedAtMs: atMs });
|
|
36
40
|
}
|
|
37
41
|
|
|
38
|
-
/**
|
|
39
|
-
function
|
|
42
|
+
/** Deposit a computed result; a failed write is a warning, never a failure. */
|
|
43
|
+
function depositReview(args, held, result) {
|
|
44
|
+
if (!result || result.degraded || !held.diffDigest) return;
|
|
45
|
+
const { writeDepositFn = writeReviewDeposit, progress } = args;
|
|
46
|
+
try {
|
|
47
|
+
const deposit = buildReviewDeposit({
|
|
48
|
+
storyId: Number(args.storyId),
|
|
49
|
+
headSha: held.sha,
|
|
50
|
+
baseRef: held.baseRef,
|
|
51
|
+
diffDigest: held.diffDigest,
|
|
52
|
+
result,
|
|
53
|
+
});
|
|
54
|
+
writeDepositFn(deposit, { config: args.config });
|
|
55
|
+
} catch (err) {
|
|
56
|
+
progress(
|
|
57
|
+
'REVIEW',
|
|
58
|
+
`⚠️ Could not deposit the Story-scope review: ${err?.message ?? err}`,
|
|
59
|
+
);
|
|
60
|
+
}
|
|
61
|
+
}
|
|
62
|
+
|
|
63
|
+
/** Compute the review of `held.sha`, held unposted; never rejects. */
|
|
64
|
+
function computeHeldReview(args, held) {
|
|
65
|
+
const { nowMs = Date.now } = args;
|
|
40
66
|
return computeStoryScopeReview({
|
|
41
67
|
...args,
|
|
42
|
-
headRef: sha,
|
|
68
|
+
headRef: held.sha,
|
|
43
69
|
deferPost: true,
|
|
44
70
|
}).then(
|
|
45
|
-
(value) =>
|
|
71
|
+
(value) => {
|
|
72
|
+
const endedAtMs = nowMs();
|
|
73
|
+
depositReview(args, held, value.result);
|
|
74
|
+
return { ok: true, value, endedAtMs };
|
|
75
|
+
},
|
|
46
76
|
(error) => ({ ok: false, error, endedAtMs: nowMs() }),
|
|
47
77
|
);
|
|
48
78
|
}
|
|
49
79
|
|
|
80
|
+
/** Adopt the matching deposit for `sha`, else compute (and deposit) it. */
|
|
81
|
+
function holdReview(args, sha) {
|
|
82
|
+
const { progress, nowMs = Date.now } = args;
|
|
83
|
+
const { baseRef, diffDigest, deposit } = probeHeldReviewDiff({
|
|
84
|
+
...args,
|
|
85
|
+
sha,
|
|
86
|
+
});
|
|
87
|
+
const startedAtMs = nowMs();
|
|
88
|
+
const held = { sha, baseRef, diffDigest, adopted: !!deposit, startedAtMs };
|
|
89
|
+
if (deposit) {
|
|
90
|
+
progress('REVIEW', `♻️ Adopting the deposited review; none computed.`);
|
|
91
|
+
return { ...held, settled: adoptedSettlement(deposit, startedAtMs) };
|
|
92
|
+
}
|
|
93
|
+
return { ...held, settled: computeHeldReview(args, held) };
|
|
94
|
+
}
|
|
95
|
+
|
|
50
96
|
/**
|
|
51
97
|
* @param {{ cwd: string, storyId: number, storyBranch: string,
|
|
52
98
|
* baseBranch: string, provider: object, runCodeReviewFn: Function,
|
|
53
99
|
* gitSpawnFn: Function, progress: Function, config?: object,
|
|
54
|
-
* readDepositFn?: Function,
|
|
100
|
+
* readDepositFn?: Function, writeDepositFn?: Function,
|
|
101
|
+
* nowMs?: () => number }} args
|
|
55
102
|
* @returns {HeldReview|null} null when the SHA is unresolvable.
|
|
56
103
|
*/
|
|
57
104
|
export function startHeldReview(args) {
|
|
58
|
-
const { cwd, storyBranch, gitSpawnFn, progress
|
|
105
|
+
const { cwd, storyBranch, gitSpawnFn, progress } = args;
|
|
59
106
|
const sha = resolveBranchSha({ cwd, storyBranch, gitSpawnFn });
|
|
60
107
|
if (!sha) {
|
|
61
108
|
progress(
|
|
@@ -64,18 +111,7 @@ export function startHeldReview(args) {
|
|
|
64
111
|
);
|
|
65
112
|
return null;
|
|
66
113
|
}
|
|
67
|
-
|
|
68
|
-
...args,
|
|
69
|
-
sha,
|
|
70
|
-
});
|
|
71
|
-
const startedAtMs = nowMs();
|
|
72
|
-
const held = { sha, baseRef, diffDigest, adopted: !!deposit, startedAtMs };
|
|
73
|
-
if (deposit) {
|
|
74
|
-
progress('REVIEW', `♻️ Adopting the worker's held review; none computed.`);
|
|
75
|
-
return { ...held, settled: adoptedSettlement(deposit, startedAtMs) };
|
|
76
|
-
}
|
|
77
|
-
const settled = computeHeldReview({ ...args, sha, nowMs });
|
|
78
|
-
return { ...held, settled };
|
|
114
|
+
return holdReview(args, sha);
|
|
79
115
|
}
|
|
80
116
|
|
|
81
117
|
/** Drop a held review unposted. */
|
|
@@ -115,19 +151,28 @@ async function postHeldReview(held, args) {
|
|
|
115
151
|
}
|
|
116
152
|
}
|
|
117
153
|
|
|
154
|
+
/** Review `sha` and post it; the branch name only when no SHA or PR. */
|
|
155
|
+
function reviewSerially(args, sha) {
|
|
156
|
+
if (args.prNumber == null || !sha) return runStoryScopeReview(args);
|
|
157
|
+
args.pauseTimer();
|
|
158
|
+
return postHeldReview(holdReview(args, sha), args);
|
|
159
|
+
}
|
|
160
|
+
|
|
118
161
|
/**
|
|
119
|
-
* Post a held review whose diff digest matches the pushed diff
|
|
120
|
-
*
|
|
162
|
+
* Post a held review whose diff digest matches the pushed diff, else review
|
|
163
|
+
* the pushed SHA serially (deposited before it posts). Either phase is
|
|
164
|
+
* untimed: the review records its own wall time.
|
|
121
165
|
*
|
|
122
166
|
* @returns {Promise<object>} the review outcome.
|
|
123
167
|
*/
|
|
124
168
|
export async function reviewAfterPrOpen(args) {
|
|
125
169
|
const { held, setPhase, progress } = args;
|
|
170
|
+
const sha = resolveBranchSha(args);
|
|
126
171
|
if (held && args.prNumber != null) {
|
|
127
172
|
const pushedDigest = computeReviewDiffDigest({
|
|
128
173
|
cwd: args.cwd,
|
|
129
174
|
baseRef: held.baseRef,
|
|
130
|
-
headRef:
|
|
175
|
+
headRef: sha,
|
|
131
176
|
gitSpawnFn: args.gitSpawnFn,
|
|
132
177
|
});
|
|
133
178
|
if (pushedDigest !== null && pushedDigest === held.diffDigest) {
|
|
@@ -146,16 +191,5 @@ export async function reviewAfterPrOpen(args) {
|
|
|
146
191
|
);
|
|
147
192
|
}
|
|
148
193
|
setPhase('code-review');
|
|
149
|
-
return await
|
|
150
|
-
cwd: args.cwd,
|
|
151
|
-
storyId: args.storyId,
|
|
152
|
-
storyBranch: args.storyBranch,
|
|
153
|
-
baseBranch: args.baseBranch,
|
|
154
|
-
prUrl: args.prUrl,
|
|
155
|
-
prNumber: args.prNumber,
|
|
156
|
-
provider: args.provider,
|
|
157
|
-
runCodeReviewFn: args.runCodeReviewFn,
|
|
158
|
-
gitSpawnFn: args.gitSpawnFn,
|
|
159
|
-
progress,
|
|
160
|
-
});
|
|
194
|
+
return await reviewSerially(args, sha);
|
|
161
195
|
}
|
|
@@ -363,12 +363,18 @@ function landedPrePush(ctx) {
|
|
|
363
363
|
lockWait: null,
|
|
364
364
|
suiteTimings: null,
|
|
365
365
|
pending: false,
|
|
366
|
+
coverageDeferred: null,
|
|
366
367
|
};
|
|
367
368
|
return null;
|
|
368
369
|
}
|
|
369
370
|
|
|
370
371
|
function landedPr(ctx) {
|
|
371
|
-
ctx.pr = {
|
|
372
|
+
ctx.pr = {
|
|
373
|
+
...ctx.landedPr,
|
|
374
|
+
alreadyMerged: true,
|
|
375
|
+
reviewOverride: null,
|
|
376
|
+
reviewSkipped: true,
|
|
377
|
+
};
|
|
372
378
|
return null;
|
|
373
379
|
}
|
|
374
380
|
|
|
@@ -448,12 +454,15 @@ function buildPrContext(ctx, deps) {
|
|
|
448
454
|
phaseTimer: ctx.phaseTimer,
|
|
449
455
|
worker: ctx.worker,
|
|
450
456
|
lockWait: ctx.prePush.lockWait,
|
|
457
|
+
baseSync: ctx.baseSync?.decision ?? null,
|
|
458
|
+
pushOutcome: ctx.pr.pushOutcome ?? null,
|
|
451
459
|
suiteTimings: envelopeSuiteTimings(ctx, deps),
|
|
452
460
|
gates: closeEnvelopeGates(
|
|
453
461
|
options,
|
|
454
462
|
ctx.prePush.validationGates,
|
|
455
463
|
ctx.pr.reviewOverride,
|
|
456
|
-
ctx.pr.
|
|
464
|
+
ctx.pr.reviewDegradations,
|
|
465
|
+
{ reviewSkipped: ctx.pr.reviewSkipped === true },
|
|
457
466
|
),
|
|
458
467
|
};
|
|
459
468
|
}
|
|
@@ -7,8 +7,9 @@
|
|
|
7
7
|
* Invariants:
|
|
8
8
|
* 1. Only classifier `improvements` are written — a regression never enters
|
|
9
9
|
* the written set, so it still fails the gate.
|
|
10
|
-
* 2. Maintainability only: CRAP
|
|
11
|
-
*
|
|
10
|
+
* 2. Maintainability only: CRAP is coverage-derived and flaps under
|
|
11
|
+
* non-deterministic V8 instrumentation, so writing its improvements
|
|
12
|
+
* back would ratchet the baseline on noise.
|
|
12
13
|
* 3. Changed files only — a full-scope write would absorb other branches'
|
|
13
14
|
* drift into whichever PR lands next.
|
|
14
15
|
* 4. Idempotent: no empty commit.
|