mandrel 2.103.0 → 2.104.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/agents/acceptance-critic.md +2 -0
- package/.agents/agents/auditor.md +2 -0
- package/.agents/agents/plan-critic.md +2 -0
- package/.agents/agents/story-worker.md +2 -0
- package/.agents/docs/configuration.md +1 -1
- package/.agents/docs/execution-reference.md +35 -0
- package/.agents/instructions.md +4 -2
- package/.agents/rules/testing-standards.md +7 -1
- package/.agents/schemas/agentrc.schema.json +1 -1
- package/.agents/scripts/lib/close-validation/test-delta.js +8 -2
- package/.agents/scripts/lib/config-settings-schema.js +1 -1
- package/.agents/scripts/lib/coverage-capture-affected.js +3 -2
- package/.agents/scripts/lib/coverage-capture-delta.js +101 -34
- package/.agents/scripts/lib/coverage-capture.js +14 -7
- package/.agents/scripts/lib/orchestration/code-review.js +24 -10
- package/.agents/scripts/lib/orchestration/evidence-stream.js +16 -7
- package/.agents/scripts/lib/orchestration/review-deposit.js +24 -7
- package/.agents/scripts/lib/orchestration/review-providers/claim-grounding.js +183 -0
- package/.agents/scripts/lib/orchestration/review-providers/claude-verdict.js +2 -0
- package/.agents/scripts/lib/orchestration/review-providers/code-review.js +6 -1
- package/.agents/scripts/lib/orchestration/review-providers/codex-cli.js +11 -1
- package/.agents/scripts/lib/orchestration/review-providers/findings-renderer.js +4 -1
- package/.agents/scripts/lib/orchestration/review-providers/generated-diff.js +7 -3
- package/.agents/scripts/lib/orchestration/review-providers/parse-findings.js +7 -0
- package/.agents/scripts/lib/orchestration/review-providers/review-provider-factory.js +7 -20
- package/.agents/scripts/lib/orchestration/review-providers/types.js +9 -0
- package/.agents/scripts/lib/orchestration/story-handoff.js +77 -18
- package/.agents/workflows/helpers/code-review.md +8 -0
- package/.agents/workflows/helpers/deliver-digest.md +8 -8
- package/.agents/workflows/helpers/deliver-reference.md +21 -14
- package/docs/CHANGELOG.md +14 -0
- package/package.json +1 -1
|
@@ -446,10 +446,11 @@ Digest § 5 states the rule and both invocations; this is what surrounds them.
|
|
|
446
446
|
## Held review at hand-off {#held-review}
|
|
447
447
|
|
|
448
448
|
The one home of this rule; the digest and the worker contract point here.
|
|
449
|
-
|
|
450
|
-
|
|
451
|
-
|
|
452
|
-
|
|
449
|
+
`story-handoff.js` starts the Story-scope code review as the credited run
|
|
450
|
+
starts — pinned to HEAD at that moment, after a `test`-depositor seat — and
|
|
451
|
+
awaits it after the push, skipping the computation when a deposit already
|
|
452
|
+
matches the diff digest. The envelope's `reviewMs` sits beside the run's
|
|
453
|
+
`suiteTimings`. The same computation stands alone for a manual re-run:
|
|
453
454
|
|
|
454
455
|
```bash
|
|
455
456
|
node <main-repo>/.agents/scripts/story-review-compute.js --story <storyId> --cwd <workCwd>
|
|
@@ -459,21 +460,27 @@ node <main-repo>/.agents/scripts/story-review-compute.js --story <storyId> --cwd
|
|
|
459
460
|
provider chain) against `origin/<baseBranch>...story-<id>`, posts nothing,
|
|
460
461
|
takes no full-suite lock, and writes
|
|
461
462
|
`temp/orchestration/story-review-<id>.json` beside the terminal envelope,
|
|
462
|
-
keyed on the **diff digest** (sha256 of the
|
|
463
|
-
|
|
464
|
-
|
|
463
|
+
keyed on the **diff digest** (sha256 of the three-dot diff with every
|
|
464
|
+
`linguist-generated` section removed; a failed attribute lookup hashes it
|
|
465
|
+
whole). It never stops the handoff on a provider throw — the step reports
|
|
466
|
+
`error` and close computes the review itself.
|
|
465
467
|
- **A CRITICAL is the worker's to fix.** The handoff settles `fix-required`
|
|
466
|
-
naming the deposit
|
|
467
|
-
|
|
468
|
-
|
|
468
|
+
naming the deposit. One that lands while the credited run is in flight
|
|
469
|
+
aborts the run (the SIGTERM a Ctrl-C sends; the child frees the full-suite
|
|
470
|
+
lock), records no credit and pushes nothing; a CRITICAL after the run still
|
|
471
|
+
settles after the push, as before. Any earlier stop still awaits the
|
|
472
|
+
review, so no provider is orphaned. Fix, commit, and re-run the handoff
|
|
473
|
+
(the fix commit voided the credit, so it re-runs the suite, pushes and
|
|
474
|
+
re-computes) — the acceptance loop's redraft discipline, bounded by
|
|
469
475
|
`delivery.acceptanceEval.maxRounds`. Still CRITICAL at the cap → take the
|
|
470
476
|
blocked path. Anything else goes in the hand-off as the severity tally.
|
|
471
477
|
- **Close adopts, else computes.** When the deposit's digest equals the
|
|
472
478
|
digest of the diff at close's held-review start, close starts no review and
|
|
473
|
-
posts the deposit after PR-open. A clean base-sync merge
|
|
474
|
-
|
|
475
|
-
does not, and close reviews as it would without
|
|
476
|
-
`--override-review-block` apply to an adopted
|
|
479
|
+
posts the deposit after PR-open. A clean base-sync merge or a seat commit
|
|
480
|
+
that writes only generated baselines keeps the deposit; a commit that
|
|
481
|
+
changes a reviewed path does not, and close reviews as it would without
|
|
482
|
+
one. The CRITICAL halt and `--override-review-block` apply to an adopted
|
|
483
|
+
result unchanged.
|
|
477
484
|
|
|
478
485
|
## Gate output {#gate-output}
|
|
479
486
|
|
package/docs/CHANGELOG.md
CHANGED
|
@@ -15,6 +15,20 @@ All notable changes to this project will be documented in this file.
|
|
|
15
15
|
-->
|
|
16
16
|
<!-- markdownlint-disable-file MD004 MD012 MD037 -->
|
|
17
17
|
|
|
18
|
+
## [2.104.0](https://github.com/dsj1984/mandrel/compare/mandrel-v2.103.0...mandrel-v2.104.0) (2026-10-25)
|
|
19
|
+
|
|
20
|
+
|
|
21
|
+
### Added
|
|
22
|
+
|
|
23
|
+
* held review grounds path-absent and remaining-caller CRITICALs against the reviewed head before halting ([#5904](https://github.com/dsj1984/mandrel/issues/5904)) ([#5906](https://github.com/dsj1984/mandrel/issues/5906)) ([2153489](https://github.com/dsj1984/mandrel/commit/2153489d7cde4a4839c404ddd28a8160a1781527))
|
|
24
|
+
* story handoff runs the held review concurrently with the credited run and stops early on a CRITICAL ([#5905](https://github.com/dsj1984/mandrel/issues/5905)) ([#5908](https://github.com/dsj1984/mandrel/issues/5908)) ([f030bc6](https://github.com/dsj1984/mandrel/commit/f030bc62d2020a2f1170cc1854e4b22021328111))
|
|
25
|
+
* **testing:** flag tests that would still pass against a null implementation (refs [#5899](https://github.com/dsj1984/mandrel/issues/5899)) ([#5900](https://github.com/dsj1984/mandrel/issues/5900)) ([7458b8d](https://github.com/dsj1984/mandrel/commit/7458b8dc6c0e8f2744b6fab99234194f7a9146dd))
|
|
26
|
+
|
|
27
|
+
|
|
28
|
+
### Fixed
|
|
29
|
+
|
|
30
|
+
* coverage delta refresh fires on tree-digest-only staleness and ignores non-suite-input overlap ([#5903](https://github.com/dsj1984/mandrel/issues/5903)) ([#5907](https://github.com/dsj1984/mandrel/issues/5907)) ([65413a4](https://github.com/dsj1984/mandrel/commit/65413a467b1701f46ba393fa7be4948ab60bf68f))
|
|
31
|
+
|
|
18
32
|
## [2.103.0](https://github.com/dsj1984/mandrel/compare/mandrel-v2.102.0...mandrel-v2.103.0) (2026-10-25)
|
|
19
33
|
|
|
20
34
|
|
package/package.json
CHANGED